- 26 Sep, 2020 24 commits
-
-
David Grogan authored
When an item with an aspect ratio stretches to the container's cross size causing the item's cross size to be considered definite, the flex base size can be computed differently. Specifically, the flex base size calculation could fall under the purview of https://drafts.csswg.org/css-flexbox/#algo-main-item part B, which requires the item to have a definite cross size. Both chrome 86 and firefox 82b2 get this wrong. Bug: 704294 Change-Id: I8410be91d3006ee9d055562887fc5c3fe7b9aa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428164Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810867}
-
Robert Ma authored
Stub out _check_that_all_ports_are_available to always return True so that the tests won't fail if some process is already listening on a port used by the server. Note that there might be a deeper issue that something else is listening on these ports. These unit tests themselves use MockHost and would never start the real server. Reduce the numbers of expected log entries by 1 as we no longer have the "DEBUG: all ports are available" message from the real _check_that_all_ports_are_available. Bug: 1114320 Change-Id: I5dfa98cabb5c0bb85a6f304b069240836af60f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428740 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#810866}
-
Matthew Denton authored
These wrap the process_vm_writev() and process_vm_readv() syscalls which write to another process's memory (as long the caller has ptrace privileges for the target process). This is necessary for the USER_NOTIF broker to read syscall params and write to syscall outparams. Bug: 1117351 Change-Id: I5b85884eb7f7545598affe91f3e4ec4cb6a569b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407010Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#810865}
-
Moe Ahmadi authored
Canary experiment: cr/329566898 Bug: 1096615 Change-Id: I8d75aec33c254d3aabe8ca8efae360c60e44a3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431462 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#810864}
-
Hidehiko Abe authored
This is preparation to share XkbTracker with wayland IME server. BUG=1123705 TEST=Built locally. Run exo_unittests. Change-Id: I7859c2193578cc5a18fa39a96c3fe86d2f39f4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428505 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#810863}
-
Istiaque Ahmed authored
This CL changes the constructor to take BrowserContext instead of ServiceWorkerContext. Typically, BrowserContext (Profile) is readily available in tests, so it makes the test code using the observer a bit straightforward to read. Bug: None Change-Id: Ife88eaf1d82708c9675f6d917b59a51d8777bdd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432806Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#810862}
-
harrisonsean authored
Make the omaha checkNow function static Bug: 1078782 Change-Id: Ia5c5c4e60b145ccb4fa306c64461654455040f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431945Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#810861}
-
Lei Zhang authored
Calculate |kBackoffPolicy| on first use at a local scope instead. Because base::TimeDelta::InMilliseconds() and friends are not constexpr, a global that calls them must do so during process startup. Remove deprecated DISALLOW_IMPLICIT_CONSTRUCTORS() usage along the way. Bug: 537099 Change-Id: If1680816bc18107f7b15e366e205b409c92bf0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430299Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#810860}
-
Robert Ma authored
These two fields have long been required and are now enforced in Chromium. Note that in the API these are represented as labels with specific formats. Also add "Test-WebTest" label by the way. Bug: 1132456 Change-Id: If8c226472f62a563a6f25f393e9dda563970de84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432055 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#810859}
-
Kevin Marshall authored
Adds unit tests which verify propagation of messages and channel events through FIDL/Blink and Blink/FIDL adapter layers. Fixes a FIDL flow control bug and adds a regression test for it. Add test main.cc for tests which depend on an active Mojo instance. Bug: 1117518 Bug: 1126571 Change-Id: Ied814298b82f9e5eef1e99b158b45bfdd9d1fd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422476Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#810858}
-
Xing Liu authored
If stopForeground is called between startForegroundService and startForeground. startForeground will not be called since we clear the cached service object. This will lead to a crash on O_MR1+. Android can reuse the service binder object when this happens. Bug: 1121096 Change-Id: Ic4088af174ca9561714442b29c2e6162995ddc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429635Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810857}
-
nuwanda authored
Change-Id: I199e2094d287748774cdf1f9930e2720ca3a3aa9 Bug: 1119834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390201Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Deep Roy <dproy@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Julia Semavina <nuwanda@google.com> Cr-Commit-Position: refs/heads/master@{#810856}
-
wutao authored
This patch adds a transform animation to scroll the long text in the media info. Text will stop a few seconds before scrolling. Bug: b/167236615 Test: added new tests Change-Id: I4c79b5e4a150dbe6d02b5d602af8b2d202e0f065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411545 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#810855}
-
Daniel Hosseinian authored
Handle messages requesting thumbnails from the PDF plugin. OutOfProcessInstance provides the callbacks for responding to the requests when the thumbnails are ready and passes the request to the PDF engine. Bug: 652400 Change-Id: I2ed5acfa4fcfbb0167a38a6149017756f44c36d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336312 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#810854}
-
Nnamdi Theodore Johnson-Kanu authored
- Creates an interface (delagate) which provides alternate UI behaviors for the Cellular Setup flows. - Cellular setup UI is embedded in either OOBE or os-settings, the delegate implements functionality depending on where it is embedded. - Creates a default implementation of delegate interface in os-settings - Updates cellular_setup ui test and adds fake_cellular_setup_ delagate screenshot: https://screenshot.googleplex.com/4qdJyUh4yx52iGa.png Bug: 1093185 Change-Id: Ifd604c8bb57643520ee69f36378053b60e09c822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419631 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#810853}
-
Tomasz Wiszkowski authored
Bug: 1106109 Change-Id: I48afdd0a754f11681520e4c8eb581d082102fddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431780 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Auto-Submit: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#810852}
-
nuwanda authored
The script runs TBMv3 metric and the corresponding TBMv2 metric on given traces and compare the results. If the metrics are equal than the newly added TBMv3 metric is the same as the old TBMv2 metric. If the results are different the script will output trace files and json files (results of run_metric) so the user is able to debug analyse them. Example usage: tools/perf/validate_tbmv3_metric --tbmv3-name=uma_metrics --tbmv3-histogram=graphics_smoothness_percent_dropped_frames_compositor_thread_universal --tbmv2-name umaMetric --tbmv2-histogram=Graphics.Smoothness.PercentDroppedFrames.CompositorThread.Universal Now a path to a file with trace link is required. We plan to automate the process of getting trace links in the future. Metric units are also ignored in this change. We plan to integrate units support later along with other fancy statistics about metric values. For more information, see https://docs.google.com/document/d/1wI1gk5X2-eQk9-NLHSK_EgmVs-doyyodz0XtP7Pd15M/edit?usp=sharing Change-Id: I4ca068357a9a0c0f9a5cd5267c64aa53acfe8513 Bug: 1128919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413492Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Deep Roy <dproy@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Julia Semavina <nuwanda@google.com> Cr-Commit-Position: refs/heads/master@{#810851}
-
Ben Pastene authored
Bug: 1132373 Change-Id: I2490fcea413a338cd8ecebc19c4ab25680a53e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432127Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#810850}
-
Brian Malcolm authored
This is the UI name of the entity that manages device's domain, which caneither be a domain name (foo.com), or the admin's email address (user@foo.com) BUG=chromium:1081272 Change-Id: I5d1adcf4182bf3beb3dfc05980106efbc88af53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431457Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#810849}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/faa49d773432..76b5fbb58db7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jam@google.com,fdoray@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1084659,chromium:1093383,chromium:1099917,chromium:1099982,chromium:1105096,chromium:1116130,chromium:1128599,chromium:1128653,chromium:1128747,chromium:1130677,chromium:1130962,chromium:1131230,chromium:912681 Tbr: jam@google.com,fdoray@google.com Change-Id: I4fe3ba9beff57593fa125e390802a546b97e8819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432786Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810848}
-
Garrett Beaty authored
Change-Id: I9a01eb868ece2231f3219903ae6201b9c3b6b924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432307 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#810847}
-
Gayane Petrosyan authored
Bug: 1102382 Change-Id: Idd1d928eb8c2885f3610d68a771798fd3b22e00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432807Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#810846}
-
Alex Moshchuk authored
Bug: 1125658, 621724 Change-Id: If32ea623620989e40fc9a814d0a97813a2067f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424347 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#810845}
-
Yusuke Sato authored
The latest arcvm-adbd.conf requires ARCVM_CID environment variable, but the variable can be set only after ARCVM is started. This CL changes the timing of the arcvm-adbd job startup. BUG=chromium:1126289 TEST=components_unittests Change-Id: If53bec0394626cc0f2d585635a3b45348bc49113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429847Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Willie Koomson <wvk@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#810844}
-
- 25 Sep, 2020 16 commits
-
-
Tommy Li authored
The dot menu was supposed to be invisible for enterprise policy injected search engines. This was regressed in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/564204/ This CL restores it and adds a test. Bug: 1123909 Change-Id: Id38a2194764b3c1fa7ffc1bec9d4ef2c8d890037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427290Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#810843}
-
cfredric authored
Bug: 1129506 Change-Id: I108aa17dc23fa407c4f3b9d6b0ed6a7ef18ce7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416881 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#810842}
-
Curt Clemens authored
Add a new pod button to the ash system tray for toggling the high visibility mode of Nearby Share. l10n strings in a followup CL. Bug: b/154866703 Test: unit_tests, ash_unittests Change-Id: I2c3be0bcf5b593c58f030e63b69d499de211f3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405441 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#810841}
-
wutao authored
Current implementation will not return callback until succeed. This patch adds a limit to the max number of retries. This patch also changes the backoff logic to use backoff entry. Bug: b/169250512 Test: added new tests. Change-Id: Id421a152dc7fe6ce3f365086d16c6e611b4fc001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427082 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#810840}
-
Kimiyuki Onaka authored
ArcCrashCollector calls DumpNativeCrash with file names and FDs when a new crash dump appears. DumpNativeCrash is responsible to call crash_reporter. FDs are used for passing the file contents. BUG=b:136697350 TEST=tast run my_crbook arc.NativeCrash.\* arc.AppCrash.\* Change-Id: I5017d388eb3182454023b354c3714bbecc664354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379331 Commit-Queue: Kimiyuki Onaka <kimiyuki@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#810839}
-
Mehran Mahmoudi authored
This CL introduces the new PaintPreviewWindowAndroidHelper class. This class stores activity-specific variables in PaintPreviewHelper. Using the BrowserControlsManager class, it makes the top toolbar persistent when a Paint Preview is shown. This CL also fixes a bug where TabbedPaintPreviewPlayer#onDismiss was never called. Bug: 1131497 Change-Id: I3caf7017f601536ba03c1e1c60c9b024917f6063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425433 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#810838}
-
Evan Stade authored
ApplicationStatus doesn't work outside of //chrome (crbug.com/470582), so this code must be deferred to the embedder. A WebContents parameter is included because it's necessary for WebLayer, even though Chrome doesn't use it. The MediaRouteDialogManager interface is also removed as it only has a single implementor, BaseMediaRouteDialogManager. Bug: 1057100 Change-Id: Ifab92742162cf64e42c75eacfdac6b014940b3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430586 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#810837}
-
Michael Checo authored
- Encapsulates a data point in a diagnostics card. Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I0cb465fdd62ac2fafa5d17436e6486f5f0a2bf5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427075 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#810836}
-
Mike Wittman authored
First in a series factoring the ThreadProfiler platform specific configuration state from the code that takes action on the state. Defines an IsSupported function that is true if the profiler is supported on the chrome branding and channel for the platform. The end goal is to reduce the configuration complexity, to support enabling per-thread on Android. Bug: 1129939 Change-Id: Ibbd6f4725804b40ac77e15aaa3bd15ad76a0e7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425165Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#810835}
-
Chris Palmer authored
On x86 as well as on ARM. It breaks Java test `JavaBridgeCoercionTest.testPassNull`. There is probably an underlying bug that we need to fix. Bug: 1131993, 977230 Change-Id: Ie579516a06d13577fcb4a61fa515a2d873bfcd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429233Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#810834}
-
Dominique Fauteux-Chapleau authored
This should not change deep scanning behaviour with Connectors. Bug: 1103390 Change-Id: I8f45972d7649eae31d7c3e9024f925c059ad68d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427427Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#810833}
-
Michael Chang authored
Rsync was failling with permission denied (13) when trying to send_file for some tests. The belief is that it's happening because the file that was trying to be sent is lacking read permissions for all. Bug: 1126533 Change-Id: Iaf02d8bb71c8a571230cab6fc5f873d8227d7f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431781 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#810832}
-
Jeffrey Cohen authored
Bug: 1024586 Change-Id: I1b3e2e7adce8d36a818e9619b4f28eb4b0fcd88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427134Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810831}
-
Meilin Wang authored
This CL moves the existing |PhoneStatusView| out of the |PhoneHubView| and adds it as a separate child view of the bubble, so that it can always show on top of UIs and display available phone information and the settings icon. Misc: remove unnecessary header files. Screenshot: https://screenshot.googleplex.com/6DXqin6MZPcTVVj.png BUG=1106937,1126208 Change-Id: I321d0511874cfa95dcbb8276fedf41b14e0f684b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429390Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#810830}
-
ssid authored
pthread_getattr_np implementation in bionic throws sigabrt on failure to read proc/ file. Implement this function to avoid crashes. BUG=1129941 Change-Id: I54b94a609201a998924aaa8c8e77051f85acf377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425744 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#810829}
-
Koji Ishii authored
This patch invalidates ink overflow cache for text when |NeedsRecomputeVisualOverflow|. Computing text ink overflow is expensive, especially for i18n fonts on Windows. Bug: 1130856 Change-Id: I73e14af84e1c261fd95acf5ceb1bade1c46d0095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424365Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#810828}
-