GitLab

Specially being both locks.

BUG=none

Review URL: https://codereview.chromium.org/661213002

Cr-Commit-Position: refs/heads/master@{#300387}

there is no Athena port of AppListService (crbug.com/417571)

In addition this CL:
- Fixes crashes in webstorePrivate.completeInstall() when the Javascript
requests the "App installed" bubble to be shown. In practice this is only
requested for extensions which should not be enabled (but are enabled) in
Athena.
- Moves ExtensionInstallUI and CrxInstallerError to
extensions/browser/install so that they can be used by code in Athena
- Refactors ExtensionInstallUI to remove the static methods

BUG=414341,417571
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/634313004

Cr-Commit-Position: refs/heads/master@{#300386}

The related CL:
https://codereview.chromium.org/657293002/

BUG=141116

Review URL: https://codereview.chromium.org/665583002

Cr-Commit-Position: refs/heads/master@{#300385}

BUG=

Review URL: https://codereview.chromium.org/658803004

Cr-Commit-Position: refs/heads/master@{#300384}

The DisplayVirtualKeyboard function on Windows 8 and beyond should not be displaying the OSK if a physical keyboard is attached to the machine.

Added a function IsKeyboardPresent locally to win_util.cc which uses the setup API's to enumerate
keyboard devices and check for the common ones like ACPI\PNP and HID\VID. This function returns
true if the number of keyboards is greater than 1. This is a hacky approach and is being done
for lack of a good way to determine the presence of a keyboard. The documented methods don't work
well.

BUG=335735

Review URL: https://codereview.chromium.org/644783005

Cr-Commit-Position: refs/heads/master@{#300383}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/43b8b36..b0e89dc

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/642293006

Cr-Commit-Position: refs/heads/master@{#300382}

By using base::ScopedFD, the ownership of the returned FD becomes
clearer.

BUG=415294
R=brettw@chromium.org, jam@chromium.org, yzshen@chromium.org, sehr@chromium.org
TBR=gene@chromium.org

Review URL: https://codereview.chromium.org/621613002

Cr-Commit-Position: refs/heads/master@{#300381}

app_shell needs the client ID and oauth2 scopes for its identity API.

Just a refactor, no functional changes.

BUG=424653
TEST=extensions_unittests
TBR=xiyuan@chromium.org for header file rename touching chrome/browser/signin/easy_unlock_toggle_flow.cc

Review URL: https://codereview.chromium.org/671553002

Cr-Commit-Position: refs/heads/master@{#300380}

BUG=424997

Review URL: https://codereview.chromium.org/664023002

Cr-Commit-Position: refs/heads/master@{#300379}

BUG=423621

Review URL: https://codereview.chromium.org/657313003

Cr-Commit-Position: refs/heads/master@{#300378}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c6bd766..660cc59

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/647553007

Cr-Commit-Position: refs/heads/master@{#300377}

-Wtype-limits will throw warnings if an enum is used interchangably
with an integer. Replace some such usages with proper integer
constants.

BUG=424334
TEST=build, unit test

Review URL: https://codereview.chromium.org/662893002

Cr-Commit-Position: refs/heads/master@{#300376}

* Refactors the code to allow adding metrics as part of metrics provider
  interface
* Implements a function in android_metrics_provider to record a new
  histogram which records the current document mode. This is needed for
  better analysis in Hera. I am adding a new histogram because the
  semantics are a bit different from DocumentActivity.RunningMode. The
  previous histogram is used only to record eligible devices that have
  manually opted in or out. The new histogram will record for all devices
  regardless of whether they could possibly be in document mode.

BUG=418642

Review URL: https://codereview.chromium.org/658903002

Cr-Commit-Position: refs/heads/master@{#300375}

The LEA instruction within the inline assembly statement was throwing
off glibc's backtrace() function, because it lost track of where the
stack was.  The easy fix for this is to convert SyscallAsm() to simply
use the standard C calling convention on X86-64, and make it into a
normal C function call so the compiler can ensure CFI information is
correct for us.

While here, there's no need to use the "call/pop/addq" trick to
compute a PC-relative address because we have %rip-based addressing.
So simply use "lea 2f(%rip), %rax" to compute the return address (and
avoid branch mispredictions from desync'ing the call stack).

BUG=424973

Review URL: https://codereview.chromium.org/661393004

Cr-Commit-Position: refs/heads/master@{#300374}

Mean frame time is in other benchmarks, but it's a good
sanity check for understanding performance changes. So is
tasks-per-frame on each thread, so that is also added in this
patch.

BUG=None

Review URL: https://codereview.chromium.org/643343002

Cr-Commit-Position: refs/heads/master@{#300373}

BUG=425164

Review URL: https://codereview.chromium.org/646753003

Cr-Commit-Position: refs/heads/master@{#300372}

Mojo: mojob.sh: Add support for gn, and remove support for gyp and shared library (component) builds.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/668603003

Cr-Commit-Position: refs/heads/master@{#300371}

This CL allows web pages to intercept the Ctrl+Shift+0 accelerator when no UI scaling is applied (which is the common case)

BUG=404473
TEST=None

Review URL: https://codereview.chromium.org/668573002

Cr-Commit-Position: refs/heads/master@{#300370}

Data reduction proxy statistics are accumulated in local
state preferences. To support desktop and other platforms
with multiple profiles, these are being ported to profile
preferences.

BUG=411373

Review URL: https://codereview.chromium.org/652743004

Cr-Commit-Position: refs/heads/master@{#300369}

There were several places in this file where an error code value
was checked to see if it was less than QUIC_NO_ERROR or
QUIC_STREAM_NO_ERROR, which are both 0. On some compilers this
causes a warning, because such checks are trivially true.

BUG=424334
TEST=net_unittests
R=rch@chromium.org

Review URL: https://codereview.chromium.org/662513007

Cr-Commit-Position: refs/heads/master@{#300368}

Remove references to cancel-button CSS class, which is not defined.

BUG=none
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/645223004

Cr-Commit-Position: refs/heads/master@{#300367}

bridged_native_widget_unittest.mm currently fails to compile on 10.7+
SDKs because there is no such thing as
NSWindowDidFailToEnterFullScreenNotification (whoops).

The failures don't go through NSNotificationCenter, but to the
NSWindowDelegate protocol directly. So, add a dummy protocol for 10.6
and, in the simulate fullscreen failure test, send
windowDidFailTo{Enter,Exit}FullScreen to the window delegate directly.

Call via `id` so the test compiles on 10.6 SDKs, but return early so the
tests pass when actually running on 10.6.

BUG=378134
TEST=By tracing the simulation test, and manually to generate an actual
failure.

Review URL: https://codereview.chromium.org/665823002

Cr-Commit-Position: refs/heads/master@{#300366}

R=lcwu@chromium.org,damienv@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/652353003

Cr-Commit-Position: refs/heads/master@{#300365}

This change makes Chrome on Chrome OS ask permission_broker for access to serial devices.

BUG=173548
TEST=Chrome can access serial devices on Linux, chromeos=1, full Chrome OS.

Review URL: https://codereview.chromium.org/646053002

Cr-Commit-Position: refs/heads/master@{#300364}

Throw IllegalArgumentException from Cronet HttpUrlRequestFactoryConfig.addQuicHint if host param is URL.

This is needed to prevent invalid hosts from being added to HttpServerProperties and having Quic hints not working correctly.

HttpUrlRequestFactoryConfig is pure Java and doesn't depend on native library, so it only provides a rudimentary check, but URLRequestContextAdapter::InitRequestContextOnNetworkThread() performs IsCanonicalizedHostCompliant check and uses LOG(ERROR) for invalid hosts.

BUG=420464
TEST=build/android/test_runner.py instrumentation  --test-apk=CronetTestInstrumentation -f *Quic*

Review URL: https://codereview.chromium.org/642913004

Cr-Commit-Position: refs/heads/master@{#300363}

Pick up the changes to use scoped_ptr<T>::Pass() instead of PassAs().

BUG=423621

Review URL: https://codereview.chromium.org/664233002

Cr-Commit-Position: refs/heads/master@{#300362}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

This CL instruments most popular OnRefreshTokenAvailable overrides.

BUG=422460
TBR=jam@chromium.org, zelidrag@chromium.org, erikwright@chromium.org

Review URL: https://codereview.chromium.org/643183003

Cr-Commit-Position: refs/heads/master@{#300361}

R=lcwu@chromium.org,gusfernandez@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/659563004

Cr-Commit-Position: refs/heads/master@{#300360}

CQ somehow broke the binary file. This CL relands it.

BUG=318404
TBR=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/668833002

Cr-Commit-Position: refs/heads/master@{#300359}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/662713004

Cr-Commit-Position: refs/heads/master@{#300358}

The string is changing to "This computer will no longer receive Google
Chrome updates because its hardware is no longer supported." Previously,
the message began with "This computer will soon stop receiving".

The new string has existed in Chrome for a long time in preparation for
this change, and it has already been translated.

BUG=425259

Review URL: https://codereview.chromium.org/663223002

Cr-Commit-Position: refs/heads/master@{#300357}

This change does not affect the behavior when using a system-configured
proxy or a PAC file.

BUG=123716

Review URL: https://codereview.chromium.org/545633002

Cr-Commit-Position: refs/heads/master@{#300356}

This pulls in the following Native Client changes:

r13932: (jvoung) Keep the perf data of the trusted version of performance_tests separate.
r13933: (jvoung) Enable arm callingconv test for varargs and va_list.
r13934: (jvoung) Allow 'opt' bots to use GN with is_debug=false ('dbg' bots get debug).
r13935: (nfullagar) Initial benchmark suite for toolchain side.
r13936: (nfullagar) Add third_party/computer_language_benchmarks_game to DEPS
r13937: (petarj) [MIPS] Add missing -mtls-use-call when building irt libraries
r13942: (yyanagisawa) Avoid using mismatch compilers from buildbot.
r13947: (shyamsundarr) allow avx/xop/fma instructions but disable all them via def file attributes.

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/667783002

Cr-Commit-Position: refs/heads/master@{#300355}

mojo_examlpes.gypi was removed in the following CL:
https://codereview.chromium.org/647263005

BUG=423889
TEST=NONE
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/642243005

Cr-Commit-Position: refs/heads/master@{#300354}

Release notes for Checkstyle 5.9
http://checkstyle.sourceforge.net/releasenotes.html

The most important part is all the fixes for Indentation check that allows
us to finally enable it for presubmit.

Also adding OWNERS file to checkstyle directory.

BUG=318404
TBR=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/661153003

Cr-Commit-Position: refs/heads/master@{#300353}

When navigation away from a page fails, the displayed error page uses
the zoom level of the current page since the underlying RenderViewImpl
is re-used without resetting its zoom level before displaying the error
page.

This CL forces the RenderViewImpl's zoom level to be reset to 0 whenever
the url being navigated to is unkown to the RenderViewImpl.

BUG=422464

Review URL: https://codereview.chromium.org/663203002

Cr-Commit-Position: refs/heads/master@{#300352}

BUG=422142
R=asvitkine

Review URL: https://codereview.chromium.org/637953010

Cr-Commit-Position: refs/heads/master@{#300351}

This deadlock involves SyncBackendRegistrar running on the sync thread and at least two
workers - one of them (worker A) running on UI thread and
another (worker B) running on some other background thread.
In this particular case it was a password worker running on Password model thread.

The deadlock occurs when the SyncBackendRegistrar shutdown
code running in the sync thread blocks on a waitable event
set by worker B, at the same time the worker B's thread is
blocked for whatever reason waiting to make a synchronous
call into the UI thread, and at the same time the worker A
is blocked on a lock owned by the sync thread while it attempts
to unregister itself with SyncBackendRegistrar.

I think the main issue here is that the sync thread might
block on a worker. This is possible in only one situation -
when that worker hasn't have a chance to run any tasks because
its own thread was blocked doing something else.

The fix removes this dependency. The only reason this
blocking occurs is because ModelSafeWorker has a mechanism
for subscribing / unsubscribing to the MessageLoop descruction
which has to be done in the right thread context.
In order to unsubscribe the worker needs to remember the message loop it runs on which is done
in SetWorkingLoopToCurrent callback, which is called from a task
posted on the worker's thread. There is also a waitable
event which is signalled at that time. The even is used to
block ModelSafeWorker::UnregisterForLoopDestruction from
delegating the call on an uninitialized message loop which
is possible only when SetWorkingLoopToCurrent has never been called.

There is no need to block in UnregisterForLoopDestruction.
If the registration for even loop destruction hasn't been
been done yet (because the thread is blocked) then there
really no reason to wait for that and then immediately
unsubscribe. We can skip both subscription to the even loop
notification altogether and let the registrar know that
it is OK to remove the worker. That's essentially what the
fix does.

I added a test that verifies that SyncBackendRegistrar::Shutdown
doesn't block on a blocked model type thread anymore.

BUG=423078

Review URL: https://codereview.chromium.org/637413003

Cr-Commit-Position: refs/heads/master@{#300350}

Added a mobile and desktop testing in case the browser being tested has a
user agent that defaults to the tablet user agent.

BUG=421229

Review URL: https://codereview.chromium.org/640453002

Cr-Commit-Position: refs/heads/master@{#300349}

Enable RenderTextHarfBuzz on Chrome OS.

BUG=321868,376077,423791

Review URL: https://codereview.chromium.org/634983002

Cr-Commit-Position: refs/heads/master@{#300348}