GitLab

BUG=646576

Review-Url: https://codereview.chromium.org/2330293003
Cr-Commit-Position: refs/heads/master@{#418543}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4d0ad1c2..567592da

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2335343003
Cr-Commit-Position: refs/heads/master@{#418542}

Revert of Add fuzzer for AXTree and fix a couple of bugs it found. (patchset #3 id:40001 of https://codereview.chromium.org/2323103002/ )

Reason for revert:
Caused Address Sanitizer problem with BrowserAccessibilityManagerTest.TestFatalError

BUG=646777

Original issue's description:
> Add fuzzer for AXTree and fix a couple of bugs it found.
>
> BUG=none
>
> Committed: https://crrev.com/cd760f121c0701c0f7609a3437735751cf4ac416
> Cr-Commit-Position: refs/heads/master@{#418308}

TBR=aarya@google.com,aboxhall@chromium.org,mmoroz@chromium.org,ochang@chromium.org,dmazzoni@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review-Url: https://codereview.chromium.org/2346473002
Cr-Commit-Position: refs/heads/master@{#418541}

BUG=601247

Review-Url: https://codereview.chromium.org/2334803002
Cr-Commit-Position: refs/heads/master@{#418540}

BUG=646097
TBR=nyquist@chromium.org
CC=juncai@chromium.org

Review-Url: https://codereview.chromium.org/2342583002
Cr-Commit-Position: refs/heads/master@{#418539}

R=mmenke@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2335133005
Cr-Commit-Position: refs/heads/master@{#418538}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599

Review-Url: https://codereview.chromium.org/2320653002
Cr-Commit-Position: refs/heads/master@{#418537}

This patch uses testharness.js asserts to test canvas
winding enumeration and also checks canvas borkedness
of rects with zero size.

BUG=639732

Review-Url: https://codereview.chromium.org/2311223002
Cr-Commit-Position: refs/heads/master@{#418536}

This CL also fixes what seems like a bug, where the original code used the
scoped temp dir path before initialization, which meant files were put in the
directory "" (presumably the current working directory).

TBR-ing achuith@, who approved this in
https://codereview.chromium.org/2318023002/ and suggested splitting off into a
separate CL.

TBR=achuith@chromium.org
BUG=640599

Review-Url: https://codereview.chromium.org/2338793004
Cr-Commit-Position: refs/heads/master@{#418535}

This cl splits the big CL with changes to net/ folder and
has changes only to net/report_sender according to the
changes to URLRequest API.

What the big cl does:
It modifies net/ clients that use URLRequest API as long as
URLRequest::Read returns int net errors and
URLRequest::Delegate and NetworkDelegate methods
(for example, OnResponseStarted or OnCompleted) have int
net_error in the arguments now.

The reason behind splitting the CL into small one is that
an android bot started to be unstable and unittests became
flaky. It was not possible to locate the problem and the
decision was to split the CL and upload small parts with a
6+ hours interval in order to make it possible to locate
the problematic code.

The big CL is located here -
https://codereview.chromium.org/2265873002/

BUG=423484

Review-Url: https://codereview.chromium.org/2331863002
Cr-Commit-Position: refs/heads/master@{#418534}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=achuith@chromium.org
BUG=640599

Review-Url: https://codereview.chromium.org/2318023002
Cr-Commit-Position: refs/heads/master@{#418533}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/96eff685..4d0ad1c2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2341683002
Cr-Commit-Position: refs/heads/master@{#418532}

This patch converts "editing/execCommand/switch-list-type.html" to use w3c test
harness to simplify test script for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2334123004
Cr-Commit-Position: refs/heads/master@{#418531}

This CL sorts handlers of the lifecycle events in call order and canonicalizes
their names.

BUG=640843

Review-Url: https://codereview.chromium.org/2337253005
Cr-Commit-Position: refs/heads/master@{#418530}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c42044026b81..b9b708477f23

$ git log c42044026..b9b708477 --date=short --no-merges --format='%ad %ae %s'
2016-09-14 petrcermak [tracing] Add support for preventing users from changing table sort order

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2341703002
Cr-Commit-Position: refs/heads/master@{#418529}

This patch provides platform sensor's default configuration to the Blink side at 'SensorProxy' initialization stage.
Default configuration will be used for sensors construction by default, e.g. 'let sensor = new AmbientLightSensor();'.

A few related changes are added as well:
- Rename 'SensorReadBuffer' to 'SensorInitParams'
- Remove repeated code calling 'startListening()' from 'Sensor::onSensorInitialized()'
- Call 'reset()' for all 'SensorProxy' members from 'SensorProxy::handleSensorError()'

BUG=606766

Review-Url: https://codereview.chromium.org/2330943002
Cr-Commit-Position: refs/heads/master@{#418528}

This patch converts "editing/execCommand/switch-list-type-with-inner-list.html" to use w3c test
harness to simplify test script for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2337413002
Cr-Commit-Position: refs/heads/master@{#418527}

This patch converts "editing/inserting/insert-3654864-fix.html" to use w3c test
harness to simplify test script, and renames to "replace_text_with_br.html" to
provide a hint what this test script verifies, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2332423004
Cr-Commit-Position: refs/heads/master@{#418526}

This patch converts "editing/inserting/insert-after-delete.html" to use w3c test
harness to simplify test script for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2340703002
Cr-Commit-Position: refs/heads/master@{#418525}

This patch makes |assert_selection()| to set focus to sample IFRAME to ensure
|eventSender| and |testRunner.execCommand()| to work on sample IFRAME rather
than main frame.

The expectation sample of "editing/deleting/delete_by_word.html" is changed to
"Ctrl+Backspace", delete by word, deletes word before caret. Before this
patch, "Ctrl+Backspace" was sent to main frame and sample IFRAME didn't handle
it and did nothing.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2341563003
Cr-Commit-Position: refs/heads/master@{#418524}

This test is flaky on Mac debug bot.

BUG=646758
TBR=gayane@chromium.org,asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2338213003
Cr-Commit-Position: refs/heads/master@{#418523}

This patch converts "editing/inserting/insert-3775316-fix.html" to use w3c test
harness to simplify test script, and renames to "insert_br_at_end_of_block.html"
to provide a hint what this test script verifies, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2337263003
Cr-Commit-Position: refs/heads/master@{#418522}

This patch converts "editing/execCommand/remove-list-items.html" to use w3c test
harness to simplify test script for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2337333003
Cr-Commit-Position: refs/heads/master@{#418521}

Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests. (patchset #4 id:60001 of https://codereview.chromium.org/2333983004/ )

Reason for revert:
Asan failure

Original issue's description:
> Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock class of DiskMountManagerObserver.
>
> This change is based on
> https://codereview.chromium.org/2292473002/
> which was once merged but reverted by
> https://codereview.chromium.org/2340433002/
>
> BUG=641943
>
> Committed: https://crrev.com/a07c4fb1ece6ee6c6a2170825208b1f873012a0a
> Cr-Commit-Position: refs/heads/master@{#418478}

TBR=satorux@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641943

Review-Url: https://codereview.chromium.org/2343593002
Cr-Commit-Position: refs/heads/master@{#418520}

Revert of gn: Generalize process_version() and move it to build/util (patchset #4 id:60001 of https://codereview.chromium.org/2308313003/ )

Reason for revert:
This appears to cause compile errors on
"Google Chrome Linux x64", closing the main waterfall.

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/13577

FAILED: installer/version.txt
python ../../build/util/version.py --official -f ../../chrome/VERSION -f ../../chrome/app/theme/google_chrome/BRANDING -o installer/version.txt
Traceback (most recent call last):
  File "../../build/util/version.py", line 170, in <module>
    sys.exit(main())
  File "../../build/util/version.py", line 159, in main
    """ % values
KeyError: 'LASTCHANGE'

Original issue's description:
> There is nothing really chrome-specific in the process_version()
> template, and if we stop always passing some files in chrome/ on every
> invocation it is possible to generalize it and move it to build/util
> instead (and fix some layering violation comments along the way).
>
> Compared to its previous incarnation, process_version() no longer passes
> LASTCHANGE, BRANDING and VERSION automatically to version.py. This makes
> it easier for callers to specify their own |sources| with values that
> may override those set in those 3 files.
>
> A new wrapper, process_version_rc_template(), was introduced to cater
> for callers (generally Windows ones) who need to process a .rc.version
> file that requires the values from LASTCHANGE, BRANDING and VERSION. It
> always passes those 3 files to process_version() before any optional
> additional |sources|, and |template_file| defaults to
> chrome_version.rc.version.
> Since this template depends on files from //chrome, it lives in the
> newly-added //chrome/process_version_rc_template.gni.
>
> R=dpranke@chromium.org,brettw@chromium.org
>
> Committed: https://crrev.com/cf276fc41653b2830a5ec796d4db09b199754677
> Cr-Commit-Position: refs/heads/master@{#418514}

TBR=phajdan.jr@chromium.org,brettw@chromium.org,ddorwin@chromium.org,dpranke@chromium.org,xhwang@chromium.org,raphael.kubo.da.costa@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2338093003
Cr-Commit-Position: refs/heads/master@{#418519}

BUG=645071
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2321953002
Cr-Commit-Position: refs/heads/master@{#418518}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599

Review-Url: https://codereview.chromium.org/2317003002
Cr-Commit-Position: refs/heads/master@{#418517}

Implements Unwrap(CrossThreadWeakPersistent) that returns a CrossThreadPersistent so the object doesn't get collected during callback invocation.

BUG=591606

Review-Url: https://codereview.chromium.org/2207333002
Cr-Commit-Position: refs/heads/master@{#418516}

BUG=617492

Review-Url: https://codereview.chromium.org/2341613002
Cr-Commit-Position: refs/heads/master@{#418515}

template, and if we stop always passing some files in chrome/ on every
invocation it is possible to generalize it and move it to build/util
instead (and fix some layering violation comments along the way).

Compared to its previous incarnation, process_version() no longer passes
LASTCHANGE, BRANDING and VERSION automatically to version.py. This makes
it easier for callers to specify their own |sources| with values that
may override those set in those 3 files.

A new wrapper, process_version_rc_template(), was introduced to cater
for callers (generally Windows ones) who need to process a .rc.version
file that requires the values from LASTCHANGE, BRANDING and VERSION. It
always passes those 3 files to process_version() before any optional
additional |sources|, and |template_file| defaults to
chrome_version.rc.version.
Since this template depends on files from //chrome, it lives in the
newly-added //chrome/process_version_rc_template.gni.

R=dpranke@chromium.org,brettw@chromium.org

Review-Url: https://codereview.chromium.org/2308313003
Cr-Commit-Position: refs/heads/master@{#418514}

ExceptionState is now a scope-like object, and guarantees
that an exception is automatically thrown at destruction.
ExceptionToPromiseScope similarly guarantees to return
a reject promise instead of throwing an exception.

A new Jinja2 filter "format_remove_duplicates" helps
write a template more easily without caring duplicates.
    {% if A_enabled %}
    ScriptState* scriptState = ...;
    A(scriptState);
    {% endif %}
    {% if B_enabled %}
    ScriptState* scriptState = ...;
    B(scriptState);
    {% endif %}
produces two lines of definitions of |scriptState|,
however, format_remove_duplicates removes the duplicates.

Jinja2 macro "propagate_error_with_exception_state" is no
longer necessary, because ExceptionState and
ExceptionToPromiseScope automatically throws an exception
or returns a reject promise appropriately.

This CL alone does not fix crbug.com/627309 , but the CL
makes it easy to fix the issue.

BUG=627309

Review-Url: https://codereview.chromium.org/2301993002
Cr-Commit-Position: refs/heads/master@{#418513}

|context_| has already been created in MojoChildConnection constructor
initialization list, no need to create it again in construtor body.

BUG=none

Review-Url: https://codereview.chromium.org/2338753002
Cr-Commit-Position: refs/heads/master@{#418512}

Revert of 🍵 Refactor the various locale_paks() templates to be more shared (patchset #2 id:260001 of https://codereview.chromium.org/2339783002/ )

Reason for revert:
The refactoring of the ios file is likely incorrect as it breaks the autoroller (as some files are no longer generated or have different name).

Reverting as half of the touched files are in ios/.

Original issue's description:
> Reland of Refactor the various locale_paks() templates to be more shared
>
> Reverted by:
> https://codereview.chromium.org/2340673002/
>
> Reason for reland:
> Now gn gens for enable_resource_whitelist_generation = true
>
> Main motivation for this is to more easily add per-target
> repack_whitelist.
>
> TBR=michaelbai@chromium.org,thakis@chromium.org,sdefresne@chromium.org,estevenson@chromium.org,rsesek@chromium.org,brettw@chromium.org
> BUG=645716
>
> Committed: https://crrev.com/d83512c644c7c61331a32c97ba549fcb1d8793cb
> Cr-Commit-Position: refs/heads/master@{#418450}

TBR=michaelbai@chromium.org,thakis@chromium.org,estevenson@chromium.org,rsesek@chromium.org,brettw@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=645716

Review-Url: https://codereview.chromium.org/2338213002
Cr-Commit-Position: refs/heads/master@{#418511}

Current clang version supports the UUID syntax in <robuffer.h>, removing
additional declaration.

BUG=512433
R=toyoshim@chromium.org

Review-Url: https://codereview.chromium.org/2341603002
Cr-Commit-Position: refs/heads/master@{#418510}

BUG=

Review-Url: https://codereview.chromium.org/2334003004
Cr-Commit-Position: refs/heads/master@{#418509}

Previously, loadFile() is called to load the test page during performance
measurement in PerfTestRunner.measurePageLoadTime(), and thus the results of
blink_perf.svg tests were affected by the performance of loadFile() (that is not
related to SVG).
This CL makes the loadFile() to be executed before measurement and thus avoids
blink_perf.svg regressions caused by loadFile() performance regression.

The loadFile() performance regression is caused by [1] because, after [1],
synchronous XHRs are evicted from MemoryCache when Oilpan GC is executed.
[1] https://codereview.chromium.org/2296913003
This is expected and we can ignore the regression unless it causes regressions
in real use cases.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
BUG=645363

Review-Url: https://codereview.chromium.org/2323313002
Cr-Commit-Position: refs/heads/master@{#418508}

For element.animate() calls of the form
"element.animate({property: [a, b, c]}, timing);" we were not accepting
non-array iterables for the value list.

This patch extends support for generic iterable objects to property indexed
keyframe values.

This behaviour corresponds to step 6.3 of
http://w3c.github.io/web-animations/#process-a-keyframe-like-object
where we cast the values as a (DOMString or sequence<DOMString>) object.

BUG=645393

Review-Url: https://codereview.chromium.org/2334123002
Cr-Commit-Position: refs/heads/master@{#418507}

BUG=610195

Review-Url: https://codereview.chromium.org/2319033002
Cr-Commit-Position: refs/heads/master@{#418506}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9d075810..96eff685

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2338163002
Cr-Commit-Position: refs/heads/master@{#418505}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2260433003
Cr-Commit-Position: refs/heads/master@{#418504}