GitLab

Popup windows don't have bookmark bars, so check for supportsBookmarkBar
before trying to position the sheet next to the bookmark bar.
Fix incorrect use of defaultSheetRect.size.height, it has no meaning according
to AppKit docs.

BUG=436959

Review URL: https://codereview.chromium.org/836173002

Cr-Commit-Position: refs/heads/master@{#310187}

Revert of Use Surfaces on Windows, Linux, and Mac OS (try #3) (patchset #1 id:1 of https://codereview.chromium.org/786243003/)

Reason for revert:
May be causing some browser_tests to flake:

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34159
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34157
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34156
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34152
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34150
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34149

Original issue's description:
> Use Surfaces on Windows, Linux, and Mac OS (try #3)
>
> Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet.
>
> BUG=334090
> TBR=piman@chromium.org
>
> Committed: https://crrev.com/7fa9d3f715573c22081f11238a4ccf44bc0efb19
> Cr-Commit-Position: refs/heads/master@{#309998}

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=334090

Review URL: https://codereview.chromium.org/840673002

Cr-Commit-Position: refs/heads/master@{#310186}

BUG=445307

Review URL: https://codereview.chromium.org/833263003

Cr-Commit-Position: refs/heads/master@{#310185}

The API was renamed a while ago, but the doc template was never
updated.

BUG=None
TBR=kalman@chromium.org
TBR=rkc@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/829333005

Cr-Commit-Position: refs/heads/master@{#310184}

BUG=445396

Review URL: https://codereview.chromium.org/838553003

Cr-Commit-Position: refs/heads/master@{#310183}

The data reduction proxy is used only if the effective proxy
configuration resolves to DIRECT for the requested URL. This
works by allowing the ProxyService to choose an effective proxy
configuration and to decide on the prioritized list of proxies
to use for a URL given that configuration. Just before the list
is
used, the DataReductionProxyNetworkDelegate's OnResolveProxy()
method provides an opportunity to change that list, which it
does, only if that list begins with DIRECT.

BUG=429826,444169

Review URL: https://codereview.chromium.org/792803007

Cr-Commit-Position: refs/heads/master@{#310182}

The test is a private key for P-256, using PKCS8 as the input format. The private key is exactly equal to order (max valid private key is n-1).

BUG=445679

Review URL: https://codereview.chromium.org/838573003

Cr-Commit-Position: refs/heads/master@{#310181}

This allows menus to fully unwind after MenuController::CancelAll() is
called, without any additional events processed through the nested
dispatcher.

In particular, tests that cancel their menu cannot hang at the very end
of the test when there are no more events left to dispatch. Before, we
relied on some event - ANY event - getting through nested dispatch in
order to continue unwinding. This could cause hangs in test code when
there weren't any more events.

If a test calls MenuController::CancelAll() and then terminates its
outer RunLoop, the program should terminate. This change ensures that.

BUG=432576, 446335
TEST=interactive_ui_tests

Review URL: https://codereview.chromium.org/831413002

Cr-Commit-Position: refs/heads/master@{#310180}

They used to be a inlined function in the header, which led to code generation when method is used. This changes the code generation only in DECLARE_WINDOW_PROPERTY_TYPE().

BUG=None
R=sadrul@chromium.org

Committed: https://crrev.com/f62e152bb7a13135a597d9766eb79551d3a24a73
Cr-Commit-Position: refs/heads/master@{#309252}

Review URL: https://codereview.chromium.org/801953002

Cr-Commit-Position: refs/heads/master@{#310179}

BUG=437116

Review URL: https://codereview.chromium.org/828063004

Cr-Commit-Position: refs/heads/master@{#310178}

BUG=

Review URL: https://codereview.chromium.org/843433002

Cr-Commit-Position: refs/heads/master@{#310177}

This icon size is needed for Mac. Now is consistent with icon sizes for
packaged apps.

BUG=445039

Review URL: https://codereview.chromium.org/836053002

Cr-Commit-Position: refs/heads/master@{#310176}

This CL
1. Relaxes the CursorShapeIsValid() check on ClientControlDispatcher
   to allow cursors with empty dimensions.
2. Modifies MouseCursorMonitorAura to sends an empty cursor when the
   cursor is ui::kCursorNone or when the cursor bitmap cannot be loaded.
3. Initializes the CursorShapeInfo with empty data on the VideoScheduler
   as it is a required field.

Review URL: https://codereview.chromium.org/833693002

Cr-Commit-Position: refs/heads/master@{#310175}

Chromecast platform has multiple binaries that each link in the data
file; this results in some wasted disk footprint.

R=lcwu@chromium.org,thakis@chromium.org
BUG=446387

Review URL: https://codereview.chromium.org/833183004

Cr-Commit-Position: refs/heads/master@{#310174}

Pulls in the following fixes:
b9d631d avformat/utils: Clear pointer in ff_alloc_extradata() to avoid leaving a stale pointer in memory
7575fa1 avfilter/buffer: use av_freep() to avoid leaving stale pointers in memory
0aa6981 avformat/matroskadec: Use av_freep() to avoid leaving stale pointers in memory
e860c4c avformat/mov: use av_freep() to avoid leaving stale pointers in memory
c61fcd2 avformat/mov: Clear array to prevent potential out of array read from av_dlog()
a6dd29c avformat/mov: fix integer overflow in mov_read_udta_string()
878627f mov: Fix negative size calculation in mov_read_default().
c179d68 mov: Fix overflow and error handling in read_tfra().

BUG=444533,444522,444539,444546
TEST=regression tests, test cases no longer crash
TBR=scherkus

Review URL: https://codereview.chromium.org/838653002

Cr-Commit-Position: refs/heads/master@{#310173}

R=hugo.holgersson@sonymobile.com,lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/835163003

Cr-Commit-Position: refs/heads/master@{#310172}

stream where available.

BUG=403138

Review URL: https://codereview.chromium.org/816193003

Cr-Commit-Position: refs/heads/master@{#310171}

This is one of the top 20 histogram by used data
size, but is unowned (thus doesn't show up on
the dashboard by default) and the data for it
has 99% of of samples fall under 3ms.

BUG=387734

Review URL: https://codereview.chromium.org/836233002

Cr-Commit-Position: refs/heads/master@{#310170}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2ad2a0a..4cdbe42

TBR=dglazkov@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/839643002

Cr-Commit-Position: refs/heads/master@{#310169}

The rotation lock tray was in an incorrect position within the system tray. This change moves it to be above the Settings item.

TEST=Have a device in maximize mode, open the system tray.
BUG=443654

Review URL: https://codereview.chromium.org/813353004

Cr-Commit-Position: refs/heads/master@{#310168}

BUG=444957

Review URL: https://codereview.chromium.org/831283002

Cr-Commit-Position: refs/heads/master@{#310167}

These events have been enabled during the M-41 dev cycle and are ready
to be enabled for M-41 stable.

BUG=442543

Review URL: https://codereview.chromium.org/835993003

Cr-Commit-Position: refs/heads/master@{#310166}

BUG=442514

Review URL: https://codereview.chromium.org/821693003

Cr-Commit-Position: refs/heads/master@{#310165}

The deleting of the temporary accent character will cause the pending accent
to be cleared so we have to keep it around for the keypress and separately
record what the new pending-accent will be once we're done.

BUG=230921

Review URL: https://codereview.chromium.org/834293002

Cr-Commit-Position: refs/heads/master@{#310164}

BUG=396626
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/835423002

Cr-Commit-Position: refs/heads/master@{#310163}

AutofillAgent::FrameDetached is no longer necessary because form_cache_ only holds the forms for a single frame.
AutofillAgent::FrameWillClose is only called on the actual closing frame (which might be a parent frame).
AutofillAgent::FrameDetached can't take the place of AutofillAgent::FrameWillClose because the RenderFrame disables sending IPCs during detachment.

Therefore, move the automatic closing of rAc from the renderer (autofill_agent.cc) to the browser (chrome_autofill_client.cc).

For PasswordAutofillAgent, add FrameDetached to RenderFrameHost.

BUG=433486

Review URL: https://codereview.chromium.org/796493004

Cr-Commit-Position: refs/heads/master@{#310162}

It's not enough to know what version of the shared module is installed, we
also need to know the language, since the web store splits up crxs by
language/platform tuples. The only way to find out which language is
installed is by looking at what files are available. In our case,
looking at the contents of the _platform_specific directory.

Review URL: https://codereview.chromium.org/804193003

Cr-Commit-Position: refs/heads/master@{#310161}

RenderWidgetHost::GetView() may return NULL, e.g. if the renderer has
crashed. MessageService::OpenChannelToNativeApp() wasn't handling this
case properly.

BUG=374778

Review URL: https://codereview.chromium.org/787253009

Cr-Commit-Position: refs/heads/master@{#310160}

BUG=428729

Review URL: https://codereview.chromium.org/833403002

Cr-Commit-Position: refs/heads/master@{#310159}

This bring in:
a48ead9 Re-enable pdfium_unittests.
dd132d8 Update externs in unicodenormalization.cpp to not have array sizes.
c5f520c Get rid of g_timeMap global object.
f964049 Fix an array size mismatch.
286ea1d Remove run-time calculation of hash constants in pdfium.
a975cfa Get rid of fifteen copies of m_sTimeMap and their initializers.
2638428 Clean up bookmark related codes.
17b5cf4 Remove static declared SymbolDictCache.
07f10ae In windows printing, convert src bitmap to dest bitmap using CompositeBitmap.
d66051b Remove g_NaN global variable and its constructor.
659a56b Get rid of FX_LPCSTR cast.
3fc36e8 Revert build of pdfium_unittests.
831e138 Fix pdfium buildbot build breakage from 336991d.
336991d Create pdfium_unittests binary.
6c06469 Refactor some code in CPDF_TextPage::ProcessTextObject().
59dffb6 Fix new third_party/BUILD.gn to use the right build configuration.
06b087a Set the freetype options missing in the recent update.
b3a3230 Add the license back to ftmodule.h after the freetype 2.5.4 upgrade.
a09d50d Transform font size to user space for valid text size comparison.
e4fc5ce Update freetype to 2.5.4.

Review URL: https://codereview.chromium.org/789613007

Cr-Commit-Position: refs/heads/master@{#310158}

This patch sets up DevicePermissionsPrompt::Prompt as a
UsbService::Observer so that the UI is updated whenever a device
is connected or disconnected.

BUG=411715

Review URL: https://codereview.chromium.org/839453002

Cr-Commit-Position: refs/heads/master@{#310157}

Based on the latest revelations:
440919 WindowImpl::WndProc2 = 90 jph.
Since the internals of OnWndProc are instrumented, this strangely indicates that it's GetWindowUserData who is responsible for this jank. Instrumenting it.

440919 <<MessagePumpForUI::ProcessNextWindowsMessage>> = 46 jph and
440919 MessagePumpForUI::ProcessMessageHelper = 39 jph
This means that with instrumenting MessagePumpForUI::ProcessMessageHelper, we've divided MessagePumpForUI::ProcessNextWindowsMessage into 2 roughly equal parts: everything that happens inside MessagePumpForUI::ProcessMessageHelper, and everything outside (GetQueueStatus and PeekMessage).
Adding in instrumentation to separate GetQueueStatus from PeekMessage.
Also instrumenting internals of MessagePumpForUI::ProcessMessageHelper.

BUG=440919

Review URL: https://codereview.chromium.org/835183002

Cr-Commit-Position: refs/heads/master@{#310156}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f48415c..2ad2a0a

TBR=dglazkov@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/841573002

Cr-Commit-Position: refs/heads/master@{#310155}

This CL adds the chrome.bluetoothPrivate.disconnectAll function, which can
be used by whitelisted extensions to teardown all connected data bearers
to a remote Bluetooth device.

BUG=441058

Review URL: https://codereview.chromium.org/819713002

Cr-Commit-Position: refs/heads/master@{#310154}

This makes SHMEM implementation of discardable memory preferred
over EMULATED implementation. This effectively makes SHMEM the
implementation used by default on Linux, CrOS and Windows.

SHMEM implementation of discardable memory gives the browser
process control over the total amount of discardable memory used
and allows us to enforce a global limit of 512MB across all
renderers.

BUG=429415,429416

Review URL: https://codereview.chromium.org/793443003

Cr-Commit-Position: refs/heads/master@{#310153}

ChromeOS doesn't have toggleable num lock; it is always considered
enabled. Always set num lock in the xkb modifier mask.

BUG=34920
TEST=numpad on link_freon generates numbers

Review URL: https://codereview.chromium.org/834373002

Cr-Commit-Position: refs/heads/master@{#310152}

This is used downstream for a more specific permissions check.

BUG=434128

Review URL: https://codereview.chromium.org/836913003

Cr-Commit-Position: refs/heads/master@{#310151}

BUG=466575
TBR=nasko@chromium.org

Review URL: https://codereview.chromium.org/834423002

Cr-Commit-Position: refs/heads/master@{#310150}

This CL adds support for a native confirmation dialog shown after the
user presses "Share" on the webapp but before an access code is
generated. It also includes a ChromeOS (Aura) implementation.
Implementation for other platforms will soon follow.

More details
============

It2MeConfirmationDialog is an interface for the confirmation dialog.
Implementations can assume they will be called only on the UI thread.

It2MeConfirmationDialogFactory is used to create platform specific
implementations of the dialog.

It2MeConfirmationDialogChromeOS is the dialog's ChromeOS implementation.

It2MeConfirmationDialogProxy is a helper class that allows the caller
(in this case, It2MeHost) to use the dialog outside of the UI thread.

BUG=444216

Review URL: https://codereview.chromium.org/816903002

Cr-Commit-Position: refs/heads/master@{#310149}

Change the PhaseBegan to not cause a vertical scroll.

Deltas for PhaseBegan events are incorrectly
ignored by ScrollElasticityController. The PhaseBegan deltas are not
ignored by impl-side scrolling, which causes the test to fail. If
ScrollElasticityController is corrected to not ignore PhaseBegan deltas,
the test fails as well.

By changing the delta for PhaseBegan, the test passes both with
impl-side scrolling and with the corrected ScrollElasticityController.

BUG=133097

Review URL: https://codereview.chromium.org/811383003

Cr-Commit-Position: refs/heads/master@{#310148}