- 26 Nov, 2020 21 commits
-
-
Michael Bai authored
This patch moves AutofillDownloadManager::Observer to AutofillHandlder No function change. Bug: 1151542 Change-Id: I7a290f72d4b51d9362c9cdec44ab74f4ae443a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553185Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#831195}
-
Ben Reich authored
Make sure the |key| supplied to getExpectedLabelText has a corresponding value in |i18nLabelReplacements| to aid debugging. --devtools-code-coverage Test: browser_tests --gtest_filter="*filesTooltip*" Test: browser_tests --gtest_filter="*filesTooltip*" Bug: 1152612 Change-Id: I20b50181aadbcfea61e0101365d2dd7f5fe51edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561224 Commit-Queue: Ben Reich <benreich@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#831194}
-
Joey Arhar authored
This patch selects all of the text in the text fields for choosing numbered values for R, G, and B in the color picker when clicking or tabbing into them. Fixed: 1137423 Change-Id: I10ca4a0f043429e762f724ddb9b9a0864fe0d7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527181 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#831193}
-
Bartek Nowierski authored
Call to De/RecommitSystemPages is almost always accompanied by SetSystemPageAccess. On Windows and Fuchsia, literally all De/RecommitSystemPages do is call SetSystemPageAccess, leading to a redundant double call. This CLs unifies this behavior, so that only one function has to be called. Apart from the double call evasion, there are other behavior changes: - gin::PageAllocator::SetPermissions, on Posix, will now make pages inaccessible when kNoAccess requested - AddressPoolManager::Alloc, on Windows, will now CHECK instead returning false - PagePool::Take, on Posix, will now CHECK (instead of returning nullptr) if failed to set permissions, and on Windows, CHECK is moved down the stack - PartitionBucket::SlowPathAlloc -> PartitionRoot::RecommitSystemPages, on Windows, CHECK is moved down the stack - NormalPageArena::AllocatePage & PageMemory::Allocate, on Windows & Posix, CHECK is moved down the stack Bug: 766882 Change-Id: I961200449abc5271c9e0bed5ad6c4544468169b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550119Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#831192}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I75c8e24cb8620f6c5a1650578e12ff1d97330ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560260 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#831191}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/36f2a96290e7..b9a5e83e55ee 2020-11-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-11-25 vapier@chromium.org repo: auto-update depot_tools when used If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1148984 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Test: Test: ran and saw it auto-update when used externallyTest: Test: ran and saw it not auto-update when used inside of a repo checkout Change-Id: I971e6b9ea3939ab31d76693829ca0953adc4fdd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561698Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831190}
-
Tim Judkins authored
This CL blocks extension API navigations to devtools scheme pages for extensions which do not have either the devtools or debugger permission. Bug: 1049265 Change-Id: I1db2847c9a15918b3557ec799810013c58a75108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555462 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831189}
-
Eric Seckler authored
This is a reland of 46c618aa with an added null check in MaterialSpinnerView.updateAnimationState (see diff from patch set 1). Original change's description: > feed: Don't spin the spinner when its ancestors are hidden > > Currently, the spinner used in feed will only stop() its animation if > the spinner view itself is hidden through setVisibility(). However, in > reality, one of its ancestor views is hidden instead. > > This causes a continuous invisible animation to tick at the display's > refresh rate (usually 60fps) if the spinner was ever shown, until it is > destroyed (when the NTP views are eventually evicted). > > Instead, stop the animation also when any of the spinner's ancestors > become hidden by listening for visibility changes and window attachment > state changes. > > Bug: 1151391 > Change-Id: Ib7b7a8e56f083619420fd58f4340991253402535 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552781 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Jian Li <jianli@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830957} Bug: 1151391, 1152817 Change-Id: I306b623fc5d7243cf96998367f01380a80833aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560108Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#831188}
-
Maggie Cai authored
This reverts commit e29c70f6. Reason for revert: This CL is likely the cause of a tree closure for failing to compile in build ios-device (https://ci.chromium.org/p/chromium/builders/ci/ios-device/173021) Original change's description: > feat: detect support for MTE and BTI > > MTE and BTI are Armv8.5-A features which help memory safety and > control-flow integrity. This CL adds support for detecting them > using the AT_HWCAP2 Linux API. > > MTE contains new instructions which will crash older cores. base::CPU > can now be used to tell whether these instructions are safe to > execute and adds a test to verify this. This does not test whether > MTE is configured correctly to give any security properties, a > subsequent CL will add tests for this. > > Bug: 1145581, 1137393 > Change-Id: I9abd66af1c1bdbf49eebd17f225a59b0a6cdfd33 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526738 > Commit-Queue: Richard Townsend <richard.townsend@arm.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831180} TBR=dcheng@chromium.org,haraken@chromium.org,richard.townsend@arm.com Change-Id: Iccd79d592321a0d6ca387a3564016999fd660234 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1145581 Bug: 1137393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560078Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#831187}
-
Yusuf Sengul authored
Bug: 1152690 Change-Id: I1cecd128f89a04eee61076b87d54b3f55e98dde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559804Reviewed-by:
Robin Lewis <wrlewis@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#831186}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f2efb80bc316..420a9ba7b5e9 2020-11-25 reed@google.com Switch to m44 for the rest of canvas virtuals 2020-11-25 mtklein@google.com remove SkVM uniform8/16 2020-11-25 mtklein@google.com remove SkVM Q14 support 2020-11-25 mtklein@google.com clean up unused SkVM debug features If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ife9b9ae4101b80045c3b7578a36d65ebf38c78c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560814Reviewed-by:
-
James Darpinian authored
KHR_parallel_shader_compile COMPLETION_STATUS_KHR queries should return true unconditionally when the context is lost. This is intended to prevent applications from entering an infinite polling loop. Spec clarification and test are landing upstream: https://github.com/KhronosGroup/WebGL/pull/3188 Bug: angleproject:3379 Change-Id: I3c63235ccc3e07e0557e80021888886f893d268a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559534 Auto-Submit: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#831184}
-
cfredric authored
Change-Id: I42bb46e23d0bda34b97754f12bbfcf575ae5d691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559157 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#831183}
-
Nico Weber authored
plistlib can do everything we need in Python 3. No behavior change. Bug: 1112471,1147069 Change-Id: Ife5f754133a3694004008909b3e819afca03e278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561276 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#831182}
-
Kyle Horimoto authored
Allowing a short timeout before shutting down the process works around race conditions that occur during shutdown, allowing the Nearby utility process to shut down without any errors. Bug: 1152609 Change-Id: I56124135cbd67a3256bc37a384ec55f40f583869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561541 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#831181}
-
Richard Townsend authored
MTE and BTI are Armv8.5-A features which help memory safety and control-flow integrity. This CL adds support for detecting them using the AT_HWCAP2 Linux API. MTE contains new instructions which will crash older cores. base::CPU can now be used to tell whether these instructions are safe to execute and adds a test to verify this. This does not test whether MTE is configured correctly to give any security properties, a subsequent CL will add tests for this. Bug: 1145581, 1137393 Change-Id: I9abd66af1c1bdbf49eebd17f225a59b0a6cdfd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526738 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#831180}
-
dpapad authored
Part 2 affects CrOS only files. The |flattenhtml| property of grd file entries is considered deprecated and new usages of it are discouraged. Removing unnecessary usages, both to: - discourage copy/paste usage - reveal which files actually still rely on it The files that don't need it were detected by locally modifying Grit, to compare the file contents before and after flattenhtml is applied. In this CL only affecting files that don't need flattenhtml=true nor preprcosses=true. Cases where |flattenhtml| can be removed, but |preprocess| is still needed will be addressed in a follow-up. Bug: 1152343 Change-Id: Ic2b8476d09a53a1cfc650dc5001526bc5ceb6c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556494 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#831179}
-
Gordon Seto authored
Connect profile discovery list page with Mojo API to display actual profiles. Bug: 1093185 Change-Id: If80bcb3c92c9ecd146aef8ab9e5ba5accde01035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557787 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#831178}
-
Luke Zielinski authored
This is intended to make the linux-wpt-input-fyi-rel bot green. There are a few key differences observed. Details on each of the affected tests can be seen in the results viewer of the current waterfall bot (which still fails these tests unexpectedly): https://ci.chromium.org/p/chromium/builders/ci/linux-wpt-input-fyi-rel/45 Differences: 1) most of the input-events tests were marked as TIMEOUT in TestExpectations but are now running to completion and failing some subtests. 2) the test input-events-get-target-ranges-deleting-in-list-items.tentative.html is crashing chromedriver, see logs here: https://ci.chromium.org/p/chromium/builders/try/linux-wpt-input-fyi-rel/3 3) The pointerevents tests below used to PASS but are now either Failing or Timing out.: pointerevent_iframe-touch-action-none_touch.html pointerevent_pointercapture-not-lost-in-chorded-buttons.html pointerlock/pointerevent_coordinates_when_locked.html pointerlock/pointerevent_movementxy_with_pointerlock.html pointerlock/pointerevent_pointermove_in_pointerlock.html pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked.html Bug: 1127055 Change-Id: I264b47f0a516b89b0c993e704b2002b57d1ec5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551318 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#831177}
-
Jeremy Roman authored
This appears to be related to Pepper Flash. Removing or migrating the profile preferences is left to later, because this does still have live call sites, and may even appear in WebUI. Change-Id: Ic21fd0d744a0508127b82fdd18ad271ca2ad4a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561029 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#831176}
-
James MacLean authored
This reverts commit 0ea7d517. Reason for revert: A fix for the problem that lead to this revert has been landed in r831153 and we need to re-enable this change to test it. Original change's description: > Revert "Origin isolation: enable by default" > > This reverts commit 824b062d. > > Reason for revert: Causing crashes with hosted apps in https://crbug.com/1141721. > > Original change's description: > > Origin isolation: enable by default > > > > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI > > > > Further work on removing origin trial code and the flags is tracked in > > https://crbug.com/1148056 and https://crbug.com/1148057. > > > > Bug: 1042415 > > Change-Id: Icbeecd0b592c76d36e2111b8e4d8fe30dbb63343 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533145 > > Commit-Queue: Domenic Denicola <domenic@chromium.org> > > Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#826910} > > TBR=creis@chromium.org,alexmos@chromium.org,jochen@chromium.org,domenic@chromium.org,yoavweiss@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1042415, 1141721 > Change-Id: I428b190fc4c6bdf39de5ffb43226ba91851e7544 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553209 > Reviewed-by: Domenic Denicola <domenic@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829937} TBR=creis@chromium.org,alexmos@chromium.org,domenic@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1042415 Bug: 1141721 Change-Id: I6cf3211dc675bd2351c8dc6831e8d3e2495d8c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560907Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#831175}
-
- 25 Nov, 2020 19 commits
-
-
danakj authored
Step 3 for bug 1125106. This is a subset of the mega-patch in https://chromium-review.googlesource.com/c/chromium/src/+/2462248. The BeginNavigation() path does not read the same-document field when deciding its navigation type. However, a regression could conceivably allow the renderer to specify same-document, bypass our checks to move into a new RenderFrame/RenderProcess, and load a document in the wrong process. We drop BeginNavigation() messages from the renderer which have the same-document flag set. Then we verify in RenderFrameHostManager when we bypass from picking a RenderFrameHost, using the current one explicitly, that the NavigationRequest did not come from BeginNavigation(). R=nasko@chromium.org Bug: 1125106 Change-Id: I58d50f524bf948c5ca4f76c237c6fe32e7fcf4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558776 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#831174}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/12af0f03..b8bd12af Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id0b3c99ba25936301cc4379f368e4a5370b74101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560833Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831173}
-
Sophey Dong authored
Bug: 1152119 Change-Id: Ifd622c16af140d799f5ccecd35e3d6a420bfee69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555471Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#831172}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I36449825112a19d53494c155b4d221c9ff951f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560935Reviewed-by:
-
Gil Dekel authored
This CL exposes the path topology of a display via its DisplaySnapshot representation. This will later be used during display configuration fallback strategies. In addition, this CL adds three UMAs to track (two of them use the new exposed path topology property): 1) the number of configured external displays 2) the number of configured external displays that are connected via an MST. 3) the percentage of configured displays connected via MST (i.e. num of external MST displays over total num of external displays). Bug: b:170745518, 1105919 Test: display_unittests && ozone_unittests Change-Id: Ida7270e60ff8d5969e1664788e2dcf7831d52c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527955 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#831170}
-
Rafael Cintron authored
Lack of xrDestroySession entry in xrGetInstanceProcAddr was causing calls to xrDestroySession in code to crash and make it difficult to debug XR tests. This CL adds an entry for xrDestroySession. Change-Id: Ib6cfe2a5181fb328409ab54e60284da1cfb816e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561297Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#831169}
-
Anton Bikineev authored
Using base::ThreadPool was not safe and prone to deadlocks, which caused DCHECKs in base::CheckedLock to fail (https://bit.ly/3l0cd5p). This CL adds an ever running thread specific to pcscan tasks. Please note that to stay indepedent of //base/ (and the allocating BindOnce function), the C++11 thread API is used. Bug: 11297512 Change-Id: I8223d7f8875f3a256ccc7e87ba190720bcfb4074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556858 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Andres Medina authored
Bug: 1152807 Test: Manual build and run on linux. Change-Id: I8b82206d47995aa1b90e3196774535de8a0be9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560061Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andres Medina <medinaandres@chromium.org> Auto-Submit: Andres Medina <medinaandres@chromium.org> Cr-Commit-Position: refs/heads/master@{#831167}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04353ebb2005..31df00826801 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com,etiennep@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1149681,chromium:1151505 Tbr: ramyan@google.com,etiennep@google.com Change-Id: I2f95208168fed8fbc62f111ca7455a4268d828d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560666Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831166}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a3762a907c02..36f2a96290e7 2020-11-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I63bd6f2ec53ec8aafc2d45b4676e299f58d70d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560669Reviewed-by:
-
Dominic Farolino authored
This CL allows for the creation of an AgentSchedulingGroup(Host) per SiteInstance. The changes can be summarized as: - Parameterizing the MBI base::Feature into the following states: - Legacy mode - Enabled: AgentSchedulingGroup-per-RenderProcessHost - Enabled: AgentSchedulingGroup-per-SiteInstance - Modifying AgentSchedulingGroupHostUserData such that it holds an std::set of AgentSchedulingGroupHosts - Introducing a std::map<SiteInstance*, AgentSchedulingGroupHost*> to preserve the invariant that no SiteInstance should ever request multiple AgentSchedulingGroupHosts during its lifetime, from the same RenderProcessHost - When the base::FeatureParam is in the ASG-per-RPH state, we DCHECK that only a single AgentSchedulingGroupHost exists in the set of owned hosts - When the base::FeatureParam is in the ASG-per-SI state, we DCHECK that a SiteInstance is never requesting an AgentSchedulingGroupHost more than once from the same RenderProcessHost is enabled. We do this by maintaining the std::map mentioned above, to preserve this invariant. Design doc: https://docs.google.com/document/d/1q-Tvdpf0bDsbzgO9lNlmEEEXMYFvgN81fN6xLFuBJPA/edit Bug: 1149830 Change-Id: I14055ecd8675b695d202924c6431dc59a6e2f059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536756Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
zhiyuancai authored
Bug: 1146636 Change-Id: I33159beed89636fd09367c2466dbc6844ab1be14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561220Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#831163}
-
rajendrant authored
Moves the PreviewsResourceLoadingHints interface away from blink, since its not used in blink. This also refactors the subresource redirect interface out of PreviewsResourceLoadingHints. Bug: 1152527 TBR: dom@chromium.org Change-Id: Id3036c3ef91240cb9fb986f06cf478780e18492c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556566 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#831162}
-
Sigurður Ásgeirsson authored
This reverts commit 0dadfa21. Reason for revert: Top crasher on Canary. Original change's description: > PM: Enable service worker relationships by default. > > Bug: 1143281 > Change-Id: I5107ca4d324248456470f5880429d10760d77076 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557223 > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830661} TBR=pmonette@chromium.org,siggi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1152860, 1143281 Change-Id: Ie1e445d3da4185e65bfb8f895b6d63468b01be1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561538Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#831161}
-
Kyle Horimoto authored
Previously, we'd just call DisconnectFromEndpoint() and invoke the callback immediately. This CL adds a "disconnecting" state which waits for the OnDisconnected() callback to be called. This works around a race condition in the Nearby Connections library during shutdown. Because we're now waiting for an event to be called, this CL also adds timeouts for each step of this flow. This CL also tweaks the log level for a few logs to help with debugging. Bug: 1152609 Change-Id: Ib23c606e4658f5ad1f5fbf013891d80888683530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561469Reviewed-by:
-
Karandeep Bhatia authored
Remove //extensions/browser/api/declarative_net_request/filter_list_converter:* from being excluded from gn checks. BUG=None Change-Id: Icc9f38b062823e5fcb5f700e3f26d4ae71e7c03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557725 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#831159}
-
spdonghao authored
Bug: 1139515 Change-Id: I8efb2168d15a78c48eb9bcd28fd579004ad0fbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560542Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
-
Alexander Bolodurin authored
This is a variant of CopyFile to use when the file paths are not accessible, e.g. passing a file descriptor across containers. Change-Id: I87a674b389139ced34cfc3ece11df5c2765df640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536652 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:
-
Pavel Yatsuk authored
This CL adds logic in SingleActionMessage to dismiss the message when the user taps on primary button. BUG=1152520 R=lazzzis@chromium.org Change-Id: I6f32c69278cd613f47839af7c70e8d41db99a848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560829 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#831156}
-
