- 23 Jan, 2020 40 commits
-
-
Yoshisato Yanagisawa authored
To experiment ios_use_goma_rbe config behavior, let me enable this. Bug: 1044515 Change-Id: I2870eb540186f89b03b2faae07265ebcf5e090bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014480 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jason Clinton <jclinton@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#734347}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/04ccecc2d7b2..3df70e9c609d git log 04ccecc2d7b2..3df70e9c609d --date=short --first-parent --format='%ad %ae %s' 2020-01-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@3df70e9c609d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icdf0b454ed68b80935501e5fc016d35048f452a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016077Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734346}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/92a85446..0537aa80 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I59eb162b8dda5137e4eee5537c98476448bba069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016242Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734345}
-
Yoichi Osato authored
This reverts commit c78cd05f. Fixed:1044826 Reason for revert: Fails Linux ChromiumOS MSan Tests Original change's description: > Parse PerAppTimeLimits policy > > Parse PerAppTimeLimits policy received from the server and store > app limits data in AppActivityRegistry. > This will be followed up by processing app limits. > > Bug: 1015654 > Test: AppTimeTest > Change-Id: I29691e0c801762a73f01cce217826423359957eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001411 > Reviewed-by: Yilkal Abe <yilkal@chromium.org> > Commit-Queue: Aga Wronska <agawronska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734123} TBR=agawronska@chromium.org,yilkal@chromium.org Change-Id: I3d66bf1a7630fb2476253b98e165e0f6c9b53aa8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015873Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#734344}
-
Yoichi Osato authored
This reverts commit 9939a33b. Reason for revert: PPAPINaClNewlibTest.NetworkProxy test failing on Mac ASan 64 Tests (1) Fixed: 1044845 Original change's description: > PPAPI: Add NetworkIsolationKeys to proxy lookup requests. > > This is needed to correctly isolate any DNS requests made by PPAPI in > the context of one page from those made in the context of other pages. > > Bug: 1021661 > Change-Id: Ibbca8db7df8c7e61cb9522630e70c8ccd365b5c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008050 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: Raymes Khoury <raymes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734094} TBR=raymes@chromium.org,mmenke@chromium.org Change-Id: Ia2c799af73dff4749b1af077b7d976f192d785aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015872Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#734343}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I2000198ca283371d99a41a122015dc11988d16b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015422Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734342}
-
Eriko Kurimoto authored
This CL is for code cleanup. This doesn't change the behavior. Bug: n/a Change-Id: Iac4a44781fde183881cea62a97c8883932a670ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011593 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#734341}
-
Sophie Chang authored
Bug: 1036490 Change-Id: I03eeb9b6051a8b399ee2aca6522ef2c0ae5ae5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013745 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734340}
-
Leon Han authored
To indicate whether it's allowed to overwrite an NFC tag that already contains some records. We do not do any special checks for the case of overwrite = true, just write into the NFC tag in any cases. In case of overwrite = false, - Writing non-formatted tags that are NDEF-formatable --> format + write - Writing (formatted + empty) NDEF tags --> write - Writing (formatted and non-empty) NDEF tags --> not allowed The spec change: https://github.com/w3c/web-nfc/pull/373/commits/b71a81e33ba568f3a8e3cd3de8271bd45be789e8 https://github.com/w3c/web-nfc/pull/526 BUG=1023231,520391 Change-Id: Ibf271f88e6e395370f994864e966f55ef44f5d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003893 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#734339}
-
Ted Meyer authored
MediaError is meant to be a relatively small (sizeof(void*) bytes) object that can be returned as an error value from functions or passed to callbacks that want a report of status. MediaError allows attaching of arbitrary named data, other MediaErrors as causes, and stack frames, which can all be logged and reported throughout the media stack. The error code and message are immutable and can be used to give a stable numeric ID for any error generated by media code. There is also an OK state which can't hold any data and is only for successful returns. doc: go/media-error Bug: 1043289 Change-Id: I11a7c6d667f9810ba85264e41c8d7ce184858b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867991Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#734338}
-
tby authored
I made a typo when the in-code histogram name and the name in histograms.xml for the metric: Apps.AppList.DriveQuickAccessProvider.ResultPresence The incorrect name is in the code (it's missing a dot), but to avoid having to merge a fix this CL changes histograms.xml to be consistent with the code. Bug: 1022150 Change-Id: Ib61ef270141c1d77559631d9ef95af10dfe4fa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985831 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#734337}
-
Mandy Chen authored
This change modifies the shape of Page.getInstallabilityErrors [1] CDP event to include the error ids and arguments that are needed to generate the detail messages that are displayed in the Applications - Manifest tool. The design is proposed in Localizability of CDP [2]. The strings that are currently present in installable_logging.cc will be moved to the DevTools frontend. They'll remain in place so we are backwards compatible. Separate CLs will be made to process the new data in the DevTools frontend. [1]: https://chromedevtools.github.io/devtools-protocol/tot/Page#method-getInstallabilityErrors [2]: https://docs.google.com/document/d/1ZbCiXbVJZJaYqKZkQ_Y5RNpUqQd1JzO17PqFJZk2Ne8/edit?usp=sharing Bug: 946860 Change-Id: I8af923c1554396c6d79a4233bf342357b3386c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008430 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734336}
-
Alexei Svitkine authored
- Fixes common typos in email addresses. - For metrics where the first owner is not a @chromium.org or a @google.com and which have another owner with such an address, moves that owner to be the primary owner. This ensures there's a primary Google contact for any metrics we're collecting. This was done by looking through the following output and manually fixing problems: grep "<owner>" histograms.xml | grep -v google.com | grep -v chromium.org | grep -v OWNERS | grep -v "Add more owner tags" Bug: None Change-Id: I5c9288764008764cd6634726a27a3cb24ad1f9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013758 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#734335}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ea20eae785f..ba163361685f git log 2ea20eae785f..ba163361685f --date=short --first-parent --format='%ad %ae %s' 2020-01-23 benjaminwagner@google.com Reduce binary size of GCC Debug builds 2020-01-22 robertphillips@google.com Add missing 'GrProtected' parameter to createCompressedTexture call chain 2020-01-22 michaelludwig@google.com Account for negative w in GrQuad::bounds Created with: gclient setdep -r src/third_party/skia@ba163361685f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:224618 Tbr: benjaminwagner@google.com Change-Id: Ic95395d63066e4473bfde6302e24790b96df6d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016068Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734334}
-
Fergal Daly authored
Bug: 882574 Change-Id: I08c0f15713bd0cd7db14017de3c0460fa29198d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1249278Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734333}
-
llin@chromium.org authored
The source language localized name might contain bracket already, for example: Chinese (Traditional). Checked with UX team and update the way we present language name to "[query] · [language name]". Bug: b/144317438 Test: unit tests Change-Id: Iab209a4eb0d2abdb5ce1b298f7528f751e39cfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013893 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#734332}
-
Fergus Dall authored
This is a reland of 2711d4f7 Fix a use-after-free in the abort callback system Original change's description: > Remove shared ownership of CrostiniRestarter > > It seems to be possible for shared references to CrostiniRestarter to > outlive CrostiniManager. Since all of CrostiniRestarter assumes that > CrostiniManager still exists, this can cause crashes. Switch > CrostiniRestarter to being exclusivly owned by CrostiniManager and > handing out weak pointers to callbacks. > > Bug: 1040797 > Change-Id: Ib65c79c7c81111aad88435b3c95da0c64226e791 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996112 > Reviewed-by: Nic Hollingum <hollingum@google.com> > Commit-Queue: Fergus Dall <sidereal@google.com> > Cr-Commit-Position: refs/heads/master@{#733496} Bug: 1040797 Change-Id: Iabe0809381785bd80f896bb77c69e9142df67255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012203Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#734331}
-
Brian Sheedy authored
Switches the expectation for conformance/textures/misc/texture-size-limit.html from "Skip" to "RetryOnFailure", as the issue the test was causing for subsequent tests has been worked around. TBR=ynovikov@chromium.org Bug: 1043953 Change-Id: Iff573b37d981c8777e8373ebd8fd025ee2beac3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015982Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#734330}
-
Karan Bhatia authored
More documentation/examples will follow once the documentation for generic priority lands. BUG=1038831 Change-Id: I88cf351a6c327c6dbcf8554cf71a17ee82b06933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001755 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734329}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bc9b29411747..6b345995a827 git log bc9b29411747..6b345995a827 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 rmhasan@google.com Revert "[Telemetry] Simplify the timeout condition in CollectTraceData" Created with: gclient setdep -r src/third_party/catapult@6b345995a827 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1039726 Tbr: nuskos@google.com Change-Id: Ic9230ff69066e5852c800eb37a9f0fd7ec90cd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016067Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734328}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8ffd3f23331d..c2e16963a9cc git log 8ffd3f23331d..c2e16963a9cc --date=short --first-parent --format='%ad %ae %s' 2020-01-22 cwallez@chromium.org Add SurfaceDescriptorFromHTMLCanvasID Created with: gclient setdep -r src/third_party/dawn@c2e16963a9cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib03d647694ad49f36bd97b62361baa8ec55ecc79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016066Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734327}
-
Jesse McKenna authored
Minor fix to web-app file-handler registration Windows unit tests per comment on crrev.com/c/2002982. Change-Id: I6a00574ac23c244c030455af821987db4f2f78b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016185Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#734326}
-
Tom Anderson authored
The name "libgtkui" is misleading: we don't actually ship a libgtkui.so, although this was planned at some point. Even if we did, it probably still wouldn't make sense to have "lib" in the directory name. This change renames the directory to simply gtk. BUG=None R=sky Change-Id: Ib2380520c8605b4d4e0fd2d6ff9207caa50a406e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011683 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#734325}
-
Jongmok Kim authored
GetTargetTemperature seems not used. Bug: None Change-Id: Ib29a2ac861665eaba30c9ab10af483d8f5892a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014350Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#734324}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a2e07326..92a85446 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5592c70c3d6f795e5a4ddfa1526d1158b4378011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016122Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734323}
-
Jason Chase authored
Update the expiry to M86. We will move the related features to use Document Policy, meaning developers will then need time to experiment/test the policies locally. Bug: 906163 Change-Id: I6d6d524d21e0d177956badb240312ac572f408cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015488Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#734322}
-
Julian Watson authored
Open Plugin VM settings pages should revert back to the top level os settings when Plugin VM is uninstalled. In order accomplish this the top level settings cr-link-row needs to be always visible, as os_settings can't dynamically hide rows. Instead the contents of the row have become dynamic, and will either say Turn On if Plugin VM is not yet installed, or show an arrow if it is installed. The resulting UI is now the same as Google Play Store and Linux (Beta). Bug: 1023256 Change-Id: I9ade77a4dff3e7799732608430f299b400338ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007803Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#734321}
-
Johannes Kron authored
The test Webrtc/ConnectionTest.Audio/0 fails for the ASAN build after a seemingly unrelated change to WebRTC. The estimated frequency is ust outside the specified limits. Bug: none Change-Id: Ic583ce4272ce6bbbbc584d3ef06b786b0b58ddbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015165 Auto-Submit: Johannes Kron <kron@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#734320}
-
Kelvin Jiang authored
This CL restricts the lifespan of matched rules not associated with an active tab to 5 minutes (currently). Change-Id: I8f3d169f822ee3f2f746b765c8956f8ab5849952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994665 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#734319}
-
Scott Haseley authored
This changes the postTask prototype to use semantically meaningful names and reduces the number of priorities. The priorities now match the updated explainer: https://github.com/WICG/main-thread-scheduling/blob/master/PrioritizedPostTask.md The changes are: "immediate" --> removed. We may reconsider if we have use cases. "high" --> "user-blocking" "default" --> "user-visible" "low" --> "background" "idle" --> removed. We may also reconsider this if we have use cases that can be differentiated from "background", but we currently don't. This also avoids conflict w/ requestIdleCallback. Bug: 979017 Change-Id: I58fb68e8bed38d8463d080bb3ff028049a69667b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008426 Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#734318}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6589db968634..aa94421bfd1f git log 6589db968634..aa94421bfd1f --date=short --first-parent --format='%ad %ae %s' 2020-01-22 oysteine@google.com Reland "Stack profiling: Don't attempt hex conversion on Breakpad build_ids" Created with: gclient setdep -r src/third_party/perfetto@aa94421bfd1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I36bde5c8049c15e42ea4703e847864ad83fec766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016062Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734317}
-
Findit authored
This reverts commit d8115a08. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 734159 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q4MTE1YTA4NTgzMmFiM2Q4OWNmMjEzNTQxNGZkNGViZDM3ZGFmNTUM Sample Failed Build: https://ci.chromium.org/b/8890523056669518464 Sample Failed Step: interactive_ui_tests Original change's description: > CrOS Shelf: Change hotseat color between in-app and home shelf. > > In this change, the hotseat background will change color for different > shelf states and will animate between colors when changing. When in-app > shelf is shown the hotseat color should have an alpha value of 90%. > When the home shelf is shown the hotseat color should have an alpha > value of 60%. > > Bug: 1041132 > Change-Id: I9459fbb61cbc538029039cd48c04144a98ab82c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003919 > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734159} Change-Id: I55a1fbb925f7c5172f1f45c418cb013216c97d6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1041132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016194 Cr-Commit-Position: refs/heads/master@{#734316}
-
Brandon Wylie authored
Just the feature flag and related setup for now, I'll follow-up with the functionality in another CL. Bug: 1041576 PRD: go/roti-prd Doc: go/roti-chrome-design Change-Id: I51b65fe999c9679201ca28ef8e88eeee9966fef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997652 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#734315}
-
Tom Anderson authored
GTK has a setting to globally disable animations. This CL uses it to disable animations in Chrome when the setting is set to disabled. R=sky Bug: 1043808 Change-Id: Idcaee97fdad3a26bb795d496599c745c83da6d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011442Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#734314}
-
Yutaka Hirano authored
Add an end-to-end test as a browser test as at this moment it is difficult to write it as a web platform test. We will covert it into a web platform test in the future. Bug: 1011392 Change-Id: I90e95f265b788042bc21a3cf633849d6ea873c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010740Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#734313}
-
Joel Hockey authored
When no paths have been shared, show a default message in the Crostini shared paths settings page. Bug: 1008172 Change-Id: I67010d015e8e5bf3a51f8cae08bf5c926faec16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014211 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#734312}
-
Julian Watson authored
Bug: 1023256 Change-Id: I35b36c4ca33a88210ff3108410082a607f074bd6 tbr: cpu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012375 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#734311}
-
Yoichi Osato authored
This reverts commit 3e49c929. Reason for revert: This is a culprit of ChromiumOS test failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17426 Fixes: 1044826 Original change's description: > [CrOS Printing] Don't send username and filename unencrypted > > This situation may come up if policy was changed after printer was > selected. We reject printing job since silently omitting username and > filename could be confusing. > > Bug: 1042798 > Change-Id: Iba385503d8f7e960291728d6515ca7c236220847 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004992 > Reviewed-by: Sean Kau <skau@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734128} TBR=thestig@chromium.org,vkuzkokov@chromium.org,skau@chromium.org Change-Id: I5edc2769677fc26c5810fe38d77d03700473c8bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015906Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#734310}
-
Weiliang Chen authored
Refactor the SharedImageInterface inside InProcessCommandBuffer so that it could be used for other Viz in process cases. Mainly this will help set up to use viz::BufferQueue for SkiaRenderer. R=ericrk Bug: 1042538 Change-Id: If2e5486d68d38452975fe035a5de59a06bc0a3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998283 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#734309}
-
Karan Bhatia authored
This CL implements the evaluation of allowAllRequests rules. To do this: - Track allowlisted frames in RulesetMatcherBase. We keep track of the highest priority matching allowAllRequests action for each allowlisted frame. This needs plumbing DidFinishNavigation and RenderFrameDeleted to RulesetMatcherBase. - Storing the parent RenderFrameHost ID for each request. This requires plumbing it for navigation requests through ExtensionNavigationUIData. - Modify RulesetMatcherBase::GetBeforeRequestAction to respect requests from allowlisted frames. BUG=1038831 Change-Id: Ie4b34341b59d568dfb94338006f7ace857bf38e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993844 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734308}
-