- 26 Jun, 2019 40 commits
-
-
Sergey Poromov authored
While external component extensions were already allowed for public (managed guest) sessions, (internal) component extensions were not whitelisted. It didn't affect previously as this code was never called for these extensions, but now it's called after https://crrev.com/c/1630229 added explicit check for all extensions and apps during ExtensionService init. This currently leads to complete block of many component extensions/apps in public session, including for example Files app and etc. However, some component apps, such as Camera app are also explicitly separately whitelisted. Bug: 976550 Test: Manual, updated unit tests. Change-Id: Id55402412bbacb0d830de001381610787fc5e57b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678369Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#672523}
-
Nazerke authored
Bug: 973040. Change-Id: If94a974ab68c947144cd0df04f3a843fadd391d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678477 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#672522}
-
Steven Bennetts authored
This CL: * Replaces all uses of CrOnc.DeviceState in Settings UI and related cr_elements to OncMojo.DeviceStateProperties. * Replaces all calls to networkingPrivate.getDeviceStates in Settings UI and related cr_elements to CrosNetworkConfig.getDeviceStateList. * Modifies device related <internet-page> events to use mojo types. Bug: 853953 Change-Id: I858fc0db3fc8d171b267776644f9a5a90fd266af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666840 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#672521}
-
Robert Sesek authored
They are no longer supported by macOS. This also removes app_resource_rules.plist. Bug: 496298, 850193 Change-Id: If5c086820469eed0082b3d450ca2359052d56e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677106Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#672520}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f97f342fd352..3472b9ae22ff git log f97f342fd352..3472b9ae22ff --date=short --no-merges --format='%ad %ae %s' 2019-06-26 nisse@webrtc.org Delete RTCInboundRTPStreamStats::fraction_lost 2019-06-26 nisse@webrtc.org Convert file objects to strings, before passing to PresubmitNotifyResult 2019-06-26 magjed@webrtc.org Android: Expose getDisplaySize() helper function 2019-06-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c30c3a10..27c2f87c (672280:672459) 2019-06-26 johnny@vidyo.com Enable H.264 temporal scalability in simulcast. 2019-06-26 estevenson@chromium.org Mass refactoring: Change JNI #includes to use full paths (webrtc/). 2019-06-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 42482d4f..c30c3a10 (672061:672280) 2019-06-26 oprypin@webrtc.org Specify min_sdk_version for unittest apks also in GN configs Created with: gclient setdep -r src/third_party/webrtc@3472b9ae22ff The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:971895,chromium:b/136037072,chromium:None,chromium:964169,chromium:None,chromium:891996 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b509ed85e2773874371061089c602ac2b4f8277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678219Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672519}
-
Peter E Conn authored
Our gradle file generators use the varargs form of java.filter.exclude which breaks when there are more than 255 files to exclude. This CL uses java.filter.exclude that takes a list instead. Change-Id: I1cd08d1b91f94f56913c0d7bca3ccf00fc7ac946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678560Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#672518}
-
Sam Maier authored
Note that proguard603.jar and retrace603.jar are both still around. Bug: 908988 Change-Id: I9763929febb4827fd0794d2334d25a845a5d37d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676834 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#672517}
-
Ian Vollick authored
Since we don't use FILTER_TOUCH_FOR_SECURITY in touchless mode, we should assert if we see it in our dialog properties. Bug: None Change-Id: I2f2f2f355c94775778822c8f92112260543e6fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677245 Auto-Submit: Ian Vollick <vollick@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#672516}
-
A Olsen authored
HTML + CSS + strings to make a dialog at chrome://confirm-password-change This dialog doesn't yet do anything - but it is guarded by the InSessionPasswordChange policy, which is turned off everywhere. Looks like this: https://screenshot.googleplex.com/KkxDvzXjx6u.png Bug: 930109 Change-Id: Ifac386689586da97353a5512d7a3cb687aa6dbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655478 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#672515}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1f456938b36f..84b037e09b93 git log 1f456938b36f..84b037e09b93 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 capn@google.com Don't treat class-memaccess warning as error Created with: gclient setdep -r src/third_party/swiftshader@84b037e09b93 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/135744933,chromium:b/134932616 TBR=swiftshader-team+autoroll@google.com Change-Id: I1ed7b837229e72b05ddac5ae443b8480ee14f30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678277Reviewed-by:
-
Robert Ogden authored
TBR=ryansturm@chromium.org Bug: 944286 Change-Id: Iececdaa2f3e10ac558bafdfe57ed041753f097c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677549Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#672513}
-
Robert Flack authored
The link highlight animation does not seem to always be started immediately. Setting the opacity to the animation target opacity early results in it not being visible during a long press and briefly flashing afterwards where it should be visible for the entire press. Bug: 974631 Change-Id: Id779be86c9957b20c7ba91b8e26f16256961c9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665269 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#672512}
-
Peter Kotwicz authored
This CL: - Updates the timeout for WebApkInstaller tests - Refactors WebApkInstallerRunner to take a WebApkInstaller and ShortcutInfo as input BUG=974729 Change-Id: I1bc7776a40123f6ac9c6e76f9bed2e1ff7d0b01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671187 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#672511}
-
Thomas Tangl authored
This is a reland of fa0a6456 Original change's description: > Add support for FIFE Avatar URL format > > The method GetAvatarImageURLWithOptions() is updated to support > image URLs coming in the FIFE Avatar URL format. > > This should resolve issues related to color-inverted account images > on the Chrome surface. > > Bug: 911332 > Change-Id: I8c0a10be69bc87a40a39cf46e0428b418d97b021 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670888 > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672116} Bug: 911332, 978578 Change-Id: I86414178c22600da40c6175b2d12ee8e311416a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678497Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#672510}
-
Miyoung Shin authored
This is a part of moving media recorder implementation to blink and a follow-up CL of https://crrev.com/c/1673406. This CL replaces WebMediaStreamTrack with MediaStreamComponent in AudioTrackRecorder and VideoTrackRecorder and calls directly AddSink and RemoveSink of track instead of passing through WebMediaStreamAudioSink or WebMediaStreamVideoSink. Bug: 960665 Change-Id: I3df392a26311a4f10388c63ba88c6c8397b74677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676204Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#672509}
-
Emily Hanley authored
1) Remove methods that handle the buffers separately 2) Remove only buffering until onload 3) Fixing up wpt tests associated with both Bug: 969123 Change-Id: I45991ff9389fe1a626a9911ff19015bcab85bfbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654876Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#672508}
-
Tommy Martino authored
This CL adds the OnFillingTriggered events to the credit card manual filling controllers. Because credit card numbers are sent to the frontend in an obfuscated format, some extra changes are needed to accommodate this: * Passing the GUID as part of the credit card number's UserInfoField * Caching the CreditCard objects in the controller * Using the GUID to get the full number when filling. This CL also makes some small changes to finish wiring the credit card controller into the manual filling controller. n.b. that masked cards are not yet supported and will be implemented in a follow-up CL. Bug: 969194 Change-Id: I01749cafe7cbf5a7f6b0cd071477baf6c78eb379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636451 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Auto-Submit: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#672507}
-
Yi Gu authored
sunxd@ has left Chrome and yigu@ takes over their work. Updating the histogram to reflect the change. Bug: None Change-Id: I2c09a430a08b5b1eb4b6cb9c193d6ef15385fb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669182Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#672506}
-
Ryan Hamilton authored
Add QPACK support to QuicTestPacketMaker. Change-Id: If10d3defd2f448762a42c849717ddecd66089d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671853 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#672505}
-
Sergio Villar Senin authored
There were several unneeded TimeDelta <-> double conversions in the class and in the tests. We can just simply return a TimeDelta and operate with it. Bug: 919383 Change-Id: I4b7fb0028883d9d427b7d6a66880fa84e452f75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678176Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#672504}
-
Mustaq Ahmed authored
The test passes manually. Bug: 978620 Change-Id: Ic40cef889d41c8b21e8e184d158ecdd2b92ebabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677067Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#672503}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf11cf135aed..f786b1874665 Created with: gclient setdep -r src-internal@f786b1874665 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: I13ff29950c734ca825e5d06706454f258fe8ad2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678220Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672502}
-
Pavel Shmakov authored
The patch https://crrev.com/c/1660848 failed to work, because there was a comma missing. It was missing before as well, which probably explains why "+components/embedder_support/android" is duplicated, so I also removed the duplicate. Change-Id: I70339f4a884088d25c32c3798536af5886b1f929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678479 Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#672501}
-
Vladimir Levin authored
This patch ensures that we process nested updates and updateAndCommits without stalling indefinitely. It rejects update() and commits updateAndCommit() R=chrishtr@chromium.org, rakina@chromium.org Bug: 972498 Change-Id: Ie3acb2034de079d5748352c546f7fc0337bdbb85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676081Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#672500}
-
Tomasz Śniatowski authored
It's an utility class that's currently only usable on full threads and with a little effort can be made to only require a Sequence. Bug: 978036 Change-Id: Iea6c57f81cb59000351534deae1dd445ad35dc03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675604 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#672499}
-
Tsuyoshi Horo authored
I will use SignedExchangeRequestMatcher to find matching subresource signed exchange in Blink. Bug: 935267 Change-Id: I8484ace6c2d766b1c76d1d602371877882299fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675424Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#672498}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e88da56930f5..d1817b193a8e git log e88da56930f5..d1817b193a8e --date=short --no-merges --format='%ad %ae %s' 2019-06-26 lalitm@google.com Merge "trace_processor: update script shas" 2019-06-26 taylori@google.com Update trace_to_text for mm_filemap event Created with: gclient setdep -r src/third_party/perfetto@d1817b193a8e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:135555191 TBR=perfetto-bugs@google.com Change-Id: Ib5dac80cecd728e3f2d36a690a4d4b3bb243bf5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678218Reviewed-by:
-
Peter Wen authored
Removed in this CL: - GooglePlayServices.ErrorHandlerAction - GooglePlayServices.ConnectionResult These were added to fix and verify an issue in 2015. They are no longer needed since their data is fairly stable. See bug for more context: https://crbug.com/490710#c8 Bug: 975726, 490710 Change-Id: I103209b2e08428613477814db51ddec4465011e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674386 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Allen Robinson authored
Bug: 934451,970240 Change-Id: Idc9584d76fb0ba3c5060b8d5e32430b31efd69f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669168 Auto-Submit: Allen Robinson <arobins@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Allen Robinson <arobins@chromium.org> Cr-Commit-Position: refs/heads/master@{#672495}
-
Rune Lillesveen authored
This reverts commit febc5471. Reason for revert: FindInPageTest.SelectionDuringFind has been flaky linux-chromeos-rel since introduced. Original change's description: > Prepopulate find with selection. > > Currently, the find box only considers its own history when opening, > but sometimes the user has selected a term on the page and wishes > to search for additional instances (especially when looking at source > code.) > > To expedite this (and prevent needing to use the clipboard), this > change considers the active text selection (if any) when the find > widget is invoked. > > Bug: 935157 > Change-Id: Ibdc6a809471fed9aa2c6b6d31f010cbcefb5aa1f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644229 > Commit-Queue: Jeff Fisher <jeffish@microsoft.com> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672342} TBR=pkasting@chromium.org,jeffish@microsoft.com Change-Id: I33b7325140b30826653bf39ac7b51a926beb2273 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 935157, 978836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678557Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#672494}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9770a4660fc9..1f456938b36f git log 9770a4660fc9..1f456938b36f --date=short --no-merges --format='%ad %ae %s' 2019-06-26 sugoi@google.com Remove incorrect and unused line to avoid confusion Created with: gclient setdep -r src/third_party/swiftshader@1f456938b36f The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I1da3d5168b07cb9f65325a0f4d7fa4aeeba07d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678217Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/948f4cb2..3d3b3c6d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1839a5ba1a661cf1c1ddc2fa2fa87d260866b243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678296Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672492}
-
Peter Kasting authored
This is basically copy-and-pasted from the <include> support. Bug: 564112 Change-Id: I402ae9c56f48de0d87726a0961687e1d6bac0e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670354 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#672491}
-
Rayan Kanso authored
Change-Id: I69c8634691e6bbf8229f14a7f520aa3fc779ff5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678318 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#672490}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/166f0ab34656..f20daf0bf0cf git log 166f0ab34656..f20daf0bf0cf --date=short --no-merges --format='%ad %ae %s' 2019-06-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src f9d08a25fbe1..4162de4bbfc5 (4 commits) Created with: gclient setdep -r src/third_party/angle@f20daf0bf0cf The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I15b690cac80cfa59113970175c5c2b31c12cfee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678216Reviewed-by:
-
Alice Boxhall authored
Algorithm described here: https://whatpr.org/html/4288/interaction.html#inert-subtrees:inert Bug: 692360 Change-Id: Ie37b2c68cabf7ae9051875b8e15ed3675980a848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568378 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#672488}
-
Caitlin Fischer authored
Bug: 969715, 951174, 978523 Change-Id: I9a7905cc410de5fc7dded45f71026926e361ac63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676546Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#672487}
-
Vadym Doroshenko authored
Bug: 949519 Change-Id: I5848a9105afc12b73b20824fad51a58f31f98264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675433Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#672486}
-
Paul Lewis authored
The code we have to populate a tree uses await, except that in the recursive case we don't await its Promise, instead treating it as a sync op. This resulted in the bug that the child list is empty when checked. This patch updates that code such that it now awaits the async populate process before checking for child nodes to expand. Bug: 961141 Change-Id: I35f3aacf3ef67d0de9a0c35a0c98ec500b08df58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657907Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#672485}
-
Shimi Zhang authored
These classes were ignored for not having @Override annotation, now they all properly annotated. Should be fine to remove the exceptions. Bug: 635567 Change-Id: Iaf5c99dddefed47d6117cbcbfa22084a5af6fcef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677128 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
