- 12 Dec, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium aed99d7e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I733950880044e2778d5b961027e0e11cf53c3baf Reviewed-on: https://chromium-review.googlesource.com/c/1373140Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615820}
-
Matt Menke authored
We never enabled it by default, and have no plans to, so we should just remove it. QUIC also makes it less useful, and TLS 1.2 0-RTT session restore means it potentially mutates state. It also leaks also leaks data between profiles, including (but not limited to) incognito profiles, since it relies on global system state. TBR=sergeyu@chromium.org Bug: 914007 Change-Id: Id9c333216661ee538cc6ce6e2b7f70b899393367 Reviewed-on: https://chromium-review.googlesource.com/c/1371938Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#615819}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5beabfe91862..b0b5835a1715 git log 5beabfe91862..b0b5835a1715 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-11 michaelludwig@google.com Add additional test to blacklist for 405 2018-12-11 ethannicholas@google.com Perform Vulkan resets in a background thread 2018-12-11 scroggo@google.com Better testing of SkCodec to 565 2018-12-11 reed@google.com move intercepts impl into textblob Created with: gclient setdep -r src/third_party/skia@b0b5835a1715 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I57517d793abab25ab137c3c9f45c1104f496d34d Reviewed-on: https://chromium-review.googlesource.com/c/1372898Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615818}
-
Eugene But authored
This change keeps the original transition type and adds PAGE_TRANSITION_FORWARD_BACK as qualifier. Change-Id: Ia3b59c3d555223a66a5553cbba2ff1ebf3b28f0c Reviewed-on: https://chromium-review.googlesource.com/c/1371883Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#615817}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ad858d1231e7..60446b8d5f30 git log ad858d1231e7..60446b8d5f30 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 84fd8a4f..7f93585b (615612:615733) 2018-12-12 amithi@webrtc.org RID parsing for Simulcast support. 2018-12-11 emircan@webrtc.org Reland 2: Add VP9 Profile 2 to default profiles 2018-12-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 573be063..84fd8a4f (615506:615612) 2018-12-11 ouj@fb.com Make CONNECTION_WRITE_TIMEOUT configurable for ice connection 2018-12-11 steveanton@webrtc.org Convert MediaSessionFactory to return unique_ptrs 2018-12-11 steveanton@webrtc.org Convert TransportDescriptionFactory to return unique_ptrs 2018-12-11 artit@webrtc.org Add support to nested third_party licenses in generate_licences.py 2018-12-11 sprang@webrtc.org Don't trigger too many probes when max allocated bitrate changes. 2018-12-11 andersc@webrtc.org Mark functions using old factory classes as deprecated. Created with: gclient setdep -r src/third_party/webrtc@60446b8d5f30 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib3f9b6c9784717f90e2a22afe3baa53ac9d29164 Reviewed-on: https://chromium-review.googlesource.com/c/1372901Reviewed-by:
-
Noel Gordon authored
- FileTransferController uses ProgressCenter in its contructor - add externs_list deps to externs backend ProgressCenter No change in test behavior. Bug: 914197 Change-Id: I12d91732edd9fec52c44af54d9c88a6e9f98719a Reviewed-on: https://chromium-review.googlesource.com/c/1373050Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615815}
-
Sunny Sachanandani authored
First failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205%29/12423 TBR=kbr@chromium.org Bug: 914206 Change-Id: Ia1130a35e1e8ba87e09217367351d08c168dee50 Reviewed-on: https://chromium-review.googlesource.com/c/1372637Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#615814}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ic1db4648fbf6e7d3f0fcb2fb3f14d3b4e1444dcc Reviewed-on: https://chromium-review.googlesource.com/c/1373092Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#615813}
-
John Lee authored
Bug: 910890 Change-Id: I794b1574ed19b4e16391abe6035ffe16aa905452 Reviewed-on: https://chromium-review.googlesource.com/c/1372712Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#615812}
-
Jay Harris authored
Bug: 853593 Change-Id: I4c3a8b4e21b283cce61579973c94236dfc057904 Reviewed-on: https://chromium-review.googlesource.com/c/1318771 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#615811}
-
Noel Gordon authored
- ImportController @types refer to {CommandHandlerDeps} - add externs_list deps UI externs/command_handler_deps.js - And the same for FileManagerCommands No change in test behavior. Bug: 914197 Change-Id: I9f71b677f22961d0e14ac55834ca0a9b0cea180a Reviewed-on: https://chromium-review.googlesource.com/c/1373051Reviewed-by: -
John Abd-El-Malek authored
It didn't actually use the return value anymore (after conversion to SimpleURLLoader in r610189), so just return a boolean. Bug: 837753 Change-Id: I9712f1520db8203f821e36c738c290c783d97dbe Reviewed-on: https://chromium-review.googlesource.com/c/1372913Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#615809}
-
Sergey Ulanov authored
Previously, gfx::SkColorTypeToVkFormat() wasn't mapping kRGB_888x_SkColorType because VK_FORMAT_R8G8B8_UNORM was not supported by Skia, but it should be able to handle that image format now. Bug: 861853 Change-Id: Ic2b861f42628946484efb872aaf0c43aad5d660b Reviewed-on: https://chromium-review.googlesource.com/c/1372724Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615808}
-
Tao Bai authored
Bug: 839646 Change-Id: I0b28b079bd5e44d8f8d9a6057d2740b4f6bc9bcb Reviewed-on: https://chromium-review.googlesource.com/c/1370373Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#615807}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I66259745a37998a96ef8010f6026385bec2d3197 Reviewed-on: https://chromium-review.googlesource.com/c/1372918Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#615806}
-
edchin authored
Bug: 905524 Change-Id: Ia07addff101cf05b2fb21309963ca9298c7a26e9 Reviewed-on: https://chromium-review.googlesource.com/c/1371284 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#615805}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f78267e16157..407a081da693 git log f78267e16157..407a081da693 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 tsepez@chromium.org Remove fragile script index mechanism. 2018-12-12 tsepez@chromium.org Remove strings/hashes from element-atttribute table. Created with: gclient setdep -r src/third_party/pdfium@407a081da693 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2e69e4733b02f5289be6046dffe3cb7d45bc104d Reviewed-on: https://chromium-review.googlesource.com/c/1373129Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79ff98db91ae..45637bf3b4b6 Created with: gclient setdep -r src-internal@45637bf3b4b6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891313,chromium:790258,chromium:790231,chromium:790219,chromium:790217 TBR=mmoss@chromium.org Change-Id: Icf6596623081a153d9725e1c03f1be538d056670 Reviewed-on: https://chromium-review.googlesource.com/c/1372900Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615803}
-
Devlin Cronin authored
Add benwells@ as an OWNER of component_extensions_whitelist to approve new component Chrome Apps. Bug: None Change-Id: If570b26b5446baa84f1ca7dcae96175d9b37ba66 Reviewed-on: https://chromium-review.googlesource.com/c/1372271Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615802}
-
Christopher Lam authored
This CL drops the closure_compilation bot for everything except the closure_compiler directory, since the bot only runs a Closure Compiler test now. Change-Id: I5f9149af0ff27ae87a294e72282e019ce926ce96 Reviewed-on: https://chromium-review.googlesource.com/c/1345790 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#615801}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/611bbaabb28c..3a2562287939 git log 611bbaabb28c..3a2562287939 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 jmadill@chromium.org Update ANGLE_multiview validation. Created with: gclient setdep -r src/third_party/angle@3a2562287939 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I6e7dc7d7885ad01898d3993e239befac0e84fc1e Reviewed-on: https://chromium-review.googlesource.com/c/1372897Reviewed-by:
-
John Lee authored
WebUI: Add common class to use on all the labels/text in settings row, update 'People' settings rows to use it Bug: 686905 Change-Id: I97e750e55e73b54451f87e34f6b0570a6b89dd71 Reviewed-on: https://chromium-review.googlesource.com/c/1359331Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#615799}
-
Stephen Chenney authored
Addresses a TODO where we were snapping the intrinsic size of an SVG image, even when that is no longer useful. This was posing issues with operations using aspect ratio, because the computed aspect ratio on the snapped value was wrong when then used on un-snapped values. R=fs@opera.com BUG=855882 Change-Id: I0c14c0109da4c5ca5e52aebf408e9b702eda799c Reviewed-on: https://chromium-review.googlesource.com/c/1370486 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#615798}
-
rbpotter authored
Locally reproduced the test failure and determined that async setup in FocusRowBehavior was often not actually completed before tests were started. Waiting for one more render to ensure async setup is complete prevents the flakes. Bug: 913197 Change-Id: Ifb893927ecf83666f5edb201c81cb5ce49791fc0 Reviewed-on: https://chromium-review.googlesource.com/c/1372831Reviewed-by:
-
Kent Tamura authored
TBR=kinuko@chromium.org Bug: 843412 Change-Id: I36cd63ab1c3b0b0541d458fa91d3b8c8759356f6 Reviewed-on: https://chromium-review.googlesource.com/c/1373049Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#615796}
-
Darren Shen authored
In r1067519, we added a UMA histogram for ViewsTextServiceContextMenu, but we only changed enums.xml and not histograms.xml. This patch fixes this. TBR=sky@chromium.org Bug: 838710 Change-Id: I5cdd9e0c76e2c5a7bace9ae3f80883ed905a26c8 Reviewed-on: https://chromium-review.googlesource.com/c/1358615Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#615795}
-
Noel Gordon authored
- FileTasks uses Crostini in its contructor - add externs_list deps to externs backend Crostini No change in test behavior. Test: browser_tests --gtest_filter="FileManagerJsTest*FileTasks*" Bug: 914197 Change-Id: I3c8c925cd7ffa24420c2986b624dcc5870b08783 Reviewed-on: https://chromium-review.googlesource.com/c/1372990Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615794}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/52411ecf1fa5..e76041196062 git log 52411ecf1fa5..e76041196062 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@e76041196062 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ifebca200a0fd5fc4d4696f6efedbfaa42eeda63a Reviewed-on: https://chromium-review.googlesource.com/c/1372896Reviewed-by:
-
Erik Luo authored
- Focus color is now 'blue', closer to the background color of a focused console message. - In both Objects and Nodes, focus highlight's width fits tightly around the text content. Screenshot: https://imgur.com/a/aLyGRqJ Bug: 865674 Change-Id: Ie0fb14897dc855cd7713b2ce6ba0328ef205fc7a Reviewed-on: https://chromium-review.googlesource.com/c/1368842Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#615792}
-
Alice Boxhall authored
Bug: 872438 Change-Id: I86931802744baa8d41a4c6ed2b1c89967fc47138 Reviewed-on: https://chromium-review.googlesource.com/c/1372105 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
-
John Lee authored
Bug: 910476 Change-Id: If8d3676d21133f49b0e872bca84d389d0a8042f3 Reviewed-on: https://chromium-review.googlesource.com/c/1372416Reviewed-by:
-
Brandon Wylie authored
TBR=twellington@chromium.org Bug: 913937 Change-Id: Idb4c3142dd6db2806662922effe2132eb1e790b6 Reviewed-on: https://chromium-review.googlesource.com/c/1372651 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#615789}
-
Ahmed Fakhry authored
Chrome used to call into debugd to get the list of user log files that it should read itself. Those files are generated by Chrome itself, and hence they should be listed in Chrome itself without the need to ask debugd to list them. BUG=907193 TEST=File feedback report, make sure the following entries are part of the system logs: * chrome_user_log, * libassistant_user_log, * login-times, * logout-times. Change-Id: I2e164db999edfc6e7089a0ae905cc6db57121621 Reviewed-on: https://chromium-review.googlesource.com/c/1352681Reviewed-by:Dan Erat <derat@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#615788}
-
Hiroshige Hayashizaki authored
https://chromium-review.googlesource.com/1153598 switched WorkerClassicScriptLoader::ResponseURL() (which is used as WorkerGlobalScope's URL later) from ResourceResponse::CurrentRequestUrl() to ResourceResponse::ResponseUrl() (in terms of the current ToT), but the same-origin check for Issue 861965 remained unchanged, i.e. checking ResourceResponse::CurrentRequestUrl(), which doesn't reflect ServiceWorker interception. This CL updates the same-origin check to also check ResourceResponse::ResponseUrl(), to ensure WorkerGlobalScope's URL and SecurityOrigin always match even if a ServiceWorker returns a response with a cross-origin URL. Bug: 861965, 861564 Change-Id: I9915599dc1ee16dbd4879525db90c4cb38da4eb3 Reviewed-on: https://chromium-review.googlesource.com/c/1368460 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#615787}
-
liberato@chromium.org authored
Change-Id: I82dce2160fd1809091fdfdbef9c854d9aef16844 Reviewed-on: https://chromium-review.googlesource.com/c/1372578 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615786}
-
CJ DiMeglio authored
Change-Id: Ib9d49e22b1483f5df6310b00c70879cb48f8659f Reviewed-on: https://chromium-review.googlesource.com/c/1372891 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#615785}
-
Alice Boxhall authored
This reverts commit 0ed2b6ca. Reason for revert: Seems to be causing build breakages on Fuchsia bots https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64/47071 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64/25530 Original change's description: > [Fuchsia] Generate more complete GN target names for FIDL packages. > > FIDL package names consist of multiple dot-delimited segments, to allow > scoping of packages to avoid clashes. Our GN generator script was using > only the final segment of each package's name, resulting in clashes, > e.g. between fuchsia.auth and fuchsia.modular.auth, if both were > present in the SDK. > > We continue to generate targets under the //third_party/fuchsia-sdk/sdk > namespace, but use the full name rather than only the final segment, > e.g. custom.modular.auth would become custom_modular_auth. > > We also special-case the top-level "fuchsia" namespace to be ignored, > e.g. fuchsia.modular_auth becomes just modular_auth. > > Bug: 910670 > Change-Id: I675d894c72b5d43b6d8b20fb026075573a5a3380 > Reviewed-on: https://chromium-review.googlesource.com/c/1372892 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615763} TBR=wez@chromium.org,kmarshall@chromium.org Change-Id: Ibc33ed422c1365b019bf53ca8e4fdb26ee781038 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910670 Reviewed-on: https://chromium-review.googlesource.com/c/1372111Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615784}
-
Alice Boxhall authored
This reverts commit 573f4675. Reason for revert: Seems to be causing EffectiveTouchActionPropagatesAcrossNestedFrames to fail https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927388648425983952/+/steps/content_browsertests_on_Intel_GPU_on_Mac_on_Mac-10.12.6/0/logs/SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossNestedFrames/0 Original change's description: > Remove code to store the last popup transiently in WebFrameWidgetImpl > > This code was copied over from WebViewImpl when adding the HidePopups > call in order to have a pinch zoom or scroll tap outside the current > popup in a non-main-frame-local-rooted iframe hide the current popup. > > This is modifying state on WebViewImpl meant to track between TapDown > and Tap, to avoid the Tap showing a popup that was hidden by TapDown. > > WebFrameWidgetImpl does not show popups on Tap, and if it did, it > should track this transient state locally not on WebViewImpl. > > Also remove the undocumented FALLTHROUGH which was not explained > in 671732 as it now goes to nothing. > > R=dcheng@chromium.org > > Change-Id: I9d67539cf0afbb9db239b73bf83418e1a877e6db > Bug: 912193, 671732 > Reviewed-on: https://chromium-review.googlesource.com/c/1372539 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615708} TBR=danakj@chromium.org,dcheng@chromium.org,wjmaclean@chromium.org Change-Id: Ifddbb605fc6165505774105d5618d57b62e3159c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912193, 671732 Reviewed-on: https://chromium-review.googlesource.com/c/1372110Reviewed-by:
-
Carlos IL authored
Added SB committed interstitials flag, and changed the cancellation error code to ERR_BLOCKED_BY_CLIENT if the flag is set. Bug: 910794 Change-Id: I43853600bee91f7fdeea78409248994372fd7091 Reviewed-on: https://chromium-review.googlesource.com/c/1364330 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615782}
-
Peter Boström authored
* Uses EASE_IN_OUT for the progress bar to match the throbber. * Uses FAST_OUT_SLOW_IN for favicon per UX request. Bug: chromium:912620 Change-Id: I3ce0a376996c016904a605aa8195cc741b8e03d1 Reviewed-on: https://chromium-review.googlesource.com/c/1373016Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615781}
-
