- 05 Oct, 2020 40 commits
-
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ib7956c406c40adc8f3a09ad0fbb68a0a71d63fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450692Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#813971}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c063270..7de00dff Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ica6f63ae248b5842ca1fd691cba58bdb2761e0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449917Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813970}
-
Mohamed Amir Yosef authored
Instead of having its own implementation, this CL uses the recently introduced ColorTrackingIconView in the autofill popup native views. Bug: 1115952 Change-Id: I77ed51c6fc903d8c8f7eee3bd9a1174f69b44ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440672Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#813969}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //url. Bug: 1113033 Change-Id: Ieb893059e1e253cfb53387de4fc37bcc580aa3af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450925 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#813968}
-
Brian Malcolm authored
This means that for Dasher organizations the manager is the domain (foo.com), but for FlexOrgs the manager will be an email address (user@foo.com). Screenshot (https://screenshot.googleplex.com/9buie7RDDnnRXyo) BUG=chromium:1081272 Change-Id: I689b10ee85e1d48f2f450c003d2e458a0649f151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451389Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#813967}
-
Ilya Sherman authored
R=mpearson@chromium.org Bug: none Change-Id: Ia3500bd41e7cdbb52097340100a5fba28cf2ad3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415270 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#813966}
-
Eric Orth authored
As was previously only done for address results, also allow non-address results to read a TTL from SOA records for NXDOMAIN and NODATA responses. This allows negative non-address results to be cached (but only for the non-transient NXDOMAIN and NODATA cases). For both address and non-address negative response parsing, do not read any TTLs unless an SOA record is present. But if an SOA record is present, still allow using the min TTL between that record and any other parsed records present (e.g. CNAME records that are still valid to be present in an NXDOMAIN response). Fixed: 1121785 Change-Id: I200f45b60c30d89ee53e45fa2cdb70302b617c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446016 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#813965}
-
John Williams authored
This change fixes two related problems, one causing notifications to appear when they shouldn't, and another causing a notification to appear in the media dialog after it has been deleted, causing a crash if it is clicked. Change-Id: Ia78ae95af2afe6d1024e86c12ebacdf0720d84cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424629Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#813964}
-
Findit authored
This reverts commit f13525f7. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 813940 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2YxMzUyNWY3MzYzNzNmOGFhM2ZhNWQ1YzQxY2Y3ZTcxNTExYTc0MDIM Sample Failed Build: https://ci.chromium.org/b/8867243040948303664 Sample Failed Step: compile Original change's description: > Roll Dawn from df909306835a to b04a92f01be0 (1 revision) > > https://dawn.googlesource.com/dawn.git/+log/df909306835a..b04a92f01be0 > > 2020-10-05 enga@chromium.org Add a per-thread proc table using thread local storage > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/dawn-chromium-autoroll > Please CC kainino@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel > Bug: None > Tbr: kainino@google.com > Change-Id: I5b8a66c618951312fdc5d3ede4f0c861ef17cd30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450581 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#813940} Change-Id: If43f8e52042eb5c6d31f7896ceeb6d56b6c00e1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450792 Cr-Commit-Position: refs/heads/master@{#813963}
-
Lucas Radaelli authored
Reland explanation: A test I wrote tested specific size values for the semantic tree. The chrome a11y code that creates the tree for us is non-deterministic, so we can't check for a specific tree size. I updated the tests to only test for a minimum threshold, which is fine in this case here. This is a reland of fdae2298 Original change's description: > [fuchsia][a11y] Sends full semantic tree when semantics are enabled. > > This change fixes the bug where chrome was sending the full semantic tree only for the first time that semantics were enabled. This happened because the semantic tree was not getting cleared on the chrome side when disabled. when semantic were disabled / enabled, the events fired on the tree included only the diffs from the previous state of the tree. > > Test: web_engine_browsertests > > Bug: fuchsia:59680, 1134147 > Change-Id: I8266d6436f9bfb9ee9e89a0f46c0916bac7a5e75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442646 > Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Sharon Yang <yangsharon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813771} Bug: fuchsia:59680 Bug: 1134147 Change-Id: I606b7628c480b775c04d84894faaba73f74789c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450704 Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Auto-Submit: Lucas Radaelli <lucasradaelli@google.com> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813962}
-
Malay Keshav authored
Adds fieldtrial testing config for Viz GLSolidColorQuad fast draw experiment. Bug: 1134771 Change-Id: Ia30ba3b1c23a2b980993556d8f90c9f98a57d72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450912Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#813961}
-
James Hawkins authored
Bug: 1045266 Test: OSSettingsInternetSubpage* R=khorimoto@chromium.org Change-Id: Ic4c1409828456121bd66f80700f23990ced14742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446191 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813960}
-
Jesse Schettler authored
Instead of firing custom events when dropdown selections are changed, use data bindings to set the scanning-app element's properties to the selected values. Bug: 1059779 Test: Select a scanner and verify its capabilities are obtained. Change-Id: If8927a4898dca25720c7f8550fe640fad160178a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448668Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#813959}
-
Leonard Grey authored
Bug: 1014639 Change-Id: I550f129e9a72cc371b5bdfa06be3c38280c10db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450703 Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#813958}
-
Frank Liberato authored
Rather than create one VideoProcessor per wrapper, create one per TextureSelector. This reduces the number of required processors to one per decoder init, rather than one per picture buffer. Bug: 1133568 Change-Id: I87d58c49742e083ca3cdf3c67841a153375f1a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441290Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#813957}
-
Dale Curtis authored
Cross-origin audio is still allowed to play out, it just can't be captured by the containing page. Bug: 1128657, 1134679 Test: Unit tests added. Change-Id: Id4c73e315072b8683e45a2ddf929d534f1da9928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450390 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813956}
-
Aaron Leventhal authored
When adding children, make sure we only add aria-owned children to the owning nodes. This avoids a common crash in chrome://bookmarks that has a confusing crash stack. In order to do this, when ComputeAccessibilityIsIgnored() is called, the relation cache must already be updated with the knowledge that the object is owned. Do not ever allow owned objects to ever have a "not included in tree" parent. Therefore, they can never be added as second line children via the recursion in InsertChild(). Also re-remove WalkAllDescendants(), which was it was recently re-added as a band-aid for the chrome://bookmarks crashes. Without this change, removing WalkAllDescendants() causes assertions in AXTreeSerializer, when aria-owns points to an unincluded node, that the same object is being added twice. Finally, add better logging and DCHECKs that will help diagnose issues more quickly. Bug: 1100968, 1131848 Change-Id: I3bb5d069814e144d426b5c3de0991bc41123206f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446200 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813955}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6d93a63356e1..afe6ca45b6da 2020-10-05 bclayton@google.com Merge changes I48e99f11,I1a914ff6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Idadaba65112faf8228f152f106f1156aa076c241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813954}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c9e3d3e3a7e0..d93ee76664c7 2020-10-05 patrick.brosset@microsoft.com New jump-to-var feature in the Styles pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124707 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I01a9a81b0dd1d4a10a1efeb64880b61af1b2a37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450583Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813953}
-
Tina Wang authored
Also added a helper api for setting the policy to integer. Bug: 1131052, 1065522 Change-Id: I2c745f2e145c932fab21396afbd9e2689aba9d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443635 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#813952}
-
edchin authored
Bug: 1099646 Change-Id: Icb8adf3f1b599c9a8cb12dd7cee563432db5671a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442171 Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#813951}
-
Kaustubha Govind authored
Extending the Cookie.ExpirationDurationMinutes* metrics through mid-2021. This data will be helpful in informing potential future work on limiting lifetime of cookies. Also, splitting up the histogram based on whether the 'Secure' attribute is specified, since we may target intervention on non-secure cookies, as per draft-west-cookie-incrementalism.html#rfc.section.3.6 Bug: 1088694 Change-Id: Ief1fe0b732df34b71d29f5e0a72dfb40fd9a0851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445910Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org> Cr-Commit-Position: refs/heads/master@{#813950}
-
Oleh Lamzin authored
Fix typo in session_manager_types.h by renaming SESSION_STATE_LOGIN_PRIMARY to LOGIN_PRIMARY. Also this change helps to be consistent within the file when mention states in comments. Change-Id: I268421fc01d79fa712da41da6a97ea04f253430f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450072 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#813949}
-
Mehran Mahmoudi authored
Bug: 1135054 Change-Id: Idec0ddfab4877137e6a7deca395370b6619a9206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450717 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#813948}
-
Yulun Wu authored
This addresses the changes in these CLs https://chromium-review.googlesource.com/c/chromium/src/+/2363799 Bug: 1134854 Change-Id: I522e5ebe9228bec7e12b9037ee4a4b95b2593c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446547Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813947}
-
Chris Thompson authored
This reverts commit 8fd53893 (which reverted the original change in commit 0d9bc827). The cause for the revert was fixed in commit 06c4cc74. Original change's description: > Remove net::ct::CTVerifyResult and merge with net::CertVerifyResult > > As part of moving CT verification to occur within the state machine > of cert verification, move the CTVerifyResult fields into the > CertVerifyResult as appropriate. > > As a nice side benefit, this allows CT verification details to be > handled in browser tests using ContentMockCertVerifier. > > Bug: 848277, 1016635 > Change-Id: I365358ca12ecd9205d8103ed0e3396cdb48144b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423060 > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810364} TBR=rsleevi@chromium.org,kouhei@chromium.org,estark@chromium.org,cthomp@chromium.org,rmcelrath@chromium.org Bug: 848277, 1016635 Change-Id: I170cafdd9aed46fed4de0e6afa34b3308ebbd6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450735Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813946}
-
Sam Sebree authored
This change updates the styling for the link controls in dark mode. Bug: 1107287 Change-Id: I62b7a05320c9a6e2597614411eee627bc72e4813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437822 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#813945}
-
Nate Fischer authored
No change to logic for Chrome, this only affects WebView. This adds an option to VariationsSeedStore to configure it to avoid accessing the "first run" Java SharedPreferences. Any access to SharedPreferences may perform disk IO; since WebView initializes variations on the UI thread, this causes a strictmode violation. WebView doesn't use the first run prefs, so this adds a configuration parameter to completely avoid SharedPreferences. This also adds unit tests to verify SharedPreferences are not modified when this parameter is passed. Fixed: 1131941 Test: out/Default/bin/run_components_unittests -f VariationsSeedStore* Test: android_webview/tools/run_cts.py -m CtsWebViewStartupApp.apk Test: Locally add 'assert false' next to SharedPreferences access, verify WebView doesn't crash Change-Id: I137fcbc49b4619dcde84fa1d0375edf6d421c8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444473 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813944}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9f0c89bd5660..eacbd972ab7e 2020-10-05 alessiob@webrtc.org AGC2 logs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I34c7e6b0cd5d56b25ed982dec225be1cef321986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451189Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813943}
-
minch authored
Bug: 1133762 Change-Id: I98c7f1323e46abf81b1349272cef1865b9575c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441809 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#813942}
-
John Lee authored
A drop event is not fired if a drag interaction did not have any x/y pointer movement. This CL moves the contextmenu call to the dragend, as the dragevent is consistently sent at the end of every drag flow. Bug: 1117652 Change-Id: I9e3fc078fcc2843808d3db454feb39084b97794d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446353 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#813941}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/df909306835a..b04a92f01be0 2020-10-05 enga@chromium.org Add a per-thread proc table using thread local storage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I5b8a66c618951312fdc5d3ede4f0c861ef17cd30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450581Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813940}
-
Chris Sharp authored
on Linux TBR=ghazale@chromium.org BUG=1134506 Change-Id: Id490ab99c96ea5eadf7dc4dfc564a23f7172e186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450953Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813939}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601899131-feda22e3411bdb75c005a38c5197b1e76964f668.profdata to chrome-linux-master-1601920728-6028d40b51a1c3ae51d439d61f82d0425613d326.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I34aa50af4524c1182188002006702aafadca8f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813938}
-
Yuwei Huang authored
This is a simpler approach to tackle (workaround) the blocked network thread issue when compared to CL 2436278. This CL simply creates a base::Watchdog that arms before closing the peer connection, and disarms after the peer connection is closed. If thread join takes longer than expected then it will crash the host so that the daemon process can respawn it. Bug: 1130090 Change-Id: Ib2400e17b848ed07df902a02b344efbf5e15c588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446840Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#813937}
-
Ramin Halavati authored
Incognito dynamic quota has been enabled by default. The feature and experimental test code are cleaned up. Bug: 1017120 Change-Id: I18895ae16dbd2641cf67d8f113b56509da67c7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426570Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#813936}
-
Adam Ettenberger authored
This change was split out of the following CL after it was reverted : https://chromium-review.googlesource.com/c/chromium/src/+/2346933 Reland "Fix Role::kButton name invalidation when descendant text is modified" This change wraps inserting into memoized sets in BrowserAccessibilityManagerWin with a method and adds DCHECKs to ensure the sets are only inserted within the scope of OnAccessibilityEvents. - FireUiaTextContainerEvent made it possible to fire text events more than once for a given text provider so it has been removed. - Instead, populate a set |text_changed_events_| which contains the text providers via |GetUiaTextPatternProvider| and fire the UIA text events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents - |text_selection_changed_events_| could also potentially end up with the same double-event problem, so it uses GetUiaTextPatternProvider now as well. - Removing usage of std::unordered_set based on the guidance in base/containers/README.md. In general these sets shouldn't grow large enough to benefit from being unordered. Bug: none Change-Id: Ic41ced4dede40c4597d5f79aa4b7f36a7d0c994a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391766 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813935}
-
Jamie Madill authored
The Linux/Win OS was missing from several bots. Needed to use 'linux_args' for SwANGLE tests. Bug: angleproject:5124 Change-Id: I075ce275d4f7ed49c71189db55a3f807d45a4b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446995Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#813934}
-
David Bertoni authored
This CL parameterizes the existing Metrics API test to run as both a persistent background page and Service Worker-based extension. Bug: 1093066 Change-Id: Iaf610882e7e4780298a58a66aac1a994015449cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441192 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#813933}
-
Caitlin Fischer authored
Also, add http://crbug/1134146 to clean up the feature-related code in media/blink/video_frame_compositor_unittest.cc. Bug: 1126640 Change-Id: Ibaaacb382ac80c443a25c7c27d3f943bb789cc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442870Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#813932}
-