- 23 Feb, 2020 7 commits
-
-
Dana Fried authored
This reverts commit ef8dbf91. Reason for revert: Fixed tests that are still failing/flaky. Some of the logic around the layout of the PWA window in the original patch was not as deterministic as it should have been, which caused test flakiness. This addresses the problem along with several related bugs. One of the fixes in this CL is to return the final resize of the failing test back to something equivalent to the logic prior to the original version of the patch, which was clearly done in a particular way to handle different layout pathways on different platforms. Original change's description: > Revert "Reland "Make PWA titlebar and icons flex and animate properly."" > > This reverts commit e490a00a. > > Reason for revert: Sheriff here: > Consistent failure of Linux MSan Tests: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests > First failed run: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/22357 > > Original change's description: > > Reland "Make PWA titlebar and icons flex and animate properly." > > > > This reverts commit de7cd485. > > > > Reason for revert: Fixing issue with Mac tests. > > > > Original change's description: > > > Revert "Make PWA titlebar and icons flex and animate properly." > > > > > > This reverts commit 8f2f4243. > > > > > > Reason for revert: speculative revert for test failures on Mac > > > for WebAppFrameToolbarBrowserTest.SpaceConstrained, see e.g. > > > https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31700 > > > > > > Original change's description: > > > > Make PWA titlebar and icons flex and animate properly. > > > > > > > > Nested layouts now allocate available space properly to their > > > > descendents. Also, we consistently use flex layout in the PWA titlebar. > > > > > > > > Removed a couple of invalid assumptions that were encoded as DCHECKs. > > > > > > > > There are still some inkdrop issues but they are purely cosmetic, see > > > > crbug.com/1006162 for more detail. > > > > > > > > Bug: 1048061 > > > > Change-Id: I403b71b5e2bbcb2d461e1ed6c543c76f91d4c652 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036264 > > > > Commit-Queue: Dana Fried <dfried@chromium.org> > > > > Reviewed-by: Peter Boström <pbos@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#738874} > > > > > > TBR=pbos@chromium.org,dfried@chromium.org > > > > > > Change-Id: I731bad118043652a6dbd082c6099ebbd0c697835 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1048061 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041615 > > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#738907} > > > > TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org > > > > Change-Id: Idb9712d1ffe45bf374af846278e26d61983a44f0 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1048061 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042326 > > Reviewed-by: Dana Fried <dfried@chromium.org> > > Commit-Queue: Dana Fried <dfried@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#742203} > > TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org > > Change-Id: If65099915ea0efa01de8cc9b0df0a7e9bf03a60b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1048061 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062996 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742549} TBR=pbos@chromium.org,poromov@chromium.org,mastiz@chromium.org,dfried@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048061, 1050957, 1053899 Change-Id: I5e709a60ae2bd1331bb48687fa9af68d7833b9a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067639Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#743824}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/93f917a48395..878e5f26c327 git log 93f917a48395..878e5f26c327 --date=short --first-parent --format='%ad %ae %s' 2020-02-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@878e5f26c327 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibd70379ce353879d37f70275432e0ff71631edcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069601Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743823}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I926acdcc4a00ff4fdefafc03bc017a5e0b8a46c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067152Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743822}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86b5a1daaf14..2feb0e216c9a Created with: gclient setdep -r src-internal@2feb0e216c9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifea8fde093e5981f5d1472d5c35b41f39dad58ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069599Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743821}
-
Michael Spang authored
This function is needed for GL/Vulkan interop on Fuchsia. Bug: 766360 Change-Id: I37645fc29fbadd49f48eefbaf4849daa1be82a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069178 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743820}
-
Nico Weber authored
Bug: 1039697 No-Presubmit: true Change-Id: Iad7f37f56377633d0503989f64c954825489a338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068136 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#743819}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1137a90e6506..86b5a1daaf14 Created with: gclient setdep -r src-internal@86b5a1daaf14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2fbf367149b186c225adbe15c12395904924f850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069597Reviewed-by:
-
- 22 Feb, 2020 33 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium f385e383. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia67915c254a9ddfab4a877bacbf5a3e39dacc2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069517Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743817}
-
Mehran Mahmoudi authored
The native implementation of UnguessableToken does not keep a reference of its Java counter-part. Therefore, having a Java equals() method comes in handy. Among other things, hashCode() enables UnguessableToken to be used as a key in HashMap. Change-Id: I062d462298990b23da22c87028a5b0520791c00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067670 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#743816}
-
Jann Horn authored
Interpret BTN_SIDE and BTN_EXTRA as "back" and "forward" commands. BTN_BACK and BTN_FORWARD are already supported for triggering navigation; however, mouse side buttons for navigation trigger BTN_SIDE ("back" button) and BTN_EXTRA ("forward" button). Add support for these, so that these buttons work the same way they did under X11. This also matches how Android interprets these events: https://source.android.com/devices/input/touch-devices#buttons See also https://www.spinics.net/lists/linux-input/msg60756.html , which says: > In practice on most mice which have more then 3 buttons, usage 4 is > used for the back(ward) button and usage 5 for the forward button. > > This means that these buttons generate an input_event code of > 0x113 resp. 0x114, which looking at the old defines maps to > BTN_SIDE and BTN_EXTRA. > > Under X these are mapped to buttons 8 resp. 9; and under wayland > the input_event code is passed through unmodified. > Apps, e.g. Firefox both when running as Wayland client under > GNOME3 and when running under Xorg, correctly interpret these as > back and forward. > > So we've back and forward buttons generating BTN_SIDE and BTN_EXTRA, > which the apps then interpret as BTN_BACK and BTN_FORWARD, rather > then as BTN_SIDE and BTN_EXTRA (which have no clear meaning). Test: manual: run with wayland, navigate, and press back/forward Change-Id: Ibf4c9112c859f6daa3cb0635f8bc1d532d1c917c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069537 Commit-Queue: Jann Horn <jannh@google.com> Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:Michael Spang <spang@chromium.org> Auto-Submit: Jann Horn <jannh@google.com> Cr-Commit-Position: refs/heads/master@{#743815}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a741abb98362..b5576b67bcf5 git log a741abb98362..b5576b67bcf5 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 spang@chromium.org Vulkan: Fix pipeline stage when waiting on a semaphore Created with: gclient setdep -r src/third_party/angle@b5576b67bcf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ie7a16209f493a8bb46c6ad8dc5a509c2dffdabbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069441Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/855f2ed75a9c..1137a90e6506 Created with: gclient setdep -r src-internal@1137a90e6506 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie5a01ead56b35d1d8b9cb5497de5f73e925bdf09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069458Reviewed-by:
-
Daniele Castagna authored
The only platform where we promote TileQuad to overlays is on Mac where we don't use OverlayCandidate related code. Bug: 1022544 Change-Id: I917a06110be0a4d106f692dbc9939253aa76a86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067551 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#743812}
-
Nico Weber authored
Broadly two types of issues: - Code missing the & in `for (const T& foo : ...`) - Code using a T that doesn't match the type of E in `for (const T& foo : E)`. Two common examples: - Iterating a map and incorrectly using `pair<K,V>` instead of `pair<const K, V>` as type. - Doing `for (const StringPiece& s : StringSplit())`. SplitStringPiece() returns an std::string, need to call SplitStringPiece() instead. TBR=msw Bug: 1039697 Change-Id: I99359f58915dbe3d59e8025d5771ca79f4e5d63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068035 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: -
Findit authored
This reverts commit be37ca15. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 743808 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYmUzN2NhMTU5NjhjZGJlY2EyZTM0NDM4MWUyZDkxMDBjYTNmMzE5MQw Sample Failed Build: https://ci.chromium.org/b/8887727527631833568 Sample Failed Step: unit_tests on Intel GPU on Mac on Mac-10.12.6 Sample Flaky Test: ContentSettingBubbleContentsTest.NullDeref Original change's description: > Regression test for null pointer deref. > > Bug: 1050801 > Change-Id: I101dc922e1e589b5741a24ffb41e10452275bcc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068309 > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743808} Change-Id: Iee2d3ed2a81fe261926ccc7af6cc4e5f1f552046 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069132 Cr-Commit-Position: refs/heads/master@{#743810}
-
Vikas Soni authored
Make context current in ~AbstractTextureImplOnSharedContextPassthrough() before destroying the |texture_| since the destructor is not guaranteed to be called from the same context on which the |texture_| was created. Bug: 1054865 Change-Id: I1647d1ec8aede954031aae70692943c2f14920e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068892 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Peter Kasting authored
Bug: 1050801 Change-Id: I101dc922e1e589b5741a24ffb41e10452275bcc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068309Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#743808}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ecd8762e1f86..9e8f60534464 git log ecd8762e1f86..9e8f60534464 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 reed@google.com SkM44.h is now in include/public Created with: gclient setdep -r src/third_party/skia@9e8f60534464 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Ic025d9c36187fd9090fcbc0e5895c7d655101be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069388Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3654b68b32c3..855f2ed75a9c Created with: gclient setdep -r src-internal@855f2ed75a9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8255f118c08f3d56d5f0767a0e55be5262f103c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069379Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c12493ff69e2..07e1a0a67aee git log c12493ff69e2..07e1a0a67aee --date=short --first-parent --format='%ad %ae %s' 2020-02-22 johnkslang@users.noreply.github.com Merge pull request #2090 from amdrexu/bugfix Created with: gclient setdep -r src/third_party/glslang/src@07e1a0a67aee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Ib118e804f34527371ec43963ae9f58c43ca49258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069381Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96c6ec923081..3654b68b32c3 Created with: gclient setdep -r src-internal@3654b68b32c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I28990dc03a0737b0d11df5e03b0160cccdd3a3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069374Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1a85d581c934..ecd8762e1f86 git log 1a85d581c934..ecd8762e1f86 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 kjlubick@google.com [canvaskit] Support children shaders into runtime shaders Created with: gclient setdep -r src/third_party/skia@ecd8762e1f86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I1fcb36e30a32860fbeb87464e0814e1e3ebcb381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069372Reviewed-by:
-
Liquan (Max) Gu authored
Before change: The PH UI crashes when users click the security icon. After change: The crash no longer happen. Change: * The CookieControlsBridge() call is moved after PageInfoControllerJni's init, so that the WebContents has initiated TabSpecificContentSettings. * Add a test for the crash path. Bug: 1053859 Change-Id: Ia30f35be32c76997ecf21418c9e8bb7e8247370e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062987Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#743802}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/adf008a9f500..93f917a48395 git log adf008a9f500..93f917a48395 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@93f917a48395 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic59db69418f271fd11b284b56bf8882dbffc3e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069369Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/92726d8bdba2..96c6ec923081 Created with: gclient setdep -r src-internal@96c6ec923081 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib1f3ecf5f078ff29d9c845d7c31855a8b62bc3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069361Reviewed-by:
-
Kazuki Takise authored
We currently save snap fraction in CompleteDrag, but if the PIP window is flinged, the bounds of the PIP window is not the flinged bounds at this point as it just creates a bounds event and sends the client a bounds change request. So we need to pass the flinged bounds to SaveSnapFraction. Before introducing snap fraction, we used restore bounds and saved the flinged bounds properly, so this CL basically does the same thing with snap fraction. BUG=b:149875362 TEST=Manually confirmed flinging PIP and rotating the screen works. Change-Id: I7b109eaf7786aee5d3c70da167c27ff5c1a69e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065510 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#743799}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I76ad8e78f7f8c514918fd64a2edd2aed702dbc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069200Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743798}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4044.5-1581936665-benchmark-82.0.4058.0-r1 to 82-4044.5-1581936665-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic96b5ed2f1a1882690ff056a562df99c6a0502b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069131Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-4025.0-1580122052-benchmark-81.0.4044.0-r1 to 82-4028.0-1581935713-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If4656962938496bd7d7f3ef49392649a6307c596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069130Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-4028.0-1580121249-benchmark-81.0.4044.0-r1 to 82-4044.15-1581938780-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I56b4e16cbee197fd0b62fd123d307aee88a07d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069128Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90f726dbcf19..92726d8bdba2 Created with: gclient setdep -r src-internal@92726d8bdba2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1cab53e643cacc7eea217de5b2e0f1d6c96dd319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069244Reviewed-by:
-
Anton Bikineev authored
Bug: 1029379 Change-Id: Ide991117023557000a40144741a1db3552b668df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066767 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743793}
-
Xianzhu Wang authored
Previously by default we didn't dump non-drawable layers, causing the dumped layer information lacked hit testable layers. Dumping hit-testable layers will help us verify CompositeAfterPaint test results when we fix crbug.com/937573 (CAP hit-testing for blank backgrounds). Bug: 937573 Change-Id: I5adb1849606895aea7333481ac9a5fd863c218bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067555 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#743792}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f19b54d3263..90f726dbcf19 Created with: gclient setdep -r src-internal@90f726dbcf19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I054da062b2878c64a0a600cceca7cd95828fd078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067756Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie6fa4b9297a0d6426fb487c99b2f5808d62ee219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069240Reviewed-by:
-
Jiewei Qian authored
Prior to this CL, WebLaunchServiceImpl is behind a FileHandlingEnabled check on the document. However, at the time of this check, the actual document is not loaded (we get a blank document without origin trial tokens). So FileHandlingEnabled check always return false, unless we turn on runtime flags. This check cause the problem: when a PWA with File Handling origin trial is launched as a file handler, the app will not receive the launch files. This CL fixes the problem by always bind WebLaunchServiceImpl, this is okay because the DOM (JavaScript) side is still behind a origin trial check, we will not be exposing extra APIs to webpages. Fixed: 1053819 Bug: 1045297 Change-Id: I19966d26afe97dfd3115f142343c6eaacdfe0eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063196 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#743789}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/113e5df9..07cf1f5a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id69fd5bf75b1cfb0c087c58c4b81b1796ea7d23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069164Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743788}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fe1df04b. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5f3cb8bb498e9cda27ff497752f0658291a01dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069162Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/165da89015c7..adf008a9f500 git log 165da89015c7..adf008a9f500 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@adf008a9f500 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6894313889454cdc161af8c8443745d6ecb18b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067755Reviewed-by:
-
Findit authored
This reverts commit eed7024d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 743767 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWVkNzAyNGRlMmQ5MDNkYzU0ZjAwMzgwYzMyMWQwMTA0YmU2NmUyNAw Sample Failed Build: https://ci.chromium.org/b/8887789665458415472 Sample Failed Step: browser_tests Sample Flaky Test: LoadingPredictorBrowserTestWithOptimizationGuide.UsesPredictionsFromOptimizationGuideIfAvailable Original change's description: > Add support for loading predictor to use hints from optimization guide > > Will add metrics in a subsequent CL. This shouldn't affect any current > metrics since the support is all behind a feature flag. > > Bug: 1050101 > Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743767} Change-Id: Ie30a3a73e89bace0febe11c558d7be4c83501936 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069258 Cr-Commit-Position: refs/heads/master@{#743785}
-
