- 30 Aug, 2019 40 commits
-
-
chromium-autoroll authored
Roll ChromeOS orderfile from 78-3865.18-1566209693-benchmark-78.0.3888.0-r1 to 78-3877.0-1566814872-benchmark-78.0.3893.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I0edb8963b3737db6db270b5f17bb27aa19601b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778644Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692145}
-
Sammie Quon authored
DCHECK in OverviewGrid::AddDropTargetForDraggingFromOverview can be hit if long-press two items at the same time with different fingers. One test was flaky on mash. Test: none Bug: 941048 Change-Id: I6a1f1884ecec53714d915cf4a671c621c18d7793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776592 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#692144}
-
Peter Kasting authored
Bug: 552274 Change-Id: Ieaef52c738965861b31fde06ee9b2d5c9a95f967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777120Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#692143}
-
Ahmed Fakhry authored
When a mini_view is removed, it outlives its desk, but ChromeVox may try to get the accessible node data at this point when `desk_` is nullptr. BUG=999595 TEST=Manual Change-Id: I62ebc62f4dee67e03da6fb5d588520451f9e85ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779184Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#692142}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2aa85df8e782..8d7245686774 git log 2aa85df8e782..8d7245686774 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 reed@google.com add bot to test savelayer legacy flag 2019-08-30 csmartdalton@google.com Don't assert mips actually need resolve during texResolveRenderTask Created with: gclient setdep -r src/third_party/skia@8d7245686774 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: If237cd83bc731bdf25904ae6a82b4c4dab6f9352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779089Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/69ffc317eb39..f0033328dd22 git log 69ffc317eb39..f0033328dd22 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 capn@google.com Fix version script renames 2019-08-30 capn@google.com Canonicalize Vulkan ICD library names 2019-08-30 jmadill@chromium.org Support Windows builds and ANGLE integration. Created with: gclient setdep -r src/third_party/swiftshader@f0033328dd22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139189696,chromium:b/139189696,chromium:b/140251624 Change-Id: I8c76611307a102df7d853c26fbc2b0ec0d6aa86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779081Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14ad3f97..8a1c4425 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If5c5e21b2b1464328fb49fffaa7daeb8581a2a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779041Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692139}
-
Natalie Chouinard authored
Because this settings screen has preference changes that occur quickly (but asynchronously) as the fragment loaded, the animations appeared janky. Tracking bug to find a better solution to this class of issues: https://crbug.com/986401 Bug: 995668 Change-Id: Ic2cc2acffc94d67d0b9dffeea5a0e0d6deaff925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776595 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#692138}
-
Takashi Toyoshima authored
This patch just fixes a syntax error in the document for developers. Change-Id: Id128a69bde993c93d8550c6d0d45e14c7ebc0481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776150 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#692137}
-
yilkal authored
This CL records the number of frames present in web contents. The records will help us better predict the cost of improving SupervisedUserNavigationThrottle to filter at the iframe level. They will help us predict the following two information: 1. By how much will the requests for the kids management servers to classify urls will increase as a result of iframe filtering. 2. By how much will we delay the overall page load time? Bug: 850328 Change-Id: I38ff0786c9b9c162367ea0513b54f47c80a8b758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752339 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#692136}
-
Jeevan Shikaram authored
This CL adds an optional icon to the settings subpage title. Bug: 979531 Change-Id: Id60b78850e038f2f0576dc1e6871588d8d947759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776151 Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#692135}
-
Maksim Ivanov authored
Update the Ash UI for the challenge-response authentication (a.k.a. smart card login) according to the newest UI mocks (see https://crbug.com/993788 ) : * The smart card icon and the "Sign in with smart card" label are NOT clickable anymore; * A separate "->" arrow button is added. Tapping it starts the authentication. Implementation-wise, additionally the existing user password input field was wrapped into another wrapper, to allow hiding it WITHOUT continuing to consume the screen space. This was done, as the UI mocks require the challenge-response "->" button to be drawn exactly in the place where the password input field is normally shown. Bug: 983103 Test: enroll a Chromebook, configure device policies to force-install smart card middleware onto Login Screen, log in using a SAML account that uses smart card authentication, lock the Chromebook, check that an arrow button, a smart card icon and "Sign in with smart card" appears, click the arrow button, check that the PIN keyboard appears, enter the smart card PIN, check that the user session gets unlocked Change-Id: Ie210d47409e9f8a1fdd44a70ebb2efd37ca1311b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776540 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#692134}
-
Aran Gilman authored
Bug: 982354 Change-Id: Ia10914a769bda850027bd8c5206f477aac2141ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775099Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#692133}
-
Jeremy Roman authored
Bug: 999597 Change-Id: I09d60471bcd5e95f0fed839f7f61e02225ff768e Tbr: csharrison@chromium.org,mmenke@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778575Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#692132}
-
Bryan Clark authored
Swap out the video decoder library needed by libcast_media_1.0_avsync when building for cast desktop. Currently it is a lightweight wrapper around null_video, plus the CastMediaShlib methods that are not implemented by the default avsync lib. Bug: b/139810309 Test: Local Change-Id: I3ee0971efd15ee023a1548005cc68f697033c42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777062Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Bryan Clark <bryanclark@google.com> Cr-Commit-Position: refs/heads/master@{#692131}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ba5eedd3. With Chromium commits locally applied on WPT: 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" c906513f "[WPT/common/security-features] Rename source context names" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If863b0f38b364c4aaf91ab3a5c091ed08ad2052f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778662Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692130}
-
Mia Glaese authored
Design here: https://drive.google.com/open?id=1qYxeX6dmNYP-wIV4Sw0btz8hD3PHMcMO Bug: 990600 Change-Id: I54ebd8a186c4f9b729c4425363771b9261209c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744334Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#692129}
-
Andrew Grieve authored
To support parameterized tests, our test runner does not use the default test listing logic, and instead requests that tests be run, and relies on BaseJUnit4ClassRunner to no-op them all when in this mode. This scheme works only if tests actually use BaseJUnit4ClassRunner (or a subclass). The consequence of not using this runner is that the tests will run during test listing. This changes our test runner to enforce that all tests use BaseJUnit4ClassRunner so that we never have tests mistakenly being run during test listing. Bug: 999007 Change-Id: I226fe55b5716c713d47a6027c088ca6774ae0c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777089Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#692128}
-
Michael Spang authored
Since 7c48a707 ("Compression of IDR_SECURITY_INTERSTITIAL_HTML and modified compression function.") cast devices fail to boot in a crash loop since CastContentClient::GetDataResourceBytes was removed incorrectly. Add it back. Bug: b/139161866 Test: boot Change-Id: Iaaa5ac6a66823fbe0bc7df0132d56d66f0983712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776725Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#692127}
-
Sophie Chang authored
Previously, the ECT was passed back to PreviewsDecider but to allow for slow page prediction to happen in one call and for LPR to leverage that slow page prediction, we need to allow for PreviewsOptimizationGuide to make that justification. Basically, the OptGuide will handle its own slow page prediction checks (initially ECT but to evolve). I will clean up the actual eligibility reasons later and consolidate HOST_*LISTED_BY_SERVER to NOT_ALLOWED_BY_OPTIMIZATION_HINTS Bug: 969558 Change-Id: I532461410f3c92473cce5d3b15fce93fbdab99fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774978 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#692126}
-
Dominik Röttsches authored
Temporarily disable Chinese characters in test1.html printing test until 15s+ subsetting delay when subsetting Microsoft Jhenghei and Microsoft Jhenghei UI is addressed. Preparation for relanding always-on API based fallback. Bug: 996185, 976737 Change-Id: I8f669c118a651a7584615bdcbb60d2686a7a8baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778484 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#692125}
-
Patrick Monette authored
This CL gets rid of the "closed" state of SharedWorkerHost. This is done by deleting the host instance when it needs to be terminated. Adds a TestSharedWorkerServiceImpl that allows tests to keep track of running remote shared workers. Change-Id: I4abe3a72f2c208014e0d406f12210da74a3f1971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758981 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#692124}
-
Jun Cai authored
This CL replaces the current infobars if there are existing ones by removing them. Bug: 999222 Change-Id: Id3d84ca24a935c6c3420dfeb8194d0610278a631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775213 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#692123}
-
Andrew Grieve authored
On my machine, this sped up the test listing step by 50% according to the timestamps from bin/run_chrome_public_test_apk_incremental -v. While this is a heuristic, I tested that it finds all tests for chrome_public_test_apk, and if it does ever miss some tests, it won't affect bots, so the error will happen only locally. Change-Id: If227a3b08963d8899839bd6d661f0f392ff1cd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777092Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#692122}
-
Balazs Engedy authored
Bug: 986737 Change-Id: I7c7f7dea72428a6ad7d0252f96d2406321069548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778603 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Auto-Submit: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#692121}
-
arthursonzogni authored
This test started failing with the BackForwardCache after: https://chromium-review.googlesource.com/c/chromium/src/+/1761051 It goes back to a page with no-cache, no-store, must-revalidate. This page is cached, while it shouldn't... TBR=altimin@chromium.org Bug: 990354 Change-Id: I355be9f434c125890817b5c1a1b402c1a6f9b2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778487Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#692120}
-
Wez authored
TBR=morlovich Bug: 999584 Change-Id: I4c6bb65b22183236164ebe3162e2f97bff6946c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778820Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#692119}
-
gogerald authored
Layout resource is used to set filling the viewport. Screenshots: https://drive.google.com/file/d/1Cp37OzJNp_b6qf7PLJ9wlwzVkAeqFlbg/view?usp=sharing https://drive.google.com/file/d/1TzXKP9YHv3tgx-_m5rJKVyc791mHt8aa/view?usp=sharing Bug: 982018 Change-Id: Icb0e1366a1e95fad6f7ce1c48c9e23d035dc8f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776858 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Peng Huang authored
Bug: None Change-Id: I3e00d6baaefc83a58a8d54f0364819c0107c56d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778805 Commit-Queue: enne <enne@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#692117}
-
Himanshu Jaju authored
Different error scenarios should show different error messages. The titles are made generic to make minimal changes for future features. Bug: 996661 Change-Id: Ieb75b8f96d9f6a95f54e0b77769034eba7ec179b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776259Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#692116}
-
Xiaohui Chen authored
Bug: 969056 Test: locally on device Change-Id: I6ad07ec69c451a39c69d63fda97bdd6c02084322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777063Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
-
Caroline Rising authored
This reverts commit 6379817e. Reason for revert: Heap use after free that caused original revert has been fixed (see crbug/998642). Original change's description: > Revert "Turn tab hover cards on by default on TOT." > > This reverts commit 6381a942. > > Reason for revert: Causing heap use after free on ASAN bots. > https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=TabStripTest.TabCloseButtonVisibilityWhenNotStacked > https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/55741 > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8905195500078197360/+/steps/unit_tests/0/logs/Deterministic_failure:_TabStripTest.TabCloseButtonVisibilityWhenNotStacked__x2f_0__status_CRASH_/0 > > Original change's description: > > Turn tab hover cards on by default on TOT. > > > > Stable approval has been given for 76 in crbug/962604. > > > > Bug: 910739 > > Change-Id: If66c3c8954794126ff194c3d681c3cc71ec20759 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747977 > > Commit-Queue: Caroline Rising <corising@chromium.org> > > Reviewed-by: Peter Boström <pbos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#686596} > > TBR=pbos@chromium.org,corising@chromium.org > > Change-Id: I361c919fb44bbe44aa7e028845693b44429f51d6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 910739 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753844 > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686743} TBR=alancutter@chromium.org,pbos@chromium.org,corising@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 910739 Change-Id: I7888f967ddfd2d7a3e3aa15256e3b4ba808967cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778983Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#692114}
-
Maggie Chen authored
After the GPU watchdog starts in the GPU initialization, the watchdog thread is stopped before sandbox initialization and then restarted after the sandbox. This CL fixes the bug that causes the watchdog restart failure. Because of this bug, the GPU watchdog did not run on Linux. This CL will enable the GPU watchdog on Linux again. Bug: 992572 Change-Id: I9dc1da1ef23bda772f2d47d9f4a733b624dce517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772516Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#692113}
-
Ayu Ishii authored
Intent to Experiment[Draft][Google Only]: https://docs.google.com/document/d/1wlvSc31ddpHoRChAbiuAz1o7gM1bF_3W1IaIjSf1Nb4/edit?usp=sharing Bug: 955750 Change-Id: Ied1b84ccec1c8ba3f720f99a3f8aca173aa94af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681114Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#692112}
-
Matthias Körber authored
With this feature, votes for the |CREDIT_CARD_VERIFICATION_CODE|-type are generated for fields which either have the CVC value, which was used to unlock the server-cards, or are heuristically detected to be most likely the CVC field of a credit-card form. Bug: Change-Id: If3b54afb801dec4aec5856a5f97a68cee56870fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762215 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#692111}
-
Andrew Grieve authored
Bug: 999007 Change-Id: I762a61350619d0f0796769b94a69013efe1c8419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777111 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#692110}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e69fbd1b2db5..f5980f492582 git log e69fbd1b2db5..f5980f492582 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 dberris@chromium.org Pinpoint: Make unicode parsing more permissive Created with: gclient setdep -r src/third_party/catapult@f5980f492582 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:998941 Change-Id: I5098a09d0ca72c893b9f79fb585bb0232751ecd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778813Reviewed-by:
-
Javier Fernandez authored
This new NG layout engine implements a different approach for margin calculation, giving the containing block the responsibility of its children's margin computation. However, in legacy layout this is children's responsibility; this is the reason why the issue this patch tries to fix is only only reproducible using layout-ng. The grid code assumed this legacy behavior when computing the 'auto' margins of the grid items. So, in order to fix the bug, this patch just ignores any previously computed 'auto' margin when performing a a relayout of a grid cntainer. Bug: 994300 Change-Id: I44658876f7c2f2067202e45c6a552593bddfe6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763749 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#692108}
-
Philip Rogers authored
This reverts commit 7f6a912d. Reason for revert: We are relanding this to prove whether this patch was or was not the cause of the style and layout performance regression. Original change's description: > Revert "Only update AnimationClock when rendering lifecycle updates." > > This is a speculative revert in order to either confirm or eliminate it > as a source for a hard to track down persistent performance regression. > > This reverts r679216 (commit 629180ff). > > Tbr: bokan@chromium.org > Bug: 993476, 785940 > Change-Id: I3585b8bc048509343af495cdb2247131e1b05527 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763754 > Commit-Queue: Emil A Eklund <eae@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689490} TBR=flackr@chromium.org,pdr@chromium.org,eae@chromium.org,haraken@chromium.org,majidvp@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993476, 785940 Change-Id: Ia98857042e4b4dff78715199a74ddc8a24f082f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778802Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692107}
-
Pavel Yatsuk authored
This is a reland of e7e516c5 Original change's description: > Pass Feed library's proguard config through its build target's proguard_config parameter > > R=skym@chromium.org > CC=agrieve@chromium.org > > Change-Id: I565a3cd2e8af0c90e5727ac9c61eec631d6ec264 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773890 > Reviewed-by: Sky Malice <skym@chromium.org> > Commit-Queue: Pavel Yatsuk <pavely@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691299} Change-Id: Ica7bd6e1d0e5065ece26106b7fa49469e2a5f804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775369Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#692106}
-
