- 10 Jul, 2018 40 commits
-
-
Shu Chen authored
The init of Preferences instance should affect the singleton InputMethodManager state only when the preferences belongs to the active user. Bug: 841112 Change-Id: I7ed3cb2cbd8c0a27cab869f336c93c1a5becefa6 Reviewed-on: https://chromium-review.googlesource.com/1125646 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#573595}
-
Patrick Monette authored
Enables chrome_elf to find the blacklist without figuring out the path to the User Data directory by itself. This is a follow up of https://chromium-review.googlesource.com/c/chromium/src/+/1117498. Bug: 846953 Change-Id: Ib868925da8b845d38ec120d585a5cf33e1e107f1 Reviewed-on: https://chromium-review.googlesource.com/1120639 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573594}
-
James Cook authored
Convert the BinderRegistryWithArg<BindSourceInfo>* to BinderRegistry*. The BindSourceInfo is never used. It was added in a mechanical refactor https://chromium-review.googlesource.com/c/chromium/src/+/575596 This allows the WindowService to maintain a single mojo interface registry, rather than both registry_ and registry_with_source_info_. Tested manually: linux-chromeos linux-chromeos --enable-features=OopAsh linux-chromeos --enable-features=Mash on-device on-device --enable-features=OopAsh Bug: 850168 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic4a041a857165c14990f2548a16e386e08d2e849 Reviewed-on: https://chromium-review.googlesource.com/1129960Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#573593}
-
Gyuyoung Kim authored
Because OnMemoryPressure will be deprecated eventually, we need to support MemoryCoordinatorClient for LayerTreeHostImpl as well. Bug: 839687 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2f2b032ab165d5c1c8fc0a9dacea097533122739 Reviewed-on: https://chromium-review.googlesource.com/1122058Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#573592}
-
Jorge Gil authored
This allows Chrome to send a classification request with a text selection that will respond with quick app actions. Bug: b/32781610 Change-Id: I56858de8d64a49392d4847f12097d0a1fc1f1b86 Reviewed-on: https://chromium-review.googlesource.com/1087724Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Jorge Gil <jorgegil@google.com> Cr-Commit-Position: refs/heads/master@{#573591}
-
Khushal authored
Currently during serialization we playback all ops through the analysis canvas. Restrict that to only what is necessary, i.e., the ops which affect the transform/clip state on the canvas and DrawTextBlobOps. R=enne@chromium.org Bug: 757605 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia351f951cfae3e7b8be1aa056057269d7ca578c0 Reviewed-on: https://chromium-review.googlesource.com/1121782Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#573590}
-
Fabio Tirelo authored
Bug: 861940 Change-Id: Id4278a864afd0872cab48c63b0493008e150676c Reviewed-on: https://chromium-review.googlesource.com/1130225Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#573589}
-
xlou authored
Since the UI displays Pages Per Sheet for the N-up setting, and there was a review comment previously to rename it to pages_per_sheet, so I am renaming the variable name here. In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. Bug: 775999 Change-Id: I538c22a450a603f6b0896a2c5c4273052ba9e969 Reviewed-on: https://chromium-review.googlesource.com/1128325Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Shirleen Lou <xlou@chromium.org> Cr-Commit-Position: refs/heads/master@{#573588}
-
Jason Guo authored
move forward with this feature. Bug: 860819 Change-Id: I02ab5e9dff13703dcdef4f319555c04ec2b9322b Reviewed-on: https://chromium-review.googlesource.com/1130509Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
-
Jared Saul authored
This change moves from using grey watermark text in the textfield to having an explicit label above the textfield along with a hoverable tooltip. Tooltip text is subject to change pending final UX strings. Example screenshots: https://screenshot.googleplex.com/gY5QKjd58Ow.png https://screenshot.googleplex.com/rQT522vErCX.png Bug: 848955 Change-Id: Id9503a9c5955ecec297061e0c5117db1bbe7c0e1 Reviewed-on: https://chromium-review.googlesource.com/1130111Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#573586}
-
Kenneth Russell authored
These tests have been failing for a few days on this bot for a known reason. Until it's addressed, get the bot green again. Tbr: geofflang@chromium.org Tbr: jmadill@chromium.org Bug: 860800 Change-Id: Id9707e6942cf1fca0745a2755b6eab5503bf3c2f Reviewed-on: https://chromium-review.googlesource.com/1130597Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573585}
-
Gyuyoung Kim authored
As StagingbufferPool and ResourcePool, GpuImageDecodeCache has been only supporting the MemoryCoordinator. However, it is not enabled by default. So it would be good if we support the memory pressure handler until the MemoryCoordinator is enabled by default. Especially, it will help low-end devices to reduce memory usage under the out-of-memory situation. Bug: 856527 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I564051a4fa65b34fa9c14c72e626000e603eb865 Reviewed-on: https://chromium-review.googlesource.com/1121952Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cae2929d..ca41e2de Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie73ba147dafab46b5d49977b0a99001ca2ee87e9 Reviewed-on: https://chromium-review.googlesource.com/1130538Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573583}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I0f3184f92d72c9ac0d064f714e510962d9fee26d Reviewed-on: https://chromium-review.googlesource.com/1130535Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#573582}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: If0342cd7fe8f4059aff7bdabfb5b756a8b895dee Reviewed-on: https://chromium-review.googlesource.com/1111563 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:proberge <proberge@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#573581}
-
Lei Zhang authored
When OS_ANDROID is set, OS_LINUX is not set. Change-Id: I6dd69bd621a99d63ca73dcfae15b365a87ff94ee Reviewed-on: https://chromium-review.googlesource.com/1130554Reviewed-by:
-
Andrey Kosyakov authored
This removes URLFetcher, GenericURLRequestJob & co, along with the support for deterministic fetch. We can't support direct access to net:: classes with the network service. The suggested way to override network behavior in headless clients and embedders is through usage of DevTools network request interception. Change-Id: I418f38e3f20c54afc7c5c60dfb20795ce7d27512 Reviewed-on: https://chromium-review.googlesource.com/1128510 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573579}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/21acb2a82232..0c92958e3ed0 git log 21acb2a82232..0c92958e3ed0 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 mheikal@google.com Refactor systrace/systrace/util.py to use device_utils 2018-07-09 dtu@chromium.org [pinpoint] Use Windows path separator for Windows test results. Created with: gclient setdep -r src/third_party/catapult@0c92958e3ed0 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I281129bcd0b2489cecfe205b4ca8f7dae0fcd995 Reviewed-on: https://chromium-review.googlesource.com/1130181Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573578}
-
Kenneth Russell authored
GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash occasionally crashes the renderer process while navigating to about:gpucrash. The test's main tab appears to crash too. Required passing an --is-asan argument to the test, similarly to the WebGL conformance tests. Bug: 861956 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic18876e88a0d99c9152be1a67599f2cae3cd4881 Tbr: jmadill@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1130507 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
tzik authored
This CL replaces base::Timer with its subclasses. As base::Timer changes its behavior subject to its construction time flags, that makes hard to see the actual timer behavior, especially it's unclear when a timer is injected from other components. Also, that OnceCallback support of base::Timer is hard to implement on the dynamically determined invocation pattern. Bug: 850247 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic479d078f2c373e02c960e8051430a427f28143f Reviewed-on: https://chromium-review.googlesource.com/1128690Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#573576}
-
Yutaka Hirano authored
This reverts commit 1aba972d. Reason for revert: The investigation has been done. Original change's description: > Introduce ThreadableLoader::ModuleId for crash investigation > > This CL adds DocumentThreadableLoader::module_id_ to see which module is > to blame for the CHECK failure. > > I'll revert this change once the cause is found. > > Bug: 837511 > Change-Id: I76a724d1d8277d5e70afed85bb5576df99d997ca > Reviewed-on: https://chromium-review.googlesource.com/1125546 > Reviewed-by: Adam Rice <ricea@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572481} TBR=ricea@chromium.org,yhirano@chromium.org,haraken@chromium.org Bug: 837511 Change-Id: If8ffdbae0524946f1229a05eee47e8bc6ed58ccd Reviewed-on: https://chromium-review.googlesource.com/1130575 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#573575}
-
Ned Nguyen authored
TBR=eyaich@chromium.org NOTRY=true # Check with PRESUBMIT Bug: 713357 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I6de11174019c3025913ab9fd1f1dbc7f9e2a5a27 Reviewed-on: https://chromium-review.googlesource.com/1130698 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#573574}
-
tzik authored
This CL replaces base::Timer with its subclasses. As base::Timer changes its behavior subject to its construction time flags, that makes hard to see the actual timer behavior, especially it's unclear when a timer is injected from other components. Also, that OnceCallback support of base::Timer is hard to implement on the dynamically determined invocation pattern. Bug: 850247 Change-Id: I6800f4ebed2dd3f4d33aa4256ceacb4677b78d0b Reviewed-on: https://chromium-review.googlesource.com/1128669Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#573573}
-
Andrii Shyshkalov authored
These consoles are as relevant to chrome as V8 ones. Just like V8, infra has its own project where these are consoles are shown. Console definition here is already out of date, suggesting maintaining them in two places is difficult. R=hinoka No-Try: True Change-Id: Ia6cb9a6dc664508ebf7606ebb565496a9a1bfd62 Reviewed-on: https://chromium-review.googlesource.com/1130824Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#573572}
-
Ryan Hansberry authored
This reverts commit 0f9ea81e. Reason for revert: this change has broken the Easy Unlock feature. When Easy Unlock is enabled, its icon is intended to appear in the password field of a user pod on the login or lock screen. This change has prevented that icon from displaying. More details at crbug.com/861918. Original change's description: > Use arrow keys to navigate through users on Views-based login screen. > > Bug: 845037 > Change-Id: I60574af1513793a0872c4d02c20c829f0adda9df > Reviewed-on: https://chromium-review.googlesource.com/1117769 > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572389} TBR=derat@chromium.org,msw@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org Bug: 845037 Change-Id: I9047f3b8d955bddc7f2d006e5da90dd30cfe98bc Reviewed-on: https://chromium-review.googlesource.com/1130755 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#573571}
-
Michael Thiessen authored
This CL switches the Android MessagePumpForUI from queuing tasks on the Android MessageQueue, to signalling File Descriptors added to the ALooper's epoll implementation. Ordering between events queued in Java and C++ is not guaranteed, but this was already not the case on Android; this CL simply takes better advantage of that. Ordering for events queued in Java and C++ are still correctly ordered with respect to other events queued in Java and C++, respectively. This CL also changes the Android test support MessagePumpForUIStub to use the real implementation when non-nested, which means that the message pump code is now *actually tested*. Performance Improvements (measured locally using Tracing): Device: gobo (low-end Android GO device) OS: Android O (8.1.0) During startup on the main thread: On Master, ScheduleWork is called ~207 times, averaging .047ms per call. With this patch, ScheduleWork is called ~63 times, averaging .02ms per call. That's ~11ms less time spent in ScheduleWork during startup. ScheduleDelayedWork is similarly faster per call, and saves ~1ms during startup. Startup profiling doesn't show any meaningful difference in startup time overall, probably because the sample sizes were too small given how noisy startup is. Data here: https://docs.google.com/spreadsheets/d/1SQJ7zYeq0Eo4lQziYCALA-noP4pHlyeAd4--4fK6mbk/edit Bug: 780100 Change-Id: Icca7443d62154e4b516a70f8afffb1882000b555 Reviewed-on: https://chromium-review.googlesource.com/751322 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#573570}
-
Esmael El-Moslimany authored
Bug: 860695 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7753608ce7b4f9eb3cd72bf6868b7400783de98c Reviewed-on: https://chromium-review.googlesource.com/1128216 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#573569}
-
Becca Hughes authored
When a webapp is has the fullscreen display mode set the fullscreen API is disabled and the activity is in an "immersive" mode. We should tell WebContents when this happens so we can support display cutouts in this mode. BUG=859241 Change-Id: I4ce0a647180aa72f2eb5361ad8335956ecb383a2 Reviewed-on: https://chromium-review.googlesource.com/1121537 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#573568}
-
Peter Boström authored
Fixes regression after a resize area was not accounted for when calculating drag/drop positions and the visible marker. This is a symptom of view placement being calculated separately from drag-drop-marker placement. This should be easier to unify when after MacViews when BrowserActionsContainer and ToolbarActionsBar can merge. Bug: chromium:859821 Change-Id: Ia6295fa4883aab8bbabaa778bdbd2dd379df9d2e Reviewed-on: https://chromium-review.googlesource.com/1130539Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#573567}
-
Andrey Kosyakov authored
Use URLLoaderInterceptor instead to provide content for other tests. Disabled a few tests that were testing implementation of GenericURLRequestJob & co, as the net/-specific code in headless is going away. Change-Id: I538528292f009d1b1a1148f8ded2c9a284a320e9 Reviewed-on: https://chromium-review.googlesource.com/1128509 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Maks Orlovich authored
Turns out these are just too hard to avoid when TestMockTimeTaskRunner is used in a browser test. Bug: 860092 Change-Id: I11e3dcfacf073549c56a40eb6840de1df4a52896 Reviewed-on: https://chromium-review.googlesource.com/1127930 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c3833b4c152a..8fe31406e980 git log c3833b4c152a..8fe31406e980 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 ethannicholas@google.com switched from NUM_SHADER_BINARY_FORMATS to NUM_PROGRAM_BINARY_FORMATS 2018-07-09 robertphillips@google.com Fix fuzzer bug in SkGradientShader::MakeSweep 2018-07-09 ruiqimao@google.com added caching of SkVertices Created with: gclient setdep -r src/third_party/skia@8fe31406e980 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/110175245 TBR=robertphillips@chromium.org Change-Id: I8067fa9e744a4eb42d4e72db9055f39acfa5364c Reviewed-on: https://chromium-review.googlesource.com/1130185Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573564}
-
Kenichi Ishibashi authored
Add notes to describe this is semi-deprecated. Bug: 852666 Change-Id: If19554c580ba082187364211451a106d275e9d96 Reviewed-on: https://chromium-review.googlesource.com/1128659 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573563}
-
Hwanseung Lee authored
replace std::find() with base::containsValue() at components/bookmarks and components/exo and components/infobars Bug: 561800 Change-Id: I9b2cb633e6872e37663a249fba77548a074d9e02 Reviewed-on: https://chromium-review.googlesource.com/1124719Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
-
rbpotter authored
Allow elements that use cr-dialog to override the appearance of the close button when it is focused. Bug: 859857 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id13b83ad9653149e0a81b2b23fe6af62ee349669 Reviewed-on: https://chromium-review.googlesource.com/1125289Reviewed-by:
-
Greg Kraynov authored
Bug: 841735 Change-Id: I0adf1eec46833b8f69cd186ef4eccef42c879cb0 Reviewed-on: https://chromium-review.googlesource.com/1093095 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Add the following UMA metrics: - Search.HistoryReport.DeltaFile.LastSeqNo - Search.HistoryReport.DeltaFile.LevelDBEntries - Search.HistoryReport.UsageReportsBuffer.LevelDBEntries These are health checking signals to see if Icing-related levelDBs could grow too big. Bug: 857345 Change-Id: Icfc67b3442864a1c31b15427de40b406ea674ff7 Reviewed-on: https://chromium-review.googlesource.com/1117937Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This CL introduces SharedBuffer::Iterator for reading data from a SharedBuffer. Now we can read all the data from a SharedBuffer |buffer| by for (const auto& span: *buffer) ProcessData(span.data(), span.size()); Also, we can read a data range starting from a specific point |pos| by for (auto it = buffer->GetIteratorAt(pos); it != buffer->cend(); ++it) ProcessData(it->data(), it->size()); This CL also removes existing GetSomeData and ForEachSegment from SharedBuffer. Bug: None Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9a5891204d3323cb87ee7b6ee0f8ec2011d88e4b Reviewed-on: https://chromium-review.googlesource.com/1127760 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#573558}
-
Chris Palmer authored
...to the extent possible. This involves lowering 64-bit Linux' limit from 8 GiB to 4, to match Windows. Note that in the process of writing a previous version of this CL, we learned that macOS apparently does not enforce RLIMIT_DATA, so we continue to not have a limit on that platform. (The same goes for RLIMIT_AS, which we previously knew about.) Bug: 853873,459158 Change-Id: I5a2a76b4c98a0862c16ce121572c4b2b0f910b44 Reviewed-on: https://chromium-review.googlesource.com/1130235Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#573557}
-
Robert Liao authored
This corresponds with the consistency change from session to permanent. BUG=859048 Change-Id: Ib6f9c977c24d75c74a5b64703610c9020f835bd3 Reviewed-on: https://chromium-review.googlesource.com/1125215 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
-
