- 19 Jan, 2021 40 commits
-
-
Caitlin Fischer authored
The server-side config shows that this study has ended. Bug: 1126640 Change-Id: If7139fb3de3a5978dcf86c0f74badae7b990d26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631434Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844909}
-
Xida Chen authored
TBR=eirage@chromium.org NOTRY=true Bug: 1122546 Change-Id: Ic158622c15bf3eff41d63aa735e5be5cd4a3b8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636945Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#844908}
-
Rune Lillesveen authored
Moved two rules styling the media element, and not its controls, into html.css. Also add a html default @namespace to the media controls sheet to avoid any unintended effects outside of html. Bug: 1166678 Change-Id: Ib1ac69f12f52700fc408d81a4655f55c18b4da89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629927Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#844907}
-
Mason Freed authored
This feature shipped in M86, with no issues reported. https://chromestatus.com/feature/6143552666992640 Bug: 1067384 Change-Id: Ic27c756b6df3e2470b4d55194c18609df5683f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633965 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#844906}
-
Victor Costan authored
* Add sequence checks. * Replace base::PostTask*() calls with calling PostTask*() methods directly on TaskRunners. * Use PostTaskAndReplyWithResult() instead of equivalent implementation based on PostTaskAndReply(). Change-Id: I291e6d9dea744bd1eb7c020f86cacf0f1ab40ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633728 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#844905}
-
Alex Ilin authored
This reverts commit b62892aa. Reason for revert: Removed the directory existence check that was failing. Directories are removed on a background thread and there is no reliable way of waiting until the remove is complete. Original change's description: > Revert "[profiles] Clean up guest ephemeral profile on startup" > > This reverts commit d660a480. > > Reason for revert: > Test fails: > https://ci.chromium.org/ui/p/chromium/builders/ci/Win%207%20Tests%20x64%20(1)/76721/overview > > Original change's description: > > [profiles] Clean up guest ephemeral profile on startup > > > > This CL fixes a bug which leads to the guest ephemeral profile not being > > cleaned up on startup if it has been left over in the previous session. > > > > ProfileManager::CleanUpEphemeralProfiles() needs to pass the `true` > > parameter in ProfileAttributesStorage::GetAllProfilesAttributes() to get > > the full list of registered profiles. > > > > Bug: 1167883 > > Change-Id: I3051a9174e8472eb2af046126be88dbfb44bcb47 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635158 > > Commit-Queue: Alex Ilin <alexilin@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#844749} > > TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I6fb55866ddcda42c54d60aaa2e823da18b353348 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1167883 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637395 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844779} TBR=droger@chromium.org,xidachen@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 1167883 Change-Id: I8f78c419804e91aaa6279660160a6310353415ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637479Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844904}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0489cc12af57..c3c15a1f6b71 2021-01-19 ehmaldonado@google.com owners_finder: Don't print comments for owners If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I68d73e4ef28e7067ab130a393001b8ae9a87a9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638363Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844903}
-
kylechar authored
Both tests have passed the last 100/100 runs on the Windows 10 with Intel 630 GPU bots the expectations applied to. Fixed: 1087993 Change-Id: Iead74a995acb6d4a3119f7acbb78eaf35b3325f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488541 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844902}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611057528-899a688a15a64f3c7bd554cd5ab3f72fe33a7d09.profdata to chrome-win64-master-1611068186-b36b631e8b34e83450d9bdf5237d6c35b34952b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8cae7630581c70ddc0171c7644550ea2e5872239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637721 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Dave Tapuska authored
More debugging to if the MainFrameImpl is null. This is the last possible pointer that could be null, add a CHECK for it. BUG=1160652 Change-Id: I03509d30c2c6d30681915ec2c178b2e6badec993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636841Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#844900}
-
Xianzhu Wang authored
- When calculating the maximum animation to screen scale, for a nested or unknown-scale transform animation, use the parent's maximum animation scale instead of kInvalidScale which would fallback to page_scale * device_scale which ignored ancestor scales. - When adjusting raster scale for transform animation, use max(raster_contents_scale_, maximum_animation_scale). In normal cases, if the former is bigger than the latter, it means that raster_contents_scale_ calculated when the animation starts is more accurate than the maximum_animation_scale calculated by the cc/animation subsystem. - In case that a bigger scale than 1.5x of the previous calculated animation scale, force an raster scale. The case should be rare. Bug: 1165408 Change-Id: Ieccdb9e16fb6f151e74a881855ce3655e857c372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633800Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844899}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I1d7d54d8999d526fc65ec54dcec4f8d15a5f03ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626419 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#844898}
-
Caitlin Fischer authored
There do not appear to be server-side configs for these studies. LoadingPredictorUseLocalPredictions is enabled on TOT, but LoadingPredictorTableConfig is disabled. Bug: 1126640 Change-Id: I8634b015af89fec4c0fdc42070784527e6a7126b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632047Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844897}
-
Ramin Halavati authored
Adds "Profile.Guest.ForcedByPolicy" metric which records if Guest profiles are initiated by user request or forced by policy. Bug: 1125474, 1167473 Change-Id: I8c87096bd60d260c1542a1c869361f3f5ed2cb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632586 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Ben Mason authored
R=rubber-stamper@appspot.gserviceaccount.com Change-Id: I97cf624f147abdf852c852f7c0b3de5985e103f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637263 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844895}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1683f26e. With Chromium commits locally applied on WPT: fafb4f34 "[EventTiming] Exclude target from toJSON" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm cbiesinger@chromium.org: external/wpt/css/css-flexbox domenic@chromium.org, ricea@chromium.org: external/wpt/streams foolip@chromium.org, lpz@chromium.org, smcgruer@chromium.org: external/wpt/tools mustaq@chromium.org: external/wpt/html/interaction/focus nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events rego@igalia.com: external/wpt/css/css-grid external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I9896ae1cecae7582b8ed3195266fe2d624a707a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637774Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844894}
-
Dave Tapuska authored
Create a SubresourceFilter interface in mojo. Adjust the tests so that we can capture the send of the message to the MockRenderProcess. BUG=993189,820612 Change-Id: I72f5d2ba3305955165fea2555271089812ada8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633353 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#844893}
-
Adam Norberg authored
This class uses the Builder pattern to write the config file loaded by ExternalConstantsOverrider. "Builder" is not common in C++, compared to Java, but here it seems like the easiest way to express our knowledge about what fields are supported in this file type; it will create reasonably terse integration test code and can be extended as new fields are added to the set of overridable constants. Bug: 1154901 Change-Id: Ia17280e5a6eaad8cd4e1d1f04f5fd0515ac2e3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631185 Commit-Queue: Adam Norberg <norberg@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#844892}
-
Xida Chen authored
TBR=eirage@chromium.org NOTRY=true Bug: 1168198 Change-Id: I3196ad66bace95157d110f840babd269d394df32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637963Reviewed-by:
-
chrome://webapksdpapad authored
Bug: 1167001 Change-Id: I324a52ebe9eda15bb8f55396a38ea037d827485f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637307 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#844890}
-
Hirokazu Honda authored
Chromecast fails to decode h264 streams encoded by the ChromeOS AMD HW encoder. This CL disables the hardware encoder for the mirroring use case as a temporarily workaround. Bug: b:169533953 Test: chromecast works on kasumi Change-Id: I6052a06ced2c432653abb46be34fcea61e13379e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627241 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844889}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: Ide75f8427f0495e73f3121f68088613917b0428f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627750Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844888}
-
Yaron Friedman authored
Not quite the same coverage but focuses on logic in TabAssociatedApp class. Other test in TabsOpenedFromExternalAppTest can serve as integration tests. Also ported over a related test. Bug: 147853 Change-Id: I51ddc8cc022bc9b44689be52b8daa68c66bcde51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637261 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#844887}
-
Scott Violet authored
SessionServiceTestHelper no longer owns SessionService. Having SessionServiceTestHelper own the SessionService is not at all expected and lead to awkward code. BUG=none TEST=none Change-Id: I652de08405d6e66b99ea114cf5c3919042a7e027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634221 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844886}
-
Dirk Pranke authored
This reverts commit b6172196. Reason for revert: We rolled GN to a new version with a fix for the win dev issues, so hopefully is good to go now. Original change's description: > Revert "Force Python 3 to be used in build." > > This reverts commit bb97ab9b. > > Reason for revert: Various breakages. > > Original change's description: > > Force Python 3 to be used in build. > > > > This CL makes Python 3 be the default script executable used by Ninja > > to run action() and action_foreach()'s during the build. > > > > This does *not* mean that everything works with Python3; many targets > > may still use Python 2 via the python2_action() and > > python2_action_foreach() targets or via custom logic. > > > > However, it does mean that it should prevent regressions from > > creeping in. > > > > This CL should not be taken to imply that we can start to write > > Python3-specific code that can run during the build; we should > > still be trying to ensure that everything is compatible with Python2. > > > > Also, this CL does not enable the use of vpython in actions; we should > > still avoid that because vpython is slower than direct Python > > invocations. > > > > Bug: 1112471 > > Change-Id: I472b032b500715156d955b0758640a7ed0384305 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787 > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#836234} > > TBR=dpranke@google.com,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I72039140f401f1fefc1b515dcfe34f1984b0d914 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1112471 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587576 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#836284} TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1112471 Change-Id: I55ee8ccb381b5aeeac58a85a6168765ed40457ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630725Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#844885}
-
Christopher Cameron authored
Bug: 1162496 Change-Id: Ie8d986ae88b4f909380b527855eb3c84b3a0a71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634016 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#844884}
-
Tommy Li authored
Two weeks ago we added a CHECK to verify in production our assumption that the default search provider was never Remove()-ed. This turned out to be violated in SearchEngineTabHelper. This CL fixes that violation. We don't need to call Remove() from that tab helper anyways, since a call to Add() will remove duplicates if possible, and will preserve the DSE. Bug: 1166372 Change-Id: Ia3d145ddc457d901fbb81c94487cee28b2792cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637957Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#844883}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611057528-6f03f3ff553c2040abb87e84fc5d258c023feaa2.profdata to chrome-mac-master-1611078768-634fb3ae1c67578f99ad9e12394867d392a20265.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I360531555dc70aaae63149e128697c47c045b528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638238Reviewed-by:
-
Joshua Berenhaus authored
Changing the client id backup logic so that it does not try to get the id from the registry if there was a cloned install. This avoids the race condition specified in crbug/1160366 Bug: 1160366 Change-Id: Iee04a5173ed7713392d15fec42ded18f2b65bc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612110 Commit-Queue: Joshua Berenhaus <joshber@microsoft.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#844881}
-
Nancy Wang authored
In ~AppWindowLauncherItemController, AppWindowBase::SetController could remove the window from windows_, so the for loop for windows_ might cause crash. Modify the for loop to use the reverse iterator to resolve the crash issue. BUG=1164188 Change-Id: Ifa561df71d3be1daf0c3505e8836d1cb60fa9143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633483Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844880}
-
Ryan Sturm authored
Bug: 1135715 Change-Id: I8363e7434c24bf6d6b52b150e9b7747fe3d421e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636215Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#844879}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611057528-c042fc837e99141efabc34633cbdaeed88679432.profdata to chrome-win32-master-1611068186-6acea0a5e8e4dcb5129946657add72ff4aa0a2a2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3e990922a2061af56be2cbb6cbc754131d7ce792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638235Reviewed-by:
-
Evan Stade authored
This reverts commit 4e7cf905. Reason for revert: no longer necessary after crrev.com/f6658bc4 Original change's description: > [omnibox] Fix Views clipboard access issues on Linux. > > Includes one behavioral change, no longer disabling the ability to paste > via keyboard shortcuts when the clipboard is empty. This change > simplifies the code, reducing the number of points of access to the > clipboard and removing the need for an auto-reset bool to control > whether the user is notified of restricted clipboard access. The removal > of the auto-reset bool is especially important as the scope-exiting > reset will always cause a memory access even if the view has been > deleted. > > Bug: 1161149 > Change-Id: I7a494c534e0efbf5d762a58fe6f7f39591cebb80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619204 > Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843159} TBR=estade@chromium.org,jdonnelly@chromium.org,manukh@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1161149 Change-Id: I9bca7d74069f69f84addf96f2c9019b80ad0dacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637259Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#844877}
-
Michael Checo authored
Screenshot: http://shortn/_EzVSDUHswl Spec: https://carbon.googleplex.com/cros-ux/pages/diagnostics/mvp#db1415fc-6806-4059-958e-459d8da17580 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I910d41a48c036b4a9067355faff4592c80b88aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530902Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#844876}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a8b2b4a5eb39..baf149636bd5 2021-01-19 morlovich@chromium.org UA-ch editting: let enter on (i) button actually work. 2021-01-19 morlovich@chromium.org UA-CH editing: fix focus indicator for (i) overlapping leading text 2021-01-19 andoli@chromium.org [module.json extensions] Adds getLazilyComputedLocalizedString to 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate snippets 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate node_debugger 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate protocol_monitor 2021-01-19 andoli@chromium.org [module.json extensions] lighthouse 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate performance_monitor 2021-01-19 tvanderlippe@chromium.org Fix localization of developer-resources If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1158760,chromium:1167652,chromium:1168075 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic45b6b30337c6db775c86f1030d576208159d15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637723Reviewed-by:
-
Rainhard Findling authored
This is a temporary workaround for crbug.com/1159942 Bug: 1152336 Change-Id: I58a55101e7344e756e694d8b8d213d33f8b1a88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627394 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#844874}
-
Peter Wen authored
D8 provides a list of dependent/dependency relationships for desugaring. When a file changes (whether within the target or on the classpath), the classes within the target that implement it will need to be re-desugared even though those classes did not change. Previously we would re-desugar all classes within the target. Now we can just re-desugar (i.e. re-dex) only the necessary ones. This provides a build speed boost primarily due to avoiding the need to run any desugaring (either bazel desugar or D8 desugar) when a change does not require it. A follow-up CL will deal with the DexSplitter issue for monochrome and trichrome bundle builds. The stats below are timed with android_fast_local_dev=true. Before: chrome_java_nosig: 34.5s avg (34.1s, 35.2s, 34.2s, 34.4s) chrome_java_sig: 36.2s avg (35.0s, 37.0s, 36.4s, 36.4s) chrome_java_res: 39.8s avg (39.8s, 39.9s, 39.6s, 40.0s) base_java_nosig: 46.0s avg (46.9s, 46.0s, 45.0s, 46.1s) base_java_sig: 107.2s avg (106.8s, 106.9s, 107.7s, 107.3s) After: chrome_java_nosig: 31.6s avg (32.5s, 31.1s, 31.7s, 31.2s) chrome_java_sig: 34.0s avg (34.2s, 34.0s, 33.8s, 34.1s) chrome_java_res: 39.8s avg (39.8s, 39.6s, 39.9s, 39.8s) base_java_nosig: 22.7s avg (22.5s, 23.1s, 22.3s, 22.8s) base_java_sig: 101.3s avg (102.0s, 101.2s, 100.9s, 101.2s) Bug: 1015559 Change-Id: Idf4e05bf41583b2ea7d4f1d3855b508be56eea94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633323 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#844873}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I4b02fe1d0f5625a1c1562339f08f792a63b622e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616741Reviewed-by:
Joon Ahn <joonbug@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#844872}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b69f54069cbf..e670fc72a5ae 2021-01-19 jmadill@chromium.org Implement shader compiler changes for Tessellation. 2021-01-19 cnorthrop@google.com Capture/Replay: Fixes for compressed texture cache 2021-01-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2bb77d70cc64 to dd50a3bce3ca (3 revisions) 2021-01-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 149733cead63 to 8da0f82baf35 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: Aztec Ruins MEC Change-Id: I89e85dd24b00447e7be03115212767b2b1695a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638078Reviewed-by:
-
Daniel Hosseinian authored
Currently, both the plugin and the UI track the state of two-up-view. Additionally, the state tracked by the plugin is consistently sent to the UI. While two-up-view can only be invoked on through the UI, the feature actually occurs asynchronously. It would be better to update the UI state with that of the plugin. Change-Id: Id0b40c2fa0d7d4eb029bbb06d8eb162871938385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631360 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
