GitLab

In practice, Extension objects are pretty much always const. Update
ExtensionBuilder::Build() to return a const Extension object, rather
than a mutable one.

TBR=tapted@chromium.org (c/b/apps, c/b/ui, c/b/web_applications)
TBR=stevenjb@chromium.org (c/b/chromeos, c/b/notifications)
TBR=dalecurtis@chromium.org (c/b/media)
TBR=holte@chromium.org (c/b/metrics)
TBR=vakh@chromium.org (c/b/safe_browsing)
TBR=treib@chromium.org (c/b/supervised_user)
TBR=raymes@chromium.org (c/c/pepper_permission_util_unittest.cc)

Bug: 889925
Change-Id: I7da674b29e209540803acfd40576c7daba3da2a3
Reviewed-on: https://chromium-review.googlesource.com/c/1256167
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596434}

WebAuthN BLE UI flow should guide the user through pairing UX if no FIDO
BLE devices have been paired with the system previously. If there is at
least one FIDO BLE device that is paired beforehand, we should default
to "activate BLE security key" flow. As so, implement logic to store
address of BLE security keys.

Bug: 877344
Change-Id: I5d376311fc2dc4b73ceab0ed43ef5b8fbd0ffdbc
Reviewed-on: https://chromium-review.googlesource.com/c/1253065
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596433}

This CL cleans up the remnants of the NUX Experiments bulid configs. Including:
- removing os_win and google_chrome_branded build flag.
- removing prefs that tracks if the one-off NUX experiments were seen.
- fixing closure compile errors now that it needs to build on non-official bots.

Bug: 874153
Change-Id: I03c1ed09c54f5ba91944bcb31837e80a0ee1fc74
Reviewed-on: https://chromium-review.googlesource.com/c/1252906
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596432}

Change-Id: Ie0cda615136c02d8e01a16d105cdcddf2dd0938f
Reviewed-on: https://chromium-review.googlesource.com/c/1258384
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596431}

https://pdfium.googlesource.com/pdfium.git/+log/2ff6cd661c02..61d8d025d568


git log 2ff6cd661c02..61d8d025d568 --date=short --no-merges --format='%ad %ae %s'
2018-10-03 tsepez@chromium.org Remove unused methods in CPDF_DocJSActions.
2018-10-03 tsepez@chromium.org Remove some impossible null checks from fx_crypt_sha.cpp
2018-10-03 tsepez@chromium.org Tidy CFX_UTF8Decoder.
2018-10-03 hnakashima@chromium.org Use numbers to test barcode encodings that do not accept letters.
2018-10-03 tsepez@chromium.org Remove blocklen argument from CRYPT_AESSetKey()


Created with:
  gclient setdep -r src/third_party/pdfium@61d8d025d568

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idde32d268bb3788dd4c1199b6835cbd1b2606432
Reviewed-on: https://chromium-review.googlesource.com/c/1259830Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596430}

Bug: 867488
Change-Id: Ic2615ce1b19eaf9fb283890d1a25df124b26fce2
Reviewed-on: https://chromium-review.googlesource.com/c/1252849
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596429}

When a portal is activated, the portal contents replace the tab contents.

Bug: 865565
Change-Id: Id666e94b0c98294dbc2eb1ce942101a2f158ebf3
Reviewed-on: https://chromium-review.googlesource.com/c/1188884
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596428}

Bug: 790265,824539
Change-Id: Ic34ea3ae7f2aa3221edb436ed443a7c943cc1d43
Reviewed-on: https://chromium-review.googlesource.com/c/1260202Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596427}

This CL updates BVC to always use the visible URL when calculating the
final frame of the NTP for animtions.

Bug: 880262
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie896009aff289b505ba3365afdc7ca9827058cd8
Reviewed-on: https://chromium-review.googlesource.com/c/1241557
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596426}

Bug: 850823
Change-Id: I60bfe8c045da13daa6fd85214381b1ff39b7afcc
Reviewed-on: https://chromium-review.googlesource.com/c/1258609
Commit-Queue: Jon Mann <jonmann@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596425}

Use uniform_int_distribution in a way that Windows allows.

Bug: 891867
Change-Id: I7a9cf5c213ddfc8ca83efa29757674eea54a1c44
Reviewed-on: https://chromium-review.googlesource.com/c/1260162
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596424}

This reverts to the older purging logic behind a feature flag (for non-unified consent). We can see if this changes the metrics as expected. If unclear, we can do an A/B test since this is also behind a Feature.

Added a simple boolean histogram to count how often we are purging on sync changes.

Bug: 891777
Change-Id: I74596d4a92eb19de301461d2b6d18a6dca8741c4
Reviewed-on: https://chromium-review.googlesource.com/c/1258573Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596423}

https://chromium.googlesource.com/external/leveldb.git/+log/7b945f200339..73d5834eceee

This CL also removes port_chromium's InitOnce implementation, because it
is no longer used by leveldb.

$ git log 7b945f200..73d5834ec --date=short --no-merges --format='%ad %ae %s'
2018-09-11 costan Rework threading in env_posix.cc.
2018-09-10 costan Remove InitOnce from the port API.
2018-09-05 costan Clean up PosixWritableFile in env_posix.cc.

Created with:
  roll-dep src/third_party/leveldatabase/src

Change-Id: Icba857ff32949a1b6f4cd385330a01c7ac02798d
Reviewed-on: https://chromium-review.googlesource.com/c/1220056Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596422}

It's always false.

Bug: 889651
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I50e3b03ff3b25bc8759b79463b72e3b63ebbd8a5
Reviewed-on: https://chromium-review.googlesource.com/c/1259944Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596421}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79c31bf9cbf4..fbfd101d0207


Created with:
  gclient setdep -r src-internal@fbfd101d0207

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ice60c44c336f98f1beccba0375d879c3c12a7a0e
Reviewed-on: https://chromium-review.googlesource.com/c/1260203Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596420}

https://skia.googlesource.com/skia.git/+log/9e0efe3189e0..4504a652c071


git log 9e0efe3189e0..4504a652c071 --date=short --no-merges --format='%ad %ae %s'
2018-10-03 michaelludwig@google.com Remove extraneous comma in printf vargs
2018-10-03 bsalomon@google.com Always turn off domain in GrTextureOp for no-aa/nearest
2018-10-03 mtklein@google.com looks like Animation can use SkNVRefCnt?
2018-10-03 scroggo@google.com Fix-up colorSpace-less decodes
2018-10-03 michaelludwig@google.com Make ProcessorOptimizationValidationTest more forgiving
2018-10-03 csmartdalton@google.com ccpr: Remove the Mac+Radeon GL blacklist
2018-10-03 brianosman@google.com Remove SkPM4f
2018-10-03 scroggo@google.com Remove SkCodec::fSrcInfo


Created with:
  gclient setdep -r src/third_party/skia@4504a652c071

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:887372
TBR=mtklein@chromium.org

Change-Id: I7642ee8e8b0a7e3be4da3863c8ec7fc3698d409c
Reviewed-on: https://chromium-review.googlesource.com/c/1259833Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596419}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I857b97d2fd8b87db3563dd6845399d977a07f68c
Reviewed-on: https://chromium-review.googlesource.com/c/1258682Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#596418}

Bug: 877702
Change-Id: Ifdd3355c2d9d0fb46fed19c21cbe2a066abf6ad4
Reviewed-on: https://chromium-review.googlesource.com/c/1239010
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596417}

Also switches Document over to use it and audit the current usage of the
downcasting macros. As a result, a number of locations now use
DynamicTo<T> instead of requiring a separate type check and cast.

Redundant DCHECKs have been removed: To<T> already implies a DCHECK() that
the operand is a T.

Bonus: ToTreeScope(Document*) has been removed: it's never needed as
TreeScope is a base class of Document.

Bug: 891908

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia9be66b435086b9c75facc4da0f9269c41e8927f
Reviewed-on: https://chromium-review.googlesource.com/c/1230233
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596416}

Also fixes the configuration of the endpoint.

Bug: 886972
Change-Id: Ia80e98ee0498af82c1b59832e7e7a68655c3a605
Reviewed-on: https://chromium-review.googlesource.com/c/1259805Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596415}

Add a separate AudioFocusManagerDebug API to isolate the
privileged GetDebugInfoForRequest method.

BUG=875004

Change-Id: I587a73a78edf7aba3fce3f8dc722d2914098013f
Reviewed-on: https://chromium-review.googlesource.com/c/1242036
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596414}

Previously, traverseFolderShortcuts expanded the directory tree by
faking a mouse click on the expand icon once it exists. However, it
didn't wait for it to be visible or ready to click, which are only the
case after updating the directory contents. Fix this by waiting for the
row to have the has-children attribute set to true. Run this test with
DriveFS enabled.

addRemoveFolderShortcuts seems to be as reliable with or without DriveFS
enabled so run it with DriveFS enabled too.

Bug: 891197
Change-Id: I40df199feda04461b65891112e3314e0eca8496d
Reviewed-on: https://chromium-review.googlesource.com/c/1258372Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596413}

Login shelf buttons should have a rounded background to indicate they
are touch / click targets. Spec is included in the bug.

Bug: 874290
Change-Id: Id3cacca32412a47b90206d637c39623977a66550
Reviewed-on: https://chromium-review.googlesource.com/c/1184161
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596412}

Bug: 870998
Change-Id: Ia945042619841fb197f374ca1b2a188916e9764c
Reviewed-on: https://chromium-review.googlesource.com/c/1259826
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596411}

It is now true by default, so there is no need to set it.

Bug: 891917
Change-Id: Id9b9490daee59ef6f864217ea595e96f0535598b
Reviewed-on: https://chromium-review.googlesource.com/c/1260016Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596410}

BUG=790343

Change-Id: I64d509837aaf84043e1e3e749bcda748e0c42da4
Reviewed-on: https://chromium-review.googlesource.com/c/1260012Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596409}

Bug: 887188

Change-Id: I6276bd2b97b4e39eb81fc52f6c8c934702f899c6
Reviewed-on: https://chromium-review.googlesource.com/c/1258052
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596408}

<activity-alias> needs to come after the <activity> it's pointing to.
Manifest merging was doing this for us but the server doesn't it.
Simples fix is to set correct order ourselves

Change-Id: I20d5184f27fe3b84a90afcdf40f6ba731b1c4a43
Reviewed-on: https://chromium-review.googlesource.com/c/1260204Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596407}

Leading white-spaces are indeed breaking opportunities that should
prevent, if there are no other css properties forcing it, breaking text
in the middle of a word when honoring the word-wrap/overflow-wrap CSS
property.

We are doing so if the leading white-space sequence is longer than 1
character, but when we have a single leading white-space, we are missing
that breaking opportunity and we may lead to cases, like the one
described in the bug.

The root cause of the issue with single leading white-space breaking
opportunities is that the RewindToMidWordBreak expects certain width to
be committed in order to choose opportunities in previous runs if none
of the ones detected by the ICU LazyLineBreakIterator prevents the
overflow.

However, this breaking opportunity should be considered together
with other provided by the word-break CSS property (eg, break-word or
break-all), as it was agreed in the discussion [1] with the CSS WG.

This CL solves the issue identifying the single leading white-space
braking opportunity in a new class field flag, and using it to consider
this opportunity inside the mid-word breaking logic, or prevent to run
it completely in the cases where 'break-all' is not set.

This is basically a reland of 6ea2a2e7
but with some changes to avoid regressions like the one reported in
issue #866109.

[1] https://github.com/w3c/csswg-drafts/issues/2907

Bug: 854624
Change-Id: I1cc0f55050d54ea1e76c655cf6b3ef8bcc0b0e2c
Reviewed-on: https://chromium-review.googlesource.com/c/1209745
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596406}

Bug: 814405
Change-Id: I2736621224048ddf1ee8de134fdb34ed742a7133
Reviewed-on: https://chromium-review.googlesource.com/c/1235274Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596405}

Adds a mojo AudioFocus API that can be used to access
AudioFocusManager inside the media session service.

This also removes the RequestId when requesting or
abandoning audio focus and replaces it with a
AudioFocusRequestClient interface. We still keep the
ID around though as it is useful for testing and
identifying requests.

BUG=875004

Change-Id: I88374a08a14171f747a120beaa380c3b126bfb4f
Reviewed-on: https://chromium-review.googlesource.com/c/1199923
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596404}

This CL allows DownloadManagerService to create InProgressDownloadManager
under cirtain circumstances.
The created InProgressDownloadManager can be used to resume download
without launching full browser process. And can be passed to the
DownloadManager when the latter is created.

BUG=695115

Change-Id: I050c1e5f5247cc1550e59117f7943a66a71656ce
Reviewed-on: https://chromium-review.googlesource.com/c/1182613Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596403}

Currently ImageSkiaReps are backed by SkBitmaps and cc::PaintImages.
While cc::PaintImages are drawables, they are sourced from the SkBitmaps
provided to the constructor. This means images that are sourced from
drawables, such as our vector icons, are rasterized into bitmaps first
and then stored as ImageSkiaReps. This rasterization takes place on the
UI thread.

This patch makes cc::PaintRecord as the backing store for ImageSkiaReps.
cc::PaintRecord are drawables and can be initialized with an SkBitmap if
needed. Having images stored this way means drawables like vector icons
dont need to be rasterized on the UI thread. Their rasterization will be
managed by cc or even the GPU in case of OOPR. This also removes the
constraint that ImageSkias are a rasterized source of image. It also
gives a way to add more drawable sources(CanvasImageSources) like
lottie.

This feature is hidden behind a feature flag UsePaintRecordForImageSkia.

Bug: 882507
Change-Id: Id4a6500ba0e12da382e95d59e5fa8bc5642082ab
Component: ImageSkiaRep, gfx, Image, Image Skia
Reviewed-on: https://chromium-review.googlesource.com/c/1227488Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596402}

This CL checks for a null LayoutView before dereferencing it.

Also cleaned up some uses of "absolute" coordinates to the more modern
"frame".

Bug: 890961
Change-Id: Ib130981f2b5af508769f44456e957785ea8cf437
Reviewed-on: https://chromium-review.googlesource.com/c/1258603
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596401}

Sync constent screen was not being shown if the browser was restarted as part of
sign-in. If the browser did not need a restart sync constent showed up as
expected.

Bug: 890967
Change-Id: I3fe1b9232626334d3060eea5abb066519c503b6a
Reviewed-on: https://chromium-review.googlesource.com/c/1259884Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596400}

ExtensionCacheDelegate has only one concrete chromeos specific
implementation: ChromeOSExtensionCacheDelegate. Pull all methods
into that class and delete ExtensionCacheDelegate.

Bug: None
Change-Id: Ibdcfad8d45d7c84039ddf0244312ccdd5b047a64
Reviewed-on: https://chromium-review.googlesource.com/c/1257900
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596399}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/18c0a2b44777..79c31bf9cbf4


Created with:
  gclient setdep -r src-internal@79c31bf9cbf4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Iccf968662c36b87c2d55fe14bd5c8cc2d5fb96ea
Reviewed-on: https://chromium-review.googlesource.com/c/1259499Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596398}

Bug: 891747
Change-Id: I73142c8bb5c4bbc78da71f230188e33d548a3dab
Reviewed-on: https://chromium-review.googlesource.com/c/1259475
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596397}

In https://crrev.com/c/1249834 the tabbable element was changed
from a button to role=button so using space to press it no longer
worked.

Bug: 891652
Change-Id: I8dd7155de5deba6f2b25c3ba5cb39761f84eafdc
Reviewed-on: https://chromium-review.googlesource.com/c/1258880Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596396}

This works on webui, so port it over to views as well.

Also generally rename version info -> system info to better capture what this
data represents.

Bug: 888049
Change-Id: Icb35156aafc9b0898dcd57e4c50dd09b067585b6
Reviewed-on: https://chromium-review.googlesource.com/c/1249823
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596395}