- 28 Nov, 2019 40 commits
-
-
Alexey Baskakov authored
Drive by changes: - Mark blocking I/O functions with ScopedBlockingCall objects. - Promote TaskPriority to USER_VISIBLE: icons are visible in UI. - Promote TaskShutdownBehavior to BLOCK_SHUTDOWN: Web Apps metadata is critical. This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. Bug: 1029221 Change-Id: Iaec0bb4b6ec97181ec0dad2326bcd249fd6d0ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941449Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#719875}
-
Luciano Pacheco authored
Change search clear button from <span> to <cr-button> so it handles the click and key down events. Bug: 910068 Fixed: 910068 Change-Id: Ie4c19dfdfa749a502a17fbb12f873901a26acd50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939138 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#719874}
-
Anand K. Mistry authored
Fixed: 809382 Change-Id: Ibab208690072668a6527a93658e5b6f65198a378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939147Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#719873}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fa0def753f3e..dafa00edc4b3 git log fa0def753f3e..dafa00edc4b3 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 dberris@chromium.org Use the vendored node runner Created with: gclient setdep -r src/third_party/catapult@dafa00edc4b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029208 Tbr: rmhasan@google.com Change-Id: I07d209aa609257d07571ce15b0dffc6e2c655a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719872}
-
Jeremie Boulic authored
browser_tests --gtest_filter="*fileDisplayLaunchOnLocalFolder" browser_tests --gtest_filter="*fileDisplayLaunchOnDrive" Bug: 1028907, 1028038 Test: Change-Id: I72e5e91a8bfc093807ccdaa4f7a29a38c73b2f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940320 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
David Benjamin authored
This is a speculative fix for the test failures in https://crbug.com/923166#c40 based on the stack in the logcat and code inspection. AndroidSystemProducer stores a raw const char* pointer passed in from many layers up the stack. In particular, the SetSystemProducerSocketAndChecksAsync function used in tests passes in producer_string.c_str() where producer_string is a std::string that was bound into a callback somewhere. This is a UAF and I suspect it is what's tripping the libc++ debugging assertion. Bug: 923166 Change-Id: Id9153009c34ef942a2d9a4b21c760c0394258f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924235 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#719870}
-
Koji Ishii authored
This reverts commit 957329b6. Reason for revert: r708894 fixed the case where hyphens are not rendered under certain conditions, but caused the infinite rewind loop in |NGLineBreaker| when there are negative margins on inline boxes. This patch reverts the fix. I will work on the new fix for the issue 1015297 after this revert. Original change's description: > [LayoutNG] Fix hyphens when rewinding occurs > > This patch removes |NGLineInfo::LineEndFragment|, which was > introduced to support hyphens and ellipsis with the single > code. However, ellipsis was changed to use different code, > and |LineEndFragment| ended up with non-optimal way to handle > hyphens. > > Although hyphens appear at most once in a line, storing this > to |NGLineInfo| makes harder to keep it in sync with the > hyphenated item. This patch changes it to a field in > |NGInlineItemResult|. > > Bug: 1015297 > Change-Id: I0706cf54bebfa967661dc40123c6dfd5887ff59c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868534 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708894} TBR=kojii@chromium.org,ikilpatrick@chromium.org Bug: 1015297, 1028817 Change-Id: I5f116288b935f3fd296f4c25c1bf0457779a8e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940323Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719869}
-
Noel Gordon authored
Bug: 1026943 Fixed: 1026943 Change-Id: If5241fafceb918cfeea5e317ecf1019e445cfe18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939812Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f31cb801f2cd..1bfe890bd8fc git log f31cb801f2cd..1bfe890bd8fc --date=short --first-parent --format='%ad %ae %s' 2019-11-28 tandrii@google.com bb: ask BB server to respond in JSONPB, which is much faster. Created with: gclient setdep -r src/third_party/depot_tools@1bfe890bd8fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1028915,chromium:1028420,chromium:1028915 Tbr: agable@chromium.org Change-Id: I9dd24f7573a0406d89a93a7872dc69ec9189d7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941201Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 764f0674. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I02738470efadabe540449b8bd64003d7c5cb76c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941368Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719866}
-
Eric Willigers authored
The spacing around the Back and Reload buttons now matches mocks provided by UI team. When a profile indicator icon is present, we move the Back and Reload icons to the right of the profile indicator. Logic controlling the Back and Reload buttons is moved into a new nested class WebAppFrameToolbarView::NavigationButtonContainer. Bug: 1016663, 1028789 Change-Id: Ie404aa64a191228161e4590e430be2dfff4a5381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909057 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#719865}
-
Chih-Yu Huang authored
This CL moves the frame format checks from VaapiImageProcessor to ImageProcessor, because all IP implementation should verify frame format. Bug: 1028889 Test: Run image_processor_test on Kevin and Eve and no break new tests Test: Pass video_decode_accelerator on Kukui Change-Id: I3751f608785b0ee2a1087228d655405f56043c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939078 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#719864}
-
Anatoliy Potapchuk authored
Previously, you were able to do an escape via tabs.create api. Now it is not possible. Bug: 1024244 Change-Id: Ic81c202891cd504f08678db3bbf42b4a5ae1a28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914360 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719863}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I7382dc2bcb9db43e720293530949a9ea9af442ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940676Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719862}
-
Miguel Casas authored
This CL teaches EdidParser about the max, max_avg and min luminance values present in some EDID blobs, and extends the unittests accordingly. Bug: 1026688 Change-Id: Ia7051ba97852b1aca16b08dbfe82bd8f43e8b14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937660 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#719861}
-
Peter Kotwicz authored
This CL introduces a CCT/WebAPK specific RootUICoordinator - BaseCustomTabRootUiCoordinator BUG=1020324, 1015627 Change-Id: I5ec73d189cc0016cbfc73734fd27ba962d9d1fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938833 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#719860}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5abf580ff877..a5262fb3c246 Created with: gclient setdep -r src-internal@a5262fb3c246 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:995903,chromium:None Tbr: jbudorick@google.com Change-Id: Id3128b2a2ddceef3f8d520a4f8b7c63617a3a3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941202Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719859}
-
Etienne Bergeron authored
This CL is adding a copy of text attributes in the layout phase. Previously, the code was keeping the styles in BreakList for |text_| and using the text indices to get them. This implies conversion between display_text_/layout_text -> text_ indices. To work correctly, the amount of codepoints need to stay the same. This assumptions is not well enforced (e.g. Eliding, Truncate, etc..). The advantage of adding the breaklist copy is that the layout styles will be kept with the same indices than the layout_text_. Also, there is no need anymore to use these functions: void ApplyCompositionAndSelectionStyles(...); void UndoCompositionAndSelectionStyles(); These functions were making a backup copy of the styles and then applying their own style modifications over it. This CL is proposing to directly applied their effects in the layout stage, therefore removing the needs of any Apply/Undo. Bug: 1025561 Change-Id: Ic664488a05a02f4d40b34b9b3eba60f6a2f59d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924954 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#719858}
-
Melissa Zhang authored
BUG=979186 Change-Id: Iae13b227d6db2276873560736b653e13def885cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940321Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719857}
-
Miyoung Shin authored
This CL converts DedicatedWorkerHostFactory mojom interface client in content and blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I3991c213428888c94b1922aabeaa1ce807e832b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935775 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#719856}
-
Leon Han authored
Because NDEFRecord#lang is supposed to be set to the document element's lang attribute in the original web page that constructs/writes this record, not in the current web page trying to construct an NDEFReadingEvent instance. This CL adds a wpt to guarantee that. BUG=520391 Change-Id: If609455d6411ee886b74ab7557292c37da41eed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930451Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#719855}
-
Austin Tankiang authored
Also some code style changes to make the code pass presubmit. Bug: 937251 Change-Id: I259d54bda0e5183c30999c6698f06761a4183e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939814Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#719854}
-
Eric Willigers authored
When a desktop PWA is launched in a window, we now record the display mode that was requested in the manifest. Bug: 1939127 Change-Id: I98b77e5eebd355add3cb38a97924fbcd457b99fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939082 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#719853}
-
Sadrul Habib Chowdhury authored
Report whether a scroll-begin/update caused the browser top-controls to move or not. Also report the end-to-end latency metrics separately for these two cases, so that it is possible to measure the impact of changing the height of the top-controls during scroll. BUG=1027129 Change-Id: I5084a439aa83999809da3a8e9419f30cd3d1a8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931922Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#719852}
-
Sergey Ulanov authored
Previously web_engine_integration_tests were using default WebEngine instance. This approach creates several issues. Particularly WebEngine that is being tested may not be the latest verstion installed on the test system. Updated the tests to use Launcher API to start a new instance of WebEngine. This approach will also allow to pass custom flags to WebEngine, which will be useful for some tests. Also fixed initialization order in ContextProviderMain Change-Id: Id6ffbd9a498fa42531193c5e9c6d01a932591ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938454 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719851}
-
Michael Spang authored
This reverts commit b7edadd9. Reason for revert: MSAN issue fixed Original change's description: > Revert "ozone: Build with xkbcommon by default on is_linux && !is_chromecast" > > This reverts commit 713420fb. > > Reason for revert: Causes MSAN failure > More details in crbug/1027853 > > Original change's description: > > ozone: Build with xkbcommon by default on is_linux && !is_chromecast > > > > This is necessary on Linux targets unless you don't want keyboard > > support or only need support for a hardcoded US layout. > > > > Noticed because the CQ broke after building for ozone locally. This > > reduces the number of flags needed to build as the Linux Ozone builder > > does. > > > > Bug: 1026476 > > > > Change-Id: I77352c133b1f7552301b6e1f252d40a4f2c72106 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925370 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org> > > Commit-Queue: Michael Spang <spang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718240} > > TBR=sky@chromium.org,spang@chromium.org,kpschoedel@chromium.org > > Change-Id: I4fa0de1881acbf1eaf7e70bfe4b24dbc84647f43 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1026476 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932436 > Reviewed-by: Tim Schumann <tschumann@chromium.org> > Commit-Queue: Tim Schumann <tschumann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718445} TBR=sky@chromium.org,spang@chromium.org,kpschoedel@chromium.org,tschumann@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1026476, 1027853 Change-Id: I4f601a169bd5d18714a1a78ca8cacd0b43939afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941277Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719850}
-
Sergey Ulanov authored
Previously Flush() was taking base::Closure, which is deprecated. Replaced with base::OnceClosure. Bug: 751838 Change-Id: Iccd5bb58b262cb67f87810613b180da9148fe145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940300 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719849}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b811565..81668204 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieaad52ef4f15c85c862e2b817e9ba232f67aba29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941237Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719848}
-
Fei Ling authored
During import, such keywords are ignored. Bug: 6867 Change-Id: I7f6955629bca92506c4be4dba398577a07483580 Fixed: 6867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937583Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719847}
-
Miyoung Shin authored
This CL converts RemoterFactory mojom interface client in content to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I2513a91b6b0a034c65cf22813d352e7e9a2929b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939067 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719846}
-
Maksim Ivanov authored
Use the color that is used for other auth methods, rather than the result of applying the "AutoColorReadability" transformation to the white color. Bug: 1024254 Change-Id: I4c4c94f3db2b1dbf1f5d8a6ac81fcc247e8bacc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816468Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#719845}
-
Miriam Zimmerman authored
This API enables tast tests to set metrics consent, which is required for us to integration test the crash reporting system. BUG=1018456 TEST=`tast run platform.ServiceFailure` with this change. Change-Id: I9bdd3d20a590224079716ef399967aae3929866b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929983 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#719844}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d60fe6b7daaf..5abf580ff877 Created with: gclient setdep -r src-internal@5abf580ff877 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1029095 Tbr: jbudorick@google.com Change-Id: I9b3ce3fe6a206c067cf177eb0f9def601a680022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941290Reviewed-by:
-
Sadrul Habib Chowdhury authored
The browser knows when the top-controls visible height changes. So include that information from the browser, using a SwapPromise. Also, extract that flag into the aggregated frame in SurfaceAggregator, and pass it along to the OutputSurfaces in OutputSurfaceFrame. BUG=1027129 Change-Id: I5b233be7da38e31138863a7da6ec06958288dfbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929584 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#719842}
-
Luciano Pacheco authored
Polymer updates the template upon any property mutation, using setProperties allows to batch property mutation and update the template only once, use it for better overall performance. AVG of 5 runs | setProperties | without setProperties onMetadataX() | 4.273876953 | 5.588183594 (~23% faster) clear() | 2.381201172 | 3.849414063 (~38% better) Bug: 948605 Change-Id: I63005391e3cbc8ed53ad142d6d9211521ad72a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937949 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#719841}
-
Yue Li authored
Extend the expiry milestone of assistant app support feature flag which is still in use. Bug: None Test: Locally build and test Change-Id: I3cfdba42aa1cc79b715575f583fe02bdfd2802e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939684Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#719840}
-
Sadrul Habib Chowdhury authored
Instead of reporting the height and shown_ratio for the browser-controls separately, merge them into a single 'visible_height' field, since that is the only information used (for the screencasting API). In addition to that, make this an optional field, so that if top-controls height do not change, then this field does not need to be set. This will be used in follow-up CLs to report latency metrics separately for scroll-begin/update events that change the visible height of the browser top-controls. BUG=1027129 Change-Id: I0fe55a5f214e69235e700985d6214c1096f77e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931101Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#719839}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8a6dcf76315c..d6e903bdc9ef git log 8a6dcf76315c..d6e903bdc9ef --date=short --first-parent --format='%ad %ae %s' 2019-11-28 sugoi@google.com Support multisampled Bresenham lines Created with: gclient setdep -r src/third_party/swiftshader@d6e903bdc9ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/142965928 Tbr: swiftshader-team+autoroll@google.com Change-Id: I80914116433fe994a6682b4cae9b38e9675fcf3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939679Reviewed-by:
-
Vitaly Buka authored
AttributeDescendantSelector.html of linux-perf/blink_perf.css was 15% slower with -ftrivial-auto-var-init=pattern. Before: https://pinpoint-dot-chromeperf.appspot.com/job/16672223220000 After: https://pinpoint-dot-chromeperf.appspot.com/job/157aebd3220000 Bug: 977230 Change-Id: Ibe020d9749caeaccdf5ca2d94abe9eeba756a454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938438Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#719837}
-
Rob Schonberger authored
This adds a reporting filter intended for Stylus' devices, which adds metric recording. Bug: 1009290 Change-Id: Ifed692f1bd6dcf6cea7891dc615d6887bb11d672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923223 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Reviewed-by:
-
