- 12 Nov, 2020 40 commits
-
-
chinsenj authored
The {TabletOrClamshell} token is used in various different ash histograms but they all use the same variants. This CL extracts the variants into a common variants tag. Bug: 1140182 Change-Id: Ifd9b5233405b65308c09b24e0e6d7700eef2db3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533362Reviewed-by:Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826874}
-
Jamie Madill authored
This reverts commit e4620991. Reason for revert: Suspected for causing crashes on Windows/Intel. For more info see bug. Bug: 1148269 Original change's description: > Ignore unknown record types in DNS responses > > Previously worked only for address requests. Other request types (e.g. > HTTPS), on seeing any unrecognized (and therefore unparsable) record > type in the response, would fail the whole response as malformed. > > Bug: 1147247 > Change-Id: Icd9e5ab2e39cf09ffe7c3945b011ebf1d4b45778 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529619 > Commit-Queue: Eric Orth <ericorth@chromium.org> > Auto-Submit: Eric Orth <ericorth@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826462} TBR=mmenke@chromium.org,ericorth@chromium.org Change-Id: I03ea912d1a9c8a01be3d84a3f4d417c385f97c2d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533548Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#826873}
-
minch authored
Extend the expiry date of the histograms' for tab/window dragging and back gesture. Bug: 1147108, 1147107, 1147106, 1147105, 1147098 Change-Id: Ic2f9d2eacc9aa39a702fa2dc67c4befcbb25a17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527678 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#826872}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/62c10c170bb3..f9e59ad07855 2020-11-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from a61d07a72763 to 1cda495274bb (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I5967a52af57d49153bf6b77586a89107c098135f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826871}
-
Matthias Körber authored
Change-Id: I59f544e93fa573d3a5ab9b7b43c3b9b51e1c4550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526062 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#826870}
-
Thomas Lukaszewicz authored
This CL adds metrics to track the position of a switched tab from both filtered and unfiltered lists. Bug: 1099917 Change-Id: I4cb7822240bd78b228906b0fd86eaf364b4cdb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529692 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#826869}
-
Andy Paicu authored
Implements a bare-bones version that mostly reuses code from RealTimeUrlLookupServiceBase without doing the work to derive from a base class. This will follow-up in a different CL. For this reason some of the callbacks have unused parameters, to make implementing a base common class less painful. Design doc: go/permission-predictions-client-doc Bug: 1138595 Change-Id: Idc26e836fba565cf42f796ee3a5b20bc8d61f53f No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513656 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#826868}
-
Rune Lillesveen authored
We did a BlendWithWhite() to not have custom selection backgrounds fully obscure replaced content like images. But, we also did that blending for text which means the author could not fully control the ::selection background. Instead, only do this blending for replaced content. This is in line with what Firefox does and what the spec says[1]. The blending is still done on the UA default background color for both text and replaced content in LayoutTheme. [1] https://drafts.csswg.org/css-pseudo-4/#highlight-replaced Bug: 1018450 Change-Id: Ibb2c63d549a21706a511bbb47ff4c686b246314b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532555 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826867}
-
Jan Wilken Dörrie authored
This change adds base::fixed_flat_map and base::fixed_flat_set as specializations of base::flat_map and base::flat_set using a std::array as the underlying container. These containers have immutable keys following their construction, and can be used as constexpr lookup tables in case the keys (and values) are known at compile time and of appropriate types. Bug: 682254 Change-Id: I47725824078beeca5100f502041c4977efde5868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532247Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#826866}
-
chinsenj authored
Currently if a user moves a window to another display via overview, its header is invisible upon exiting overview. This CL resets the clipping created when the overview item is created to prevent this bug. Test: manual Fixed: 1140639 Change-Id: I9e5d943bcb4ac7e8fb2054775c2695b2516dc381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533553 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#826865}
-
David Bienvenu authored
Bug: 1007801 Change-Id: I2b93105731784095eee61591478756f6dcafb58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532561 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#826864}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=sdefresne@chromium.org Bug: 1145565 Change-Id: I6079224aa98f835cd8913977b157e02b0a679f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533136Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826863}
-
Xiaodan Zhu authored
This CL add a policy for the fullscreen alert to make admin be able to turn it on/off for certain apps. In M89, we will change this policy to a allowlist policy. Test: Manually tested on the test device. Bug: 1107185 Change-Id: I58c01980218f94946d66b7ee2995d49d30ad329d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530654 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#826862}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605139151-5e724661a0d96b85fc6a4800d483b70ce425d91c.profdata to chrome-win32-master-1605171583-b81bb40f399242d480e6bc76fe7dadde7d574957.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If85c1f0cef656378fe91dacb6d16ef73d0b6b7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534006 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Dave Tapuska authored
MockRenderProcessHost had a unique lifecycle, it could self delete when Cleanup was called and this would lead to a double free in some tests that allocated it via a unique_ptr. In fact the majority of tests allocated it via unique_ptr or stack allocated where self deleting the object makes no sense. To clean this up remove the self deleting and change all ownership to explicit ownership via unique_ptr. BUG=993189 Change-Id: I2cd6ddf3298cbcfe630f17fd008a8895e9562937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528620 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826860}
-
Roger McFarlane authored
Bug: 1110384 Change-Id: I7c0324071625e4bf25e3b797d5a1fb60bdedd1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476134Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#826859}
-
Hans Wennborg authored
These tests are in zlib_unittests, and that's already built and run by the bots (after crrev.com/804566). This removes the redundancy of building and running them twice, and takes some load of the already very large unit_tests target. While here, also move the zip and compression_utils to zlib_unittests and try to clean up chrome/test/BUILD.gn from unnecessary zlib references. Bug: 352073 Change-Id: I3cfe020df9bc2699bbb160ae95b511840589e054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534930 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826858}
-
Tim Volodine authored
StartSurfaceTest#testShow_SingleAsHomepageV2_VoiceSearchButtonShown__Instant_Return StartSurfaceTest#testShow_SingleAsHomepage_VoiceSearchButtonShown__Instant_Return are failing / flaky on L and M bots. BUG=1148352 NOTRY=true TBR=wychen@chromium.org,hanxi@chromium.org Change-Id: I86d4873301d578236f760d323b90c8386c0462bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534932Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#826857}
-
David Dorwin authored
Without a background color, the page is transparent, which can make it hard to read or notice whether it worked when the background behind it is black. Also, add a console log to allow testing of setting the console log level and DevTools. Change-Id: Ib8c4197615b425addc8d44ef9e8e9275a97d4810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533862 Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826856}
-
Angela Yoeurng authored
If a suggestion has a remove suggestion button, this CL adds a voiceover saying 'Press Tab then Enter to remove suggestion.' If a suggestion has a remove suggestion button AND another option, the voiceover will read 'multiple actions are available, press Tab to cycle through them.' The Remove Suggestion button previously was not included in the action count. Bug: 1099798 Change-Id: I84f012d0f9d40a82a8c85214128ce25c6b4323b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533634Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#826855}
-
Ben Joyce authored
Bug: 989569 Change-Id: I71607e5272ca98c896d5dd48307f2198b46ef4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520332Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#826854}
-
Chris Lu authored
Bug: 1107489 Change-Id: I8d7f9a4c8567936993a95589bbc9333360df8570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521108 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#826853}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b01e06269f7..2f813eb9ddbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com,mamir@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: zmin@google.com,mamir@google.com Change-Id: I829985734e2d419246bf35495341f67b1507dd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534807Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826852}
-
Alex Rudenko authored
Bug: 1121900 Change-Id: Ia64736ac414b08c4999a9ff077bf82c0e31d03f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534830Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#826851}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8e6646c31e9d..9534205dbf29 2020-11-12 tvanderlippe@chromium.org Typecheck changes/ChangesHighlighter.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I96e42dd4aa3753a0b4ad2f149162b9cad90fa52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535074Reviewed-by:
-
Brandon Wylie authored
Connecting buttons to their actions, writing to prefs and displaying the consent dialog when needed. mocks: https://www.figma.com/file/b1CT6jM3mj0MdBvgQicy4b dd: https://docs.google.com/document/d/1ZnmJUYFBEiIx8TjQPxD18e7NAeJa6yIBamAJyR-ggOk Bug: 1117271 Change-Id: I90dd40c285d9246cfe5b48c62ffdee093c591086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531356 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#826849}
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Bug: 328932 Change-Id: I13caaf4f9eff77db7cb0afc1516ed485e1908556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515142Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#826848}
-
Sammie Quon authored
We only have once window observer function OnWindowDestroying, and it only removes the observer unless it is the restore focus window. So there is no point observing the other windows or storing their pointers. Bug: none Test: none Change-Id: Ib66cb0c34c316b1d7ed8c30f3d110e8b32d7b2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533857Reviewed-by:
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Bug: 328932 Change-Id: Iab033c7cd7174d82be4740bcf1ee4fca5288665f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514807Reviewed-by:
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Bug: 328932 Change-Id: I6b93bf1977582ff5a104820728ad891bd2a329e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514965Reviewed-by:
-
Rushan Suleymanov authored
If the last tab is closed, it won't be removed from the "Tabs from other devices" list. This CL fixes it by sending the latest state even if there are no tabs left in window. After current CL the window is considered syncable if it is not about to be closed (regardless of the number of tabs). Bug: 1039234 Change-Id: I15c61b38a6bbd53ea158b216644cd27655f8c4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485261Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#826844}
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Bug: 328932 Change-Id: I524d814fd6c9839e9804e6de808bd62ebc2f8fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515441Reviewed-by:
-
Evan Stade authored
Bug: 1147268 Change-Id: I5dd82eb4a2158f68f517d11e3f9c8e06ab89988f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531293Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#826842}
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Note: action.setIcon does not yet support promises as it uses a custom hook. Promise support for APIs using custom hooks will be added at a later time. Bug: 328932 Change-Id: I3271db95514a5410ae4e361b514c8932dad1d85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514745Reviewed-by:
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Bug: 328932 Change-Id: I6b2f545c3b3b92e30a1a355256a17083e12c2e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515141Reviewed-by:
-
Olesia Marukhno authored
Make new permission requests to override current pending requests and then restore pending requests in stack order. Bug: 1019129 Change-Id: Ia7503432cceb27e4db40708c63e3e442e026595e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418445 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#826839}
-
Miyoung Shin authored
This CL changes chrome.dom namespace's channel from dev to stable. Bug: 778816 Change-Id: I4ed039f72330a14baee487e89da325ff1ca707e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532540 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Evan Stade authored
This changes ShortcutHelper to download the splash image for a webapp while the webapp is being installed, rather than after. If the splash image is downloaded before the webapp installation process finishes, the splash image will be stored in a local map until it can be transferred to the WebappDataStorage object. This simplifies the code and fixes a potential UAF. Bug: 1147913 Change-Id: I9405ee9cc304eaf8b9ff2bbaca17c1c63cfd6e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533031 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Sammie Quon authored
Use the sessions AddItem instead of grids AddItem. The former updates the recent items widget and also |num_items_|. This prevents a DCHECK from crashing when exiting overview, since |num_items_| will have the wrong value. Fixed: 1147990 Test: manual Change-Id: I27f76a6da28572da6fa9f8bd045b239e63d7d19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533994Reviewed-by:
-
Nohemi Fernandez authored
UX and Product have aligned to recommend "Signed in as [full name]" as the title for the sign-in notifications infobars. Bug: 1145592 Change-Id: Idb923fbf284b1a466ae0976d1920e20301319764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534856 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#826835}
-
