- 15 Feb, 2019 40 commits
-
-
Aleks Totic authored
Only behavioral change is keeping track of placed elements. This will be important in future CL. This CL is part 3/X of placing Legacy contained OOF Elements by NG. Bug: 907911 Change-Id: I5fb2c1e777bee3310239d7673211c6c6e08b3200 Reviewed-on: https://chromium-review.googlesource.com/c/1474538Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#632824}
-
Bill Orr authored
This change allows getting position and orientation data through Windows Mixed Reality APIs. It also adds optional fields to the XRFrameData mojo struct for updating per-frame eye offsets and eye parameters. Bug: 928812 Change-Id: Ic38271348ae5ee8472952da342837b5f8a25432b Reviewed-on: https://chromium-review.googlesource.com/c/1457724 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#632823}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd091589..8d1908ec Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9f500cd3af370b7a5806210ae6a27bf85a0df8c5 Reviewed-on: https://chromium-review.googlesource.com/c/1474987Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632822}
-
khmel@chromium.org authored
TEST=Unit test BUG=915316 Change-Id: I19637f8a6266f99ecbc04dff01a53e149f6aa94e Reviewed-on: https://chromium-review.googlesource.com/c/1475887Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#632821}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/685ea8d6f03c..2b0f8cfb7440 git log 685ea8d6f03c..2b0f8cfb7440 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 dhanyaganesh@chromium.org Revert "repository: FetchAll -> RepairMissingRemotes." Created with: gclient setdep -r src/third_party/chromite@2b0f8cfb7440 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I85bdcf6b0d43743d5cf6ede4eb916e343e8a658c Reviewed-on: https://chromium-review.googlesource.com/c/1475749Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632820}
-
Alexei Filippov authored
The C++ thread_local is slightly faster while making the code clear. Besides that calls to TlsGetValue on Windows may alter the result of GetLastError, thus changing behavior of the underlying code. BUG=920440 Change-Id: Ic89632f4a54f35d58b93cdecfffc68fc1a94dac1 Reviewed-on: https://chromium-review.googlesource.com/c/1461681Reviewed-by:
Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#632819}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/aead8edf8c46..b6c1c66d2547 git log aead8edf8c46..b6c1c66d2547 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 courtneygo@google.com Vulkan: Discard scissor if either dimension is 0 2019-02-15 jonahr@google.com Refactor ANGLE's extensions struct to more easily represent multiple 2019-02-15 enrico.galli@intel.com ES31: Add atomic counter buffer support to D3D11 renderer Created with: gclient setdep -r src/third_party/angle@b6c1c66d2547 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I2ebcae5e84035ed8472d69d72857486e838db1c1 Reviewed-on: https://chromium-review.googlesource.com/c/1475197Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632818}
-
John Abd-El-Malek authored
Add a test to verify the renderer doesn't hang if it's making a sync XHR and the network process crashes. Bug: 932305 Change-Id: I8fb8b0bb0f1fdf36583f75b70112c60ab9669174 Reviewed-on: https://chromium-review.googlesource.com/c/1474265Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#632817}
-
Hiroshige Hayashizaki authored
Previously, if the encoding returned by XMLHttpRequest::FinalResponseCharset() is invalid, Latin-1 encoding was used due to the logic in TextResourceDecoder::DefaultEncoding(). After this CL, the encoding determined by the latter half of XMLHttpRequest::CreateDecoder() is used in such cases, which is UTF-8 for text. Bug: 905968 Change-Id: I04e6ae524b8e1d3abd21e4a7a10279eb5638a58c Reviewed-on: https://chromium-review.googlesource.com/c/1342813 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#632816}
-
Ian Kilpatrick authored
This also makes the function accept a LayoutBlock instead as well. Unittests which call NGConstraintSpace::CreateFromLayoutObject on a LayoutObject are updated to ensure that the LayoutObject is a new formatting context. Should have no behaviour change. Change-Id: Ibaeffaecd47b37474fc426f80b006592a3257de8 Reviewed-on: https://chromium-review.googlesource.com/c/1473393 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#632815}
-
Morten Stenshorne authored
This saves 448 (of 2928) bytes per in-flow layout recursion [*]. This part of the code uses a lot of stack, because of quite a few local variables, but also due to a CHECK(), which alone costs 272 bytes [*]. It's the "child_bfc_block_offset.value()" line that contains the CHECK(has_value()). Fun fact: The compiler would have optimized away the CHECK if our code had called has_value() on its own first. [*] Linux 64bit release. Bug: 930637 Change-Id: I3afe43e8d72e5432b3ff9c3c113ce4f8067b873f Reviewed-on: https://chromium-review.googlesource.com/c/1472619 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#632814}
-
manuk authored
When the clipboard contains large text, certain user interactions with the omnibox (e.g. right click) exhibit a significant delay. Previously, when the clipboard contained more than 32*1024 characters, we skipped classifying the text and disabled the 'Paste and Go / Search' context menu item as those were the largest sources of delay. However, at around 130 million characters, sanitizing the text begins to contribute significant delay (3-4 seconds) as well. Additionally, certain user actions fetch and sanitize the clipboard text multiple times; e.g., right clicking the omnibox fetches the clipboard 5 times; then selecting 'paste' fetches the clipboard 2 additional times; these calls accumulate an ~18 second delay. This CL: (1) removes the earlier truncations and (2) instead truncates the clipboard text when it is fetched, and therefore before it is sanitized. Additionally, (3) it increased the truncation length to url::kMaxURLChars (2*1024*1024) characters. This is sufficient to keep the right click delay under 9 seconds while also leaving greater safe room for potentially long URLs (google images serves data URLs up to at least 30k characters). Bug: 543675 Change-Id: I8c3df3dc262747d57e37cd766d84efa12d8d94ee Reviewed-on: https://chromium-review.googlesource.com/c/1474192 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#632813}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/crc32c.git/+log/f8925d027884..e4dfc9f1b583 $ git log f8925d027..e4dfc9f1b --date=short --no-merges --format='%ad %ae %s' 2019-02-14 pwnall Remove MSBuild section from AppVeyor config. 2019-02-14 costan Replace TEST_CASE with TEST_SUITE. (#29) 2019-01-15 costan Update Travis CI config and dependencies. (#27) 2018-11-15 costan Add shared library mode to Travis CI. (#24) 2018-11-14 coryan Support shared libraries. (#23) 2018-10-23 costan Fix Travis CI for Mac. (#22) 2018-07-23 costan Update dependencies and bump GCC to 8. (#20) Created with: roll-dep src/third_party/crc32c/src Bug: 925652 Change-Id: Ie5a2309b4b81134fa68e1d393fbec6796c84e6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1475748 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#632812}
-
Aga Wronska authored
ConfigSource is responsible for delivering access code configuration and ParentAccessService does not depend directly on the source. PolicyConfigSource implements getting configuration from the user policy. Bug: 911326, 921147 Change-Id: I186e6e3c58b0692558907b91185fffb78188e5c3 Reviewed-on: https://chromium-review.googlesource.com/c/1469424Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#632811}
-
Adam Langley authored
Seems like we're going to want to make this more generic to cope with PIN support. Change-Id: I230f317e364a8072b02ffe577b33232c5b9b9786 Reviewed-on: https://chromium-review.googlesource.com/c/1475008 Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#632810}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=rogerta@chromium.org Bug: 714018 Change-Id: I6b26b0eb43cb5167e8c115781c956bfe13d6bdfc Reviewed-on: https://chromium-review.googlesource.com/c/1475637 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#632809}
-
Harley Li authored
The specification [1] states that each object store may have a key generator [2]. This is essentially a counter that works exactly like the counters used by SQL's auto-incremented primary keys. [1] https://w3c.github.io/IndexedDB [2] https://w3c.github.io/IndexedDB/#key-generator In the test: the key generator's value is only bumped if it is used, so the first "key generator value" is 1, and the second is not 1. Bug: 929817 Change-Id: Iaf8d0dbf65e7de3de3163726d9791f4aad7048fd Reviewed-on: https://chromium-review.googlesource.com/c/1464968 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#632808}
-
Siddhartha S authored
The shared database is implemented and new databases should directly use the shared version instead of using the unique, to avoid migration in the near future. Also, use enum instead of namespace and prefix strings. The actual prefix for identifying a database is also changed to numbers. The only string the api takes in is for UMA. The field trial will still use strings, but these will go away soon. BUG=870813 Change-Id: Id8b506424c66e3a744539838da8b565ca3ddb20d Reviewed-on: https://chromium-review.googlesource.com/c/1472070 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#632807}
-
Tibor Goldschwendt authored
Bug: 930914 Change-Id: Ife8d6046e46c070d16543bfa0f5ff337bb57f98a Reviewed-on: https://chromium-review.googlesource.com/c/1471351 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#632806}
-
Ayu Ishii authored
Bug: 916176 Change-Id: I273a74070546652c80deffc600157ccda06c35aa Reviewed-on: https://chromium-review.googlesource.com/c/1459785Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#632805}
-
Scott Violet authored
It would seem neither of these are necessary any longer. BUG=none TEST=none Change-Id: Iec712982e85a80255d270c9818093085f0343841 Reviewed-on: https://chromium-review.googlesource.com/c/1474990 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#632804}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b85323f10e7..34a2a76e2094 git log 1b85323f10e7..34a2a76e2094 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 scroggo@google.com Remove assert that BGRA and RGBA are not opaque 2019-02-15 herb@google.com Revert of CL/192440 which would not reland cleanly. 2019-02-15 fmalita@chromium.org add mixer colorfilter 2019-02-15 csmartdalton@google.com Remove shader caps argument from GrGLSLTypeString 2019-02-15 robertphillips@google.com Stop using resourceProvider in GrRenderTargetContext's ctor Created with: gclient setdep -r src/third_party/skia@34a2a76e2094 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I54f8a515e6da7c0d7aeeefd5e53cb621ca6cf799 Reviewed-on: https://chromium-review.googlesource.com/c/1475036Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632803}
-
Eric Karl authored
In certain cases, drivers hang when tearing down the Display. Finishing before teardown appears to address this, and should have minimal impact as we're during Display teardown so no frames are likely to be produced soon. We will hopefully replace this with a more targeted fix, but this should allow us to test some theories. Bug: 899705 Change-Id: Ie93ee00dcb975b704dccc51ba37a6267bb2d9719 Reviewed-on: https://chromium-review.googlesource.com/c/1468681 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#632802}
-
Becca Hughes authored
Add support for an "ambient" audio focus type. This is used when a media session can have its audio mixed with other sources; therefore it has no effect on other sessions when it gains focus. It can also be used when we want a session to appear in audio focus manager but without taking focus from other players (e.g. remote playback, paused). BUG=932315 Change-Id: I75318bc6ecc8fd561da4ad62764d0f44ee1ed178 Reviewed-on: https://chromium-review.googlesource.com/c/1474979Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#632801}
-
siyua authored
This DCHECK makes sure the email passed in CreateExplanationText() is not empty, but we later made change so that this function will be called when creating feedback dialog view where there is no user email address. So this DCHECK will always fail on an expected event. Bug: 897998 Change-Id: Id22300ba56fcc4de15f014a554d5c2d1e88df01d Reviewed-on: https://chromium-review.googlesource.com/c/1474805 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#632800}
-
Theresa authored
Start the trace after the early return to avoid a trace begin without end. NOTRY=true Bug: 932356 Change-Id: I07968ee22b41d9b0274ccfcaad6581173a10b020 Reviewed-on: https://chromium-review.googlesource.com/c/1474740Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#632799}
-
Yue Li authored
Bug: b/124240611 Test: Manual Test Change-Id: Idfd180d408a22f97330fb4f4deb60d0bc430cf80 Reviewed-on: https://chromium-review.googlesource.com/c/1471265Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#632798}
-
Alex Clarke authored
This is in preparation for the BrowserUIThreadScheduler where we hope to have only one location where it's set up. Bug: 863341, 872372 Change-Id: Ia7c07adc1d60280f2aed25f5226bfce80c6aba4b Reviewed-on: https://chromium-review.googlesource.com/c/1461393 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#632797}
-
Sergey Ulanov authored
This change reverts some parts of https://crrev.com/632311 . Modular still depends on ViewsV1, so it was broken by that change since it removed ViewsV1 support in web_runner. Bug: 899348 Change-Id: I10cd2c2c11b3b4d2ad2d3a0000ffee5c13e549e7 Reviewed-on: https://chromium-review.googlesource.com/c/1476063 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632796}
-
Oksana Zhuravlova authored
Change-Id: I7d503196544f976ddaf1eeea4916b44a8989722b Reviewed-on: https://chromium-review.googlesource.com/c/1475830Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#632795}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2b14855de938..efc7e91fa764 git log 2b14855de938..efc7e91fa764 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 iannucci@chromium.org [recipes] Manual roll. Created with: gclient setdep -r src/third_party/depot_tools@efc7e91fa764 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:914992 TBR=agable@chromium.org Change-Id: I145d4a1cb21987361fe8d6e1742ea471a4c9cf75 Reviewed-on: https://chromium-review.googlesource.com/c/1475893Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632794}
-
manuk authored
This is a reland of 6e200e4f Original change's description: > [omnibox]: Initialize HistoryURLProvider earlier. > > This CL moves the HistoryURlProvider's initialization after the SearchProvider's > but before the ZeroSuggestProvider's and ClipboardURLProvider's. > > For threading reasons, CL 1384637 moved the HistoryURlProvider's initialization > last in the AutocompleteController's constructor. However, the zero suggest and > clipboard URL providers take a reference of the history URL provider when > initialized. To avoid setting these references to NULL, this CL moves the > history URL provider's initialization before the other two's but keeps > it after the search provider's for the reasons described in the other CL. > > Bug: 932257 > Change-Id: I1085ad89e13f29ea29264ce3fa1a2d33197f3b17 > Reviewed-on: https://chromium-review.googlesource.com/c/1474383 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632682} Bug: 932257 Change-Id: If1dd04d838bc78f8f323280b4023fea551a80b3a Reviewed-on: https://chromium-review.googlesource.com/c/1475249Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#632793}
-
Hiroshige Hayashizaki authored
Will be used by [1] for V8 Code Cache for module scripts. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1237715 This doesn't change behavior. Bug: 841466 Change-Id: I15c4e6d4894ad5f41cc365dfb2c73b2d5fa3c40a Reviewed-on: https://chromium-review.googlesource.com/c/1475089Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#632792}
-
Erik Chen authored
This CL specifies the owners for the memlog flags, and indicates that they should never expire. Change-Id: I90a44edde7110355dde97dcfcbb6f9fd93246c03 Reviewed-on: https://chromium-review.googlesource.com/c/1473406 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#632791}
-
Min Chen authored
Bug: None Change-Id: I9635ede393d0390633b316030b2b0496d361d845 Reviewed-on: https://chromium-review.googlesource.com/c/1474993Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#632790}
-
Danyao Wang authored
This patch uses test_driver.bless() to automate manual tests that need a user activation to trigger .show(). The new automated tests pass on Chrome after this patch. Bug: 929773 Change-Id: Ic220c89db48c12a594ff9f77d091ff952b0c9abc Reviewed-on: https://chromium-review.googlesource.com/c/1474708Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#632789}
-
Oksana Zhuravlova authored
Change-Id: I26ca6eafa573be059dc6aceb63667f5d84b3e832 Reviewed-on: https://chromium-review.googlesource.com/c/1474625Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#632788}
-
Yutaka Hirano authored
The test was leaky when introduced, so it got DISABLED. Making Resource garbage collected solved the leak problem, but another change (probably https://crrev.com/aadbd2624c5003698624cf2e21fd6ae876e28629) broke the test silently. Bug: 340306 Change-Id: I5a5b2e619831fefd1ac9183fed9cff1293768e1c Reviewed-on: https://chromium-review.googlesource.com/c/1474884Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#632787}
-
Peter Collingbourne authored
Bug: 916828 Change-Id: I62582adf66fba07ebda6bda9980925ed515fb9dd Reviewed-on: https://chromium-review.googlesource.com/c/1475169Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#632786}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e1f0d4e639f6..695b68d1009b git log e1f0d4e639f6..695b68d1009b --date=short --no-merges --format='%ad %ae %s' 2019-02-15 cwallez@chromium.org WebGPU error handling 3: CommandEncoder for validation tests Created with: gclient setdep -r src/third_party/dawn@695b68d1009b The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I918187ec7a89ffa7add8d086ce6302839b092103 Reviewed-on: https://chromium-review.googlesource.com/c/1475698Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632785}
-