- 14 Apr, 2020 40 commits
-
-
Sahir Vellani authored
Currently, if physics based fling curve is enabled, even if the fling is boosted, the scroll distance is capped by upper bound which is three times the size of viewport. Thus it nullify the effect of fling boosting and travels the same distance as it would if fling is not boosted. This CL fixes fling boosting with physics based fling curve. It does so by increasing the upper bound every time a fling is boosted. Bug: 647137 Change-Id: Ib2dd51b37df91168ae1f1e8d33888e3b5dc43e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118218Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758878}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1a9188613b21296335597bdadaf6efdc4427a6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149266Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758877}
-
Greg Thompson authored
BUG=933975,1069116 R=etiennep@chromium.org Change-Id: I294eba49176369fe06f541e681b7fee84aba48bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146548 Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758876}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/575e040c7661..decaee5ce9bf git log 575e040c7661..decaee5ce9bf --date=short --first-parent --format='%ad %ae %s' 2020-04-14 changhaohan@chromium.org TextPrompt: skips ")" entry if there is a unmatched "(" Created with: gclient setdep -r src/third_party/devtools-frontend/src@decaee5ce9bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065728 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f824cd9507dc2ecacac6e0cac436ce981961c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149257Reviewed-by:
-
Koji Ishii authored
|NGBoxFragmentPainter| skips painitng if the ink overflow is outside of culled rect, but doesn't apply the optimization to <br> because its ink overflow is empty but selection needs to be painted. This patch restricts it only when the <br> is selected. Note, currently there are 3 code paths that paint <br>: 1. Legacy 2. LayoutNG (NGPaintFragment) 3. LayoutNG (NGFragmentItem, not enabled yet, crbug.com/982194) This patch changes 2 and 3. Bug: 982194 Change-Id: I87a0b21b5dae3e9d04daa71a3366f4b37cdb7268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147439Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758874}
-
Clark DuVall authored
These are now being build on the official builders, so it probably makes sense to enable by default. Bug: 1033098 Change-Id: I04224c174ac3de526cadd26f05fe34fdd77d2ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145821 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#758873}
-
Constantin Manea authored
handling ephemeral profiles As described in https://crbug.com/1064758 the kProfilesLastActive pref list is not explicitly cleared when ephemeral profiles are handled. In some cases this can cause profiles to be created at browser start when they should not be. This change adds safeguards that mitigate against this issue. Bug: 1064758 Change-Id: Ib16f85b2c511a27a5fe618c10bfea1704b8e567f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122917 Commit-Queue: Constantin Manea <comanea@microsoft.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#758872}
-
David Bokan authored
Add a DumpWithoutCrash to KeyPress events where the timestamp of the OS differs from the current time by more than 5 seconds. We see in UMA that we often see events in the 95% percentile reaching many seconds of difference. Hopefully the crash stacks will reveal something about what's causing this. A previous iteration of this investigation in https://crrev.com/c/2111782 showed that we sometimes redispatch events that have been reinjected back from the renderer. This should never happen. This CL adds crash keys to dump some of the related app state to help explain how this happens. However, not all such stack traces showed reinjection so that can't be the cause of all these bad timestamps. This CL also adds some timing information to the existing crash key in NSApp:sendEvent which might reveal something. Bug: 1039833 Change-Id: I90a8bb210debc8e9f0fcfba23a566200de72e9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144627Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6ca7a1bee1ab..38cf748e7a5f git log 6ca7a1bee1ab..38cf748e7a5f --date=short --first-parent --format='%ad %ae %s' 2020-04-14 fmayer@google.com Merge "Use package name for deobfuscation." 2020-04-14 lalitm@google.com Merge "tp: move context to types" 2020-04-14 treehugger-gerrit@google.com Merge "Fix bazel build win: make Subprocess os-conditional via #if" Created with: gclient setdep -r src/third_party/perfetto@38cf748e7a5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iac9c0918f11b1833845b953c5d58ee569d50c865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148932Reviewed-by:
-
Jonathan Metzman authored
Fuzzer is causing flakiness in CQ. It can be added back if build issues are fixed. Bug: 1028212 Change-Id: I45e764e20af1cbc59763cff32f4d379d67b47278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142589Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758869}
-
Bo Liu authored
Add an error if marker file creation failed. Bug: 1065585 Change-Id: Iaa86c52b63111097b675f93bdad95ce706cde3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148840Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758868}
-
Sadrul Chowdhury authored
If a reporter is replaced by a new reporter, but the frame had not produced a frame, then use the timestamp of the 'did not produce' notification as the termination-time to end the trace-event, rather than the time of the replacement. BUG=none Change-Id: I91ad6b9a1b0c31afe5309f89e7f8aaf43121e8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146517 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#758867}
-
Caroline Rising authored
Bug: 1067783 Change-Id: I624d43ee3863272bb4d7bef347b157164e886d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145861Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#758866}
-
Peter Kasting authored
https://chromium-review.googlesource.com/c/chromium/src/+/2079258 deleted third_party/blink/common/origin_policy, but not the public API. Additionally, various OWNERS files were left pointing at a nonexistent file. AFAICT the new canonical home is services/network/origin_policy, so point to that. Bug: none Change-Id: I2f27b9a63083e92c708590955849122fef9ffe00 No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144106Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#758865}
-
Sadrul Habib Chowdhury authored
The member variables should be private, and can be accessed in tests via protected accessors. BUG=none TBR=behdadb@chromium.org Change-Id: I40e19a3d76323800df9b6c2aa45ad27efe1bc31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149275Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#758864}
-
Trent Begin authored
Update cros_healthd telemetry handling code to check for and log errors from TimezoneInfo request. Bug: chromium:1041153 Change-Id: I2319094bd80b478c275ee4ceee35faa9e75263f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145925Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758863}
-
Haiyang Pan authored
Also enable snapshot debugging when "snapshot" option is set for avd create. Plus some minor fixes for root_ini and logging for emulator start Bug: 922145 Change-Id: I6aaebc099ce25e9180efb6a66c097f885b804db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145957Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Juanmi Huertas authored
According to a study done in go/canvas-flaky-spreadsheet-2020 there are some tests that are not flaky anymore. Updating the expectations accordingly. Change-Id: Ib4acb4c200abbe9424af18036232e3f925952836 Bug: 1011060, 990918, 786641, 831496, 922951, 971612, 1061131, 1050306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136858Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#758861}
-
Anastasiia Nikolaienko authored
Bug: 1043108 Change-Id: I069cfb88d15f2c480ca76d2d06b10dcb1c7cbd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130187Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#758860}
-
Antonio Gomes authored
BUG=767015, 1063749 R=svillar@chromium.org Change-Id: I635081a2f98896e52d8f5aa1c95dc1f1d9836f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148072 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#758859}
-
Peter E Conn authored
This CL is a reland of the following CL. It fixes the issues that produced lint warnings. https://chromium-review.googlesource.com/c/chromium/src/+/2120724 TBR=dominickn@chromium.org, twellington@chromium.org, agrieve@chromium.org, yfriedman@chromium.org Bug: 980567 Change-Id: Ia48f18c9f10ce3a2239781d0c97174de4d234d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142251Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#758858}
-
Amr Aboelkher authored
Migrating the supported release branch for DeviceChromeVariations and ChromeVariations into M83, instead of referencing to the defunct M82 release. BYPASS_POLICY_COMPATIBILITY_CHECK=both policies were never used Bug: 1070442 Change-Id: I9f46fc428a0b0968cfc086b5cee5a1ae68fa34a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148312Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#758857}
-
Eugene But authored
This reverts commit 8c860979. Reason for revert: Rohit sees the failures on the internal waterfall. Original change's description: > Revert "Disable testSucessfullDownloadInIncognito on device." > > This reverts commit 0e8c98fa. > > Reason for revert: Download test server performance was improved, > which might have fixed the test. I don't have access to iPad device and won't have for a while, so reverting to see if the test still failing/flaky. > > Original change's description: > > Disable testSucessfullDownloadInIncognito on device. > > > > Bug: 1059320 > > Change-Id: Ib14a8dd209e277d01b7d2769b2b7ff6da5169f7e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091937 > > Auto-Submit: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Sergio Collazos <sczs@chromium.org> > > Commit-Queue: Sergio Collazos <sczs@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#747837} > > TBR=eugenebut@chromium.org,sczs@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1059320 > Change-Id: I47716dd36214b3e2204ab2a4e1400f1b246b9310 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148168 > Auto-Submit: Eugene But <eugenebut@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758806} TBR=eugenebut@chromium.org,sczs@chromium.org Change-Id: Ic91761c6dfa9ea731ea87dd93d7195edc7581160 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148964Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#758856}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fe1175d9. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 2f3bb77d "[device-orientation] Upstream web tests to WPT" d53acfce "[css-grid] Migrate positioned-grid-items-crash.html to WPT" 03a85d57 "[client hints]: Properly apply persisted accept-CH policy in 3P context" f064e48f "Make will-change: backdrop-filter a containing block for fixed and abs" c21ee9b0 "[css-masking] Migrate clip-path-descendant-text-mutated.html to WPT" 8ab053d0 "[css-flexbox] Move stretch-table-child.html test to WPT" b99c852b "[css-grid] Migrate flex-and-minmax-content-resolution-rows to WPT" 2b980e38 "Add regression test for https://crbug.com/1064676" 304e175c "[css-masking] Migrate clip-path-reference-nonexisting-existing-local.html to WPT" fe1175d9 "[css-grid] Migrate compute-intrinsic-widths-scrollbar.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I69c4584d600fd879e900b03623b401f9b6bfb035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147957Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758855}
-
Alexandre Courbot authored
C++ aggregate initializers will only initializer the first member of a union, which in the case of v4l2_format leaves a lot of data uninitialized. Fix this by initializing it with memset(). BUG=chromium:1068447 BUG=b:153935975 TEST=VDAtest passes on nyan_kitty. Change-Id: I7138b49780a9845ea924be00f11ccaa7a6904f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147399Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#758854}
-
Rayan Kanso authored
https://github.com/WICG/content-index/issues/21 Change-Id: I829db49bc39ae49288c198f4080e334c226c33f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144077Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#758853}
-
Thomas Lukaszewicz authored
Interactive Widget tests now use WidgetAutoclosePtr where applicable. Bug: None Change-Id: Ibf3e904585b1f25817e5e51a7a5d9e743679193a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148123 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#758852}
-
Mike West authored
We previously required `CSPRO` headers to contain `report-uri`. Since we added a DOM interface (`SecurityPolicyViolation` events and Reporting API integration), that requirement is no longer applied. We still surface a warning, but that's more verbose than it needs to be, given that the use case it warns about is completely legitimate. Bug: 1070533 Change-Id: Ica89fa0c8d53d563c6510426e2f6f11d2e7400c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145881 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758851}
-
Hans Wennborg authored
This is a reland of c195e902 with a higher token limit in check_op.cc to accommodate release component dcheck_always_on=true builds on Linux (see crbug.com/1069971). It also addresses some post-commit comments on the original CL. Original change's description: > [base] Move the CHECK and CHECK_op macros to more light-weight headers > > This provides cheaper (in terms of compile time) alternatives for code > that just wants to do a few simple CHECKs without pulling in the full > weight of logging.h. On Linux, the preprocessed size of check.h and > check_op.h are 2% and 62% of logging.h, respectively. > > Splitting the CHECK and CHECK_op macros out to separate files also > reduces the complexity of logging.h which has become very complicated. > > As a bonus, the new implementation is leaner, causing a 3% local > compile-time reduction for the chrome target on Linux even though no > includes have been changed yet. > > Bug: 1031540 > Change-Id: If7aca321f077110bea0907e487d2e8d29a8c50fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128112 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758287} Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Bug: 1031540 Change-Id: Ie524997796b90bea593c1a5f04be5ae0c89f8954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144180 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#758850}
-
Aaron Leventhal authored
Bug: 1065122 Change-Id: I2d73a5d5d1e9ed59f26afe10fcce421572ca7fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147813Reviewed-by:
-
edchin authored
This CL adds eg2 tests for changes in crrev.com/c/2140953. The test fixture in this CL must enable certain command-line flags to be able to run the managed bookmarks enterprise policy. The eg2 tests for managed bookmarks include testing: - disabling long-press for managed items (URLs and folders) - disabling swipe-to-delete for managed items (URLs and folders) - disabling new folder context menu button when inside a managed folder - disabling edit context menu button when inside a managed folder Bug: 1065187 Change-Id: Ide92b87f03585d186b133f192d1e39a4fbbaa1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145260Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758848}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/603aaa5f..a0ab3490 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I49c3231c5bdaf6c071d0fb71fbad5e892937c1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147958Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758847}
-
Antonio Gomes authored
BUG=767015,1063749 R=jfernandez@igalia.com Change-Id: I810770fc14973b41e6560eff55da0e26fc3d1f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145639 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2d2c2947fd50..39fb817efdce git log 2d2c2947fd50..39fb817efdce --date=short --first-parent --format='%ad %ae %s' 2020-04-14 ilnik@webrtc.org [Video, Svc] Remove inactive spatial layers in codec initializer 2020-04-14 mbonadei@webrtc.org Remove OpenSSLIdentity::GenerateWithExpiration. Created with: gclient setdep -r src/third_party/webrtc@39fb817efdce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2ed25d5977161b999614ac363abae8045e95672b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148725Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad653d8378d7..871d40b74c63 git log ad653d8378d7..871d40b74c63 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 westont@google.com [infra] Add Debian9 docker image. Created with: gclient setdep -r src/third_party/skia@871d40b74c63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I385e75fb26bd1d032b50d30d584bf1d49424245e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148727Reviewed-by:
-
Brian Liu Xu authored
Updates PopulateAccessibilityData() in |TreeView| to ensure it does not lookup row/depth information for nodes inside collapsed subtrees via GetRowForInternalNode(). Previously, the check only worked when the node's immediate parent was collapsed. This changelist expands it to examine ancestors as well. PopulateAccessibilityData() can happen when assistive technologies attempt to retrieve property information for arbitrary tree items inside |TreeView| subtrees. Previously, this would lead to a DCHECK failure during row/depth lookup at GetRowForInternalNode(). Bug: 811277 Change-Id: I83e1a127adfcf24dac7a3a9643a659b42a198cff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146134 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
Thomas Tellier authored
This reverts commit c7743509. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1052316#c19 Original change's description: > Show enterprise disclosure as a bottom status indicator in login/lock screen > > Bug: 1015746 > Change-Id: I995eb65b7f99f47a9f2ec5bd33798ee74fb78699 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929813 > Commit-Queue: Thomas Tellier <tellier@google.com> > Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718850} TBR=xiyuan@chromium.org,rsorokin@chromium.org,raleksandrov@google.com,tellier@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015746 Change-Id: I2694ddd0eb17d23d47789e3910d974b6ab8bf542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148737Reviewed-by:
Thomas Tellier <tellier@google.com> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#758842}
-
Antonio Gomes authored
This CL moves column-property-should-not-apply-on-grid-container.html from fast/css-grid-layout/ to external/wpt/css/css-grid/grid-model/. It also adds links and references to the related spec, and expected behavior. Last, it removes the uses of -webkit-column-* and -moz-column-* in favor of their respective column-* counterparts. Relevant spec change: https://github.com/w3c/csswg-drafts/issues/1364 ([css-multicol-1][css-flexbox-1][css-grid-1] Clarify that column-* properties only apply to block containers). BUG=767015, 1063749 R=dgrogan@chromium.org Change-Id: I1a5b27a863be4f7b10ffda4e65ed52050dbf0f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144720 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
-
Xianzhu Wang authored
This avoids a copy of viz::BeginFrameArgs for the argument. sizeof(viz::BeginFrameArgs) is 56 on LP64 systems. Change-Id: I2d0c99ae490824563907cdfbe86b5196f3015936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146784 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758840}
-
Randy Rossi authored
Chromecast should focus on the full screen shell surface node that holds the child tree for the UI. Otherwise, things like live regions will fail to find a focused root node and will not work. Bug: NONE Test: Local chromecast build Change-Id: I5b34eb40fd3c7240b8584fc83bf312727f9e2658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134568Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#758839}
-
