GitLab

invocation

In the current implementation, we assumed that whenever callback is invoked,
there must be at least one records needing to assign swap time to itself.
However, this ignored the possibily that nodes may be deleted between a callback
is registered and invoked.

Because the assumption is violated, we should remove the dcheck.

Bug: 869924
Change-Id: Ifdfda96fd2260f85add1c2a78ad48cff22cd0dbf
Reviewed-on: https://chromium-review.googlesource.com/c/1340966
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609388}

A previous patch inadvertantly changed the code to return the set of
PhishingClassifierDelegates by value.  This lead to a crash because
all modifications to the set where only applied to the local copy,
and when PhishingClassifierDelegate::SetPhishingScorer got called,
pending classifications (which stashed a raw pointer to the deleted
data) where not cancelled.

Bug: 905598
Change-Id: Id629c460b1fba66605565b8f17b6bd1d1fc6cf33
Reviewed-on: https://chromium-review.googlesource.com/c/1341520
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609387}

Bug: 846033
Change-Id: I2b1892437d44edd47245addd1c14901dad6f0d4b
Reviewed-on: https://chromium-review.googlesource.com/c/1342803
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609386}

This change ensures that all English locale pak files (i.e.
en-US.pak and en-GB.pak) are stored inside an app bundle into
a directory named:

  assets/fallback-locales/

This ensures that said .pak files are always stored in the base
module split APK, and thus available on all Chrome installs, after
any system locale change.

This prevents Chrome from crashing on startup under rare
circumstances (see related bug for details).

Testing was performed manually because we don't have a good regression
test suite that can change the device's system locale programmatically
(see http://crbug.com/904360 for this). Following these steps:

1) Set device's language to Spanish
2) Ensure Chrome is not installed, then install the bundle.
3) Start Chrome. It displays its UI in Spanish.
4) Change system language to Slovenčina, and *remove* Spanish from
   the list of system languages.
5) Start Chrome. It displays its UI in English (the fallback)
   instead of crashing.

English is chosen because it is the fallback language that the Android
framework actually choses when the application doesn't have any
resources compatible with the current system language.

BUG=905725
R=agrieve@chromium.org,estevenson@chromium.org,yfriedman@chromium.org,tiborg@chromium.org,tedchoc@chromium.org

Change-Id: I2c1f53a805122b6e48fb5105c1d9aa8c6262fa1d
Reviewed-on: https://chromium-review.googlesource.com/c/1340303Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609385}

https://chromium.googlesource.com/angle/angle.git/+log/774fe563c663..8a0fb48a56d6


git log 774fe563c663..8a0fb48a56d6 --date=short --no-merges --format='%ad %ae %s'
2018-11-19 jmadill@chromium.org Vulkan: Suppress functional.shaders.invariance.* on NV.


Created with:
  gclient setdep -r src/third_party/angle@8a0fb48a56d6

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I82113145611980e17062a58edf73a970db75077c
Reviewed-on: https://chromium-review.googlesource.com/c/1342777Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609384}

Currently when a frame is evicted, we immediately generate a new
viz::LocalSurfaceId. This has been inflating our statistics for
embedding times.

This is a side-effect of how Window::UpdateLocalSurfaceIdFromEmbeddedClient
uses null LocalSurfaceIds to represent generate a new one. This change
adds a new InvalidateLocalSurfaceId for use during Frame Eviction.

RenderWidgetHostViewAura has also been updated to verify if the current
LocalSurfaceId is valid when beginning to show a currently evicted frame.
So that it can allocate a new one.

Bug: 655231
Change-Id: Iafb81333dfeb230311ef5ce19b81aa0d96d05061
Reviewed-on: https://chromium-review.googlesource.com/c/1336438Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609383}

This is a follow-up CL from the comments at:
https://chromium-review.googlesource.com/c/chromium/src/+/1274585/11

This CL uses ifdef "using" decl to use web::TestWebThreadBundle on iOS as
the equivalent to content::TestBrowserThreadBundle.

Bug: 898307
Change-Id: I35620aade68dc2b6e9855be49afabd5fcd6dfd5d
Reviewed-on: https://chromium-review.googlesource.com/c/1313450Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609382}

Also updated frame_imple_browsertest.cc not to use deprecated version
of set_error_handler().

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=fdegans@chromium.org

Change-Id: Iccba408e0080b9fb70edcd6b64c51737bf8f4851
Reviewed-on: https://chromium-review.googlesource.com/c/1342599
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609381}

Change-Id: I7db9d09d2ccf6cfa8ba11302464a6fb316aff79b
Reviewed-on: https://chromium-review.googlesource.com/c/1342767Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609380}

This CL is 1) a reland of r604955 + 2) fixes.  Original CL description
follows below.

Summary
=======

This CL makes layout tests use the default site isolation from the
platform they are run on (instead of opting out of strict site isolation
via LayoutTestContentBrowserClient::ShouldEnableStrictSiteIsolation).
Additionally, on platforms where strict site isolation is enabled,
layout tests opt into slightly stricter isolation by enabling isolation
of same-site origins used by Web Platform Tests - this ensures that
features covered by WPT also get sufficient coverage of out-of-process
iframes (OOPIFs).

After this CL, expectations for tests that differ in behavior with and
without OOPIFs are being moved from
LayoutTests/FlagExpectations/site-per-process to:
- LayoutTests/VirtualTestSuites (virtual/not-site-per-process suite)
- LayoutTests/virtual/not-site-per-process/README.md
- LayoutTests/TestExpectations and LayoutTests/NeverFixTests
  ("Site Isolation failures" section)


Desirability
============

The CL helps with the following:

- Focusing on testing the mode that is actually shipped to end users
- Helping ensure that newly developed features get site-per-process
  coverage without having to set up a separate step (i.e. it is
  sufficient to set-up a bot that runs layout tests with
  --enable-features=NewFeature without also having to have a separate
  test step for runing layout tests with *both*
  --enable-features=NewFeature *and* --site-per-process

This CL does *not* help with reducing requirements for CQ capacity,
because we need to maintain a separate
not_site_per_process_webkit_layout_tests step to make sure that tests
pass without isolation (which is the mode Chrome ships on Android).
Also note that layout test coverage on Android is very sparse - see
https://groups.google.com/a/chromium.org/d/topic/blink-dev/SOXhTYysYkE/discussion


Preserving test coverage
========================

Most tests
----------

The CL preserves covering most layout tests with and without OOPIFs, by
relying on the fact that CQ/waterfall run layout tests on both kinds of
platforms - ones that default to strict site isolation (desktop
platforms) and ones that default to no site isolation (Android).


Tests that used to be excluded FlagExpectations/site-per-process
----------------------------------------------------------------

Around 40 tests fail when run in presence of OOPIFs.  Such tests are
disabled by this CL by moving test expectations from
FlagExpectations/site-per-process into the main TestExpectations file.
The CL preserves non-OOPIF test coverage provided by the disabled tests
by introducing virtual/not-site-per-process directory which runs all
such tests with site isolation disabled.  Using a virtual test suites
for preserving the test coverage relies on the ability to have separate
test expectations for these tests (i.e. relying on the fact that
disabling these tests in TestExpectations doesn't disable their
virtual/not-site-per-process equivalents).

Note that the CL keeps isolating "oopif.test" site even in
virtual/not-site-per-process suite.  This site should only be used by
tests that require an OOPIF.


Preserving site-per-process-specific test expectations
------------------------------------------------------

Some tests have site-per-process-specific expectations:
- http/tests/inspector-protocol/network/security-info-on-response.js
- http/tests/inspector-protocol/network/raw-headers-for-protected-document.js

The tests above highlight that cross-origin cookies are not displayed in
site-per-process mode (a known regression tracked by
https://crbug.com/849483).  This CL preserves expectations and coverage
by shuffling things around:
- old, main expectation -> android expectation
- old, site-per-process expectation -> main expectation


There is one additional test with site-per-process-specific
expectations:
- external/wpt/dom/events/EventListener-addEventListener.sub.window.js

Unlike the other 2 tests, it seems less important to preserve exact test
expectations for the case when the test fails with Site Isolation.
Therefore this test is covered by virtual/not-site-per-process test
suite and an expectation for this test is added to the main
TestExpectations.


Lost test coverage
------------------

Even with extra caution described above, some test coverage may be lost:

- Features covered by tests only on one kind of platform (e.g. disabled
  on Android) are at risk of losing OOPIF or non-OOPIF coverage.

- Before this CL, site-per-process was also applied to all other
  `virtual/...` test suites.  After this CL,
  `virtual/not-site-per-process` will not provide such coverage.


Cleaned up test expectations
----------------------------

Some additional test expectations clean-up is done, while preserving
test coverage:

- The http/tests/perf/large-inlined-script.html test has been already
  present in `SlowTests` and therefore I didn't include this test in the
  new `virtual/not-site-per-process` suite.

- The http/tests/devtools/network/network-datareceived.js test was
  already marked as expecting a `[Failure]` in TestExpectations and
  therefore I didn't include this test in the new
  `virtual/not-site-per-process` suite.

- The http/tests/devtools/console-cross-origin-iframe-logging.js test
  was already marked as `[Timeout]` in the old TestExpectations but for
  Win only.  Since I can repro a timeout on Linux (with and without site
  isolation), I just extended the old expectation to all platforms and I
  didn't include this test in the new `virtual/not-site-per-process`
  suite.  I also removed the test from SlowTests (since timeouts in the
  test are not expected everywhere).


Bug: 870761, 477150
Tbr: alexmos@chromium.org
Change-Id: If3c6fbc58ccdac8bc64a81963238db13c0bff391
Reviewed-on: https://chromium-review.googlesource.com/c/1318750
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609379}

This crash was occurring because we added an element to the scroll chain
that didn't have a ScrollableArea. This occurs on an iframe because we
promote the iframe to be the effective root scroller (due to it filling
the viewport). However, iframe elements don't have a ScrollableArea so
this would crash when we bubble a logical scroll.

The condition for always adding the root scroller is incorrect. We want
to always add the _global_ root scroller, not the effective. The global
is where the apply scroll callback is registered which is what correctly
does pinch-zoom panning and overscroll glow. The global root scroller is
guaranteed to always have a ScrollableArea.

Bug: 904247
Change-Id: I14080a74ff3aa5a85347076e74edbc53b2fb9cfc
Reviewed-on: https://chromium-review.googlesource.com/c/1340610Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609378}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a58355c49753..dac70cc74650


git log a58355c49753..dac70cc74650 --date=short --no-merges --format='%ad %ae %s'
2018-11-19 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@dac70cc74650

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I6431c9dea1f733127e0082d062d4f41a3a7718cf
Reviewed-on: https://chromium-review.googlesource.com/c/1342479Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609377}

https://skia.googlesource.com/skia.git/+log/f7376330d11e..a1211832046d


git log f7376330d11e..a1211832046d --date=short --no-merges --format='%ad %ae %s'
2018-11-19 halcanary@google.com SkPDF: move image serialization over to new immediate mode.
2018-11-19 mtklein@google.com clean up SkBitmapProcState a bit
2018-11-19 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-11-19 bsalomon@google.com When outsetting for rect blur fast path use abs of scale factors.
2018-11-19 bsalomon@google.com Add single thread assertions to GrResourceCache functions called by GrGpuResource
2018-11-19 jvanverth@google.com Reland "Remove use of integers for atlas indexing"
2018-11-19 brianosman@google.com Use GrVertexWriter in GrDashOp
2018-11-19 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@a1211832046d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:899512
TBR=csmartdalton@chromium.org

Change-Id: I076eaa7f924b584032ac32413163876a28cfb9ac
Reviewed-on: https://chromium-review.googlesource.com/c/1342009Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609376}

We haven’t supported macOS 10.6 in years.

BUG=none

Change-Id: Ie19b16d0b2417f292b8c763ceeb412e73bdaa95f
Reviewed-on: https://chromium-review.googlesource.com/c/1342799Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609375}

This allows us to use the hashes as value types with convenient
assignment and comparison operators.

Also add myself as owner of the third_party_dlls subdirectory as
pennymac@chromium.org no longer works on Chrome.

Change-Id: I66838fd4890637bf53faa22fbcbbfcae6456b583
Reviewed-on: https://chromium-review.googlesource.com/c/1340967Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609374}

Changed addresses_ to an Optional and added additional optional fields
for text results (eg for TXT records) and hostname results (eg for SRV
or PTR records). Deliberately avoided assumptions that only one result
field could be non-nullopt at at time (but no constructor currently
allows creating it) because there's nothing wrong with some query
having results of multiple types. Eg, we may in the future choose to
pull cannonname out of AddressList and set it as a hostname result.

A subsequent CL will alter HostResolverImpl to allow querying, caching,
and returning non-address types, and it will also use HostCache::Entry
internally (and only internally) as a results container. For now, in
this CL, most of the code dealing with HostCache results will just
assume Entry::addresses() always has a value.

Bug: 846423
Change-Id: I62e177452bf89e5931f75a74448f9de70b7f2357
Reviewed-on: https://chromium-review.googlesource.com/c/1331143
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609373}

BUG=756085,875111
TEST=covered by test

Change-Id: Idc65b7ca5b340401855694f1f123402612b73003
Reviewed-on: https://chromium-review.googlesource.com/c/1341021
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609372}

Disable tests on all platforms as it causes flaky test failures.

TBR=yosin@chromium.org

Bug: 906591
Change-Id: I505ed183094dbd662005f4ea903dbd2d6e03d9ee
Reviewed-on: https://chromium-review.googlesource.com/c/1342798Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609371}

Internal link to UX mocks: http://shortn/_x5YgxIQutq

Bug: 883486
Change-Id: If8c6026231c4d1e0da72832c834d727f125a543d
Reviewed-on: https://chromium-review.googlesource.com/c/1323902
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609370}

This reverts commit 1f29016e.
The original CL was found not to be the culprit for the test failure.

TBR=jdufault@chromium.org

Bug: 905436
Change-Id: I750baa17c1d27a2940c3ed050c3f274fc4e8226c
Reviewed-on: https://chromium-review.googlesource.com/c/1342762Reviewed-by: Quan Nguyen <qnnguyen@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609369}

Bug: 905524
Change-Id: I882f6c0f2acae848c8089eb7241dc4023366cf82
Reviewed-on: https://chromium-review.googlesource.com/c/1341147
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609368}

Changes:
Fix the crash by doing early return when no root window exists for the
specified display.

Bug: 903293
Test: AppListPresenterDelegateTest.ShowInInvalidDisplay
Change-Id: I866f07e037c269851ab6c72fff622a0c7c27a4ac
Reviewed-on: https://chromium-review.googlesource.com/c/1341000
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609367}

If is_java_debug is set to false the JNI generator and
JNI annotation processor will hash/obfuscate native method
declarations to save binary size.

Change-Id: Ic083a7fe6564665ed0ffa0a5e508b9d75697f6b3
Reviewed-on: https://chromium-review.googlesource.com/c/1318394
Commit-Queue: Aiden Benner <abenner@google.com>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609366}

This will be used in ChromeCast to override window token used by
content/public/android/java/src/org/chromium/content/browser/androidoverlay.

Bug: None.
Change-Id: Ibc5a97c24acfad1d8ab8aef69ec8b821abc71854
Reviewed-on: https://chromium-review.googlesource.com/c/1333727
Commit-Queue: Jan Lamecki <jachor@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609365}

This reproduces the same login in PasswordFormManager. As soon as a change
in PasswordStore happens we need to inform all form managers about it in
order to avoid strange behaviours - for example show save prompt when the
credentials were already saved.

Bug: 831123
Change-Id: Ie49d05e0fbea5d4dbe824220362d30a43e16809d
Reviewed-on: https://chromium-review.googlesource.com/c/1341917Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609364}

As part of this CL, we move LockScreen control and user account functions into
LoginTestBase and make LoginKeyboardTestBase a subclass. In the future, test
fixtures with new login-related functionality can inherit from LoginTestBase.

Bug: 809330
Change-Id: I0d082a60e667fec7fd391984de6469ead5d57e77
Reviewed-on: https://chromium-review.googlesource.com/c/1338476Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609363}

[TaskScheduler]: Migrate off of AssertBlockingAllowedDeprecated in /services/device/time_zone_monitor

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=mark@chromium.org

Bug: 903957
Change-Id: I2be2db1919ad6f58b47a8e66e47fa7a138684d87
Reviewed-on: https://chromium-review.googlesource.com/c/1338490
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609362}

Bug: 900755
Change-Id: Ie4bc5f815fe698594de99fde68517ccb0bd6a105
Reviewed-on: https://chromium-review.googlesource.com/c/1340608
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609361}

Bug: 905524
Change-Id: I69d4993ff2551a9aa76ef38494e10f4488d8a611
Reviewed-on: https://chromium-review.googlesource.com/c/1340912
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609360}

Now if the new parsing is on PasswordManager doesn't update
PasswordFormManagers. That's wrong since they are used for saving and
for comparing with NewPasswordFormManagers. This CL fixes that.

Bug: 906253, 831123
Change-Id: I35e16993126699d86e89e2ab6519b7be335f3e04
Reviewed-on: https://chromium-review.googlesource.com/c/1341990
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609359}

https://webrtc.googlesource.com/src.git/+log/2058d52d475c..3a83748422c9


git log 2058d52d475c..3a83748422c9 --date=short --no-merges --format='%ad %ae %s'
2018-11-19 crodbro@webrtc.org New loss-based bandwidth control mechanism.
2018-11-19 nisse@webrtc.org Replace RTC_DCHECK by RTC_DCHECK_RUN_ON for worker thread.


Created with:
  gclient setdep -r src/third_party/webrtc@3a83748422c9

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:none
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: If629ccb163bcc421358cc341e885d8f50d4e1e47
Reviewed-on: https://chromium-review.googlesource.com/c/1342437Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609358}

This reverts commit e73c82bc.

Reason for revert: source problem looks fixed.

Original change's description:
> Suppress failling WebGL test on Linux Nvidia
> 
> WebglConformance_conformance2_context_methods_2 is failing sometimes on Linux Nvidia with
> a GPU crash. Mark the test as flaky.
> 
> BUG=906212
> TBR=kbr@chromium.org
> 
> Change-Id: I86bea7e01fde6b26b25d7fa27c8a9f41e5be9df7
> Reviewed-on: https://chromium-review.googlesource.com/c/1340948
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609037}

TBR=rjkroege@chromium.org,kbr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 906212, 905519
Change-Id: Ie5918918c972ac81fd0d48e9ac285c0a705a91d8
Reviewed-on: https://chromium-review.googlesource.com/c/1342500Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609357}

This ensures that the layout of notifications is kept as intended.

Bug: 901045
Change-Id: I0dcc92464a5751cd61ff7552824c57798aa73661
Reviewed-on: https://chromium-review.googlesource.com/c/1320169
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609356}

[sheriff] Disable GoogleServicesSettingsTestCase.testActivityAndInteractionsDisabledWithHistoryDisabled on simulators.

The test is failing continually on simulators.

TBR=sczs@chromium.org

Change-Id: I4c44bf44a04fd99e7545f974d9db5d1e64a96a63
Reviewed-on: https://chromium-review.googlesource.com/c/1342558
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609355}

This simplifies the test harness and makes the test pass with
single process Mash (due to extra setup performed by the parent test
fixture).

Bug: 905430
Change-Id: Ic68c5900bc7632dc9177e730706007fb4e3eab39
Reviewed-on: https://chromium-review.googlesource.com/c/1340949Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609354}

Reduce the sending rate of QUIC BBR as the connection observes more packets lost.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_startup_rate_reduction.

Merge internal cls: 218417489 and 220238389

R=rch@chromium.org

Change-Id: I246bc6894f4c67cf6b86a759905a720222453277
Reviewed-on: https://chromium-review.googlesource.com/c/1335878
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609353}

In an upcoming change, I split the GuardedPageAllocator into two
objects. I'm moving these methods into the GuardedPageAllocator because
SlotMetadata lives in the base object but these methods should not.

Bug: 896019
Change-Id: Ia98e966ce6cc8aa843bcaa4ce322c1b355e508a1
Reviewed-on: https://chromium-review.googlesource.com/c/1341062
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609352}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfb70dcb5696..be3e8ee6b10b


Created with:
  gclient setdep -r src-internal@be3e8ee6b10b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I9a097fa74656d01d14777c53e34bfeec67806b76
Reviewed-on: https://chromium-review.googlesource.com/c/1342477Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609351}

Bug: 905524
Change-Id: I883868f373b39fcbcb39b63869e19ff1532369b6
Reviewed-on: https://chromium-review.googlesource.com/c/1340527
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609350}

Bug: 901563
Test:
 - SadTab is correctly presented for renderer crashes and chrome://crash
 - SadTab support pull to action
 - SadTab show different help text for incognito
 - SadTab bottons and links work as expected (reload, help page,
   feedback)
 - SadTab is correctly displayed in TabGrid and during SideSwipe
 - The user can switch between tabs and that does not break SadTab UI

Change-Id: I68a7a972a97375f4aff084aa83095a736c8e3b41
Reviewed-on: https://chromium-review.googlesource.com/c/1332775
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609349}