- 05 Jun, 2019 40 commits
-
-
Lucas Tenório authored
In this change we are simply listening for the ARC app instance connection status and reporting it back to Kiosk Next Home. This is similar to a different approach we tried in the past: https://chromium-review.googlesource.com/c/chromium/src/+/1570287 But in this change we are not making major changes to the GetAndroidId method implementation. Bug: 959326 Change-Id: I0827ac588a4eb62b4b9b5dc9902a5e75a8b22db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643928Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#666508}
-
Sharon Yang authored
logging::LogMessage has a special-case to write LOG_ERROR messages to stderr, even if LOG_TO_STDERR is not enabled, to make ERROR and FATAL messages more visible, especially in tests. Restrict this behaviour to apply only if LOG_TO_FILE is set, so that binaries which only LOG_TO_SYSTEM_DEBUG_LOG will never emit logspam to stderr. Tested by adding a unit test for this case. Bug: 968387 Change-Id: Icfe094e7d7bf9697a70a589eab48edbe79c36091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638782 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#666507}
-
Xianzhu Wang authored
Use physical coordinates in HitTestLocation, HitTestResult, and let hit test functions use and produce physical coordinates. This doesn't change PositionForPoint. This CL temporarily flips the hit test result for PositionForPoint in legacy layout to meet the current requirements. Change-Id: I8675745483926116990ffa9fbd17b97ef9c8a392 Bug: 969383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626656 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#666506}
-
Akihiro Ota authored
This reverts commit 718c6717. Reason for revert: Causing some full-screen videos to vibrate constantly in WebView. This is likely because the event for slider value changes was changed from a Scrolled event to a Selected event. Original change's description: > Android: Fix talkback silence when changing slider value > > Previously, Talkback would not report the new value of a slider > when adjusted; in order to hear Talkback report the new value, user > had to un-focus and re-focus the slider. Changed the AccessibilityEvent > that is fired when detecting a slider value-change from > TYPE_VIEW_SCROLLED to TYPE_VIEW_SELECTED, which triggers Talkback to > report value of the focused item. This mimics Talkback behavior > of native Android sliders. > > Bug: 836554 > Change-Id: I4bb3bfafdb4d077f80e1ba4f3c9eecf8a7536497 > Reviewed-on: https://chromium-review.googlesource.com/c/1308978 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604021} TBR=dmazzoni@chromium.org,akihiroota@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836554 Change-Id: I0c64141654c084318cf0a45e8d551fdadd746cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643235Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#666505}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/01927c1c5000..b933eedeb03d git log 01927c1c5000..b933eedeb03d --date=short --no-merges --format='%ad %ae %s' 2019-06-05 cjmcdonald@chromium.org chromeos_config: Add APAC reviewers to config OWNERS Created with: gclient setdep -r src/third_party/chromite@b933eedeb03d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ib2b86059dc80efaf951963f8ccd0276fc30c16a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666504}
-
Kinuko Yasuda authored
It looks it's only used by the browser-side code now. Bug: N/A Change-Id: Id045ce703c71e38a381d246e24eeb6e4a0ae3e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644953 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#666503}
-
Olivier Yiptong authored
These features are no longer part of the spec. This code removes their implementation. Bug: 968552 Change-Id: I089254cac5ebc52a989194c69236497d347260d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643892 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#666502}
-
Nick Diego Yamane authored
Remove unused header includes in settings_provider{_gtk}.h No behavioral changes. Change-Id: I0d43f3c7240ef00d03accd015ee7518b2428c67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646074 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#666501}
-
Collin Baker authored
This implements basic session restore functionality for tab groups. Currently, only whole browser session restore is supported; restoring a window or a tab from the history menu won't restore groups. Bug: 905491 Change-Id: Ib6ad643c7efd75f468bb518fa5881b17a3d9f05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627947Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#666500}
-
Caroline Rising authored
This change considers 'scrubbed' to mean a tab that is activated for <= 1.5 seconds before the user navigates away. We are making the assumption that when a tab is 'scrubbed' it is likely that the user did not navigate to that tab to use it. The goal is to see this metric go down with use of the tab hover cards feature. This would show that tab hover cards help users find the tab they are looking for without having to activate as many tabs as they would have without the feature. Bug: 910739 Change-Id: Ia00b0e5ec4ce0969bd8807ac1564fceed0682651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636346 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#666499}
-
Eric Willigers authored
Add ericwilligers and raymes as owners for Android implementation of WebShare. Bug: 903010 Change-Id: I18ed73dcd0b6178cb80817c512fff4f9b3b02c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645375Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#666498}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4a00a80c4048..08cc49ec59c3 git log 4a00a80c4048..08cc49ec59c3 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 afdx@google.com Fix bug in 'split blocks', and add tests for fuzzer. (#2658) 2019-06-05 dneto@google.com Optimizer: Handle array type with OpSpecConstantOp length (#2652) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@08cc49ec59c3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I2b6497a61bb2fe36ee17c645976c2eb8676c24b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646892Reviewed-by:
-
Suman Nelson Kancherla authored
The above string has been changed when it was moved between files. Because of this, it became an new untranslated string on translation console. Restoring it would bring back the translations, avoiding a time-consuming translation cycle. Bug: 971444 Change-Id: I64467c5c1d2d2a72ffae13c43f3317a48d8926f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646643Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#666496}
-
Xianzhu Wang authored
For benign differences about - Font anti-aliasing - Filter gradient - Layer tree Bug: 524134, 832928, 932429 Change-Id: Ib1a87ca64dfee881a9ce9dee3501e4cdee789c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645973Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#666495}
-
Tomasz Wiszkowski authored
This change introduces the following histograms: - Omnibox.RichEntityShown - number of rich entities shown at the time user navigates anywhere, and - Omnibox.SuggestionUsed.RichEntity - boolean value indicating, whether used suggestion is an Entity suggestion. Bug: 960467 Change-Id: Iaca9bb4af8dbc4af50d1852eb34142f67f82025b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639438 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#666494}
-
David Bokan authored
This method is used to scroll and zoom an editable element into view and to a legible scale. This generally happens on Android where the on-screen keyboard appears and the input box is zoomed into the viewport. The linked bug occurs because we try to zoom the input box while it has a selection (e.g Ctrl-A the text) rather than a blinking caret. This method would then receive an empty rect for the caret_rect which would cause us to zoom into the maximum possible scale. The fix here is to fallback to the selection rect if there is no carret. Bug: 968638 Change-Id: I980183bf9843192e694579cf2af4af816b78a090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642248Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#666493}
-
Sky Malice authored
Bug: 968611 Change-Id: I1816950bef9db9b6b85203035cf62fc708f7e467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644012 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#666492}
-
Marijn Kruisselbrink authored
Also update all references to it, and get rid of some other (partial) copies of the file as well. Tbr: ccameron@chromium.org Bug: none Change-Id: I22f5e59d9d5206a71ffcccb7b9c2a6447bb8dbd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639659 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Peter Kasting authored
* Use ?: * NULL -> nullptr * Inline cheap accesses * Remove unnecessary {} * StringPrintf() -> NumberToString() (faster, will handle size_t more easily) * Init members at declaration * Don't alias * Be consistent about prefix ++ * Rewrap * Spaces around operators * Use find_if() where appropriate * Use range-based for * No || on expressions * Replace indexes with iterators (allows down-counting loops to convert to size_t more safely) * One DCHECK per condition Bug: none Change-Id: If9ab39a1b976217257283bf69857ba71127cdff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637940Reviewed-by:Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#666490}
-
Owen Min authored
DefaultBrowserSettingEnabled is only supported on Windows 7. Update the adm/admx templates' "Supported on" field to "Microsoft Windows 7". Adding a new option named 'chrome.win7' for the supported_on field in policy_templates.json. It is treated as Windows platform with an additional flag during template parsing. And this flag will change the text for the Policy. Bug: 900206 Change-Id: Iac8dace3c4f2d88d45ce27478432b992eb177cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644032 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#666489}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6788784ac192..d71ff5db15ed git log 6788784ac192..d71ff5db15ed --date=short --no-merges --format='%ad %ae %s' 2019-06-05 rmhasan@google.com [Telemetry] Add isatty implementation to _LoggingOutputStream Created with: gclient setdep -r src/third_party/catapult@d71ff5db15ed The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:970335 TBR=skyostil@google.com Change-Id: If1c7b973e82ede274d950ab1c6cc9a5f1915d6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646893Reviewed-by:
-
Christopher Thompson authored
The old Security.TimeOnPage histogram was not correctly calculating the time spent on the page. This CL updates the description to clarify what it actually measured (as the old and replacement histograms shouldn't have identical descriptions). Bug: 949370 Change-Id: Ib6497d58780e5e342fa796dd594e73ae1934179f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642225 Auto-Submit: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
-
Matthew Webb authored
PinAuth calls the static method MakePinAuth, which does not modify and does not need to copy the base::spans it takes. This CL makes PinAuth const correct and passes everything by const-ref. This change was also made in, but is unrelated to, crrev.com/c/1636723 so I brought it out to another CL. Change-Id: I48c4cd470e667766fd544774746de4ed04b9f99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642238 Commit-Queue: Matthew Webb <noviv@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Matthew Webb <noviv@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#666486}
-
wutao authored
There are two sizes for embedded Assistant Ui: smaller size for empty Ui opened by hotkey and hotword etc, larger size for Ui with response or opened from search result page. Bug: 957643 Test: manual Change-Id: I275378f1b68f1977fa28de607fa3a7215b778378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629435 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#666485}
-
Istiaque Ahmed authored
Add a flag to RunExtensionTest so that an existing event page based test extension can be loaded as SW based extension. This can be used to run extension tests with Service Worker based extensions. This CL also adds a simple event page based tabs API test at tabs/lazy_background_on_created/ and demonstrates that the extension can be loaded as SW extension and the corresponding test ExtensionApiTabTest.LazyBackgroundTabsOnCreated passes with the flag in ServiceWorkerBasedBackgroundTest.TabsOnCreated. Doc: https://docs.google.com/document/d/1PvXZ7VGRGdmd1s99SFByn9NCGj0GAiBhhPmfjj35ZeI/edit# Bug: 967899 Change-Id: Ie979986e4c9f5bcac644152d8527aeb1c8c365c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636988 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666484}
-
Michael Giuffrida authored
The Kiosk Next Home app should only be loaded in Kiosk Next Home sessions (using the pref as a proxy for this). Also removes unused local_state references. Bug: 937549 Test: kiosk_next_home now only appears in user's Preferences file if they have enabled Kiosk Next Change-Id: I62b8e05fb30579c4d21cdbb54ed0788c783fe69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639479 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#666483}
-
Joshua Bell authored
Reduce visual noise in code by removing std::make_pair and push_back() calls when brace initializers for pairs/vectors can be used instead. No functional changes. Change-Id: I3553eccb670093ef05044ae19ba6a198cd7e1c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641516 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#666482}
-
Khushal authored
This reverts commit 959fa419. Reason for revert: Speculative revert for failure: https://ci.chromium.org/p/chromium/builders/ci/Android%20Release%20%28Nexus%205X%29/20525 Original change's description: > Remove the system URLRequestContext in src/chrome as it's not used anymore. > > The only usage remaining was in safe browsing unit_tests, so I've switched those specific tests to enable the network service feature flag (as it's disabled by default still for unit_tests). > > Bug: 934009 > Change-Id: I8eb23503bbb3f3610b958dce1d62f0b7428d2289 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643082 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#666407} TBR=jam@chromium.org,rockot@google.com Change-Id: I27d1c49de54bdac15d9527bc364b57c0a2ebefff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646648Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#666481}
-
Chris Harrelson authored
This is because the overlap-testing rects depend on scroll offset. Bug: 950154 Change-Id: Iacb3d373fe1b9be315701a55d604e44edb88f040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638620 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Chandani Shrestha authored
Network Conditions drawer had following issues: - Form controls like Network Throttling, User Agent combox box and input box was missing labels for screen reader users. This change addresses that issue by adding aria-label to them. Additionally, axe test is added for Network Conditions. Tested keyboard navigation - navigate up/down drop-down items using arrow keys - Checkbox is checked/unchecked using space bar - Tab into/out (no tab traps) Tested screen reader - reads checkbox label - reads items selected from the drop down list Bug: 963183 Change-Id: I7dec31f1c476f7c63ce4fff9a3b73c1b5377bfc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614138Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Cr-Commit-Position: refs/heads/master@{#666479}
-
Aaron Leventhal authored
Menu events should fire when a menu is made visible or hidden, whether or not the menu or something within it gets focused, because some authors simply show the menu at first, and only move focus if the user arrows into it. If the menupopupstart doesn't fire when the menu first appears, then the screen reader does not know to change to focus mode (virtual cursor off), and the web page will not receive down arrow keys. This also matches the behavior of Firefox for menupopupstart. See the two bugs listed. One contains a general simplified test case and the other describes how to reproduce the issue with Gmail. Bug: 98981, 964546 Change-Id: I975513ba73f3b23e884a7f1b38e6b5b161028d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637057Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#666478}
-
Etienne Bergeron authored
This CL is removing the function GetPlatformFontHeight since it's no longer needed. It was used to be more complicated to get height of fonts on windows. Since recent migration, the code is straigh forwards and font heights are constants. Address comments left on previous commit https://chromium-review.googlesource.com/c/chromium/src/+/1570653 R=tapted@chromium.org CC=benck@chromium.org Bug: 701241 Change-Id: I2db7c53914aa9105d5c9390dd98d5266998676c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642735Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#666477}
-
Ken Rockot authored
Fixes some leaks in a few bindings tests and re-enables them. Bug: 969789 Change-Id: Iee46b8de5559f2f655b70ced6d0ef9f7a831a379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644320Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#666476}
-
Devon O'Brien authored
Add newly Qualified CT Logs and remove 2018 CT Log shards. Bug: 962537, 859093, 888130, 796333, 801624 Change-Id: I4b0e5b772c1726af2cb7c633de038b0827453b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644898 Commit-Queue: Devon O'Brien <asymmetric@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#666475}
-
Chris Palmer authored
jcivelli is no longer working on Chromium, and we need more OWNERS for this security-relevant service. Bug: None TBR: jcivelli, rsesek Change-Id: I77f0ee0eafb4eb3b4709d18dd4ab09d9ecb7a037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645240 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#666474}
-
Matt Mueller authored
Bug: 749276 Change-Id: If49f4fb0d5e550da54e9aa6c66c1ba5d893a8a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645982Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#666473}
-
Kristi Park authored
The tile's restricted ID is referenced in multiple places as "rid" and "tid". Standardize naming by changing all references of "tid" to "rid". Change-Id: I285d7b21abb404adb0c97cdecad38c38ae3a39d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642235Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#666472}
-
Henrique Nakashima authored
Testing Offline Prefetch in reduced mode manually requires a bit more time. Bug: 933358 Change-Id: Iea9e52fda62bbf7fc2251fe3ca8eef2d110f4889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626495 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#666471}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2f4a8dfd3a59..d3692c701b12 git log 2f4a8dfd3a59..d3692c701b12 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 johnkslang@users.noreply.github.com Merge pull request #1791 from dj2/unused Created with: gclient setdep -r src/third_party/glslang/src@d3692c701b12 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I09a91e60063dc1083e76aac7782a64a80d04ac85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644848Reviewed-by:
-
Carlos Knippschild authored
Bug: 960069 Change-Id: I1870678c0fe42311a2c7ea3e30f272d6de89d372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644301 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#666469}
-
