- 21 Jan, 2020 40 commits
-
-
David Van Cleve authored
This CL adds net::trust_tokens::Store, which translates between Trust Tokens protocol-related operations and the underlying key-value representation of the persistence layer (net::trust_tokens::Persister). Bug: 1036494 Change-Id: Ida2e2f85bb473ffb8057ba96583ddc76d689d558 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986383Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#733777}
-
Yoshifumi Inoue authored
This patch extends execCommand histograms until end of 2020. These two metrics are useful for prioritizing maintenance of editing commands. Bug: 1037375 Change-Id: Ie73720bfc8ff188ac7a07272aedf4a5796258d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011473 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#733776}
-
rbpotter authored
Certain widths of the slider resulted in rounding errors when computing the value of the slider based on simulated pointer events at different locations. Put the slider in a 200px width wrapper so that the test always behaves the same way. Bug: 984919 Change-Id: I1e6292cba02c1949bd4739a48ad90bd0cbfbcc55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012908Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#733775}
-
Akihiro Ota authored
Change-Id: I400cf1c6d96c95a99008d527b33863d78c546ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012802Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#733774}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f5aa560c98d..b58c1c280d8f Created with: gclient setdep -r src-internal@b58c1c280d8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1034098 Tbr: jbudorick@google.com Change-Id: I082ec7868250539cc662dc6e7fd05e01547ff778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013501Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733773}
-
Rohit Rao authored
The code was incorrectly passing the main (non-Incognito) Browser to the TabGrid. BUG=1043935 Change-Id: I7c5348c4424a2c199194455b2286eec9efdaabe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012088 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#733772}
-
dalyk authored
This is a reland of c4f3b72d Now not squashing ERR_INTERNET_DISCONNECTED to avoid disrupting existing non-DNS related logic checking for that error code. Original change's description: > Reland "Squash top level error code returned from host resolver." > > This is a reland of 834f2092 > > Now not squashing ERR_NOT_IMPLEMENTED to avoid disrupting existing > InProcessBrowserTests. > > Original change's description: > > Squash top level error code returned from host resolver. > > > > If the host resolution process fails, the top level error code should > > now be only ERR_NAME_NOT_RESOLVED. A more specific error code (e.g. > > ERR_CONNECTION_REFUSED if a secure mode DoH server was offline) may be > > found in ResolveErrorInfo. > > > > Bug: 1016325 > > Change-Id: I9f5f857fffd71be6485d05280239cd0b649d7a8f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974678 > > Commit-Queue: Katharine Daly <dalyk@google.com> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Eric Orth <ericorth@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#728725} > > Bug: 1016325 > Change-Id: If2d029ea94f1a85f95d641cf02e4283973316a98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992191 > Reviewed-by: Eric Orth <ericorth@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Katharine Daly <dalyk@google.com> > Cr-Commit-Position: refs/heads/master@{#730951} Bug: 1016325 Change-Id: I00d38017f57a3414319019df30a021875b19b154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003078Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#733771}
-
Yuke Liao authored
This CL deletes the existing schedule of linux-code-coverage to favor the specific coverage scheduler that triggers a build every 6h. Bug: 1016929 Change-Id: I2aa7896860f5602d25f6da34ab6e47c318d8fb14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974893Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#733770}
-
Philip Rogers authored
In working on https://crrev.com/733649 this unused variable was noticed. Change-Id: I1ec61c972e9df85cc098b92cea79fe0e5843a92f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013322 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733769}
-
Lukasz Anforowicz authored
Before this CL, the extensions allowlist (see [1]) applied only to CORB. This meant that requests from non-allowlisted content scripts (to a destination the extension has permission to) would be allowed by CORS, but may be blocked by CORB. Not only was this inconsistency bad from hygiene/simplicity perspective, but it also was hurting content script ability to issue requests that are allowed by CORS (ones where the server would reply with Access-Control-Allow-Origins if given an Origin header with the origin of the webpage where content scripts got injected). This CL implements applying the allowilist to both CORB and OOR-CORS. The CL adds test coverage for this new behavior, but for now the new behavior is behind a disabled-by-default base::Feature. For more information, please see the design doc at https://docs.google.com/document/d/15QPPRwnWl5YboQ6foTM65IfFW0KHRPqHHk-IoGN04-Y Bug: 920638 Change-Id: I37325535d3633e5d44fd627b844032fbac550a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993759 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#733768}
-
Siye Liu authored
IME may ask us to remove some text before starting composition on existing text. We should remove selected text before calling |StartCompositionOnExistingText|. Bug: 1013154 Change-Id: I2b86f43245dca38b7bca8451ed71a8f041b2307e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869476 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#733767}
-
Manu Cornet authored
Change-Id: I6d84d357bf2f748813ad816bae6c95473a24d85b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012522Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#733766}
-
Tommy Li authored
Extend these two metrics to 2021: Omnibox.MatchStability.AsyncMatchChange2 Omnibox.Start.WantAsyncMatches Currently these will expire in March 2020. These metrics are in active use and seem useful indefinitely. Per the below link, we are therefore setting the expiry for one year: https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#how-to-choose-expiry-for-histograms Bug: 1043726, 1043727 Change-Id: I934e4cf1a5b7a4eb37d1a2998d8b9d17c6b44ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012808Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#733765}
-
Bo Liu authored
Bug: 1042063 Change-Id: I389cc648f31e65fe24e57de611be610d99091e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012524Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733764}
-
Rune Lillesveen authored
When BlockHTMLParserOnStyleSheets is enabled, two of the lazy image loading tests requires RunPendingTasks to finish parsing after the stylesheet loading is completed. Bug: 891767 Change-Id: I82acfe201b1988a6f10e5793868073b63708aad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011805Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#733763}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b28ca6f3..ff2a47b9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I427200693ed560e2678897aa04b088b297bbba53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013360Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733762}
-
Liquan (Max) Gu authored
Context: In the expandable PaymentHandler UI, users who click on a http link in a payment app get a crash. The cause is that the WebContents' didFinishLoad callback destroy FrameTreeNode when http content is detected. Since the subsequent execution of WebContents still relies on FrameTreeNode, it causes a null pointer crash afterwards. Before change: users click on a http link in a payment app get a crash. After change: no crash in the same scenario any more. Change: when closing PH UI is needed in WebContentsObserver callbacks, postpone the closing until the main thread is free. Bug: 1044077 Change-Id: If574cb9b23f4ff6b176f49daa8fcb47b25572ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013440 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733761}
-
Brandon Wylie authored
Change-Id: Icaf90b5b6cb4926abac4863052d9d87b30f5befb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013621 Auto-Submit: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#733760}
-
Lambros Lambrou authored
Host was calling a deprecated version of PeerConnectionFactoryInterface::CreatePeerConnection(). This updates it to use the recommended version - see third_party/webrtc/api/peer_connection_interface.h Change-Id: I59b33627fc5e9c1e9dd013959131e77017da1bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008769 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#733759}
-
Stepan Khapugin authored
Removes HL feature flags and cleans up call sites. Since HL flag was used for EG2 launcher to verify that it can run Chrome with a feature flag, and the flag is removed, I add a new kTestFeature flag that we won't need to replace in the future because it doesn't actually correspond to any feature. Bug: 945334 Test: none Change-Id: Iec29898214e8bf9d46a8e39e1cce5db5abd7dba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007688 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733758}
-
Steve Becker authored
Both the sandboxed and native versions of the NativeFileSystem postMessage() test are flaky due to timeouts in the CI. Looking at recent results, these tests take 5 or more seconds to complete successfully. This amount of time is dangerously close to the 7 second timeout, which sometimes occurs, causing the flakiness. This change adds "meta timeout=long" to both test variants to extend the 7 second timeout to a longer value, which gives these tests enough time to pass. Bug: 1043435 Bug: 1043028 Change-Id: I73eab928bce53a36be8c33e4b6e5746e7195f16a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013580Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#733757}
-
rbpotter authored
These tests aren't run on any bots, so failures were not discovered until running them locally. Bug: 967861 Change-Id: Ic8070f375db4db94703ef24f0e9e36e04ed03ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008773 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Paul Moy authored
Add a new mojo method, GetCrosHealthdDiagnosticsService, to wilco_dtc_supportd. This will allow the Chrome OS daemon to request an implementation of the CrosHealthdDiagnosticsService interface, which it will use to process diagnostics-related requests. running 'diag --action=get_routines' on a sarien board Bug: chromium:1040161 Test: manual testing by reverting crrev.com/c/1947112 and Change-Id: I055f16521caecc70da77c3e04c8a8b1e07613ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999106 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#733755}
-
Gang Wu authored
Implement copying image to android clipboard via context menu. UI review is https://docs.google.com/presentation/d/1YCYsjDRgqzfUklLLN_h1EtmQTTHUY89mC0lRmacvFLc/edit?ts=5e1d5808#slide=id.g7c8d36d508_1_0 Bug: 1043221 Change-Id: I3b1438e2dc6abae5934c33b8952038b7264a7b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008319Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733754}
-
Charlene Yan authored
This reverts commit 3accf2ce. Reason for revert: I think this currently broke the build https://ci.chromium.org/p/chromium/builders/ci/GPU%20Linux%20Builder/194027 Original change's description: > Add code to generate PROMPT_FOR_SCANNING verdicts > > This CL adds the code needed to generate PROMPT_FOR_SCANNING danger > types. This danger type is used when an Advanced Protection user > downloads a file that is marked as UNCOMMON. It causes the user to be > prompted to send this file to Google for deep scanning. The generation > of these verdicts is guarded by a Finch flag as well as the user's > Advanced Protection enrollment status. > > It also removes the old Finch flag related to Safe Browsing performing > additional download scanning for Advanced Protection users, to > minimize confusion. > > Bug: 1020418 > Change-Id: I506c1ff5fd3d923f8817f4db16563996d937a418 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007984 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733747} TBR=mek@chromium.org,tedchoc@chromium.org,vakh@chromium.org,xingliu@chromium.org,drubery@chromium.org Change-Id: I45841a077b35c1383aee6f83471bdbe7dc4270da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013645Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733753}
-
Charlene Yan authored
This has started failing intermittently https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44040 https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44022 https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44014 TBR=karandeepb@chromium.org Bug: 1044265 Change-Id: Id21d3fb149a4df20652b6781d2fb9f1cd0b7ffa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013025 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
-
Charlene Yan authored
This has failed recently https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81325 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81301 TBR=tommi@chromium.org Bug: 1044271 Change-Id: I669538712db5618926e16bbecc22ba1cb96792a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013350Reviewed-by:
-
yilkal authored
This CL makes sure that SupervisedUserNavigationObserver is created only for supervised user accounts. This saves memory and processing time. Bug: 1043232 Change-Id: I5d13ce0261d07c29384f5ba5dc83e420ed3138dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008315Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#733750}
-
Azeem Arshad authored
This CL removes the use_messages_google_com_domain flag. This flag was used as part of migrating users of Android Messages integration in ChromeOS to the new google.com subdomain. This migration is complete and the flag is not required anymore. Bug: 1043416 Change-Id: Ic797c5f57c7355734d2c44ce913928745bd755c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008771Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#733749}
-
Brandon Wylie authored
As a follow-up to reparenting the current Tab when the theme is changed, this CL reparents the entire TabModel. When the theme is swapped, first the foreground tab is detached, then all other tabs are detached in tab index order. When the app restarts, the tabs are reattched in reverse tab index order (attaching the last, second to last), added as the first tab with the exception of the foreground tab, which is left out. After the tabs are stacked, restoring the original ordering, the original foreground tab is added at the correct index. Bug: 944302,1031332 Change-Id: I7eb1465157500e7f1f6c1da79240c96f38c9b6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974992 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#733748}
-
Daniel Rubery authored
This CL adds the code needed to generate PROMPT_FOR_SCANNING danger types. This danger type is used when an Advanced Protection user downloads a file that is marked as UNCOMMON. It causes the user to be prompted to send this file to Google for deep scanning. The generation of these verdicts is guarded by a Finch flag as well as the user's Advanced Protection enrollment status. It also removes the old Finch flag related to Safe Browsing performing additional download scanning for Advanced Protection users, to minimize confusion. Bug: 1020418 Change-Id: I506c1ff5fd3d923f8817f4db16563996d937a418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007984 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733747}
-
Saman Sami authored
Don't keep track of owned planes directly in HardwareDisplayController. We already know the set of owned CRTCs and we can ask the plane manager to find the planes corresponding to those CRTCs. By removing |owned_hardware_planes_| from HardwareDisplayController, we reduce the amount of state that has to be protected by a lock if we wish to perform pageflip testing on another thread (see the bug for more context). TEST=Built and ran on eve and chell. Connected and disconnected an external monitor. There is also plenty of existing unit tests that cover this code. Bug: 1034559 Change-Id: I16fccc549c272c8659d392996a163877ac7bd7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003561 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#733746}
-
Natalie Chouinard authored
Following the naming conventions decided in go/clank-preferences-refactor, this change replaces the "Preferences" suffix with "Settings". Skip presubmit to avoid AlertDialog checks for existing usages. NOPRESUBMIT=true Bug: 1030446 Change-Id: I86ee42fd63fb808840306bee99cdc762c5a86444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003757 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#733745}
-
Manuel Rego Casasnovas authored
This patch adds two tests related to transforming the root element background, to avoid regressions in the future. First is a static test that was passing in Chromium but failing on Firefox. Now it's also failing in Chromium after r733661. The other one is a dynamic change that has been fixed recently in Chromium (see crbug.com/898293). BUG=988446 Change-Id: Id33bdd07c8911f4eba419dc553ece24b7ad40300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007692 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8effa4d0637c..d339e36642df git log 8effa4d0637c..d339e36642df --date=short --first-parent --format='%ad %ae %s' 2020-01-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d339e36642df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ic7d7df1b0b48daaeccc3e6e2877c63df1807c65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013305Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733743}
-
Kurt Horimoto authored
This interaction handler is a subclass of InfobarModalInteractionHandler that exposes functionality handling the dispatch callbacks that can be sent for the InfobarPasswordModalDelegate. Additionally, this CL adds a callback installer subclass that handles setting up the callbacks to handle these dispatched comments and forward them to the interaction handler. Bug: 1030357 Change-Id: I07e5b872ebd1c8998333a1ad9369529942bf5fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001525 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#733742}
-
George Burgess IV authored
Bug: None Change-Id: I732bc38f4a541cbafb85501d3b6e72dafa36762e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994103 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#733741}
-
Garrett Beaty authored
Change-Id: I79ceaba42d5ad5440f03e58ac493f8a14c148da0 Bug: 1011908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013581 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#733740}
-
Albert Chaulk authored
This reverts commit 8985ccdc. Reason for revert: not needed, already plumbed through different path Original change's description: > Add CastContentWindow::SetCanGoBackQuery > > This allows querying the CanGoBack status of the underlying app > > Bug: b/145762033 > Test: None > Change-Id: I330d7124dd7817db69f5ff41bfa58f6059971113 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008066 > Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org> > Commit-Queue: Albert Chaulk <achaulk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733446} TBR=achaulk@chromium.org,dnicoara@chromium.org,halliwell@chromium.org,seantopping@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/145762033 Change-Id: I668bc87b91d7e70d70c04b995a98d6d756ad5808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013464Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#733739}
-
Alex Ilin authored
This CL implements display of the remote consent dialog for the new consent flow. As before, the consent page is opened in a separate window within the IdentityApiUiApp. The new dialog, however, doesn't wait until the page is redirected or the page title changed. The consent page passes the consent result via private JS api that is yet to be implemented in the next CL. For now, the browser never gets the result back. After the consent result is get, the browser should send a request to IssueToken endpoint. This part hasn't been implemented yet. (see NOTIMPLEMENTED() in IdentityGetAuthTokenFunction::OnGaiaRemoteConsentFlowCompleted()). Bug: 1026237 Change-Id: I105f4036a4b2ae85eed4b29d810b9fe3bea2c6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997303 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#733738}
-
