- 28 Apr, 2020 40 commits
-
-
Henrique Ferreiro authored
Targets depending on //ui/base/x need to use "linux:xrandr" config and the ones depending on //ui/gfx/x, "linux:x11". This CL makes those configs public in targets where they are used, so that they can be omitted everywhere else. Change-Id: Ied1f5cc85e9af4172b1472a75d53a71526d491f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162864 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#763380}
-
Samuel Huang authored
In SuperSize-archive, SectionSizeKnobs was originally added to store tuneable constant parameters. However, over time the class has gained additional fields that are derived from |args|. To enable Trichrome support, SuperSize-archive will need to process multiple "containers" (e.g., APK files). Each of these containers effectively has its own |args|. This challenges SectionSizeKnob's status as a singleton. This CL splits |args|-dependent fields in SectionSizeKnobs into a new class ContainerArchiveOptions. This class is instantiated for each container's |sub_args|. Bug: 1040645 Change-Id: I0ce2f6eb21a23cc2495d5924ab2e28bc5301d7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169758Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#763379}
-
Trent Begin authored
This test ensures that device_status_collector can properly handle responses from cros_healthd that are partially populated. Bug: chromium:1071668 Change-Id: Iad83aef1df75726d6bb9b323889fc5c7642b79da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163746 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#763378}
-
Sebastien Lalancette authored
This will be used by QRGeneratorCoordinator to generate a UIImage to share the QR code via the Activity View. Bug: 1064990 Change-Id: I434ed84959d8534ac1a64b341aa84cfadc79faad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167156 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#763377}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f5132a05c893..7676f4ecf3ec git log f5132a05c893..7676f4ecf3ec --date=short --first-parent --format='%ad %ae %s' 2020-04-28 scroggo@google.com Remove SkFrontBufferedStream 2020-04-28 kjlubick@google.com [infra] Add POC task driver Created with: gclient setdep -r src/third_party/skia@7676f4ecf3ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I7d0fd3cabb07677cffb808f236586f217e3d89bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170295Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763376}
-
Yutaka Hirano authored
Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s9npIUKHkMA Bug: 1072283 Change-Id: I8045d2f2906a26cf64897ee445209c50f88b2493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154352Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#763375}
-
Ovidio Henriquez authored
This change updates the bluetooth-test.js and bluetooth-helpers.js file to use async/await to improve readability. Bug: 1070816 Change-Id: I26b3f66f971f73860e6f2e89ef63709b0da6d164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160087Reviewed-by:
James Hollyer <jameshollyer@google.com> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#763374}
-
Mehran Mahmoudi authored
This implements the logic for pre-fetching adjacent tiles to the viewport in the player. It also removes references to previously saved bitmaps that are not close to the viewport anymore. Bug: 1021111 Change-Id: Ie3520ae88ebd3230133af71c24ccc7b691de04ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165909Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#763373}
-
Nazerke authored
This CL removes BrowserViewController's dependence on TabModel in |setPrimary|. Bug: 1045575, 1049842 Change-Id: I82aebf6ed8eee23e1a48043090a8b6164e281ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170266Reviewed-by:
-
Domenic Denicola authored
It turns out that we automatically origin-isolate web-platform.test domains. This makes the web platform tests under external/wpt/origin-isolation, for the opt-in origin isolation feature (https://crbug.com/1042415), useless, since the opt-in does nothing. This CL introduces a new virtual test suite, which toggles a new command line flag to disable this automatic origin isolation of WPT domains. When running this virtual test suite, then, the WPT domains will only be origin-isolated when they are explicitly opted in by the test files, by setting the Origin-Isolation header. The tests are run exclusively in this virtual test suite, by adding their default configuration to NeverFixTests. Fixed: 1073181 Change-Id: I9db3285f1ac3a0e5b04e8d63694649d2dbe6419e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159536 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#763371}
-
Kurt Horimoto authored
When SafeBrowsingTabHelper cancels a navigation for an UnsafeResource, it will create a CancelAndDisplayError PolicyDecision using an NSError with kSafeBrowsingErrorDomain and kUnsafeResourceErrorCode, which can then be used by ChromeWebClient's PrepareErrorPage() implementation as a signal to display a safe browsing blocking page. Bug: 1064803 Change-Id: Ic7bee74881ab8fd83158ebef2df95bf8a317e503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168523Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#763370}
-
Fergus Dall authored
In crrev.com/c/2142699 AppIconFactory was refactored to use a new pipeline for all the icon loading flows. This caused LoadIconFromFileWithFallback to no longer call the fallback callback passed by the caller. This happens for two reasons. First, the pipeline is not aware of the fallback because it's wrapped inside the result callback. Because of this the pipeline prioritizes all other fallbacks over the callback, including the default icon set when no icon can be found. Second, the pipeline creates a new non-null image if loading that resource fails, but the wrapper decides whether or not to call the fallback by checking if the image pointer is null. Fix both of these cases by making the pipeline function that attempts the fallback aware of the fallback callback. This callback will now be tried before trying to load the default icon resource. The callback will indicate a failure by passing a null pointer instead of a valid image to its result callback. Bug: 1075445 Change-Id: Ia1eb5a1655760405e71b24cc282fb6388936d836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167798 Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#763369}
-
Devlin Cronin authored
//chrome/browser/extensions/extension_action.h and extension_action.cc have no //chrome dependencies. Move them to //extensions. This is a pure move; there are no functional changes. Bug: 1073590 Change-Id: Iedf4fcbaf871470e727046dce0976270a239b035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162140Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763368}
-
Ben Pastene authored
This will let folks check out multiple board SDKs at once without having to modify their .gclient file each time. Needs to land after crrev.com/c/2163589. Bug: 937821 Change-Id: I191985b4d5044c84009b8a7d05e33785b6e81e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163849Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#763367}
-
Nate Chapin authored
This means DeviceOrientationController and DeviceMotionController become Supplements of LocalDOMWindow instead of Document, too. Bug: 1029822 Change-Id: I16511f45f1ac1eb343e466217b324b1217f14a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166586Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#763366}
-
Pavol Marko authored
This CL makes TestNavigationObserver track state per-WebContents instead of globally: (*) Whether a navigation is in progress (in |navigation_started|) (*) Whether the last navigation that finished matched the |target_url| / |target_error| filter (in |last_navigation_matches_filter|). When TestNavigationObserver is configured with matching against a target_url, only set last_* member variables if the target_url actually matches. This solves a race condition that TestNavigationObserver suffered from previously when receiving events from multiple WebContents: TestNavigationObserver with target_url_ == A, and default wait_event_ == WaitEvent::kNavigationFinished. (1) OnDidFinishNavigation for URL A Set last_navigation_url_ == A (2) OnDidFinishNavigation for URL B Set last_navigation_url_ == B (3) OnDidStopLoading (probably matching (1)) Does not trigger EventTriggered() because (target_url_ == A) != (last_navigation_url_ == B) (4) OnDidStopLoading (probably matching (2)) Same as above. Also, use base::Optional to make it obvious if |target_url| / |target_error| filters are active. Bug: 830337 Change-Id: Id1d47a0e4ed20d6df38ac222e5eb3eed97bcbc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161032 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#763365}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I43dfde446232343dabb16ab223396199251d0524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170136Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763364}
-
Liviu Tinta authored
Adding missing wpt test description. Bug: 1031745 Change-Id: I118731dfb49dc7b454ada3ecf8d9b4edabcb5061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169760 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#763363}
-
Xing Liu authored
The build failure histogram is added to track an android bug. This can be removed now. TBR=bcwhite@chromium.org Bug: 1075635 Change-Id: I67acd66efcfdef186528a0076724175f8e789b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168008 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#763362}
-
Nate Chapin authored
Because it (and its subclasses) no longer use a Document, we can remove a couple of functions that are duplicated between Document and LocalDOMWindow. Bug: 1029822 Change-Id: I8d023642ef82818e9b75d9041cb861be0996947b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168511Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e08eda8..d50c00bf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I38c7777b388d9c8d949a42838f73bb7752a876b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170187Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763360}
-
Andrei Salavei authored
Attempt to recover Access Token in case request to the |ExchangeToken| endpoint failed with 4xx(unauthorized) http error. Bug: 1071397 Test: browser_tests --gtest_filter=ArcAuthServiceTest.* Change-Id: I39d89a7ace885de589030cea297a58ce924d1e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151592Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Andrei Salavei <solovey@google.com> Cr-Commit-Position: refs/heads/master@{#763359}
-
Rushan Suleymanov authored
This patch extends checks for the bookmarks metadata while loading from the disk. If the duplicate tombstone is detected then the whole metadata is rejected with a new reason DUPLICATED_CLIENT_TAG_HASH. Bug: 1050716 Change-Id: I61d9e5dded864a1a3ce4ee3c9295b01ca82a5ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162906 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#763358}
-
Trent Begin authored
This splits cros_network_config mojo interface into a shared group of enums that are reused in Network Health's interface. Bug: chromium:1057739 Change-Id: I5bc2673f0c856dbbcb689a96282982e795562271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157769Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763357}
-
Colin Blundell authored
In the initial bringup of ExternalNavigationDelegateImpl this method was not implemented, and //weblayer's flow was configured to ensure that closing tabs was never requested. However, WebLayer's flow now properly detects cases where tabs should be closed, and hence ExternalNavigationDelegateImpl can actually be requested to close a tab. This CL implements that closing via the same flow as //weblayer's InterceptNavigationDelegateClientImpl#closeTab(). The only case in which this flow currently occurs is an extreme corner case that is unlikely to occur in practice: - The app using WebLayer does not have storage permissions - The user goes to a file URL in a context where the tab should be closed if the navigation is overridden (essentially, the navigation is the initial navigation in the tab) - The user denies the app storage permissions in the dialog that WebLayer pops up I looked at testing this flow. However, it turns out that it would require adding a private AIDL API to configure the WindowAndroid instance to not regard the app as having the READ_EXTERNAL_STORAGE permission. This seemed like an unnecessary amount of overhead for a flow that is basically non-existent in the product. When I implement the warning dialog for launching intents from incognito, that will also go through this closeTab() method. At that point I will look at constructing a test for that more-realistic use case. Bug: 1074301 Change-Id: Ic342877c569298b2a0e29cda10316c0cbe5074d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162750Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#763356}
-
Harald Alvestrand authored
This will happen if invoking functions on an object after its context has been destroyed. Added test. Bug: chromium:1072412 Change-Id: Icc2e8a5ad47398acffb2d56a299a51b11386c9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160909 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Michael Ershov authored
When key_name_for_spkac_ is specified, return public key for it. In other cases return public key for key_name_. Bug: 1045895, 1075840 Change-Id: I5af345ecda8c4c61fe9eaaedaa7f059a1810ed8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169994 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#763354}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/012aa375b177..4381af48b40b git log 012aa375b177..4381af48b40b --date=short --first-parent --format='%ad %ae %s' 2020-04-28 landrey@webrtc.org Change connection ASSERT into metrics for the PC level framework. 2020-04-28 landrey@webrtc.org Add cpu_usage metrics. Created with: gclient setdep -r src/third_party/webrtc@4381af48b40b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I98c7d9807d1f4a5c1d3cded5c17bac4a25a947ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170287Reviewed-by:
-
Nicolás Peña Moreno authored
This CL attempts to fix test flakiness. * For the click counts, remove tests about mouseout/mouseover since those could fail under certain starting positions of the mouse, and the test has a pretty high flakiness score right now. * For other tests, fix flakiness by making sure that PerformanceObserver callbacks where mousedown is not present are ignored. This is possible since a click triggers mousedown, mouseup, click, etc., so we cannot just assume that mousedown will always be present at the callback. Bug: 1074048 Change-Id: I95a082948c105cf18b51376c9d6421195b23b718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163775Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#763352}
-
Mehran Mahmoudi authored
This CL implements a new system for managing custom Views for Tab. The TabViewManager class acts as the entry point for all users who want to display a View on top of Tab's Content view. TabViewManager knows the priority of all its users and always displays the TabViewProvider with the highest priority. Internal design doc: http://go/tab-view-clients Bug: 1073948 Change-Id: I5d5d0384b512d6722dd0357295de5542b9b77306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159248Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#763351}
-
Bartek Nowierski authored
This is needed because of how argument-dependent lookup works (it looks in the namespace of the type for an unqualified function name). According to go/using-std-swap, the recommended usage pattern is: using std::swap; swap(thing1, thing2); Having swap outside of base namespace wouldn't work with this recommendation as slower std::swap would be silently used instead. Bug: 1073933 Change-Id: Ib4485b51ba52ad491306bec9b4402a154adae16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167796 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Jank analysis uncovered that Windows uses native ::PeekMessage calls as an opportunity to yield to other threads according to some heuristics (e.g. presumably when there's no input but perhaps a single WM_USER message posted later than another thread was readied). MessagePumpForUI doesn't intend to give this opportunity to the kernel when invoking ::PeekMessage however as it runs most tasks out-of-band. Hence, PM_NOYIELD should be used to tell ::PeekMessage it's not the only source of work for this thread. R=fdoray@chromium.org Bug: 1075960 Change-Id: Ic8808cab8c15aa690f7dfd8405741323285c107b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169728 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#763349}
-
Alexander Hendrich authored
These all seem to be related to each other: ProfileHelperTest.DeleteActiveProfile (WIN) ProfileHelperTest.DeleteSoleProfile (WIN) ProfileManagerBrowserTest.DeleteAllProfiles (WIN) ProfileManagerBrowserTest.DeleteCurrentProfile (WIN + LINUX) ProfileManagerBrowserTest.DeleteSingletonProfile (WIN) TBR=droger@chromium.org,rhalavati@chromium.org Bug: 1073451 Change-Id: Id3817808337330664a04210ed6a3a1c94639ac1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169104Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#763348}
-
Victor Hugo Vianna Silva authored
Bug: None Change-Id: I9d6c7023c3ec0bd016a84606fda509a3f56e6496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169990Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#763347}
-
Rohit Agarwal authored
URL navigation in incognito with intent based scheme "intent://" currently results in one of these behaviour: 1) Launches an incognito intent with a user dialog that requires permission to leave incognito. This is shown only if chrome can't handle the resultant intent via willChromeHandleIntent method. The method willChromeHandleIntent returns true, if target intent has the same package name as chrome; if not then android is asked to resolve this check; the method returns false otherwise. |OVERRIDE_WITH_ASYNC_ACTION| 2) Default case, launches the resultant intent without any user dialog. |OVERRIDE_WITH_EXTERNAL_INTENT| Behaviour 2 is a bug that leaks user session from incognito without the user dialog. For example, clicking on an intent url that opens custom tabs from incognito doesn't show any dialog. This is because, the package name of intent is that of chrome which fails condition 1. This CL modifies the behaviour in incognito for external navigation from intent based schemes as : a) Same as behaviour 1. b) In case chrome can handle the resulting intent it will continue to do so in the incognito session. c) The default case, i.e behaviour 2, is no longer true for incognito session, we will fall in either a) or b) always. It also adds unit tests and browser test. Bug: 1062548, 1062550 Change-Id: I1dcab96f054e2696c6993a9f11975e436bc12ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148738Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#763346}
-
Xida Chen authored
This CL makes the numbers in the debug string in the FrameSequenceTracker % 1000 such that the debug string won't be too long, and will be easier for debugging. Bug: 1072482 Change-Id: I732eced597a568dc365eafa6d12b8661469ca486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166394Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#763345}
-
Yoshifumi Inoue authored
This patch changes "paste-4039777-fix.html" to utilize selection_test() for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I1b16bde5e3b6d3bb4a3d82551dbda7787e7b47c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170007 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Kush Sinha authored
Extend the expiry of AccountManager.TokenLoadStatus histogram by 1 year. Bug: 1075621 Change-Id: Ia5d7e664c2e4d42098bd24608326f9d2f9363bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169893 Commit-Queue: Kush Sinha <sinhak@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#763343}
-
Alice Wang authored
This CL adds a render test for AccountPickerDialogFragment.updateSelectedAccount to check that this call updates the account selection mark. Bug: 967374 Change-Id: I0ebd2abfa0f7782daa3b2690101271af65dc1f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166904Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#763342}
-
Vincent Boisselle authored
Change-Id: Ib2f8514e4c1c54cf92bb25c66109fbe3a243564f Bug: 1075680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145249 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
-
