GitLab

A flaw was introduced in the snackbar refactoring, which led to several
touch handling errors. This CL fixes several of the recently discovered
bugs.

BUG=616013,615826,614698,614614

Review-Url: https://codereview.chromium.org/2023053002
Cr-Commit-Position: refs/heads/master@{#397234}

Also move all offline client namespace constants into one central place.

BUG=616231
TBR=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2022283003
Cr-Commit-Position: refs/heads/master@{#397233}

Change automated with clang-tidy (details @ https://crbug.com/612843#c13)

BUG=612843

Review-Url: https://codereview.chromium.org/2028993003
Cr-Commit-Position: refs/heads/master@{#397232}

With this roll, we can enable uniformapi/* and fbocompleteness.html tests.

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/2211435..97d0194

BUG=
TEST=bots
TBR=kbr@chromium.org,cwallez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2027873005
Cr-Commit-Position: refs/heads/master@{#397231}

Change automated with clang-tidy (details @ https://crbug.com/612843#c13)

BUG=612843

Review-Url: https://codereview.chromium.org/2027303002
Cr-Commit-Position: refs/heads/master@{#397230}

R=cpu@chromium.org,darin@chromium.org,jam@chromium.org,tsepez@chromium.org,jeremy@chromium.org
(multiple owners as FYI for losing a teammate only need one stamp)

BUG=He no longer works on Chrome and no longer reviews

Review-Url: https://codereview.chromium.org/2027343002
Cr-Commit-Position: refs/heads/master@{#397229}

For background mode, just dump same details as light mode.

BUG=613198

Review-Url: https://codereview.chromium.org/2013643005
Cr-Commit-Position: refs/heads/master@{#397228}

BUG=

Review-Url: https://codereview.chromium.org/2025623007
Cr-Commit-Position: refs/heads/master@{#397227}

This fixes a bug in gdb-add-index that meant it never cleaned up its
temp files.

Review-Url: https://codereview.chromium.org/2023363002
Cr-Commit-Position: refs/heads/master@{#397226}

Change automated with clang-tidy (details @ https://crbug.com/612843#c13)

BUG=612843

Review-Url: https://codereview.chromium.org/2023003005
Cr-Commit-Position: refs/heads/master@{#397225}

InputMethodManagerService in Android platform sometimes access disk
to record the IME state. This prevents crashes in dev.

BUG=616283

Review-Url: https://codereview.chromium.org/2027923002
Cr-Commit-Position: refs/heads/master@{#397224}

BUG=616168

Review-Url: https://codereview.chromium.org/2025993002
Cr-Commit-Position: refs/heads/master@{#397223}

BUG=616564
TBR=amistry@chromium.org

Review-Url: https://codereview.chromium.org/2027163003
Cr-Commit-Position: refs/heads/master@{#397222}

Change automated with clang-tidy (details @ https://crbug.com/612843#c13)

BUG=612843

Review-Url: https://codereview.chromium.org/2027313002
Cr-Commit-Position: refs/heads/master@{#397221}

Change automated with clang-tidy (details @ https://crbug.com/612843#c13)

BUG=612843

Review-Url: https://codereview.chromium.org/2031673002
Cr-Commit-Position: refs/heads/master@{#397220}

After 532d3841, we need to also check for MOUSE_MOVED, not just
POINTER_MOVED.

BUG=603369

Review-Url: https://codereview.chromium.org/2027283002
Cr-Commit-Position: refs/heads/master@{#397219}

BUG=563722

Review-Url: https://codereview.chromium.org/2032453003
Cr-Commit-Position: refs/heads/master@{#397218}

BUG=604144,396825,607185,587094,155836,602933
TBR=wkorman@chromium.org

Review-Url: https://codereview.chromium.org/2025243002
Cr-Commit-Position: refs/heads/master@{#397217}

BUG=525873, 606066

Review-Url: https://codereview.chromium.org/2027873002
Cr-Commit-Position: refs/heads/master@{#397216}

Change automated with clang-tidy (details @ https://crbug.com/612843#c13)

BUG=612843

Review-Url: https://codereview.chromium.org/2031693002
Cr-Commit-Position: refs/heads/master@{#397215}

Calls to set shelf state should go through Shelf, not ShelfLayoutManager.
* Move all calls to SetAutoHideBehavior() and SetAlignment() to Shelf instead
of ShelfLayoutManager.
* Add Shelf::GetVisibilityState() and Shelf::GetAutoHideState() and prefer
using them to accessing ShelfLayoutManager directly.
* Remove ShelfLayoutManager::GetAutoHideBehavior().
* Rename variables mis-named "shelf" to shelf_widget, shelf_layout_manager, etc.
so they match their actual types.

No functional changes.

BUG=615502
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2017413002
Cr-Commit-Position: refs/heads/master@{#397214}

Change automated with clang-tidy (details @ https://crbug.com/612843#c13)

BUG=612843

Review-Url: https://codereview.chromium.org/2023353002
Cr-Commit-Position: refs/heads/master@{#397213}

BUG=616556
TBR=esprehn@chromium.org

Review-Url: https://codereview.chromium.org/2028203002
Cr-Commit-Position: refs/heads/master@{#397212}

There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
BUG=615904
R=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2021953002
Cr-Commit-Position: refs/heads/master@{#397211}

https://chromium.googlesource.com/chromium/src/+/d501ee220

BUG=613118
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/2026403002 .

Cr-Commit-Position: refs/heads/master@{#397210}

This finishes up the refactorization of the JNI interface. Scheduled tasks
inside a session will not be lingering after the session ends.

BUG=526336

Committed: https://crrev.com/800991e54ced74fc425843070a1941827af5b787
Cr-Commit-Position: refs/heads/master@{#396036}

Review-Url: https://codereview.chromium.org/2007403002
Cr-Commit-Position: refs/heads/master@{#397209}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e1916b6e9756..77276cd20e4e

$ git log e1916b6e9..77276cd20 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2025103004
Cr-Commit-Position: refs/heads/master@{#397208}

https://chromium.googlesource.com/skia.git/+log/4a603fc591dc..edc743a57657

$ git log 4a603fc59..edc743a57 --date=short --no-merges --format='%ad %ae %s'
2016-06-01 bsalomon Add SkPathPriv::IsSimpleClosedRect
2016-06-01 jvanverth Add offset to memory allocations

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2029683002
Cr-Commit-Position: refs/heads/master@{#397207}

We can no longer expect a single cycle of message-loop iteration to
paint a widget, since painting is now driven by BeginFrameSource. So
update the tests to wait for the painting to happen first.

These tests create desktop-widgets, which we do not support in mus, so
disable the tests in mus.

BUG=596039

Review-Url: https://codereview.chromium.org/2032573002
Cr-Commit-Position: refs/heads/master@{#397206}

This CL logs BIDIRECTIONL_STREAM_ALIVE before we start any stream request.
This makes sure that HTTP_STREAM_REQUEST is nested inside
BIDIRECTIONL_STREAM_ALIVE begin and end events.

BUG=516342

Review-Url: https://codereview.chromium.org/2016863002
Cr-Commit-Position: refs/heads/master@{#397205}

tcmalloc defines malloc and free as wrappers (or aliases) for tc_malloc
and tc_free, so we can test tcmalloc by using malloc and free directly
instead of tc_malloc and tc_free. This fixes the test in component
builds, where tc_malloc and tc_free are defined in a separate DSO with
hidden visibility (due to https://codereview.chromium.org/2019183002/),
and so will not be visible to tests.

Some compilers (e.g. clang) will specifically recognize and optimize
away calls to malloc and free, which would break these tests, as
they are testing specific behavior of the allocator. Address this by
marking the wrappers for malloc and free as NOINLINE.

BUG=
TBR=primiano@chromium.org

Review-Url: https://codereview.chromium.org/2028183002
Cr-Commit-Position: refs/heads/master@{#397204}

Added a Setting to tell Blink whether or not to always show the
context menu on a long press.

BUG=616060

Review-Url: https://codereview.chromium.org/2024323002
Cr-Commit-Position: refs/heads/master@{#397203}

Use isSpecified() to query for existance in setStandardAttributes. This
avoids triggering unnecessary attribute synchronizations.

While here, drop the "double precondition" checking since the only caller
of this function checks this already.

BUG=235256

Review-Url: https://codereview.chromium.org/2026343002
Cr-Commit-Position: refs/heads/master@{#397202}

Since the transform tree tracks whether there is a curretly running
transform animation, it can be used to determine whether the local
transform in transform tree node should be overwritten at commit time

BUG=609208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2027073002
Cr-Commit-Position: refs/heads/master@{#397201}

Also should fix it on Mac, but untested.

BUG=616449
TBR=piman@chromium.org, sievers@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2027753003
Cr-Commit-Position: refs/heads/master@{#397200}

Added tests for antialiasing, alpha channel, and Chromium image.

BUG=607130
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2023153002
Cr-Commit-Position: refs/heads/master@{#397199}

Use the new multi-line elision in RenderText to manage/display
a dictionary definition answer-in-suggest, which can
span multiple lines.

BUG=591803

Review-Url: https://codereview.chromium.org/2009673005
Cr-Commit-Position: refs/heads/master@{#397198}

This is required to run the browser_tests on swarming.

BUG=614745,582622
TEST=This fixes failing browser_tests.

Review-Url: https://codereview.chromium.org/2028133002
Cr-Commit-Position: refs/heads/master@{#397197}

BUG=

Review-Url: https://codereview.chromium.org/2024033003
Cr-Commit-Position: refs/heads/master@{#397196}

BUG=611802
TBR=tsepez@chromium.org, piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2027223002
Cr-Commit-Position: refs/heads/master@{#397195}