- 24 Jul, 2018 40 commits
-
-
Derek Cheng authored
It started flaking on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/70474 TBR=fsamuel Bug: 823043 Change-Id: I23a000160c81ed75a277331a6739095958ff6e77 Reviewed-on: https://chromium-review.googlesource.com/1149097Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577730}
-
Javier Ernesto Flores Robles authored
Right now `checkIfAccessoryViewIsAvailableForForm` always return YES in the block. This CL actually checks with the providers, and returns NO, if none has suggestions. This means That no accessory will be provided by the form suggestion if no suggestion exists. Gated to the AutofillManualFallback feature flag. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id36c0e8280555dc87829b78e7b1d6a9ed6df88b7 Reviewed-on: https://chromium-review.googlesource.com/1136550 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577729}
-
Nick Harper authored
TBR=mattm@chromium.org Bug: 796230, 867174 Change-Id: I4ece7e608e597c9455bac468f828bdee91233c16 Reviewed-on: https://chromium-review.googlesource.com/1149197Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#577728}
-
Sahel Sharify authored
Bug: 846424 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I13dc5826152a1b3f8157342a7f1d644f333a89e2 Reviewed-on: https://chromium-review.googlesource.com/1144230 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577727}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ddd6e8746851..21edf3db5e33 git log ddd6e8746851..21edf3db5e33 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 ynovikov@chromium.org Fix stencil mask check in Framebuffer::partialClearNeedsInit Created with: gclient setdep -r src/third_party/angle@21edf3db5e33 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I207f8b26c7e21d06ab3900b2d5e2875c931522f7 Reviewed-on: https://chromium-review.googlesource.com/1148615Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577726}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ca7d881540e3..01ce05914f99 git log ca7d881540e3..01ce05914f99 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@01ce05914f99 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2ae0b7db67272beb622af6140f5152b02f73f0b9 Reviewed-on: https://chromium-review.googlesource.com/1148741Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577725}
-
Scott Violet authored
This interface is *only* exposed in tests. It's to be used for tests that want to generate events and ensure they are processed. My plan is remove the existing interface (services/ui/public/interfaces/event_injector.mojom) soonish. BUG=852439 TEST=covered by tests Change-Id: I2df1e5d428564f78b7280087a4f5453ce76b55b7 Reviewed-on: https://chromium-review.googlesource.com/1144472 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#577724}
-
Christopher Cameron authored
Also add a glFlush before calling GLFence::Create, as it should be sufficient to trigger the crash. Bug: 863817 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I589ba525d771895d00cf4aebfea57ce62f8add3f Reviewed-on: https://chromium-review.googlesource.com/1148682 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577723}
-
Bailey Berro authored
This change takes the drop-down-search-box from the "Add Cups Printer" dialog and makes it a cr-element so that it can be used elsewhere. - Updates cups_add_printers_dialog to use cr-searchable-drop-down Bug: 866146 Test: browser_tests Change-Id: Ib0d953c3dbb1f51dad94a73451eb924d12d1b39e Reviewed-on: https://chromium-review.googlesource.com/1145774 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#577722}
-
Aldo Culquicondor authored
Using the state produced some E2E tests to fail, because the button down and button up events happen in the same frame. Reason for TBR: fix failing tests on CI. TBR: asimjour Bug: 867016 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icbc657838d80bf28d60ab2114625936aa4826883 Reviewed-on: https://chromium-review.googlesource.com/1148964 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#577721}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e0ae2989b096..bd499d73987d git log e0ae2989b096..bd499d73987d --date=short --no-merges --format='%ad %ae %s' 2018-07-24 dtu@chromium.org [pinpoint] Move bug template from GitHub to Monorail. 2018-07-24 simonhatch@chromium.org cloud_storage - Use default env if SWARMING_HEADLESS is set Created with: gclient setdep -r src/third_party/catapult@bd499d73987d The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib57f3a4061ba9a03f9805a371d14e203586761fe Reviewed-on: https://chromium-review.googlesource.com/1148902Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577720}
-
Robert Ma authored
Summary and description of an issue may contain non-ASCII characters, so we need to use `unicode(issue)` instead of `str(issue)` to stringify an issue. Bug: 866873 Change-Id: I8d9a59c9c3864ccc21138b777dcf4e59637caf42 Reviewed-on: https://chromium-review.googlesource.com/1149010Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#577719}
-
Chris Mumford authored
There are a large number of crashes dereferencing a null ExtensionThrottleEntry. Temporarily adding a check for null to eliminate crashes and allow time for further investigation. TBR=rdevlin.cronin@chromium.org Bug: 866798 Change-Id: I785c7b907d5377ea42b1452af45d73306b87bd1e Reviewed-on: https://chromium-review.googlesource.com/1149064Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#577718}
-
Matt Wolenetz authored
In preparation for logging when there appears to be a mismatch between MSE MP4 keyframe metadata and the encoded video bitstream's keyframe metadata, this change incorporates basic analysis of the latter as part of the existing Annex-B bitstream validation for MSE MP4 video. Note that mp4::BitstreamConverter::AnalysisResult contains base::Optional<bool> for each of conformance and keyframe-ness fields. If a field doesn't have a value, that portion of the result was not analyzed. Note that keyframe analysis is implemented only for AVC currently, but even that is skipped if the frame is detected as non-conformant before enough indications of whether or not it is a keyframe are detected. Neither AVC-DV nor HEVC AnnexB analyses do any actual keyframe analysis, since such was either skipped or not yet implemented previously, respectively. A subsequent CL will use the newly reported MSE MP4 video bitstream converter's keyframe analysis results, if that analysis was done, in reporting to chrome://media-internals when the bitstream keyframe-ness mismatches that of the mp4 container for a coded frame. BUG=860420,584384 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I169c7774070ad232c86658bcd7803160323993ad Reviewed-on: https://chromium-review.googlesource.com/1144456 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#577717}
-
Clark DuVall authored
This test was timing out with network service enabled, due to the difference in behavior of the web request API in the network service. With network service enabled, when the first web request rule or listener is added, we reset all current URLLoaderFactories so they will be proxied through WebRequestAPI. They are then rebound when the connection error handler runs. This can lead to a situation where messages are dropped, due to the error message arriving asynchronously. For example: (1) First web request listener added, URLLoaderFactory bindings cleared (2) CreateLoaderAndStart is called on an existing URLLoaderFactory (3) Error message reaches existing URLLoaderFactories, and they are reset Due to the way mojo pipes work, the message from (2) will be dropped. This change makes that much less likely by clearing the URLLoaderFactory in the storage partition directly instead of waiting for the error handler to be called. Bug: 721414 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I633e3ea933f9170767371fde697bc9de2a5258af Reviewed-on: https://chromium-review.googlesource.com/1147072Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577716}
-
Oriol Brufau authored
[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in styleguide, and add check to avoid future uses Bug 850000 added standard logical properties and aliased prefixed ones to them. The prefixed properties are still used in various places, but the standard ones should be used instead. This patch updates the style guide so that it refers to the standard properties, and adds a new CSS presubmit check to ensure that the prefixed properties are not added back anywhere. Spec: https://drafts.csswg.org/css-logical/#box BUG=862141 Change-Id: I50166e5bf13259302eb02aaa16ec299c9b2a4b0a Reviewed-on: https://chromium-review.googlesource.com/1147524Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#577715}
-
Weidong Guo authored
1. Add rounded cap and join for the arrow. 2. Change from Point to PointF. Bug: 861845 Change-Id: Id0019af3eb3f43136dcf13ebe5349ab6e309732b Reviewed-on: https://chromium-review.googlesource.com/1148987Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#577714}
-
wutao authored
This cl creates a mojo service for assistant audio decoder. The decoder is running in utility process. This is a temporary solution until MediaService for Chrome OS is implemented. Bug: b/80315134 Test: manual tested can create the audio decoder for assistant. Change-Id: Ib4d1a8d3e6d38b0cbb436e20e6d12033d74ed7cf Reviewed-on: https://chromium-review.googlesource.com/1137020Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577713}
-
Lei Zhang authored
PrintingPdfContent() uses URLs to figure out if the content to be printed is PDF or not. This does not work when printing Flash content. Go back to checking PrintSettings::is_modifiable(), which already works correctly on Mac. On Windows and Linux, the "is modifiable" setting needs to be preserved when getting settings from the user in the native print dialog. BUG=859481 Change-Id: I674cf3c0f38b87c17fb6d2ca30ebae842c260d8c Reviewed-on: https://chromium-review.googlesource.com/1146024Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577712}
-
Matt Falkenhagen authored
These have all been enabled by default client-side or removed for some time: - PWAFullCodeCache in Chrome 67 - ServiceWorkerNavigationPreload in Chrome 59 - ServiceWorkerScriptFullCodeCache in Chrome 67 - ServiceWorkerScriptStreaming in Chrome 64 - SpeculativeLaunchServiceWorker was removed Bug: 661071, 683037, 768705, 640132 Change-Id: Id218f3882273063db7e4c358cac956ca54f362d8 Reviewed-on: https://chromium-review.googlesource.com/1147895Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577711}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4e04db90df438e59833761c1a70733247ddedee7 Reviewed-on: https://chromium-review.googlesource.com/1149070Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#577710}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5107ef4f..b4f02e85 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8b53f431d0d418b21b648a9d60b129cdcae0747b Reviewed-on: https://chromium-review.googlesource.com/1148814Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577709}
-
Donn Denman authored
Adds a new Feature for integration with Unified Consent. When this is enabled, and unified consent is on, the TTS opt-in promo will not be needed. We'll implement a follow-on CL that does the conditional disabling off of this flag. BUG=825428 Change-Id: I4becefb6bf3d1862f941bccd85c2bbc863cb99d4 Reviewed-on: https://chromium-review.googlesource.com/1148689Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#577708}
-
David Quiroz Marin authored
This fixes advances from TextMetrics for Right-to-left text. Currently it's returning values that are correct when there is just one text_run (or word), but the values are in the reverse order within each text_run for when there's more than one run. Bug: 864193 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6459f3800a33aedf46692b3931fb5778ee3ce825 Reviewed-on: https://chromium-review.googlesource.com/1144629Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577707}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/642c7b758944..75e5406be66a git log 642c7b758944..75e5406be66a --date=short --no-merges --format='%ad %ae %s' 2018-07-24 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 06235df9ff91..ddd6e8746851 (1 commits) Created with: gclient setdep -r src/third_party/skia@75e5406be66a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ibb99b6bf67291294a2bd5a10f917b0ba1b6ba6f2 Reviewed-on: https://chromium-review.googlesource.com/1148612Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577706}
-
Daniel Nicoara authored
Set the window name since it makes it easier to track windows while debugging. BUG=None TEST=Compiled Change-Id: I301c3c55dc5709d7b009c140d4bff57cccad3809 Reviewed-on: https://chromium-review.googlesource.com/1121081Reviewed-by:
-
Hector Carmona authored
Bug: 832938 Change-Id: Iefcd5912e94e4616277f5fdc401edf578f538b42 Reviewed-on: https://chromium-review.googlesource.com/1148773Reviewed-by:
-
Peter Kasting authored
The latter has various transformations around when it queries the underlying the provider and with what constants. Use this behavior in HasCustomColor() too. This ensures callers get consistent behavior in these cases. Along the way this changes a multi-arm conditional to a helper function. That isn't necessary for this patch, but it will make it easy to land subsequent ones that add more such constants. Bug: 862664 Change-Id: I83295902f7c38767c3a051a40e5f195f8e78e4ef Reviewed-on: https://chromium-review.googlesource.com/1147601 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#577703}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b140af05. With Chromium commits locally applied on WPT: 4bd63c29 "webrtc wpt: close RTCPeerConnection in generateAnswer helper" 9f17ab2f "Refactoring XR mojo interfaces" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21666 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Ia2b83e713246779aa75818735667cbe17592ae57 Reviewed-on: https://chromium-review.googlesource.com/1148805 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#577702}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/315f94a09617..36b2059cae7f git log 315f94a09617..36b2059cae7f --date=short --no-merges --format='%ad %ae %s' 2018-07-24 hnakashima@chromium.org Fix UAF in CPDFSDK_Widget::GetMixXFAWidget(). Created with: gclient setdep -r src/third_party/pdfium@36b2059cae7f The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:860697 TBR=dsinclair@chromium.org Change-Id: I226f5ba0eb56c7773a902ea3c44f30dbe867bf52 Reviewed-on: https://chromium-review.googlesource.com/1148608Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577701}
-
Devlin Cronin authored
It seems that ChromeExtensionsClient::Init() is taking a non-trivial amount of time (see linked bug). Add UMA so that we can track it, and measure any future improvements. Bug: 847237 Change-Id: I1b86dd9a8f2a7500841f253580a9e6d64c9f4d45 Reviewed-on: https://chromium-review.googlesource.com/1142617Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577700}
-
Nate Fischer authored
No change to production logic. Before this CL, locally compiled APKs will have a versionName attribute equal to "Developer Build". This CL changes public Chrome and WebView targets to use the real chromium version number from version.gni. This affects ChromePublic, ChromeModernPublic, MonochromePublic, and SystemWebView. Downstream targets will be addressed in a follow-up CL. R=agrieve@chromium.org, torne@chromium.org chrome_modern_public_apk, monochrome_public_apk) and run `aapt dump badging` on each APK and grep for 'versionName'. Bug: 866739 Test: Build APKs (system_webview_apk, chrome_public_apk, Change-Id: I4e1ab22a2d646ef996a84dd79b015754549bf6ad Reviewed-on: https://chromium-review.googlesource.com/1147871 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Richard Coles <torne@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#577699}
-
Oksana Zhuravlova authored
Change-Id: Ic544f6b27243a0342aab51ed3fb8a6f809c4a2cc Reviewed-on: https://chromium-review.googlesource.com/1148609Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#577698}
-
Moe Ahmadi authored
screenshot: https://drive.google.com/open?id=1td8sD7YO_VwIlY8WTW5xRc4es7bOslxu Bug: 860526 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9d2f1a589d9ae1bb5bac45c04ceb973f88385a84 Reviewed-on: https://chromium-review.googlesource.com/1145484 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577697}
-
Sunny Sachanandani authored
IsActiveTree() indirectly calls active_tree_.get() in LayerTreeHostImpl. Since std::unique_ptr::reset() nulls out its ptr before deleting the owned object, IsActiveTree() will always be false, and the swap promises will always be broken with ACTIVATION_FAILS. This causes LayerTreeHostTestSwapPromiseDuringCommit to fail when the wait for main frame or commit condition is removed from LayerTreeTest::EndTest(). R=danakj BUG=703263 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3819f76ab8f576c80faccf8db3ecd7ddb9b5954d Reviewed-on: https://chromium-review.googlesource.com/1145920Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#577696}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/68844342e7b7..17fb50f21647 git log 68844342e7b7..17fb50f21647 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 yueherngl@google.com rammus: add new paladin 2018-07-24 vapier@chromium.org cbuildbot: fuzzer: stop processing Chrome stages 2018-07-24 dgarrett@google.com gen_luci_scheduler: Add branched build config support. Created with: gclient setdep -r src/third_party/chromite@17fb50f21647 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iec8c0d9a4c45f7c216edc01bc296c7265358b320 Reviewed-on: https://chromium-review.googlesource.com/1148606Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577695}
-
Quan Nguyen authored
This button will launch the signin-trouble help app in a future CL. Bug: 863620 Change-Id: Ib6c3cf0179375502f7a5cde5a877c59d76ee73e8 Reviewed-on: https://chromium-review.googlesource.com/1145770 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#577694}
-
Annie Sullivan authored
Bug: 867103 Change-Id: I4130ebfd255a7db799d7a572ddc307267e4edbb7 TBR: charliea@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1148988Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#577693}
-
Muyuan Li authored
Bug: None Test: Manual Change-Id: I7a9968bb3b421ef26cc90dd68b063e514e3f4094 Reviewed-on: https://chromium-review.googlesource.com/1147502 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#577692}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d269b0e87d1e..e0ae2989b096 git log d269b0e87d1e..e0ae2989b096 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 benjhayden@chromium.org Add a new ReportTemplate system. 2018-07-24 simonhatch@chromium.org Disable a bunch of pylint warnings. 2018-07-24 nastasoiuf@google.com Initial implementation Created with: gclient setdep -r src/third_party/catapult@e0ae2989b096 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866260 TBR=sullivan@chromium.org Change-Id: I7f71d7246cfd6312d73d4ef4dac17b1c3c6af864 Reviewed-on: https://chromium-review.googlesource.com/1147917Reviewed-by:
-
