- 20 Nov, 2020 40 commits
-
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=Diagnostics* Change-Id: I4e4754937c0694814faa75dcad22b9cba457527d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550249 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#829677}
-
Christopher Cameron authored
Ensure that the CanvasImageProvider use its target canvas' color space as its target color space. This was previously hard-coded to sRGB, which caused images to be clipped when drawn to wide color gamut canvases. Bug: 1115286 Change-Id: I42c7cca905b5a9f525854ca2c6e99d0f87016eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551836 Commit-Queue: ccameron <ccameron@chromium.org> Auto-Submit: ccameron <ccameron@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#829676}
-
Alex Turner authored
IsAdRoot() implies IsAdSubframe(). However, some callers check whether IsAdRoot() || IsAdSubframe(). This cl removes these redundant checks and adds documentation to the methods to clarify their meaning. Change-Id: I62a437dead30141854351f3c9e7aecf9ecceec75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550429Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829675}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9dce4d081f8a..8c5889937172 2020-11-20 johnstiles@google.com Fix fuzzer crash when casting between int and float. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: Ie325aafd47ada43399eef0ae1561eda022656347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552471Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829674}
-
Joshua Pawlicki authored
This reverts commit df72c8d5. Reason for revert: external/wpt/native-io/rename_async_failure_handling.tentative.https.any.html external/wpt/native-io/rename_async_failure_handling.tentative.https.any.serviceworker.html external/wpt/native-io/rename_async_failure_handling.tentative.https.any.sharedworker.html external/wpt/native-io/rename_async_failure_handling.tentative.https.any.worker.html failing on multiple bots: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10 https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-rel Original change's description: > NativeIO: Add Error Handling for file errors > > This CL adds a mechanism to report file errors, as reported by > base::File::Error, though DOMExceptions. Due to security and privacy > considerations, not all errors are exposed to the user. For those > operations performed by the browser process (open, rename), the exact > error type is not exposed to the renderer. > > Errors that are not reported by base::File::Error are left unchanged and > will be addressed in a followup CL. > > The design document for this change is > https://docs.google.com/document/d/1rvs615AU2s8kVsmUlukbmtQNvUWFny0yzAS_gsnYZEs/ > > Bug: 1095537 > Change-Id: If047ddccb6464dd6efb2b06a5da262d049f1e9a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436344 > Commit-Queue: Richard Stotz <rstz@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829643} TBR=pwnall@chromium.org,mkwst@chromium.org,krivoy@google.com,rstz@chromium.org Change-Id: I1078ca3dd40685d711a9717b143f2974d62e084c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1095537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551842Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#829673}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cc8c82e4bcb7..7b66decf2b27 2020-11-20 alexrudenko@chromium.org Update CDP 2020-11-20 szuend@chromium.org TypeScript-ify ui/KeyboardShortcut.js 2020-11-20 szuend@chromium.org TypeScript-ify ui/Dialog.js 2020-11-20 sigurds@chromium.org Cleanups in front_end/ui/Treeoutline.js 2020-11-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-20 bmeurer@chromium.org [refactor] Reduce performance overhead of `ContentProviderBasedProject`. 2020-11-20 kimanh@chromium.org [e2e] Disable flaky recorder test 2020-11-20 jacktfranklin@chromium.org [DataGrid]: swap hidden flag to visible + hideable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1121900,chromium:1125968,chromium:1148713,chromium:1150793,chromium:1151234 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I32e2e874bcf15f77990c433c96cb40c22b9cba96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552466Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829672}
-
Denis Kuznetsov authored
Bug: 1150430 Change-Id: Idbfa4e0fc570ff243fa97e65883f9a62557937f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547289Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#829671}
-
Aaron Leventhal authored
This condition does not appear to have any use. I cannot find any reason for it and it only serves to make the code less clear. Bug: None Change-Id: If4a0dbca8bdd90ea4b65e7d8e0b55288fd8338da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551773Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#829670}
-
Sami Kyostila authored
The Perfetto tracing muxer now uses the "all data sources started" event[1] to detect when a tracing session is active (even if there are no data sources in the session). This patch implements support for emitting that notification in Chrome's Perfetto tracing backend. [1] https://android-review.googlesource.com/c/platform/external/perfetto/+/1505634 Change-Id: I7dd82245caca45df2571b30e583f1f2814a972a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551123 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#829669}
-
Alice Wang authored
This CL renames accountName to accountEmail for profile data related code. Bug: 1131344 Change-Id: I8651cd5759c38844444fbbe199391baa3f4f9d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552392Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829668}
-
Sorin Jianu authored
This is the first of a series of three or four CLs to rename the ControlService related names in the updater project. This CL consists in a global mechanical replacement of ControlService->UpdateServiceInternal, control_service->update_service_internal, and fixing related whitespace. The next CL is going to rename related names in the Windows COM interfaces and implementations. The third CL renames the source files and build files. The last CL cleans up some potential macOS issues and wraps it up. Bug: 1151106 Change-Id: Ib5b66d1fb50c100042310726ccac6121d685720c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551260Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829667}
-
Mohamed Heikal authored
Local sizediffs shared as oneoffs can include private symbols. Detect if so and upload privately instead. Change-Id: I62d17183716afe18b02c4a005c56c1190bc97115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552204 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829666}
-
Nohemi Fernandez authored
For MICE we are moving all identity information into the top-level Settings page. The Google Services Settings will now only contain the relevant Services information. Before: https://drive.google.com/file/d/1IaeI3UWGWIeFEWWR8s_FZIFQ_99ZDqha After: https://drive.google.com/file/d/1jP4iYi5Fewd1o2hn5scJEwaYW-jgmdsK Bug: 1151296 Change-Id: I6ce11e114873ae9ec411bfb6aeec342c4165083d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550555Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#829665}
-
Ossama Mahmoud authored
This fix allows the user to submit by clicking the enter key after typing the old password. Bug: 1110051 Change-Id: I1068dce770926163705c401495a8c145452c55ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550186Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Cr-Commit-Position: refs/heads/master@{#829664}
-
Hannes Payer authored
PartitionAlloc: PCScan: Perform scan only when quarantine is larger than the minimum scanning threshold. This CL also another Reclaim mode to PartitionAllocMemoryReclaimer to force a scan when memory is critical. Bug: 11297512 Change-Id: I054d8d032ed0b7e3abc9da57b33e6e471c830ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550062 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#829663}
-
Jérôme Lebel authored
-[SceneController openURLInNewTabWithCommand:] is not used, -[SceneController openURLInNewTab:] should be used instead. Change-Id: I5a650a7e2fe44fd46e8733b2c6dc1dcf8b9511dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552389Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#829662}
-
Sigurd Schneider authored
This CL refactors DedicatedWorkerServiceImpl to keep a pointer to the DedicatedWorkerHost instead of the DedicatedWorkerInfo. Bug: chromium:1145158 Change-Id: I081c77c04fa4741dd244ca1939cac6916a7f15c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517579 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#829661}
-
Marc Treib authored
This was an explicit ordering of all ModelTypes, used to determine the order in which to kick off LoadModels() on all the controllers. However, the next layer (DataTypeManagerImpl) anyway waits until all types have finished loading before continuing with the next stage, so the order really makes no difference. Bug: 1102837 Change-Id: If1c60d9861655c3540218cb06a1f2285872720c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550671 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#829660}
-
Eric Lawrence [MSFT] authored
Previously, this test would filter console messages to only the success string, leading to a 30 second delay for the timeout to be reached in the event of a failure. Change the test to filter for any relevant console messages to enable the test to fail more quickly. Bug: 1111261 Change-Id: Ia2c7e4945de9344e440a0430c53dfb45624fbb74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550582 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#829659}
-
Benoit Lize authored
Whether the renderer is backgrounded is not used anymore, no need to track it. Change-Id: I4547feceb362d5fba90fbabf0b3842862a2d6af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552404Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#829658}
-
Michael Lippautz authored
- Move kMaxHeapObjectSize to HeapAllocator as Oilpan has no internal restrictions on object sizing other than ultimately running OOM. - Size quantization for Oilpan can just return whatever is required to match capacity needs. Internally, sizes may be padded and aligned accordingly. Bug: 1056170 Change-Id: I5c833a2b6cb5354bd24b117406e68fe18e622f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551121Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#829657}
-
Vasilii Sukhanov authored
compromised passwords and mutes. Bug: 1137775 Change-Id: If9f2d4e7b130318a1f1ff6c12f4ef04fb0e005af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550045 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#829656}
-
Karandeep Bhatia authored
Currently the docs are not clear on whether priority is optional or mandatory. Make it optional and clarify the same. Skipping presubmit since this seems to be hitting crbug.com/956368. BUG=1150821 No-Presubmit: True Change-Id: I68ade1dc31b3d56bd49f195fe41d7db69a164fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550364 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829655}
-
Mikhail Khokhlov authored
It appears that on some devices the SignalStrength.getLevel method requires the READ_PHONE_STATE permission that Chrome doesn't have. This CL catches the exception to avoid crash in this case. Bug: 1150536 Change-Id: I1fcbdbbe36d62cc48357e01f66654ca1c1fe5291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549967Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#829654}
-
Chris Sharp authored
Change-Id: Idf8027acd402ce8faf8095370688ea8f33f46fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551513Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#829653}
-
sandromaggi authored
This changes the signature of |WebController::SelectOption| to take a regular expression (string) and a value source instead of the previous strategy. The regular expression is matched in JS (similar to how |TextFilter| works in |ElementFinder|), which makes it a "contains" by default. The matching is done case insensitive as was done so far. The |RequiredFieldsFallbackHandler| still operates on the strategy and builds the regexp on the client. This is done to reduce complexity in that action. Currently the script does not know whether or not a field is a dropdown, this is evaluated on the client. Setting a regular expression as a value would be possible but potentially confusing. Bug: b/171281545 Change-Id: I00ab0bcf518d16063ceeae60da4b854707cfeff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542983 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829652}
-
Vasiliy Telezhnikov authored
VulkanContextProvider is created before GrShaderCache and so cache wasn't pass to Skia via GrContextOptions. This CL defers init of GrContext in VulkanInProcessContextProvider to SharedContextState::InitializeGrContext to mitigate this. Use of cache itself is under feature flag for metrics comparison and a kill switch purpose. Bug: 1151031 Change-Id: Idc410b9b557f7ca67164eb80d6a37a27ceb0f6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551245Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829651}
-
Thomas Tellier authored
Bug: 1104336 Change-Id: I7669ebd551e003c0199a3274af38ab0287fcc0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547441Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#829650}
-
Elizabeth Popova authored
Prior this change, at the bottom of the dialog there was always a label with text "* Field is required". Now this text is only shown when there is at least one required field. For now it only affects the AddressEditor usage opened from Autofill Settings. Bug: 1149568 Change-Id: I581c7ca6e89f1aaacb3e698dd3fb21981f2aa087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536438 Commit-Queue: Elizabeth Popova <lizapopova@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#829649}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605851942-6f480177b4524c7e895c150a8dd7d9195900edb6.profdata to chrome-linux-master-1605873573-9397db153d32d8ff4c4f46949924e1cd67fa6977.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9fc090440237088088fcb09c2a5ea40eee028f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552467Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829648}
-
Sigurd Schneider authored
Bug: chromium:1011811 Change-Id: Ia1473a40ff26070f87ef8ff5bcbcba0286fb9976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550828 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#829647}
-
Michael Lippautz authored
Re-structure write barrier to allow delegating to the Oilpan library. Bug: 1056170 Change-Id: I872fdb902a51d16d985f4e88ffd7e9368bf46623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551115 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#829646}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aaaa5b96c66b..68553be73643 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mmoskvitin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mmoskvitin@google.com Change-Id: If8b50089b7fbfe935c6664647e67417b899ccf2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552464Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829645}
-
Peter Boström authored
Adds View::GetMirroredContentsBounds() which takes view insets into account. Bug: 1150725 Change-Id: I2d07b90f6388790fdb442f172b72452a5401ea03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551082Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#829644}
-
Richard Stotz authored
This CL adds a mechanism to report file errors, as reported by base::File::Error, though DOMExceptions. Due to security and privacy considerations, not all errors are exposed to the user. For those operations performed by the browser process (open, rename), the exact error type is not exposed to the renderer. Errors that are not reported by base::File::Error are left unchanged and will be addressed in a followup CL. The design document for this change is https://docs.google.com/document/d/1rvs615AU2s8kVsmUlukbmtQNvUWFny0yzAS_gsnYZEs/ Bug: 1095537 Change-Id: If047ddccb6464dd6efb2b06a5da262d049f1e9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436344 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#829643}
-
Gyuyoung Kim authored
This CL replaces all uses of net::EffectiveConnectionType with blink::mojom::EffectiveConnectionType to reduce type conversion between them in blink. Bug: 919392, 1097943 Change-Id: I42db0329e9a0e436391e30779d69cf8d7f8040cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550321Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#829642}
-
Dave Tapuska authored
Move the self keep alive member into the base class. Remove Close overrides. Remove Compositor() dead code. Remove web_view_ member and use View(). This leaves one method left in the subclasses. BUG=1097816 Change-Id: I7fd2c6fd87c8990070f329a6ade53cbe4f94cf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548500 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#829641}
-
Maksim Ivanov authored
Document the minimum Chrome version for the new enum values in the chrome.certificateProvider API that were introduced in r828892 (the new PSS-related entries in the Algorithm enum). Without this change, the documentation at developer.chrome.com doesn't contain information that these enums were added later than the other ones. Apparently, the documentation only autogenerates these notices for types and methods, but not for enum items. Bug: 792204 Change-Id: Ia81a11691d9db5e1ba75cacd0d6dda53e679d0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550545 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#829640}
-
Alice Wang authored
This CL changes the current variable name accountId to accountEmail so that we can have a consistent name for account email. Bug: 1131344 Change-Id: I652755e7485673d6611622f5bd60aceda5d849ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550827Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829639}
-
Xi Han authored
Start. Bug: 1150937 Change-Id: Ief46f56a25ec90a35a84aa15c0c2a04f4d67d203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551795Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829638}
-