- 14 Jul, 2018 11 commits
-
-
Mina Almasry authored
A number of changes to improve AV sync at playback start: - AvSync now will not perform corrections if it measures a slope that is way off from what it expects. There are a number of reasons this could happen: - Samples measured right after resuming playback may be from the paused state, which messes with the measured slope. This is especially important given our current interaction with the BufferingController... - Some vendor video decoder implementations will play video at an accelerated rate if they are not able to start playback in time, to 'catch up' to the required value, and then resume normally. We need to ignore this behavior in AvSync. - Modify the initialization of AvSync a bit to treat Start/Stop similar to Pause/Resume. From the prespective of AvSync these should be identical calls, and should maybe be combined to one in the future. Also, due to the interaction with BufferingController, Start is actually Start + Pause + Resume, so we need to treat Resume as we do for Start, because the start of playback is actually the first Resume. - For AvSync to compare the slope to an expected case, it needs to know the current rate of playback, so add code from MediaPipelineBackend to notify AvSync of playback rate changes. - As a bonus, the playback rate change is handled a bit better now. It's not perfect, but this is the first time I'm testing it as it seems no app supports it. - Add ability for linear regression to dump its samples. This is very useful for debugging unexpected slope calculations. This was very useful to root cause the issue. Bug: b/110481225 Test: Manual Change-Id: I28ffa83c633446f2441ff5dfb8d5674b5e149ea5 Reviewed-on: https://chromium-review.googlesource.com/1132518Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#575130}
-
Takumi Fujimoto authored
Add CastDialogMetrics, which will be used by CastDialogView to record various UI metrics. The recorder will keep track of when/if certain events (init, paint, load sinks, first user action) happened, to record when an event happens for the first time, and the durations between events. MediaRouterMetrics calls that CastDialogView was making directly will now go through CastDialogMetrics. Metrics recorded by CastDialogMetrics via MediaRouterMetrics: MediaRouter.Ui.Device.Count MediaRouter.Ui.Dialog.Paint MediaRouter.Ui.Dialog.LoadedWithData (new) MediaRouter.Ui.Action.StartLocalPosition MediaRouter.Ui.Action.CloseLatency (new) MediaRouter.Ui.Action.StartLocal.Latency (new) (MediaRouter.Ui.FirstAction will be added later) (MediaRouter.Ui.Action.StopRoute will be added later) Bug: 853369 Change-Id: Ib27ecc9293fd148d8592b76b22c9fbab3910a5e5 Reviewed-on: https://chromium-review.googlesource.com/1135582 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575129}
-
Yafei Duan authored
Use the first tile of the 'Most Visited' as the homepage tile when NTPButton is enabled. HomepageClient will be used to provide information of the homepage from Java to native side, and the tile will be added (if necessary) along with other tiles aggregated by MostVisitedSites. The homepage tile will always be the first tile if enabled, currently it would not be degraded as other tiles, unless the user removes it from NTP. This CL mostly revives the code removed by the following CLs: https://chromium-review.googlesource.com/c/chromium/src/+/1087048 https://chromium-review.googlesource.com/c/chromium/src/+/1087270, and ignoring the changes related with Chrome Home. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I261a0c4cff8e3beb37f4a97db33512abc87b2f23 Reviewed-on: https://chromium-review.googlesource.com/1132613Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#575128}
-
Ryan Hansberry authored
This provides a simple wrapper around MultiDeviceSetup service, allowing it to easily be stubbed out in tests. R=khorimoto@chromium.org Bug: 824568 Change-Id: I3a15ee75cc2886f15dabd90a8b5bba7712a9201e Reviewed-on: https://chromium-review.googlesource.com/1136897Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#575127}
-
Xiaocheng Hu authored
When the first letter part of a text node has 'visibility' CSS property set to non-visible, while the remaining text remains visible, current TextIterator fails to skip the first letter part and proceed to remaining text correctly. This patch fixes that. This patch also reveals other existing issues in TextIterator, which will be fixed later. Bug: 858924 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id2a52d229393d9f6c4d3a664ac24d794e836cff1 Reviewed-on: https://chromium-review.googlesource.com/1134487Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575126}
-
Takumi Fujimoto authored
When the dialog reports the number of sinks, pseudo sinks should be excluded, because they aren't real sinks and they inflate the number of devices recorded. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ieb8840c0a06c98ca76275e682fcfa42ca52629a8 Reviewed-on: https://chromium-review.googlesource.com/1137029Reviewed-by:
-
Vladimir Levin authored
This is called frequently and might be skewing parent slice times when tracing. R=chrishtr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibfc3f81b78b191a5a7e1dfc44933796337763ca7 Reviewed-on: https://chromium-review.googlesource.com/1137337Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575124}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/882c91ed97c3..579c98612b6f git log 882c91ed97c3..579c98612b6f --date=short --no-merges --format='%ad %ae %s' 2018-07-13 ehmaldonado@chromium.org Reset the fetch config in the bots before each run. Created with: gclient setdep -r src/third_party/depot_tools@579c98612b6f The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:862547 TBR=agable@chromium.org Change-Id: If4f65f2adf63d619ef4846a57255dcdae2d9badf Reviewed-on: https://chromium-review.googlesource.com/1137313Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575123}
-
bsheedy authored
Renames/moves a number of files related to VR/AR testing: 1. "Vr" files that apply to both VR and AR have been renamed to "Xr" 2. "WebVr" tests have been moved to "WebXrVr" 3. "VrShell" tests have been moved to "VrBrowser" 4. //chrome/test/data/vr has been moved to //chrome/test/data/xr Bug: 863256 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I09cd6f7dad1c62377ac13106fbda2050908be138 Reviewed-on: https://chromium-review.googlesource.com/1136009 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#575122}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b2ecc3dc49dc..c528c0a07f85 git log b2ecc3dc49dc..c528c0a07f85 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 emircan@webrtc.org Revert "Reland "Add Profile 2 configuration to VP9 Encoder and Decoder"" 2018-07-13 mhoro@webrtc.org I have been informed that the fix to libvpx for which the unit test in this CL was created has been rolled into chrome. Consequently, I will again revert to (hopefully) land this CL. 2018-07-13 emircan@webrtc.org Reland "Add Profile 2 configuration to VP9 Encoder and Decoder" Created with: gclient setdep -r src/third_party/webrtc@c528c0a07f85 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I115873bc98e2a78877c7dbc7b269d90fc7d04455 Reviewed-on: https://chromium-review.googlesource.com/1137312Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575121}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ecbaf6663915..06ca634eba4a git log ecbaf6663915..06ca634eba4a --date=short --no-merges --format='%ad %ae %s' 2018-07-13 jmadill@chromium.org Vulkan: Refactor for draw call shader patching. 2018-07-13 fjhenigman@chromium.org Vulkan: prepare for buffer format fallbacks. Created with: gclient setdep -r src/third_party/angle@06ca634eba4a The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I2afba6ae066406e279dd5a8a72ccff80bafa97bb Reviewed-on: https://chromium-review.googlesource.com/1137311Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575120}
-
- 13 Jul, 2018 29 commits
-
-
Yue Cen authored
This screen should show after the user accepts ARC terms of service. Bug: 835029 Change-Id: Ib17cc71e5c322cbe48fa824c299d5269d30226c1 Reviewed-on: https://chromium-review.googlesource.com/1111334 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#575119}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a50a4e11ae0f..0cd3404ce483 git log a50a4e11ae0f..0cd3404ce483 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@0cd3404ce483 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I67c669c3b7aeb62d34e7bc95c63f066eed3dc36e Reviewed-on: https://chromium-review.googlesource.com/1136773Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575118}
-
Alexander Alekseev authored
Bug: 857193, b/79987581 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iebac32d290096c148a615bf0b3d1278a9038649b Reviewed-on: https://chromium-review.googlesource.com/1136010 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Tommy Steimel authored
This reverts commit 76ee32bd. Reason for revert: Histogram recording crashes Chrome if it isn't already open because native isn't initialized. Original change's description: > [Media Intent Handler] Add UMA metrics for media type > > This CL adds a MediaLauncherActivity.MediaType histogram to track the > type of media the user opens with the MediaLauncherActivity > (audio/image/video). > > Bug: 861954 > Change-Id: I28cc0a379ad2bc70d34f2d2f5751c3eb2ebbda45 > Reviewed-on: https://chromium-review.googlesource.com/1135522 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575071} TBR=mlamouri@chromium.org,holte@chromium.org,steimel@chromium.org Change-Id: Ic090a8660d6139fc6043a8990b0c6966a9cb311e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 861954 Reviewed-on: https://chromium-review.googlesource.com/1137392Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575116}
-
Ken Rockot authored
We never want to explicitly close a Channel endpoint until after the corresponding child process is dead. This prevents that from happening in some cases where it's still possible today. TBR=dcheng@chromium.org Bug: 859386,861607,863430 Change-Id: I2858b6e011e06a000ae976c1e6ae96595cf67a85 Reviewed-on: https://chromium-review.googlesource.com/1135712 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#575115}
-
chrome://omniboxMark Pearson authored
as this can affect what suggestions are offered a lot, and sometimes isn't obvious from looking at the input. Only show this in "detailed" mode. Also move cursor position information into detailed mode section, as we rarely need it. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic78751fe07c968f4fa30854cb7e3bb1442f0fcb2 Reviewed-on: https://chromium-review.googlesource.com/1119232Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#575114}
-
Katie D authored
Fixes a bug by using a "while" rather than an "if" when stepping to the next node in word boundary events. This allows STS to skip nodes if they are not spoken, which may occur if there are nodes that are punctuation only in the list, like ")" or "-". For example, on the English alphabet Wikipedia page, A a * B b * C c * etc, the * node is not spoken, which causes highlight to get delayed because those nodes could not be skipped. Changing the "if" to a "while" fixes that. Bug: 830116,830116 Change-Id: Ic40aa7c32ab10db3a084e94f1d4db49f096abd9c Reviewed-on: https://chromium-review.googlesource.com/1136524Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#575113}
-
Taylor Bergquist authored
The various content setting bubbles were listening to their radio buttons and maintaining a separate copy of the buttons' checkedness state. However, radio buttons didn't notify their listeners when the arrow keys were used to change checkedness; they only notified on mouse events. This CL makes the bubbles refer to the actual radio button state when closing instead of listening to the buttons. It also gets rid of radio button listening as a thing, since it didn't work anyways and nobody else was using it. Other yaks shaved by this change: - Remove Checkbox::set_listener so that it can't be called on radio buttons. Listeners must be added at construction time now. - Move the business logic out of destructors in the content setting bubbles so that the bubble models can reference their views without worrying about them having been already cleaned up. It's now in an explicitly invoked separate method 'CommitChanges'. - The RPH (register protocol handler) content setting bubble was the only one that applied settings changes as users clicked on radio buttons, rather than when the dialog was closed. It's now consistent with the other bubbles. Bug: 841202 Change-Id: I16761571fd03bb1925d95995d8b7e6f0e03aa02a Reviewed-on: https://chromium-review.googlesource.com/1128377Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#575112}
-
Kim Paulhamus authored
-virtual/gpu/fast/canvas/canvas-blend-image.html -external/wpt/requestidlecallback/callback-iframe.html TBR: tkent@chromium.org Bug: 863350, 863599 Change-Id: I56246e6b83ecad9365a2974f82e17f5d8e7de65a Reviewed-on: https://chromium-review.googlesource.com/1137234Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#575111}
-
liberato@chromium.org authored
This CL adds a cleanup CB to AbstractTexture, so that it can notify the client that it is no longer keeping a reference to the underlying TextureBase. This lets the client perform any cleanup tasks that are associated with either (a) the client dropping the AbstractTexture or (b) the decoder stub being destroyed. This CL also modifies TexturePool to use it, rather than sending a callback to be run when the sync token clears. This has the advantage of freeing codec resources immediately upon context loss, rather relying on VideoFrame cleanup to happen properly when the renderer is being torn down. Bug: 863012 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I672ae8831c1e5a8d92aa3812fa938901d2a171fd Reviewed-on: https://chromium-review.googlesource.com/1135757Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#575110}
-
Reilly Grant authored
This is a follow-up to r564119 where it was suggested that by always returning true from ShouldShowIconBeforeText() the "no devices found" message would be offset to the right. To fix this, when there are no options to display this change hides the table view entirely and displays the message using the same style of overlayed label as the "adapter off" message. Bug: 654137 Change-Id: I7544698425e94fb3d1666ba9c70063091f85f438 Reviewed-on: https://chromium-review.googlesource.com/1117873 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#575109}
-
erikchen authored
There appears to be a bug in Launch Services that causes MallocNanoZone=1 to always be set by default for all applications [this affects applications launched by Finder, and on restart, but not applications launched from the Terminal]. I filed https://bugreport.apple.com/web/?problemID=42181038 to track this. MallocNanoZone causes libMalloc to use the nano malloc zone by default [affects allocations <= 256 bytes]. The implementation of nano malloc never frees memory. See https://bugs.chromium.org/p/chromium/issues/detail?id=861939#c6 for more details. This has been observed to cause > 1GB of wasted memory in the browser process. Possibly a lot more when added up across all processes. To test this: 1) Build Chrome with patch. 2) Run /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister -f <path_to_chrome> 3) Launch Chrome from Finder 4) Use "vmmap <pid>" to observe whether there is a MALLOC_NANO summary. Bug: 861939 Change-Id: I740bcbb006e4ce641d0dde6f6e53dcf4f032ff0b Reviewed-on: https://chromium-review.googlesource.com/1137131Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575108}
-
Oksana Zhuravlova authored
Change-Id: I97dd67db41337f69cc9ed54eb743b7f1664301f3 Reviewed-on: https://chromium-review.googlesource.com/1137271Reviewed-by:
-
Toni Barzic authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/ec6d4902f36c..0eac64e18aba $ git log ec6d4902f..0eac64e18 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 phongo Un-deprecate supervision_transition field. 2018-07-10 dgreid vm_concierge: Add an export message 2018-07-09 baileyberro system_api: Add StartCopy and ContinueCopy to SmbProvider constants 2018-07-06 tbarzic Add is_demo_session to UpgradeArcContainerRequest 2018-06-26 hychao service_constants: Add GetSystemAecSupported method 2018-06-28 baileyberro system_api: Add Smb Copy Errors 2018-06-22 zachr vm_cicerone: add debug information constants 2018-05-22 xzhou cryptohome: add nvspace bootlockbox protos Created with: roll-dep src/third_party/cros_system_api Change-Id: I1d4d9f055c3fd9e4dbca69755fb3d40a162e0448 Reviewed-on: https://chromium-review.googlesource.com/1137056Reviewed-by:
-
Dan Harrington authored
Bug: 860228 Change-Id: I8ea5f1f39b8d9a62b5f2a4c608e9a1054d0fb297 Reviewed-on: https://chromium-review.googlesource.com/1129466 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#575105}
-
Wez authored
Previously Fuchsia required IPv4 multicast binding to specify the desired interface by its IP address, requiring an extra step to look up the address based on the interface index. Fuchsia's netstack now supports binding using the interface Id directly, which is what we use on all other platforms than MacOS, so switch to using that version of the API. Bug: 862189 Change-Id: Idecc66cb1d6e7bbe0ab1061dbb96c12114cac9dc Reviewed-on: https://chromium-review.googlesource.com/1136390Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#575104}
-
Tom Anderson authored
BUG=863460 R=thakis Change-Id: I658c215071c5dfe9dcc2b7e7bc5a5d21ee57ac18 Reviewed-on: https://chromium-review.googlesource.com/1136495 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#575103}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a80a012456a9..1128ebcb6dde git log a80a012456a9..1128ebcb6dde --date=short --no-merges --format='%ad %ae %s' 2018-07-13 reed@google.com make u32 check runtime Created with: gclient setdep -r src/third_party/skia@1128ebcb6dde The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:848521 TBR=robertphillips@chromium.org Change-Id: I7a78fd591eae7f4a7916fcce8e977fa1d8a8ed80 Reviewed-on: https://chromium-review.googlesource.com/1136772Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575102}
-
Kevin Strohbehn authored
Bug: 863479 Change-Id: Iad8c001d9ae2ce9606a31d98cc694f904b900b86 Reviewed-on: https://chromium-review.googlesource.com/1136974Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#575101}
-
Jordy Greenblatt authored
The main change in this CL is the addition of the Smart Lock icon, and with it the necessary infrastructure for adding the of the icons. There are also some alignment and naming cleanups. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I13b32e26228bbea02378ef03a74405be1b926c46 Reviewed-on: https://chromium-review.googlesource.com/1136896Reviewed-by:
-
Kenneth Russell authored
Since all of the 10.12.6 machines were upgraded to 10.13.5 this has been failing. Tbr: jmadill@chromium.org Bug: 856799 Change-Id: I7937b7b8a3d59b3d2e60db9665f3ffb89dd5b745 Reviewed-on: https://chromium-review.googlesource.com/1137254Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575099}
-
Patti authored
Show the number of cookies on a domain / eTLD+1 group of sites in All Sites. Since cookies at their widest scope can be set on eTLD+1s, this display will be restricted to sites that are grouped. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I66d2c36b2af1ad577d4d71512f3d22541e1c926f Reviewed-on: https://chromium-review.googlesource.com/1111770Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#575098}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3a83fe5cf6cf..cf403ba5720c git log 3a83fe5cf6cf..cf403ba5720c --date=short --no-merges --format='%ad %ae %s' 2018-07-13 hnakashima@chromium.org Create API to remove a parameter from a content mark. 2018-07-13 hnakashima@chromium.org Create API to remove a content mark from a page object. 2018-07-13 hnakashima@chromium.org Fix mark parameters not saved if nothing changed. 2018-07-13 thestig@chromium.org Validate out-parameters in FPDF_GetPageSizeByIndex(). Created with: gclient setdep -r src/third_party/pdfium@cf403ba5720c The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I95b79f108eaf746ab80a49bb122a5cd4410b8839 Reviewed-on: https://chromium-review.googlesource.com/1136494Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575097}
-
Guido Urdaneta authored
Some devices report zero frame rates in their supported video formats and this makes getUserMedia() fail if frame-rate constraints are used. This CL replaces zero frame rates with a fallback frame rate to work around this issue. Bug: 862325 Change-Id: If7e844856d9652480ed6bca607037dc0a4b9b7c4 Reviewed-on: https://chromium-review.googlesource.com/1136642Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#575096}
-
Malay Keshav authored
This patch achieves two goals. 1. Snaps the NativeHostView of the extension popup to the physical pixels. This is because NativeHostView's layer will have a render surface of its own which needs to be snapped to the physical pixels for all its content to be snapped as well. 2. Snaps the RenderWidgetHostView to the nearest ancestor instead of of the toplevel or root window. This ensures that it snaps to the render surface it belonds too, instead of snapping to some other render surface in the hierarchy. To achieve the two goals, this patch also moves the utility method that snaps windows to its nearest snapped ancestor window from src/ash to ui/wm/core. Bug: 843250 Change-Id: I9d9f0bdd2391b1d9904537ec8580de72d225fdf6 Component: Windows, Snap to physical pixel, HighDPI, extensions Reviewed-on: https://chromium-review.googlesource.com/1121330 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Yue Cen authored
There is an "App downloading" screen after user chooses to install the selected packages. The screen is added in this CL. Bug: 835029 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8412980e0e1bec0ff1d9257a509f3ccf6bf77c8f Reviewed-on: https://chromium-review.googlesource.com/1103665 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
-
Kim Paulhamus authored
TBR: tkent@chromium.org Bug: 863544 Change-Id: Ie4f20bb619366eb7e9ac296ac4497ec27241a7b1 Reviewed-on: https://chromium-review.googlesource.com/1136971Reviewed-by:
-
Francois Doray authored
With this CL, frozen tabs can be unfrozen at configurable intervals for a configurable amount of time. The goal of unfreezing tabs is to let them update their state, so they are up to date when they are reactivated. The code enforces that a single tab is unfrozen at a time. Bug: 775644 Change-Id: Ifd57c4ef0aea866089a931020242bc60486f6edd Reviewed-on: https://chromium-review.googlesource.com/1135639 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#575092}
-
Nico Weber authored
- Run components_browsertests on 32-bit linux dbg main waterfall bot, and on the win7 and win10 dbg main waterfall bots. If the tests end up failing there, we can re-disable them with a link to a bug explaining what exactly fails. - Run mash_unittests on the fyi Mojo ChromiumOS bot (suite takes seconds to run). Bug: 843511 Change-Id: I6b529723300ade97712e5e360dfddff8d8d64c40 Reviewed-on: https://chromium-review.googlesource.com/1136464Reviewed-by:
-
