GitLab

This is a reland of d260e9cf

It was reverted because of crbug.com/824716, these weren't new crashes
but known crashes mislabeled as a fallout of this change.
http://cl/190471699 fixes the crash backend to not rely on
"content::BrowserThreadImpl::IOThreadRun" being in the signature.

Only diff in this CL is to use base::debug::Alias() in methods that we
don't want optimized (i.e. IOThreadRun) out as CHECK_GT was seen as
optimized out in some of the reported crashes (even though the same
pattern as before was used by this CL..?)

Original change's description:
> Refactor BrowserThreadImpl, BrowserProcessSubThread, and BrowserMainLoop
>
> This brings back the invariant that BrowserThread::IO isn't available
> before BrowserMainLoop::CreateThreads(). This was broken to fix issue
> 729596 to bring up the thread earlier for ServiceManager but it is
> important that code that posts to BrowserThread::IO statically have an
> happens-after relationship to BrowserMainLoop::CreateThreads(). Exposing
> it statically earlier put that invariant at risk.
>
> Thankfully fixing issue 815225 resulted in finally reaching the long
> sought goal of only having BrowserThread::UI/IO. Now that the IO thread
> is also kicked off before it's named statically, BrowserThreadImpl no
> longer needs to be a base::Thread, hence this refactoring.
>
> Before this CL:
>  * BrowserThreadImpl was a base::Thread
>    (could be a fake thread if SetMessageLoop was used)
>  * BrowserProcessSubThread was a BrowserThreadImpl
>    (performed a bit more initialization)
>  * BrowserProcessSubThread was only used in production (in
>    BrowserMainLoop)
>  * BrowserThreadImpl was used for fake threads (BrowserMainLoop for
>    BrowserThread::UI) and for testing (TestBrowserThread(Impl)).
>  * BrowserThreadImpl overrode Init/Run/CleanUp() from base::Thread to
>    perform some sanity checks as well as drive IOThread's Delegate (ref.
>    BrowserThread::SetIOThreadDelegate())
>  * BrowserProcessSubThread re-overrode Init/Run/CleanUp() to perform
>    per-thread //content initialization (tests missed out on that per
>    TestBrowserThread bypassing BrowserProcessSubThread by directly
>    subclassing BrowserThreadImpl).
>
> With this CL:
>  * BrowserThreadImpl is merely a scoped object that binds a provided
>    SingleThreadTaskRunner to a BrowserThread::ID.
>  * BrowserProcessSubThread is a base::Thread and performs all of the
>    initialization and cleanup specific to //content (this means it now
>    also manages BrowserThread::SetIOThreadDelegate())
>  * BrowserProcessSubThread can be brought up early before being bound to
>    a BrowserThread::ID (BrowserMainLoop handles that through
>    BrowserProcessSubThread ::RegisterAsBrowserThread())
>
> Unfortunate exceptions required for this CL:
>  * IOThread::Init() (invoked through BrowserThreadDelegate) perfoms
>    blocking operations this was previously performed before installed
>    the ThreadRestrictions on BrowserThread::IO. But now that //content
>    is initialized after bringing up the thread, a
>    base::ScopedAllowBlocking is required in scope of IOThread::Init().
>  * TestBrowserThread previously bypassing BrowserProcessSubThread by
>    directly subclassing BrowserThreadImpl meant it wasn't subject to
>    ThreadRestrictions (unfortunate becomes it denies allowance
>    verification to product code running in unit tests). Adding it back
>    causes DCHECKs, as such
>    BrowserProcessSubThread::AllowBlockingForTesting was added to allow
>    this CL to pass CQ.
>
> Of note:
>  * BrowserProcessSubThread is still written as though it supports many
>    BrowserThread::IDs but in practice it's mostly always
>    BrowserThread::IO (except in ThreadWatcherTest I think). This change
>    was big enough that I didn't bother also breaking that
>    generalization.
>  * BrowserThreadImpl's constructor was made private to ensure only
>    BrowserProcessSubThread and a few select callers get to drive it (to
>    avoid previous missed initialization issues)
>  * Atomics to manage BrowserThread::SetIOThreadDelegate were removed.
>    Restriction was instead added that this only be called before
>    initialization and after shutdown (this was already the case).
>
> Follow-ups to this CL:
>  * //ios duplicates this logic and will need to undergo the same change
>    as a follow-up
>  * Fixing ios will allow removal of base::Thread::SetMessageLoop hack :)
>  * Removing BrowserThreadGlobals::lock_ to address crbug.com/821034 will
>    be much easier
>  * BrowserThread post APIs should DCHECK rather than no-op if using a
>    BrowserThread::ID before it's registered.
>
> Bug: 815225, 821034, 729596
> Change-Id: If1038f23079df72203b1e95c7d26647f8824a726
> Reviewed-on: https://chromium-review.googlesource.com/969104
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544440}

TBR=jam@chromium.org

Bug: 815225, 821034, 729596, 824716
Change-Id: I9a180975c69a008f8519d1d3d44663aa58a74a92
Reviewed-on: https://chromium-review.googlesource.com/980793Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546104}

Remove the WebMouseEvent dependency in MouseEvent
and all its subclasses like DragEvent and WheelEvent.

Bug: 820249
Change-Id: Icc62baea6862901cb91a531f7b649c6858ee94dd
Reviewed-on: https://chromium-review.googlesource.com/956543
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546103}

The fix is to reduce the scope of the |lock_| during track adapter
creation because Create[Local/Remote]TrackAdapter() may synchronize with
another thread that is busy waiting for the |lock_|. There is no reason
to hold the |lock_| while creating the adapter; we are ensured no other
adapters of the same kind (=local/remote) are created concurrently
because they may only be created on the appropriate thread (local =
main thread, remote = signaling thread) which is the thread currently
running the operation. In other words, at most 1
GetOrCreateLocalTrackAdapter() on the main thread and at most 1
GetOrCreateRemoteTrackAdapter() on the signaling thread can run at the
same time.

This is the equivalent of the WebRtcMediaStreamAdapterMap fix
(https://chromium-review.googlesource.com/c/868656/) but for the track
adapter map.

The deadlock is quite rare, but due to recent unrelated changes it has
become frequent enough that it is easily reproducible on some platforms
and applications, see bug.

Bug: 813574
Change-Id: I2e7ba605db973221f80443267fd099c5973ab818
Reviewed-on: https://chromium-review.googlesource.com/980949
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546102}

Mostly moving things around, refactoring...

1. Move GetRTCStatsCallback from rtc_peer_connection_handler.cc to
   rtc_stats.[h/cc] where other blink/webrtc stats-related content-glue
   is placed, and rename it RTCStatsCollectorCallbackImpl.

   This allows it to be used by content's RTCRtpSender and
   RTCRtpReceiver in follow-up CLs.

2. Remove unused content::RTCRtpSender-constructor.

3. Move WebRTCStatsReportCallbackResolver from RTCPeerConnection.cpp
   to its own file.

   This allows it to be used by blink's RTCRtpSender and RTCRtpReceiver
   in follow-up CLs.

4. Implement new PeerConnectionInterface::GetStats() functions in
   MockPeerConnectionImpl (need to wait for
   https://webrtc-review.googlesource.com/c/src/+/62900 to land and roll
   into chromium).

Bug: 680172
Change-Id: Ief18b2fb96ebc292149af606bd0edd87bac9e961
Reviewed-on: https://chromium-review.googlesource.com/973368
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546101}

 * Mac10.10 Tests
 * Mac10.11 Tests
 * Mac10.12 Tests
 * Mac10.13 Tests

No-Try: True
Bug: 790162, 790157, 790160, 818391, 790164
Change-Id: I9bc62e97f97012ca147f09e7ddb82b96169588ed
Reviewed-on: https://chromium-review.googlesource.com/982002Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546100}

This CL adds a switch allowing the choose which icon to use for the
search button in the bottom toolbar.

Bug: 826192
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I363822bd9fa94606bf5422b0664febc91b81e03e
Reviewed-on: https://chromium-review.googlesource.com/980935
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546099}

Bug: 819223
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I41edb5310f0529f9d770f5b415cd6f5179a89d1a
Reviewed-on: https://chromium-review.googlesource.com/980672Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546098}

Currently I am working on touch selection module from Samsung,
parallely trying to improve touch selection module in open source.
Hence visibility of ongoing reviews in touch selection will help me
to understand and early planning of upcoming patches. Also it will
help in guiding Samsung peer contributors as well.

Change-Id: Ifbc6b49a9ff01c618ab8f7be0269c6580a90961a
Reviewed-on: https://chromium-review.googlesource.com/981837Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com>
Cr-Commit-Position: refs/heads/master@{#546097}

Bug: 825908
Change-Id: I51019116cbcd2ca8ca969efa77ce4ea93f90450a
Reviewed-on: https://chromium-review.googlesource.com/980669Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546096}

There are users of TCP socket APIs who do not care about the specific read/write
errors. One example is net::HttpServer.
This CL makes the observer param optional.

Bug: 721401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I028a01b6b8e3dea87a3865b704cc15347a3f2793
Reviewed-on: https://chromium-review.googlesource.com/978033Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546095}

No need to use MutableComputedStyle there.

Bug: 813068
Change-Id: If1ce7d3048af3ae7085ad09dd04350a5d4f1dd67
Reviewed-on: https://chromium-review.googlesource.com/980537Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546094}

Following bot results are included.
4362 4366 4367 4370 4371 4373 4375 4379 4385 4389 4395 4397 4398 4400
4401

5 lines were removed and 9 lines were deflaked by consecutive
results since 4322.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I9e099f354bc5411ed6a24ea9579546196ab1a19d
Reviewed-on: https://chromium-review.googlesource.com/979573
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546093}

Replaces the following GCStates with GCPhase counterparts.
- kGCRunning
- kSweeping
- kSweepingAndIdleGCScheduled
- kSweepingAndPreciseGCScheduled

Bug: 757440
Change-Id: I92b40d326bbedfe66ce41aca7d563968eaf3b28a
Reviewed-on: https://chromium-review.googlesource.com/980412
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546092}

(Report them to UMA, that is)

Bug: 787679, 808286
Change-Id: I7ad003574fd62c3429024b7ce45e55a2b39662bb
Reviewed-on: https://chromium-review.googlesource.com/975823
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546091}

This change updates base::span to match the std::span R6 proposal.
Quoting from the proposal document [1]:

Changes from R5:
 - Added constexpr qualifier to all iterator access functions on span.
 - Removed length() member function from span.
 - Removed constructor from span that took a nullptr_t.
 - Removed move constructor and move assignment operator.
 - Corrected definitions of comparison operations to take arguments
  by-value rather than by-reference.

[1] http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0122r6.pdf

TBR=mkwst@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibd217c296a15b5ddf74162eb58a2b97674b9d293
Reviewed-on: https://chromium-review.googlesource.com/976123
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546090}

1. Consolidate logic to create VideoResourceUpdater into helper
   functions.
2. Improve ResourceType enum readability.
3. Delete dead code.
4. Fix software compositing tests expectations to ensure no new shared
   bitmap allocations.

Bug: 730660
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1c4120b511a4e411f2699462eb03d9843a85c0a3
Reviewed-on: https://chromium-review.googlesource.com/977891Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546089}

These keys are pinned in the client and rotated annually.

Bug: 820479
Change-Id: I5d38e7ac182d6794d86354334a7a92ab6da67c8a
Reviewed-on: https://chromium-review.googlesource.com/956974
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546088}

Bug: 823831
Change-Id: I60dc7eb1d6a24e6e2e898c23dcacf1a74f06ccfd
Reviewed-on: https://chromium-review.googlesource.com/978223Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#546087}

We stored the previous match state for :empty, for elements affected by
:empty selectors, on their computed style. For :empty in non-rightmost
compound selectors, we would set the flag on on an already calculated
computed style. That required the ComputedStyle to be mutable.

Also, this flag didn't really work as we weren't trying to detect when
an element changed between empty and non-empty state. Instead, modify
CheckForEmptyStyleChange to check if there are any element or non-empty
text nodes before/after the added/removed node. If there are, no :empty
selector matching needs to be updated.

Bug: 813068
Change-Id: Ic2e7c9a855067267d84c50c71215114a834e92ae
Reviewed-on: https://chromium-review.googlesource.com/980946Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546086}

This CL adds a check when initializing the ContextProvider for layout
tests. We should retry the on transient failures but just crash for
fatal failures. There is no compositing mode fallback in layout tests
for simplicity, so we can't do much other than crash here.

The reason for this change is that ClusterFuzz was picking up access to
some uninitialized data in some vaguely related code. This happens
because there is a fatal failure in CreateDisplayOutputSurface() that is
ignored. The crash stack should now pinpoint exactly where the failure
was and make problems easier to diagnose.

Bug: 817758
Change-Id: I766c0526e0e2c01d16be922f78de1b89365ae401
Reviewed-on: https://chromium-review.googlesource.com/980653Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546085}

In NativeWidgetMacNSWindow, sendEvent: will *not* call [super sendEvent:] for
events that might be the start of a drag, which prevents the window from
receiving the event if we think it might start a drag. Any LMouseDown could
start a drag, so that causes mouse clicks that aren't on some other NSView to
not raise the window. Fix that by not returning early when maybe starting a
drag.

Bug: 775984
Change-Id: Ibe93e45dc4dde39630a3d97f5a148de018c99ab2
Reviewed-on: https://chromium-review.googlesource.com/980701Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546084}

In websocket_stream_test.cc, test methods take URL, host (with optional
port), and path arguments, which are redundant.  This CL removes the
host and path arguments and generates them from URL.

Also, every test uses the same origin and host_for_cookies, therefore
there is no need to pass those as arguments either.

Bug: 825231
Change-Id: I31c0c7a44e3e0d28d10c5b1b0c61b2fc744c7e48
Reviewed-on: https://chromium-review.googlesource.com/980958Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546083}

Bug: 820299
Change-Id: I9e380416b18f30294fe7cb969a0ce7d0ab1fd7bd
Reviewed-on: https://chromium-review.googlesource.com/977910Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546082}

When investigating failures due to handling of large traces,
we disabled some of the pages on v8.browsing_mobile benchmarks.
Some of these are enabled later on v8.browsing_mobile but not
on v8.browsing_mobile-future. Enabling them now.

BUG=chromium:799080

Change-Id: I8b25464be3f01d71d1b3cce07e0c66db8b0b5427
Reviewed-on: https://chromium-review.googlesource.com/962244Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546081}

Bug: 823655
Change-Id: If6dfa9d775d3be37b72b4cf5f2fd9db89763819a
Reviewed-on: https://chromium-review.googlesource.com/981314Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546080}

This patch implements Range.getClientRects and getBoundingClientRect
by implemeting LayoutText::AbsoluteQuadsForRange, the underlying
function to compute quads for a range of text.

VisibleUnits and TouchAdjustment are other users of this function.

crbug.com/698038 added some logic to clear the quad vector under
specific condition for legacy, but the logic is a bit complicated.
This patch tries to match to the spec without using the same logic.
There may be a need to tweak the logic a little more, but the new
logic seems to be more interoperable with Edge/Gecko.

Bug: 636993, 755750
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5c6323680285a4e03d64109cd5681c788f6a6bbf
Reviewed-on: https://chromium-review.googlesource.com/979732Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546079}

This should fix the size of trays when the docked content is above the
desktop (eg. docked magnifier, spoken feedback, etc...)

Bug: 824077
Test: manual
Change-Id: Iecccb721b14a2ffde045a87993d4951cd677efa4
Reviewed-on: https://chromium-review.googlesource.com/981846
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546078}

This CL changes the ownership of base::Clock and base::TickClock from
injectee-owned to injecter-owned. Before this CL, these instances are
owned by the owner of the injectee or one of the injectees themselves.
That makes the ownership handling complex.

After this CL, the injectee of clocks never own the clock. Instead,
injecters owns a clock for testing, and a shared clock is used on the
production code.

Bug: 789079
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2c31982370181504cb80f2084ddf7cd15fb043a8
Reviewed-on: https://chromium-review.googlesource.com/975503Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546077}

This CL does the following refactoring to ModelTypeWorker
1- Changes DecryptSpecifics to a static one that accepts a
cryptographer as an input.

2- Changes the WorkerEntityTracker::UpdateContainsNewVersion to
take the exact update version instead of the whole
UpdateResponseData object

Those changes are in preparation for a later patch that will
add more preparation for Bookmarks migration to USS

Bug: 516866
Change-Id: I0444db35e6b5e31352d5f8aaff546bac7fbd8ec1
Reviewed-on: https://chromium-review.googlesource.com/980313
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546076}

We would like it to be possible for headless C++ embedders to be able
to customise resource metadata caching and this patch adds an API
which allows them to capture resource metadata.

NB the custom HttpCache introduced by this patch if selected completly
disables the regular HttpCache.

Design Doc: http://goo.gl/eZp9wz

Change-Id: Ie3e916c6f21114c4f4929bbba156d6dac96c88f6
Reviewed-on: https://chromium-review.googlesource.com/953003Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546075}

Inheriting from SupportsWeakPtr<T> is error-prone because weak pointers
are not invalidated until the parent object has been partially
destroyed.

Use WeakPtrFactory instead in WebSocketFactory::Delegate.
WebSocketFactory doesn't need weak pointers at all, so remove it
completely from there.

Bug: 721400
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I94f8dc6fa20b4ede14295760db44bdeaae207610
Reviewed-on: https://chromium-review.googlesource.com/981964Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546074}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6e9cb694..2943c641

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ic6a08781c28e6a7ee9b1ce39a0f4ee8babb9bef0
Reviewed-on: https://chromium-review.googlesource.com/981932Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546073}

Currently, no response length (L_e) is encoded in U2F commands. The U2F
spec[1] says “if the instruction is not expected to yield any response
bytes, L_e may be omitted” – i.e. we are specifying that no response is
allowed to our commands.

The VASCO SecureClick respects the maximum response length and thus
doesn't send a reply. Therefore Chromium's webauthn stack doesn't
currently work with these tokens.

This change causes us to always specify the maximum possible response
length for U2F register and sign commands, and fixes interop with the
VASCO token.

[1] https://fidoalliance.org/specs/fido-u2f-v1.2-ps-20170411/fido-u2f-raw-message-formats-v1.2-ps-20170411.html#extended-length-encoding

Change-Id: I5cc906eb6f167fb95c9a42a13ff46237d0e58b79
Reviewed-on: https://chromium-review.googlesource.com/979702
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546072}

SessionRestore on Chrome OS in a non-OWNER profile and with any flag
enabled doesn't work correctly after logout/login.
This was caused by the change to allow saving a session file
without commands. (https://crrev.com/c/899249)
This CL reverts the problematic parts and fixes session restore.

Bug: 816586
Change-Id: I4a5050c532143c4fa9990e153952a82b72e3385f
Reviewed-on: https://chromium-review.googlesource.com/978214Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546071}

This CL adds a section separator for the tools menu, displayed as an
item with a grey line in the middle.

Bug: 804773
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I70d783ee0db85b8889dda5bbbe0d8ab2714a04a6
Reviewed-on: https://chromium-review.googlesource.com/977911Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546070}

TBR=fukino@chromium.org
notry=true

Bug: 804413
Change-Id: I6fd7c66036d38bf23c6b77e16f214eff06c7d903
Reviewed-on: https://chromium-review.googlesource.com/980939Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546069}

This CL starts using activity creation time instead of applicaton creation
time for the Startup.Android.Experimental.Cold.TimeToFirst{ContentfulPaint,NavigationCommit}
histograms.

It's done in order to reduce histograms noise. These histograms are still
experimental, so renaming isn't required.

Bug: 778302
Change-Id: Ic615c14d62566bb31fec651e706ded158abf9d99
Reviewed-on: https://chromium-review.googlesource.com/977968Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546068}

Currently we're just adding a TODO when we want to test a list-valued
property. It's probably easier if we stub that test function and then
implement it later.

Bug: 774887
Change-Id: Iab3cea915afbcc8490cacbd45e5632a18e7dece1
Reviewed-on: https://chromium-review.googlesource.com/981956Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546067}

Make RWHVMac call through RWHVNSViewBridge, and make RWHVCocoa call
through RWHVNSViewClient.

Some of these methods depended on knowing if RHWVMac::host() still
existed, so refactor tear-down to add a RWHNSViewBridge::Destroy method
which informs the RHWVCocoa whether or not its |client_| is still
callable. Once RWHVCocoa no longer calls into the RWHVMac directly, all
of these lifetimes will be clean-up-able.

Bug: 821651
Change-Id: I30f6060ce661504f1eadf933384a6f1cbe4a3c96
Reviewed-on: https://chromium-review.googlesource.com/979595
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546066}

As a first (baby) step of removing the old signin APIs from Sync.

Bug: 825190
Change-Id: I1554c96c54555083f06963a72d2c38248afeb960
Reviewed-on: https://chromium-review.googlesource.com/978186Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546065}