GitLab

PlatformDevice is now a base interface, which is implemented by the various flavours of BitmapPlatformDevice, and VectorPlatformDevice.  The BitmapPlatformDevice and VectorPlatformDevice classes now inherit directly from SkDevice, or SkPDFDevice, as appropriate.

PlatformDevice helper functions access the PlatformDevice interface attached to a SkDevice via meta-data on the SkDevice.

BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98230
Review URL: http://codereview.chromium.org/7633040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98585 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rsleevi

Review URL: http://codereview.chromium.org/7736007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7777003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98583 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98580 0039d316-1c4b-4281-b951-d872f2087c98

TBR=kkania@chromium.org
BUG=94470
TEST=

Review URL: http://codereview.chromium.org/7736004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=89931
TEST=Run the test on a loaded single-CPU system before and after the change.
Before, notice the dialog staying up past when the main windows goes away,
won't get through more than 1 or 2 repeats before breaking.
After, dialog goes away first, no more flakey.


Review URL: http://codereview.chromium.org/7747036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98576 0039d316-1c4b-4281-b951-d872f2087c98

Windowless Flash plugins on Mac do not currently draw in single-process applications using the Chromium WebKit API because the current design assumes a multi-process implementation and requires a buffer context. Add a new flag to indicate no buffer context will be used and change WebPluginDelegateImpl::WindowlessPaint() to paint directly to the window context when this flag is set. Also change test_shell to force Flash plugins to run in windowless mode by setting the wmode="opaque" attribute.

BUG=94395
TEST=load Flash plugin in test_shell

Review URL: http://codereview.chromium.org/7746009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98571 0039d316-1c4b-4281-b951-d872f2087c98

Move native_web_keyboard_event_views.cc to chrome, so that we don't have any views code in content. Although this is now away from the other NativeWebKeyboardEvent implementations, it's at least in the same module as the rest of the views related implementations like RenderWidgetHostViewViews and TabContentViewViews which use it.
Review URL: http://codereview.chromium.org/7766012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98570 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7764010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98569 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dyu@chromium.org
BUG=chromium-os:19760
TEST=


Review URL: http://codereview.chromium.org/7778002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98568 0039d316-1c4b-4281-b951-d872f2087c98

Currently, ovda is expecting profile to sent in initialize().
Change this to be optional.

Test=ovda unit test, gles2 sample plugin

Review URL: http://codereview.chromium.org/7741012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98565 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98564 0039d316-1c4b-4281-b951-d872f2087c98

Previously i was recording number of RTT's vs Kilobytes of data downloaded per http transaction. This was generating lots of histograms.
Removing them for efficiency.

Review URL: http://codereview.chromium.org/7714020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98562 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dennisjeffrey@chromium.org
BUG=94468
TEST=

Review URL: http://codereview.chromium.org/7776003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98561 0039d316-1c4b-4281-b951-d872f2087c98

- Add mock_export_object.{cc,h} to dbus.gyp, which were missing.
- Add a comment about shutdown of Bus in bus.h.
- Update mock_unittest.cc to call ShutdownAndBlock().
- Replace DCHECKs with LOG(ERROR)s followed by early exit.
- Add virtual to SetUp() and TearDown() in tests.
- Renamed a member variable to make it clearer.

BUG=chromium:90036
TEST=dbus_unittests


Review URL: http://codereview.chromium.org/7745044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98560 0039d316-1c4b-4281-b951-d872f2087c98

Set the porfile info when creating a decoder.

Test= gles2 plugin

Review URL: http://codereview.chromium.org/7749004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98559 0039d316-1c4b-4281-b951-d872f2087c98

Add support for disabling/enabling notifications to the test server, and support for triggering notifications.

BUG=92928
TEST=


Review URL: http://codereview.chromium.org/7753023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Pepper Flash


Review URL: http://codereview.chromium.org/7763007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98555 0039d316-1c4b-4281-b951-d872f2087c98

several bots, like the trybots hinted it will)

- DevTools: introduce DevToolsAgentHost

We need an abstract interface that would encapsulate communication
with inspected instance's DevTools agent. It is going to have different
implementations at least for render views and shared workers. This
patch leaves all methods on the DevToolsManager that accept inspected
RenderViewHost just for convenience. Eventually DevToolsManager should
operate in terms of DevToolsAgentHost and DevToolsClientHost only.

BUG=None
TEST=DevTools tests

Review URL: http://codereview.chromium.org/7719026

TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/7774004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98554 0039d316-1c4b-4281-b951-d872f2087c98

We need an abstract interface that would encapsulate communication
with inspected instance's DevTools agent. It is going to have different
implementations at least for render views and shared workers. This
patch leaves all methods on the DevToolsManager that accept inspected
RenderViewHost just for convenience. Eventually DevToolsManager should
operate in terms of DevToolsAgentHost and DevToolsClientHost only.

BUG=None
TEST=DevTools tests

Review URL: http://codereview.chromium.org/7719026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98552 0039d316-1c4b-4281-b951-d872f2087c98

Encode the changed types into the XMPP push message and nudge only for those data types.

Filter out notifications sent from the originating client.

Instead of calling observers directly, synthesize a notification and send it to the server with target = self only.

BUG=92928
TEST=

Review URL: http://codereview.chromium.org/7745040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92268,94448
TEST=none

Review URL: http://codereview.chromium.org/7765010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98550 0039d316-1c4b-4281-b951-d872f2087c98

Mostly format manager code, that diplays and handles unreadalbe device. There's option to format them. One cannot access them.
Icons were added as well.

Depends on the following change in ChromeOS: http://gerrit.chromium.org/gerrit/#change,6406

BUG=19506
TEST=None.


Review URL: http://codereview.chromium.org/7706028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Open tab 1 and tab 2. Open print preview from tab 1. Put the tabs in this order: 1, 2, 1_PP. Printing from the print preview tab should activate tab 1.

Review URL: http://codereview.chromium.org/7761014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98547 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=1) Start remoting session with Mac as host
	 2) Go to the preferences file for the browser (com.google.Chrome.plist)
	 3) Add a bool pref "RemoteAccessHostFirewallTraversal" set to NONE
	 4) Wait 15 minutes
	 5) You should not be able to do NAT traversal.

Review URL: http://codereview.chromium.org/7748027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98546 0039d316-1c4b-4281-b951-d872f2087c98

Test fails consistently on Linux Views bots:

PrerenderBrowserTest.PrerenderVisibilityBackgroundTab: 
[6686:6686:0826/200949:368667468:WARNING:zygote_host_linux.cc(148)] Running without the SUID sandbox! See http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[6686:6686:0826/200949:368753313:WARNING:proxy_config_service_impl.cc(654)] Error retrieving proxy setting from device
[6686:6686:0826/200949:368754972:WARNING:wm_ipc.cc(311)] Missing _CHROME_LAYOUT_MODE property on root window
[6686:6691:0826/200949:368757012:INFO:gl_implementation.cc(94)] Using desktop GL implementation.
[6686:6691:0826/200949:368762612:ERROR:gl_surface_glx.cc(64)] GLX 1.3 or later is required.
[6686:6691:0826/200949:368762779:ERROR:gl_surface_linux.cc(73)] GLSurfaceGLX::InitializeOneOff failed.
[6686:6691:0826/200949:368762962:ERROR:gpu_info_collector_linux.cc(216)] gfx::GLContext::InitializeOneOff() failed
[6686:6686:0826/200949:368808876:ERROR:timezone_settings.cc(61)] GetTimezoneID: Cannot read timezone symlink /var/lib/timezone/localtime
[6686:6686:0826/200949:368808913:ERROR:timezone_settings.cc(141)] Got an empty string for timezone, default to America/Los_Angeles
[6686:6686:0826/200949:368816216:WARNING:input_method_manager.cc(146)] No active input methods found.
[6686:6686:0826/200949:368818013:WARNING:input_method_manager.cc(146)] No active input methods found.
[6686:6686:0826/200949:368818259:WARNING:input_method_manager.cc(146)] No active input methods found.
[6686:6686:0826/200950:369084812:WARNING:native_widget_gtk.cc(418)] compositing not supported; allowing anyway
chrome/browser/prerender/prerender_browsertest.cc:680: Failure
Value of: display_test_result
  Actual: false
Expected: true

- Deflake PrerenderExcessiveMemory, fixing a race in setting 
the visibility state of prerendered RenderViews in the 
process.

Also add some more visibility API tests that would have
reliably failed when losing the fixed race.


BUG=93081
TEST=PrerenderBrowserTest.PrerenderExcessiveMemory. PrerenderBrowserTest.PrerenderInfiniteLoop

Review URL: http://codereview.chromium.org/7693029

TBR=mmenke@chromium.org
Review URL: http://codereview.chromium.org/7736003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7745046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98544 0039d316-1c4b-4281-b951-d872f2087c98

BUG=75518, 70793
TEST=Build and then watch builds.

Review URL: http://codereview.chromium.org/7764008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98543 0039d316-1c4b-4281-b951-d872f2087c98

Disable frame pointer optimization on base::debug::StackTrace() so it works properly in release builds.

Similarly disable optimizations in npobject_stub.cc so base::debug::StackTrace() can recognize more frames (This last de-optimization is only temporary, whereas the change to base::debug::StackTrace is intended to be permanent).

BUG=94179
Review URL: http://codereview.chromium.org/7763008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98542 0039d316-1c4b-4281-b951-d872f2087c98

(Rolling just 1 revision because something farther on seems to tickle an ld crash, but I'd like to get the rest of this CL in.)

Also pass --disable-threads and --disable-pthreads to configure, for goma.

Also modify the script to try to download prebuilt binaries first. This is faster,
and makes sure the bots use the exact same binary as goma. The binaries are
downloaded from http://commondatastorage.googleapis.com/chromium-browser-clang/index.html

Also add a script that packages a clang build up into a tgz for uploading with
gsutil, based on code by ukai@.

Finally, if the svn checkout fails, remove the destination directory and try
again (for bots that have a checkout from before we had an internal llvm svn
mirror).

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98416

Review URL: http://codereview.chromium.org/7741039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98541 0039d316-1c4b-4281-b951-d872f2087c98

It saves the stack trace where initial deletion happened from. In the case where the deletion was initiated by DeleteSoon(), we will show the stacktrace for the caller of that function (rather than the actual deletion stacktrace from running the task).

BUG=94179

Review URL: http://codereview.chromium.org/7748024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98540 0039d316-1c4b-4281-b951-d872f2087c98

the visibility state of prerendered RenderViews in the 
process.

Also add some more visibility API tests that would have
reliably failed when losing the fixed race.


BUG=93081
TEST=PrerenderBrowserTest.PrerenderExcessiveMemory. PrerenderBrowserTest.PrerenderInfiniteLoop

Review URL: http://codereview.chromium.org/7693029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98539 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98538 0039d316-1c4b-4281-b951-d872f2087c98

TBR=podivilov@chromium.org

Review URL: http://codereview.chromium.org/7766011

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7764015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98537 0039d316-1c4b-4281-b951-d872f2087c98

Revert 98511 - Don't send DidChangeView to the plugin unless the parameters have actually changed.

Apparently WebKit sends the update for every layout, even if nothing has changed.
Review URL: http://codereview.chromium.org/7761005

TBR=brettw@google.com
Review URL: http://codereview.chromium.org/7762014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98531 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98530 0039d316-1c4b-4281-b951-d872f2087c98

TBR=podivilov@chromium.org

Review URL: http://codereview.chromium.org/7766011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98529 0039d316-1c4b-4281-b951-d872f2087c98

TBR=satorux@chromium.org
BUG=88863
TEST=none

Review URL: http://codereview.chromium.org/7766015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98528 0039d316-1c4b-4281-b951-d872f2087c98

Before, it abused the noExtensions flag to determine to disable share groups for WebGL, which was awful.

This patch is dependent on https://bugs.webkit.org/show_bug.cgi?id=66516.

See also http://codereview.chromium.org/7669072 where I perpetrated the aforementioned hack.

BUG=92356
Review URL: http://codereview.chromium.org/7669072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98527 0039d316-1c4b-4281-b951-d872f2087c98

the test suite implicitly provides global resources for each test,
but they're re-initialized between each test.

The performance overhead is negligible.

We need that to continue moving tests from unit_tests
to content_unittests. Because of shared test fixtures
the test suites need to be compatible.

BUG=90443

Review URL: http://codereview.chromium.org/7744039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98526 0039d316-1c4b-4281-b951-d872f2087c98