- 07 Jul, 2020 40 commits
-
-
Peter Kasting authored
With the recent saturation fixes, these are now simple enough to inline without increasing binary size significantly. Doing this allows using them in constexpr contexts, of which there are a few (at least for InMinutes()). On my 64-bit Windows "official" non-branded release build, chrome.dll had the following sizes: Before saturation fixes: 147661312 bytes After saturation fixes: 147660800 bytes After this constexpr CL: 147663872 bytes Bug: none Change-Id: I786ed3f36e0952bd766d3826f0eca34fe676af30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281730 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#785640}
-
Khushal Sagar authored
Bug: 1080911 Change-Id: I4f1456912dafde7ab97bd2895cefbc5a7b6358c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283825 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#785639}
-
Dale Curtis authored
If a caller requests that high bit depth outputs are decoded to half-float, this should always be respected. Otherwise when used in combination with an external allocator you will get silent failures during ExternalMemoryAllocator::allocPixelRef(). There are two instances of this behavior that are fixed: - In ImageDecoder creation the HBD option is always forced off for low end devices. This should not be done and isn't really important since there are no users of this path other than float16 canvas. It should instead be a caller decided option during normal rendering. - PNGImageDecoder doesn't support 16-bit APNGs when the blend op is kBlendAtopPreviousFrame, but instead of just declaring that the image isn't high bit depth it rejects the HBD argument under the hood. Both cases are now fixed with this patch. This will become important when we start decoding hdr and possibly hbd images to half float when on an HDR/HBD display. R=pkasting, wtc Bug: 874057, 1076568 Change-Id: Iccb52387f434e4bff0cb28fc9c9f08c1129f56c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284210 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#785638}
-
Tal Pressman authored
Change-Id: Ic51be0c3d5a58a588958bbf270509b0a76f0a946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279525Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#785637}
-
sauski authored
CL removes logic to support the pre-redesign version of settings. This was previously dependent on the privacySettingsRedesignEnabled flag. Bug: 1067336 Change-Id: I4e8ecb28045b19b8dc156bfc269f15b8e0c28c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274886Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#785636}
-
Quang Minh Tuan Nguyen authored
Bug: 1007685 Change-Id: Iea6a8c6be3f625652e191b028368d2dbbdb51686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282734Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Quang Minh Tuan Nguyen <nqmtuan@google.com> Cr-Commit-Position: refs/heads/master@{#785635}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594079083-ffdb62397d431714a12b5676f4643cd82d22aa28.profdata to chrome-mac-master-1594101275-38e9917f0b53891d9ca12d959315a5fd47c1594e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iaadeaf628959620ee22f7d7aeae9bda096683559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284281Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785634}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b8583bcc95fc..36a97db1bb2b 2020-07-06 syoussefi@chromium.org Vulkan: Compress internal shaders 2020-07-06 shrekshao@google.com Fix multiDraw* with DYNAMIC_DRAW buffer usage 2020-07-06 shrekshao@google.com MultiDraw Refactor 2020-07-06 dpranke@google.com Fix import paths for //scripts/run_gtest_angle_test.py. 2020-07-06 m.maiya@samsung.com Vulkan: Query aspect flag from the image 2020-07-06 jonahr@google.com EGL: Add basic multithreading support 2020-07-06 jmadill@chromium.org Test Runner: Batch tests by config. 2020-07-06 lehoangq@gmail.com Fix end2end intermittent crash on macOS if custom OSWindow is used. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:816629 Tbr: syoussefi@google.com Change-Id: I1f999a795e4299ea90b67da13d4f45f006c3fa52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283559Reviewed-by:
-
charleszhao authored
Bug: 1099555 Change-Id: Id24ad276c2b553e2e029e79f5ff933d9081232d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269401 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#785632}
-
Lan Wei authored
BackForwardCacheBrowserTest.SubframeWithDisallowedFeatureNotCached fails on Linux Ozone Tester (X11), https://ci.chromium.org/p/chromium/builders/ci/ Linux%20Ozone%20Tester%20%28X11%29, disable it for now until it is fixed. TBR= arthursonzogni@chromium.org Bug: 1102571 Change-Id: I961397307d226d323ccd29d38b6cb6e90999c05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283964Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#785631}
-
Jian Cai authored
Add an option to redirect clang crash diagnoses different from the default location. BUG=chromium:1056904 TEST=None Change-Id: I0fc88ed657981ad0e9dfb17147945976227b8d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255216Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jian Cai <jiancai@google.com> Cr-Commit-Position: refs/heads/master@{#785630}
-
Lan Wei authored
GpuProcess_canvas2d is flaky on fuchsia X64, https://analysis.chromium.org/p/chromium/flake-portal/flakes/ occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTgsSBUZsYWtlIkNjaHJvbWl1bUBmdWNo c2lhX3RlbGVtZXRyeV9ncHVfaW50ZWdyYXRpb25fdGVzdEBHcHVQcm9jZXNzX2NhbnZhczJk DA, disable it for now until it is fixed. TBR= kbr@chromium.org Bug: 1102542 Change-Id: Ic1da21a76f46b333f597594d300e34cc56a02f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284282Reviewed-by:
-
Ted Meyer authored
just saw this while debugging vaapi, thought tripped me up before i realized it was a typo. R=dalecurtis Change-Id: I38fd54b34304482bfdf6644e8e23badb9cc0108d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284348 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#785628}
-
Clark DuVall authored
This API uses the Mirror protocol to intercept any requested GAIA account changes, and forwards them to a callback. The core logic is implemented in weblayer::SigninURLLoaderThrottle and is similar to chrome's signin::URLLoaderThrottle. One difference in behavior between WebLayer and Chrome's handling of Mirror, is that WebLayer skips the "Choose an account" page when a GoogleAccountsCallback is set. This is done by adding a manage=true query parameter to the /SignOutOptions page. This matches the behavior we want for WebLayer and was suggested by the Google sign in team. Bug: 1054160 Change-Id: Ibb316321105418d12901e91cf2a0b569f65e3bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277337 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#785627}
-
Fergal Daly authored
I'm debugging a failure of this test and having it execute a series of independent tests makes it difficult to isolate the problem. Create a DisableExtensionBrowserTest class to factor out all of the common setup. Change-Id: I3ea3574270a1b88a27a0a2095de1905789b8479c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274318 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#785626}
-
Jinsuk Kim authored
This CL fixes a bug that removes tab history popup immediately when releasing a long press. Now that the tab history is the only client using NavigationSheet, this check gets easier by seeing if there's already a navigation sheet running, and cancelling the key-up event in that case. Android version check was removed since this is reported to happen on later versions as well. Bug: 1023018 Change-Id: I0885291d7b91c1205904efded3b73a8fb5ec5337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279256Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#785625}
-
Devlin Cronin authored
Some features specified more types than there were allowlisted IDs. Remove the unnecessary types. (There may be more entries with this issue, but these were the ones I saw.) Bug: None Change-Id: Ib8dcf68e3dc09045247219febfc02bcc315f8525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276804Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785624}
-
Yuichiro Hanada authored
It will be used by the proxy IME to send a key event to the host IME. Chrome returns whether it's consumed by the host IME. Android will let an ARC app handle the event if it's not consumed by the host IME. Bug: b:148193316 Change-Id: I72dcb63d0853cd87baab5f3ab911e704628e2edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273038Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#785623}
-
Christopher Lam authored
This CL adds a CSS-only prefix to cros_colors.json5 to avoid overly wordy variable names. This will allow C++ color names to be more concise (e.g kTextColor rather than kCrosTextColor) while still helping avoid name collisions with other CSS variables. This CL causes all current C++ colors to be renamed but keeps CSS colors relatively stable. Bug: 1018654 Change-Id: I08d65caeafb4e5ffbc4745293950775e6645592c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265705Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#785622}
-
Jesse Schettler authored
Now that the flag is expired and Android no longer checks for the arc_print_spooler boot property, remove the flag. Bug: b:160174237 Change-Id: I715f821278c3a8ce26dc2082f5cf1477d44fd0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283045Reviewed-by:
-
Takashi Toyoshima authored
There are some existing TODOs for request modifications on CORS redirects. Since this could cause enterprise affecting compatibility breakages even if this is a spec conformance fix, let's fix this after the Blink CORS removal, with a well-considered safe rollout plan. Bug: 1073353 Change-Id: I6b14304fa981ff3d2212f8189c40e171a1c79d61 NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280747Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#785620}
-
Fergal Daly authored
ShouldTreatNavigationAsReload ignores subframe navigations. The result is that we send reloads of subframes as non-reloads and have to correct that on the renderer side. This change makes it so that ShouldTreatNavigationAsReload also handles subframes. BUG: 1068965 Change-Id: I992c74bc1452ea19a96bf420e808d1c26c9bd5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269615Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
WangHui authored
Pick the best icon to return based on size. Prefer 192x192 on mobile same as |favicon_handler|. Bug:None Change-Id: I726523042fc0af809d75daf20e55c98ba51cc2ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275975Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#785618}
-
Glen Robertson authored
Previously gomacc(.exe) was removed on Windows only. The compile_commands.json generated by these files used gomacc as the command on each file, which isn't understood as a cpp compiler by CLion. It results in an error message "Cannot determine compiler type by executable file" and CLion doesn't parse any symbols. Now the script remove gomacc from the command, leaving clang as the command instead of the first argument. This allows CLion to generate symbols correctly. Change-Id: If4b1e17be2d8ec62ced53c6a19891b170e6156b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269604 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#785617}
-
Xiaohan Wang authored
Extend the expiration time of this UMA. Bug: 1089735 Change-Id: Ia1e781e5141222872d8f2bf5d3b95360386c2e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283642 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8fe932a5a368..a166a353fbc3 2020-07-06 saza@webrtc.org webrtc::AudioSendStream: Add lock annotation to audio_level_ 2020-07-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a9cc4f47..31d34f54 (785286:785408) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia5091857676f51a9e4778a217b6933e743625459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284167Reviewed-by:
-
Gyuyoung Kim authored
This CL converts remaining StrongBinding's uses to MakeSelfOwnedReceiver. Besides that this CL removes all unnecessary strong_binding.h includes. Additionally, PRESUMIT scripts start warning the use of StrongBinding. Bug: 955171 Change-Id: I3336fc31b7c7f390c00d4dfdd87dca404cce5e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281790 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#785614}
-
Mustafa Emre Acer authored
Presubmit currently warns when a UI string is missing translation screenshots. We'll now require all strings to have associated screenshots. This CL changes the warnings to errors. Bug: 1087641 Change-Id: I0968dee994e304bd9c7c59bab56d5f1b0325d5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283261Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#785613}
-
Tao Bai authored
Add browser test. Bug: 1098480 Change-Id: I32e1f8fef6f0ff18c0a117a367fa0005c2fe0c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271524Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
-
Nate Chapin authored
* Document::open uses GetSecurityContext(), but only when it is known that dom_window_ is non-null. Route all SecurityContext usage through the dom_window_. * Document::DidEnforceInsecureRequestPolicy() and Document::DidEnforceInsecureNavigationsSet() are only used from ExecutionContextCSPDelegate. Inline them there. Bug: 1101402 Change-Id: I38558a7a95fb7a8c47c9f6b55e902d684c4522da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283634Reviewed-by:
-
Anand K Mistry authored
Using a smart pointer is less error-prone than doing the memory management manually. Bug: None Change-Id: I5b14f065aeb27d7062a9789b6b9fa77b6d7f9c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247989Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9ef36d0c0fe8..1b843e7903f8 2020-07-06 rmhasan@google.com telemetry: Remove subprocess spawning from unit test runner unit tests 2020-07-06 lanwei@chromium.org Disable flaky test ActionRunnerTest.testWaitForElement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101827,chromium:960833 Tbr: eseckler@google.com Change-Id: I35d74693faf3cb826f9a957deedf31c97ee6fbb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284069Reviewed-by:
-
Karandeep Bhatia authored
This CL ensures that the isolated world CSP is used for CSP checks while loading images from isolated worlds. It also simplifies the ImageLoader code. BUG=1099975 Change-Id: I9ea9be9c0b960e49b0420c1db17b7eed4a1ed47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276816Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#785608}
-
John Chen authored
This reverts commit 261d1f80. Reason for revert: Pinpoint unable to repro the failure Original change's description: > Disable failing v8.browsing_desktop/browse:news:cnn:2020 on win10 > > TBR=wenbinzhang@google.com > NOTRY=True > > Bug: 1101850 > Change-Id: Ib3e44106666eb68ae039c20a2327761c1bceef70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280362 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784915} TBR=johnchen@chromium.org,wenbinzhang@google.com NOTRY=True # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1101850 Change-Id: I3c746aadf68ec571781134390048f77a9d72068a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283050 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#785607}
-
David Van Cleve authored
The initial implementation adding custom caller-provided additional signing data to Trust Tokens signed outgoing requests (crrev.com/c/2265518) imposed a couple restrictions on the signing data---no longer than 2048 bytes in UTF-8; forms a valid header value--- and failed outgoing requests entirely when these conditions were not met. This was stricter than the other failure modes for request signing; this CL brings it in line with other signing errors by changing the behavior to just fail the signing operation, attaching an empty Sec-Signed-Redemption-Record header, rather than failing the request as a whole. Bug: 1101559 Change-Id: I91be979cd24dca968c0eddec59862ef0a969fdd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278606 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#785606}
-
Tsuyoshi Horo authored
Bug: 995428, 1042722, 1068965 Change-Id: I3e0c68edda01cad0ec6e3a7673f5c1dace7ebc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275567 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785605}
-
Reilly Grant authored
Reason for reland: There is no more dependency in iOS > Revert of bluetooth: Remove UriBeacon code (patchset #2 id:20001 of https://codereview.chromium.org/2015703002/ ) > > Reason for revert: > This code is still used on iOS. The code will be upstreamed soon, but at the moment some dependencies prevent it. > > Original issue's description: > > bluetooth: Remove UriBeacon code > > > > This code was introduced by the Physical Web team when they were exploring > > integration with Chrome. They ended up going a different route so this > > code is useless now. > > > > Committed: https://crrev.com/3d392de68c541604a01a0c077c44d0ba4c7a02c7 > > Cr-Commit-Position: refs/heads/master@{#396112} > > TBR=scheib@chromium.org,ortuno@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/2faae4040325203cc26381aa24126c7fc6320f8a > Cr-Commit-Position: refs/heads/master@{#396142} Change-Id: If7718c2bf48124e933758f5ee1d105638deccce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278308 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#785604}
-
Chris Harrelson authored
This reverts commit 19192c46. Reason for revert: Re-landing since broken test does not reproduce. Original change's description: > Revert "Remove dependency of paint offset translation on compositing" > > This reverts commit 6b69ef4c. > > Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/19163 > > Original change's description: > > Remove dependency of paint offset translation on compositing > > > > Before this CL, some non-direct compositing reasons induced a > > paint offset translation for descendant reasons - in particular: > > CompositingReason::kComboCompositedDescendants > > CompositingReason::kNegativeZIndexChildren > > CompositingReason::kRoot > > > > and we depended on the computation of these reasons in > > CompositingRequirementsUpdater. > > > > With this CL, we only do so for kComboCompositedDescendants, and > > remove the dependency on CompositingRequirementsUpdater. > > > > Bug: 1100711 > > > > Change-Id: I8b9948cfae01b0973623aba84a1fdf84ae0a9611 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276521 > > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#784695} > > TBR=wangxianzhu@chromium.org,chrishtr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1100711,1101917 > Change-Id: I41164b5235575a5e56e14472b1dd2bf9d32da8fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281106 > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785145} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org,schenney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1100711, 1101917 Change-Id: Ic857f8dda802095ef3a4b1ad364ff2dc4c4566ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283731Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#785603}
-
Lan Wei authored
This reverts commit f77bb9e7. Reason for revert: Builder: Linux ChromiumOS MSan Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests First failing build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/b8875468439609281712 Original change's description: > Add buttons in PdfAccessibilityTree > > This CL creates button nodes using PdfAccessibilityButtonInfo sent from > plugin process and inserts them in the PdfAccessibilityTree. > > This CL also includes test to validate the creation of button nodes in > PdfAccessibilityTree. > > Bug: 1030242 > Change-Id: I854f394ce4a5f66a626755040685eb6e5e40d4be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275981 > Commit-Queue: Mansi Awasthi <maawas@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#785553} TBR=dmazzoni@chromium.org,thestig@chromium.org,mohitb@microsoft.com,maawas@microsoft.com,virens@microsoft.com,ankk@microsoft.com Change-Id: I1fd7721e6036bda573359d2b226ea293f5e49a03 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030242, 1102727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284446Reviewed-by: -
Ella Ge authored
MediaFileSystemsCallback to OnceCallback GalleryWatchManager::ResultCallback to OnceCallback SelectDirectoryDialog::Callback to RepeatingCallback MediaGalleriesPermissionController.on_finish_ to OnceClosure Bug: 1007635 Change-Id: I9661a8e6006caf1457ca22feaf3da7e38db48986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279915 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
-
