- 14 Sep, 2018 40 commits
-
-
Vikas Soni authored
Add a new pixel test which creates and rasterizes multiple tiles. This test is meant to check if all tiles are drawn correctly without overwriting each other contents. Bug: 883500 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I83190b6f887122aaf76cfd74533650e732391cdf Reviewed-on: https://chromium-review.googlesource.com/1222890Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#591440}
-
Scott Violet authored
PerformWmAction was provided as a way to have the window manager perform an action not known to the window service. The window-service defined this api so that a window's id could be passed, which is unique to the client. A more generic approach is to allow the environment hosting the window service to supply arbitrary associated interfaces that are not known to the window service. It's important the interface is associated so that we can know the ordering. That's what this patch does. This adds WindowTree::BindWindowManagerInterface() that takes a name and handle. The name is the name of the interface (every mojom interface has a name). The function is typed to associated WindowManager& window_manager, but that is just a necessity of the mojom. It's used to request *any* interface. In fact requesting ws::mojom::WindowManager won't work at all. An interface needs to be named here as there is no way in a mojom to say *any* associated interface. This also converts the one use of PerformWmAction to an interface defined by ash, AshWindowManager. BUG=883947 TEST=covered by tests Change-Id: I21870a1d173352b596716cd1a807b591385f8a2b Reviewed-on: https://chromium-review.googlesource.com/1225693Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#591439}
-
rbpotter authored
These tests are flaky on the Chrome OS MSAN bot. Bug: 882606 Change-Id: Ia4a8eaf07b4f0d649f197a89290595a3250a9f3d Reviewed-on: https://chromium-review.googlesource.com/1217715 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#591438}
-
Artur Khachatryan authored
Adding a comma at the end of the newly added entry Change-Id: I3d3fb4f86fbedea46489737abb602321f07a67dc Reviewed-on: https://chromium-review.googlesource.com/1227189Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#591437}
-
Raymond Toy authored
When the document goes away while the audio thread is running and trying to notify the document that audible audio has started, we can't create the necessary mojom interface. Just return because the document is gone. Bug: 882734, 882639 Change-Id: I168318fb0c44ceb564edeee223aa5f7ee46d43ef Reviewed-on: https://chromium-review.googlesource.com/1220568Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591436}
-
Dave Tapuska authored
PointerEvent's types didn't match the IDL definitions. Use wtf_size_t when iterating WTF types. BUG=588506 Change-Id: Ic208216e5559f3eb43d90f95712b45b22d38dd2f Reviewed-on: https://chromium-review.googlesource.com/1227143Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#591435}
-
Chris Palmer authored
Bug: None Change-Id: I5f2b326a1b7b6c73156edfb43ceae6356433f4f2 Reviewed-on: https://chromium-review.googlesource.com/1226454 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Bailey Berro authored
Previously, if there were no valid NetworkInterfaces we would exit out of NetBios discovery, but the discovery timer would still be set causing a moved-from callback to be run twice. The crash was especially subtle becuase it required having no valid network interfaces, which is uncommon because both Wifi and Ethernet are valid interfaces. Bug: chromium:882972 Test: verified manually on Elm device Change-Id: I2e7a28aded718845a08669f464b60bba2bbc6174 Reviewed-on: https://chromium-review.googlesource.com/1226364 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#591433}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7557e7b0efc0..4dc8c50f81bd git log 7557e7b0efc0..4dc8c50f81bd --date=short --no-merges --format='%ad %ae %s' 2018-09-14 tsepez@chromium.org Make ContentParam::m_Name be a ByteString. 2018-09-14 thestig@chromium.org Initialize CBC_OneDimWriter members in the header. Created with: gclient setdep -r src/third_party/pdfium@4dc8c50f81bd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I597af98c9ae8e0f5ce5489df6ece55db9a78bdd0 Reviewed-on: https://chromium-review.googlesource.com/1227151Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591432}
-
Wei-Yin Chen (陳威尹) authored
Only iOS makes use of image data for offline viewing. Skip image fetching to avoid network activity, and save memory usage in InMemoryContentStore. Bug: 864015 Change-Id: Ieda9e1155bcb96d9e01442af9898df8547c7af13 Reviewed-on: https://chromium-review.googlesource.com/1226520Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#591431}
-
David Bokan authored
Since rotation used to be supported only on Android, where windows can't be resized, we made the assumption that if the width changes it must be a rotation. This changes in ChromeOS where entering tablet mode enables rotation but also resizes the window (when entering tablet mode). This caused inappropriate rotation anchoring. The underlying issue has been fixed in other patches linked to this bug, the rotation trigger should be improved to check that the width and height are swapped. Bug: 831473 Change-Id: I0acd39d16319d8cb7819faac4c4ce54b6f7a2e46 Reviewed-on: https://chromium-review.googlesource.com/1224711Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#591430}
-
liberato@chromium.org authored
SequenceBound<T> allows for easy creation, posting, and destruction objects of type T on a designated Sequence. It does not expose the underlying pointer to T, so it's hard to accidentally pass them around in callbacks that are then run on the wrong thread. A SequenceBound<> may be created anywhere, passed (moved) between threads, etc., safely. Destruction of the SequenceBound schedules destruction of the underlying instance of T on the appropriate thread. Not implemented here (but prototyped elsewhere) are weak pointers to these objects that may be passed and used between threads safely; utility functions to generate thread-hopping callbacks; support for strong shared ownership semantics. Tests: sequence_bound_unittest.cc Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3bbf7e975884fce8e18f3bb15a0d211ead58a619 Reviewed-on: https://chromium-review.googlesource.com/875241 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#591429}
-
Tatiana Buldina authored
Make ExecuteSetAlertText() return kInvalidArgument according W3C standard Bug: chromedriver:2003 Change-Id: Ibd65e8861f0a3f17bb21b54b0d031b88de7dc05c Reviewed-on: https://chromium-review.googlesource.com/1226794Reviewed-by:
-
Edward Jung authored
Removed the fixed height of the blue button and corrected the icon alignment. Bug: 883316 Change-Id: I2928b0c45e4f4d7873105cddc9fa6b2a1aff6b7d Reviewed-on: https://chromium-review.googlesource.com/1222727Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#591427}
-
Wei-Yin Chen (陳威尹) authored
In DistillerTest.DistillMultiplePages, the images were added in an incorrect way, so that there were actually no images in the distilled results. Therefore, the image data matching in function VerifyArticleProtoMatchesMultipageData() were never executed. This was discovered when working on https://crbug.com/864015, and the lack of coverage was identified here: https://chromium-coverage.appspot.com/reports/590937/linux/chromium/src/components/dom_distiller/core/distiller_unittest.cc.html This CL fixes this by constructing the expected distillation correctly in CreateMultipageDistillerDataWithImages(). Bug: None Change-Id: Iaf6a1fc81ac956f362ee584d691b066dcde2dab7 Reviewed-on: https://chromium-review.googlesource.com/1226517Reviewed-by:
-
Christian Biesinger authored
It's more efficient (avoids a copy), as confirmed by inspecting the generated assembly. R=eae@chromium.org,ikilpatrick@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I55a0d9edded65545b2e7404e941f776a3e9978da Reviewed-on: https://chromium-review.googlesource.com/1226306 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#591425}
-
Leonard Grey authored
Bug: 877493 Change-Id: I359348731dfac3a6c952966ef27b23973d40c8b6 Reviewed-on: https://chromium-review.googlesource.com/1225999Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#591424}
-
Scott Graham authored
TBR=kmarshall@chromium.org Bug: 884260 Change-Id: I47a407077b9ee38a0db8a6710f827cb111d4ab07 Reviewed-on: https://chromium-review.googlesource.com/1227210Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#591423}
-
David Bokan authored
This test was fixed and is passing as of https://crrev.com/c/adc4e84b405bdf17be6f602c450586e5a5a9a8ab Bug: 875097 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I60e11d3a79f087eb255e4144e08f4eb9caa362a8 Reviewed-on: https://chromium-review.googlesource.com/1227145Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#591422}
-
Robert Ogden authored
There's no pretty way to do this with field trial args and this will make it much easier to do local testing. Bug: 864635 Change-Id: I9deeef643291d36733763767eea4cbc2f65a0a3c Reviewed-on: https://chromium-review.googlesource.com/1226353Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#591421}
-
Andrey Lushnikov authored
Target.exposeDevToolsProtocol implementation was attaching the same client to multiple agent hosts. In fact, we assume there's a single client per session. R=dgozman Change-Id: I780abc7d86612cef977999e6f6319f00722cee1a Reviewed-on: https://chromium-review.googlesource.com/1221726 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#591420}
-
Dave Tapuska authored
When the navigation bar is shown we weren't applying the immersive sticky flag and we really should. BUG=881738 Change-Id: Ie53918846a5f528b825d9818c574b46b9a61a3d1 Reviewed-on: https://chromium-review.googlesource.com/1227133 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#591419}
-
Devlin Cronin authored
Add karandeepb@ to extensions API owners, and also add a quick explainer at the top of the file. Bug: None Change-Id: Id03313864c7f3f7e6c4f77a39785eefa283f67b5 Reviewed-on: https://chromium-review.googlesource.com/1226078Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#591418}
-
Mike Dougherty authored
JavaScript can only be executed on a WebFrame which represents a main frame or an iframe with an encryption key as signified by |CanCallJavaScriptFunction|. Bug: 881816 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3831f353b664f8ec8ce80fb47b55660ec6868daa Reviewed-on: https://chromium-review.googlesource.com/1214803Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#591417}
-
Mike Dougherty authored
Messages from cross origin iframes are validated using the corresponding frame ids instead of the web state global window id. This allows features the ability to support cross origin iframes instead of only the main frame and same origin iframes. Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Idd092efaa4e18ae699a91043f37b304e500f4238 Reviewed-on: https://chromium-review.googlesource.com/1227137 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Jamie Madill authored
no-over-optimization-on-uniform-array-06 is failing consistently. Bug: 884210 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2cbead8a26e4883b221be9f873f711ba3aeb84ef Tbr: kbr@chromium.org No-try: True Reviewed-on: https://chromium-review.googlesource.com/1226308Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Ted Choc authored
The previous code would layout each View to be the full height of the suggestion container and then move them around at draw time. BUG=883143 Change-Id: I2d25293042395d75608f2b7cc55399edf8518e57 Reviewed-on: https://chromium-review.googlesource.com/1225215Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#591414}
-
Xianzhu Wang authored
TBR=pdr@chromium.org Bug: 884239,884240 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iafece0358cf595c3055c481ac7af7368dde110f7 Reviewed-on: https://chromium-review.googlesource.com/1226354 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591413}
-
Koji Ishii authored
This patch marks these new values as "stable" in runtime_enabled_features.json5. Intent to ship thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/gXXMY1grZ-o/b0y3ENIaCQAJ Bug: 313888, 854091 Change-Id: I2cb4174e644d338163ad5162c7574aaee75d3abd Reviewed-on: https://chromium-review.googlesource.com/1226485Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Manu Cornet authored
Because the "homecher" view is now always enabled in tablet mode, it doesn't make any sense to show a highlight behind the app list button (which would always be there). Never showing the highlight in tablet mode is the recommended solution from UX (see linked bug). Bug: 878957 Change-Id: I0c5de178b6c9a3ad24d3390b645f5f91d034ed0e Reviewed-on: https://chromium-review.googlesource.com/1226491 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#591411}
-
Xianzhu Wang authored
- cc::TransformNode::flattens_inherited_transform - ccLayerId and ccContentsLayerId in GraphicsLayerAsJSON for matching blink and cc layers TBR=chrishtr@chromium.org # for trivial change in cc Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I03ce50e44bca724a2d5b6b9a88ce38bc7d2d2835 Reviewed-on: https://chromium-review.googlesource.com/1225871 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591410}
-
Sergey Ulanov authored
AudioOutputStreamFuchsia was relying on AudioOut::Play() to calculate stream reference time. When the stream was previously paused Play() doesn't take into account the current media position, as result reference_time wasn't calculated correctly (see MTWN-164). Updated the code to calculate reference_time_ explicitly instead of relying on AudioOut::Play(). Also added DiscardAllPackets() call in Stop() to discard all buffered data to avoid playing it when the stream is restarted. Bug: 882983 Change-Id: I216fd41bfdb3479ea4c8db6523c7e66ce91552cf Reviewed-on: https://chromium-review.googlesource.com/1220704Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591409}
-
Ramin Halavati authored
kEnableReferrers is removed from incognito persistent preferences list as it is not exposed to UI and cannot be changed from incognito mode. The tests checking its former behavior are also updated. Bug: 861722 Change-Id: I357e81482efa41c6436b7ed79c0b84e4e55cfc0b Reviewed-on: https://chromium-review.googlesource.com/1219609Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#591408}
-
Yue Li authored
Restore the changes that was incautiously overridden in a refactor cl. The change initially come from the file assistant_optin_handler.cc in the cl https://chromium-review.googlesource.com/c/chromium/src/+/1198002. Bug: None Test: Manual Test Change-Id: I5505875c916cbe7de3260a63db232d491228eba4 Reviewed-on: https://chromium-review.googlesource.com/1226611Reviewed-by:
-
Xing Liu authored
This CL finishes the video thumbnail pipeline for most codec except vp8, vp9. Now it's ready to hook to the UI frontend. It does following: 1. Render the video frame with existing media toolkit, which can read back pixel data from a texture in GPU process. 2. Plumbs a few metadata fields and thumbnail bitmap to Java layer. Bug: 826021 Change-Id: Id6635975726f4b12ab51e01cb6b3e78a198632f4 Reviewed-on: https://chromium-review.googlesource.com/1222694Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591406}
-
Mike Wittman authored
Change-Id: Id68c456d354ecae820de360d6c7a4b9ba8754eb7 Reviewed-on: https://chromium-review.googlesource.com/1226622Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#591405}
-
Sergey Ulanov authored
P2P sockets destroy themselves on errors, but there were some cases when they would still access themselves after an error has occured. Some, but not all of these issues were addressed in crrev.com/590539. This CL addresses remaining problems. Particularly errors from P2PSocketTcpBase::OnPacket() were not handled properly. Also updated unittests to destroy sockets, to make it possible to catch these issues in tests in the future. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I9cae97c5715f199c3f6dbccd3fbcd687e276a325 Bug: 884242 Reviewed-on: https://chromium-review.googlesource.com/1220676 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591404}
-
Weidong Guo authored
The removed code was originally used to make shelf remain transparent for fullscreen backdrop window [1]. Now the shelf is no longer transparent, it should be removed. [1] https://chromium-review.googlesource.com/c/chromium/src/+/606706 Bug: b/79201599 Change-Id: Ic5b214cc714a7699d8ea4fda1a059a7d03104f6c Reviewed-on: https://chromium-review.googlesource.com/1224640Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#591403}
-
Vladislav Kaznacheev authored
Blacklist this flaky test for single_process_mash_browser_test. Keyboard overlay is slated to be removed soon. Bug: 884216 Test: verify filter file locally Change-Id: I48c7cc0de3648c9a5445d502f3fe08f436631605 Reviewed-on: https://chromium-review.googlesource.com/1227139Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#591402}
-
Scott Graham authored
Bug: 813631 Change-Id: Ib179df82faf2052e86a7c1a26994eff4d9f0ab45 Reviewed-on: https://chromium-review.googlesource.com/1226355Reviewed-by:
-
