- 23 Oct, 2020 40 commits
-
-
Tim Volodine authored
The test is flaky on Android bots and has been failing recently on the "Marshmallow 64 bit Tester" bot in particular. BUG=1141870 TBR=horo@chromium.org Change-Id: I82d73ac8c57595485047d6c8eb2a91195b155bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495144Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#820279}
-
Rohit Agarwal authored
This CL explictly makes uses of Regular profile in the tests as OfflinePageBridge is null for OTR profiles and it's already tested in OfflinePageBridgeTest Bug: 1060940 Change-Id: If215f7ea0beee9a1c5d7cdb20863a8df321dc6c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494860Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#820278}
-
Marijn Kruisselbrink authored
External paths aren't absolute paths, and thus need to be treated differently. Actually blocking paths (like the root of the Downloads directory) seems to have been broken already, so for now this just allows all external paths. We should add special chrome-os logic to block what we do want to block in a follow-up. Bug: 1009970, 1134029 Change-Id: I8e5e437698b619d9df643706119c8b3492f58476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442901Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#820277}
-
Rohit Agarwal authored
Bug: 1060940 Change-Id: I523009ba4a6d9ad6d257b9b2bc0e6b3061b379cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494724Reviewed-by:
-
Jordan Oroshiba authored
Fixes unintended behavior of clicking on ImageView not opening the dialog. The intended behavior is for a click anywhere in the preference row to open the dialog, for local consistency in preference behavior. Bug: 1141799 Change-Id: I23b35c492819bec28f690f9f87d7ec4fddf68f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495321 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Auto-Submit: Jordan Oroshiba <oroshiba@google.com> Cr-Commit-Position: refs/heads/master@{#820275}
-
Robert Ma authored
from c808aa3d15a42648d8b25a838024813990959e37 Change-Id: Ibec6a32fc4994773b728214ce9c1ab944dd00e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495242 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#820274}
-
Mohamed Heikal authored
Currently it is not easy to test the supersize viewer without uploading a dev version to the production site. Add option to upload_html_viewer.py to host locally. Also adds a staging option because WFH and local development don't mix so well. Change-Id: Ieb79a47ba836898cf9da28805ce3c6a9a3e208a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485781 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#820273}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I36a30aea10b4522a144328eedf1a6347ea47cd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820272}
-
Anthony Cui authored
This change adds two new histograms for tracking the availability of manual translate from menus on both desktop (context menu) and mobile platforms (app menu). The first logs whether or not manual translation is available on the current page. This replaces the existing Translate.MobileMenuTranslate.Shown metric, which served a similar purpose but was mobile-specific. The second histogram logs all the reasons why manual translate is not available in such an event. This metric will be used to investigate the prevalence of these reasons, and leverage it to make the menu translate feature more visible to users. Logging is done from the shared TranslateManager::CanManuallyTranslate through a flag. Logging is done once per menu open. Bug: 1127094 Change-Id: Iddc46cc3e80d29a2cc8d757414fe9b74888ef02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468796 Commit-Queue: Anthony Cui <cuianthony@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#820271}
-
Vincent Boisselle authored
Bug: 1141737 Change-Id: I01750af13a9fd4b58863957a98a0dabaf9a68230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493708Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#820270}
-
Benjamin Beaudry authored
We initially added IsUIAControl with a different implementation for web content nodes and views nodes. For web content, we have this great and complete implementation that got refined over time, but for views, we never really updated it - it's basic. Turns out that the value returned by IsUIAControl is incorrect for views that are marked as read-only. For example, click on the "Try it" button in the following link and try to focus the read-only address bar of the new window. It doesn't work. https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_win_open3 My first solution had the intent of unifying the implementations for web content and for views. However, that caused issues with menus and sub-menus when using Narrator, so I instead decided to go with a safer approach - simply remove the IsReadOnly condition. That condition doesn't have its place there and everything works better without. I tried this on Chromium with and without UIA and on Edge, with UIA. Everything still works great! editable one. AX-Relnotes: A read-only omnibox is now accessible to ATs, just like an Bug: N/A Change-Id: Ib551701e0220a3422c989b271ed5edfad15f060e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490846Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820269}
-
Scott Violet authored
This reverts commit d42167eb. Reason for revert: This seems to have made ProfilePickerEnterpriseCreationFlowBrowserTest.CreateSignedInProfileSettings fail on win7 bot: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/65702 . Output: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8865640044637153696/+/steps/browser_tests/0/logs/Deterministic_failure:_ProfilePickerEnterpriseCreationFlowBrowserTest.CreateSignedInProfileSettings__status_CRASH_/0 Original change's description: > [Dice sync delegate] Split sync confirmation and sync disabled > > This CL splits the ShowSyncConfirmation() function of the dice turn on > sync helper delegate into one that shows the normal sync confirmation > and one that shows a error message that sync is disabled by the admin. > > Since both the dialogs are implemented by the same webUI page, there > is not much behavioral change. The only change is for the delegate > for the signed-in profile creation flow which opens a new browser > window and shows the dialog in this window instead of showing it in > the creation flow window. > > In follow-up CLs, the variant of the UI will be passed as a param > to the WebUI page replacing the logic to decide which variant to show. > > Bug: 1126913 > Change-Id: Ibac9a339c4fb071f960f15864482c818247f5719 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487100 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820222} TBR=droger@chromium.org,jkrcal@chromium.org Change-Id: I81c91215340e0d77530c3e1faf0a23eac31722b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495329Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820268}
-
Kevin McNee authored
We make the following updates to the guest view files being watched: - Add missing guest view directories and files - Fix entries which appear to be globs and make them regular expressions - Only watch guest view related documentation, rather than all extension documentation Bug: None Change-Id: Iddf47c8f9f03763a3ee2cd923f36ca00a594cd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493322Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#820267}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3836bccd. With Chromium commits locally applied on WPT: 02278791 "Revert "[mathml] Implement special drawing of largeop operator in displaystyle"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I463d57bd1e61bed04276ae359df70c4b58114f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495241Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820266}
-
Benoit Lize authored
On gLinux, this shows that with the thread cache, for tests that hit the cache: - PartitionAloc is ~2x faster with the thread cache on a *single* thread - The thread cache makes PartitionAlloc an order of magnitude faster at least with 4 threads (on a machine with 20 physical cores) - It is competitive with the System allocator (glibc) no matter the number of threads. See below: 1. One thread: [ RUN ] MemoryAllocationPerfTest.MultiBucketWithFree/0 *RESULT MemoryAllocationthroughput: MemoryAllocation.MultiBucketWithFree_System_1_total= 49925308 runs/s *RESULT MemoryAllocationtime_per_allocation: MemoryAllocation.MultiBucketWithFree_System_1_total= 20 ns *RESULT MemoryAllocationthroughput: MemoryAllocation.MultiBucketWithFree_System_1_worst= 49925308 runs/s *RESULT MemoryAllocationtime_per_allocation: MemoryAllocation.MultiBucketWithFree_System_1_worst= 20 ns [ OK ] MemoryAllocationPerfTest.MultiBucketWithFree/0 (2039 ms) [ RUN ] MemoryAllocationPerfTest.MultiBucketWithFree/1 *RESULT MemoryAllocationthroughput: MemoryAllocation.MultiBucketWithFree_PartitionAlloc_1_total= 25700384 runs/s *RESULT MemoryAllocationtime_per_allocation: MemoryAllocation.MultiBucketWithFree_PartitionAlloc_1_total= 38 ns *RESULT MemoryAllocationthroughput: MemoryAllocation.MultiBucketWithFree_PartitionAlloc_1_worst= 25700384 runs/s *RESULT MemoryAllocationtime_per_allocation: MemoryAllocation.MultiBucketWithFree_PartitionAlloc_1_worst= 38 ns [ OK ] MemoryAllocationPerfTest.MultiBucketWithFree/1 (2063 ms) [ RUN ] MemoryAllocationPerfTest.MultiBucketWithFree/2 *RESULT MemoryAllocationthroughput: MemoryAllocation.MultiBucketWithFree_PartitionAllocWithThreadCache_1_total= 47524712 runs/s *RESULT MemoryAllocationtime_per_allocation: MemoryAllocation.MultiBucketWithFree_PartitionAllocWithThreadCache_1_total= 21 ns *RESULT MemoryAllocationthroughput: MemoryAllocation.MultiBucketWithFree_PartitionAllocWithThreadCache_1_worst= 47524712 runs/s *RESULT MemoryAllocationtime_per_allocation: MemoryAllocation.MultiBucketWithFree_PartitionAllocWithThreadCache_1_worst= 21 ns 2. 4 threads [ RUN ] MemoryAllocationPerfTest.MultiBucketWithFree/9 *RESULT MemoryAllocationthroughput: MemoryAllocation.MultiBucketWithFree_System_4_total= 126134856 runs/s *RESULT MemoryAllocationtime_per_allocation: MemoryAllocation.MultiBucketWithFree_System_4_total= 7 ns *RESULT MemoryAllocationthroughput: MemoryAllocation.MultiBucketWithFree_System_4_worst= 28002580 runs/s *RESULT MemoryAllocationtime_per_allocation: MemoryAllocation.MultiBucketWithFree_System_4_worst= 35 ns [ OK ] MemoryAllocationPerfTest.MultiBucketWithFree/9 (2049 ms) [ RUN ] MemoryAllocationPerfTest.MultiBucketWithFree/10 *RESULT MemoryAllocationthroughput: MemoryAllocation.MultiBucketWithFree_PartitionAlloc_4_total= 2960527 runs/s *RESULT MemoryAllocationtime_per_allocation: MemoryAllocation.MultiBucketWithFree_PartitionAlloc_4_total= 337 ns *RESULT MemoryAllocationthroughput: MemoryAllocation.MultiBucketWithFree_PartitionAlloc_4_worst= 699706 runs/s *RESULT MemoryAllocationtime_per_allocation: MemoryAllocation.MultiBucketWithFree_PartitionAlloc_4_worst= 1429 ns [ OK ] MemoryAllocationPerfTest.MultiBucketWithFree/10 (3352 ms) [ RUN ] MemoryAllocationPerfTest.MultiBucketWithFree/11 *RESULT MemoryAllocationthroughput: MemoryAllocation.MultiBucketWithFree_PartitionAllocWithThreadCache_4_total= 95663528 runs/s *RESULT MemoryAllocationtime_per_allocation: MemoryAllocation.MultiBucketWithFree_PartitionAllocWithThreadCache_4_total= 10 ns *RESULT MemoryAllocationthroughput: MemoryAllocation.MultiBucketWithFree_PartitionAllocWithThreadCache_4_worst= 21672892 runs/s *RESULT MemoryAllocationtime_per_allocation: MemoryAllocation.MultiBucketWithFree_PartitionAllocWithThreadCache_4_worst= 46 ns Bug: 998048 Change-Id: I13ac85714fae343871f0f448f0a36729e8ad4c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491366 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#820265}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 88-4277.0-1602497703-benchmark-88.0.4294.0-r1 to 88-4280.20-1603104419-benchmark-88.0.4296.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9dbe6cffc45f292aaf310678cd659899dd37864d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495325Reviewed-by:
-
Harvey Yang authored
Updating with CL:2494163, this commit replaces GetAttribute with GetAttributes so that sensor clients can get multiple attributes within one Mojo request. BUG=chromium:1006141, b:162154663 TEST=builds and run ash on octopus Change-Id: I33fb315050b5aaefa8e387a8afcdc2aa1c9ca2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490320Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Auto-Submit: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820263}
-
Scott Violet authored
This reverts commit da531d49. Reason for revert: I think this is the source of tast failures on the waterfall. See https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/29675 for one. I think the issue is that it looks like tast tests have hard coded the string to search for, and since you're renaming it the string is no longer found: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/platform/tast-tests/src/chromiumos/tast/local/crostini/ui/settings/settings.go;l=52?q=tast-tests%20Linux%20(Beta)&ss=chromiumos%2Fchromiumos%2Fcodesearch:src%2Fplatform%2Ftast-tests%2F Original change's description: > Crostini settings string changes. > > Instead of "Linux (Beta)", now shows as "Developers" > > Bug: 1140370 > Change-Id: Id4e076b5d918e41e22e5c59d65958da9e75a3f55 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486528 > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Auto-Submit: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820205} TBR=khorimoto@chromium.org,nverne@chromium.org,davidmunro@google.com Change-Id: I6aa9216749d2d175b145821bf514c1642496e0e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495327Reviewed-by:
-
Justin Miron authored
This change introduces a new UKM for counting navigation redirects in the pop up tracker. Redirects are commonly used for navigaing abusive pop-ups to ad content from elements not tagged as ads by the ad tagging framework. Using redirect counts as a new filter will help us refine our abusive popup identification. BUG=1044601 Change-Id: I68ad28a1b2965a8c1e844ec06eb42b487c6ef717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438669Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#820261}
-
cfredric authored
Using matchers (instead of multiple, simpler expectations) is more declarative, less repetitive, and allows the test to give better error messages in case of failure. In this test in particular, the matchers allow us to avoid crashing the test if `secure_dns_config.servers()` contains the wrong number of elements; and allows us to delete the `ContainsSubstring` helper. Change-Id: Ia0f274bbe19a009e7cefbea43ff7fb33c31463be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488220 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#820260}
-
Alex Turner authored
base::Bind and base::Callback are deprecated and should be replaced with the more explicit base::Bind{Once,Repeating} and base::{Once,Repeating}Callback. Bug: 1141533, 1007642 Change-Id: Iae0a64868e4e63743cf5743b1c1f897260059078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492561Reviewed-by:Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#820259}
-
Marc Treib authored
After recent cleanups, this method did nothing except maintain |associated_types_| - which itself wasn't used at all, except for some DCHECKs, so it's removed now as well. While we're here, also remove ModelAssociationManager::state_ which wasn't used (or useful) either anymore. Bug: 1102837 Change-Id: Id62edd0f4be324fd4449dfd16e2a98530ee0c3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494867Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#820258}
-
Stephen McGruer authored
This rolls up to sha d004bddde373550fe9a563487adda3e17fc4c697 Bug: None Change-Id: I7b92df20ea3462512ff1978a766cf84a09d9e358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480143 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#820257}
-
Ricky Liang authored
When the render thread encounters GPU context lost, we need to re-create the SharedImage resources to recover the video capture stream. This is a reland of crrev.com/c/2455328 with a fix to address the MSAN test failure Bug: 1131998, b:169429427 Test: Manually with chrome://gpuclean on soraka TBR=jcliang@chromium.org,ccameron@chromium.org,kbr@chromium.org,dcastagna@chromium.org,guidou@chromium.org,ccameron@google.com Change-Id: I872a06a37dbce1eefadf6b0f256b80d0f87ecac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494297Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820256}
-
Frédéric Wang authored
This relands [1] but removing the test RegisterProtocolHandlerAndServiceWorkerInterceptor.DoNotRegisterFetchListener which is flaky on mac and not essential for testing the bug fix. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2379672 Original change's description: > [Sheriff] Revert "Make custom protocol handlers work with service workers' fetch event" > > This reverts commit c007dfe1. > > Reason for revert: RegisterProtocolHandlerAndServiceWorkerInterceptor.DoNotRegisterFetchListener is very flaky on mac (and possibly elsewhere). > > Sample failure: > [ RUN ] RegisterProtocolHandlerAndServiceWorkerInterceptor.DoNotRegisterFetchListener > [23479:30231:1019/055809.421386:WARNING:notification_platform_bridge_mac.mm(374)] AlertNotificationService: XPC connection invalidated. > [23479:775:1019/055809.917320:ERROR:device_event_log_impl.cc(211)] [05:58:09.906] FIDO: touch_id_context.mm:127 Touch ID authenticator unavailable because keychain-access-group entitlement is missing or incorrect > [23479:96771:1019/055810.044487:WARNING:embedded_test_server.cc(667)] Request not handled. Returning 404: /favicon.ico > [23479:775:1019/055810.218450:INFO:CONSOLE(0)] "Failed to launch 'web+html:path' because the scheme does not have a registered handler.", source: (0) > ../../content/public/test/browser_test_base.cc:702: Failure > Failed > RunLoop::Run() timed out. > Stack trace: > 0 browser_tests 0x0000000110d3e9c2 _ZN4base8internal7InvokerINS0_9BindStateIZNS_4test20ScopedRunLoopTimeoutC1ERKNS_8LocationENS_9TimeDeltaENS_17RepeatingCallbackIFNSt3__112basic_stringIcNSA_11char_traitsIcEENSA_9allocatorIcEEEEvEEEE3$_0JS5_SI_EEEFvvEE3RunEPNS0_13BindStateBaseE + 290 > 1 browser_tests 0x0000000110c5916f base::(anonymous namespace)::OnRunLoopTimeout(base::RunLoop*, base::OnceCallback<void ()>) + 31 > 2 browser_tests 0x0000000110c5a1a3 base::internal::Invoker<base::internal::BindState<void (*)(base::RunLoop*, base::OnceCallback<void ()>), base::internal::UnretainedWrapper<base::RunLoop>, base::RepeatingCallback<void ()> >, void ()>::RunOnce(base::internal::BindStateBase*) + 67 > 3 browser_tests 0x000000010cf23a83 void base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::ForwardOnce<>() + 35 > 4 browser_tests 0x000000010cf23b34 base::internal::Invoker<base::internal::BindState<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::*)(), base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> > > >, void ()>::RunOnce(base::internal::BindStateBase*) + 148 > 5 browser_tests 0x0000000110c7a946 base::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 310 > 6 browser_tests 0x0000000110c8fb55 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) + 405 > 7 browser_tests 0x0000000110c8f858 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 168 > 8 browser_tests 0x0000000110ce29a1 ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 49 > 9 browser_tests 0x0000000110cdb662 base::mac::CallWithEHFrame(void () block_pointer) + 10 > 10 browser_tests 0x0000000110ce223f base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63 > 11 CoreFoundation 0x00007fff38600884 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 > > Original change's description: > > Make custom protocol handlers work with service workers' fetch event > > > > When a service worker intercepts a page that is later registered as a > > handler for a custom scheme via navigator.registerProtocolHandler, and > > if one clicks a link with this custom scheme, then the service worker > > is only able to intercept the page after reload. This CL fixes that > > bug by allowing the service worker to intercept the page after > > registering the custom scheme. > > > > A new browser unit test is added to verify this fix. This also makes > > the following manual WPT tests pass (*): > > protocol-handler-fragment-manual.https.html > > protocol-handler-path-manual.https.html > > protocol-handler-query-manual.https.html > > > > (*) https://w3c-test.org/html/webappapis/system-state-and-capabilities/the-navigator-object/ > > > > Bug: 522370 > > Change-Id: I95eda9025885838665e9735ac9f47a3d65d89aa8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379672 > > Commit-Queue: Frédéric Wang <fwang@igalia.com> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#818416} > > TBR=falken@chromium.org,fwang@igalia.com,dominickn@chromium.org > > Change-Id: I026705f0116f3e0d684c8b1d80847aec85ec36db > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 522370 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485837 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818511} Bug: 522370 Change-Id: Id30235a64a5a6a5c5d783ee686df321c7c853b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487107Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#820255}
-
Roman Sorokin authored
To the Views-based user adding screen. Bug: 1066489 Change-Id: Ib8e96ef0ed08cb3779681088fd27d6c9d5301a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470632 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#820254}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5641e3c185a8..4791cf2cde52 2020-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from ea52b3c2d270 to 3b334b2b8e1a (1 revision) 2020-10-23 jmadill@chromium.org Temporarily duplicate standalone tests. 2020-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e02d8938821a to 8012e62471be (1 revision) 2020-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 6fac705e7616 to 69f07da41b3b (24 revisions) 2020-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cb0c1533 to e203e4bc (25 revisions) 2020-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 8832c373 to cb0c1533 (272 revisions) 2020-10-23 courtneygo@google.com Vulkan: Fix segv referencing contextVk 2020-10-22 ianelliott@google.com Add run-time check in EVENT() to disable debug markers 2020-10-22 sugoi@chromium.org Allow rendering to half float in ES2 contexts when possible 2020-10-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 72a62c65 to 8832c373 (1033 revisions) 2020-10-22 cnorthrop@google.com Revert "Tests: Add FIFA Mobile trace" 2020-10-22 syoussefi@chromium.org Vulkan: Validate SPIR-V transformer at link time 2020-10-22 xiaoxuan.liu@arm.com Fix end2end tests VertexAttribute* failure 2020-10-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 970c132746b1 to 91ce213a1d88 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Test: Test: angle_perftests -v --local-output --gtest_filter="TracePerfTest.Run/*nba*" Change-Id: I93bf7d16b36bd14e76ac3ed82c984bbb0daec99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495113Reviewed-by:
-
Leo Lai authored
BUG=None TEST=build. Change-Id: I0c825259f32c6edc07cf1ca089c02fda97b33579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491760Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#820252}
-
Sadrul Habib Chowdhury authored
In the regular async multi-threaded setting, the compositor submits a CompositorFrame 'during a frame', i.e. between BeginImplFrame() and FinishImplFrame(). In the sync setting for webview, the CompositorFrame is submitted 'after a frame', i.e. after both BeginImplFrame() and FinishImplFrame() has been called. This change defers the FinishImplFrame() to happen after the CompositorFrame is submitted (when a draw is anticipated). This change brings the webview configuration a little closer to the regular configuration. In the process, it also fixes the PercentDroppedFrames metrics for webview. BUG=1136519 Change-Id: I924c772d57cf2b5210d324e4da7acbe877aa298f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469779Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#820251}
-
Nate Chapin authored
Change-Id: I5dbcb6c06c98862facd34376c8b43abe557f4b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493375Reviewed-by:
-
Maksim Moskvitin authored
Removed matcher is unused. Bug: 1105388 Change-Id: Iafc5a2236873c1bc02ea1f1c7500647d714553de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494870 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Steve Kobes authored
This feature launched in M84. Bug: 1053510 Change-Id: I2351e31665d135fd39f8219ce5002dff8c8109cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493484Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#820248}
-
harrisonsean authored
Add button accessiblility label to items when they are clickable. Bug: 1078782 Change-Id: I07fb2e6b965218aefd4fb5ff0627ccfa5c202834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490108 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#820247}
-
Clark DuVall authored
This is a reland of b9d174e5 There were issues uploading to the Play console which should now be fixed, see crbug.com/1141430 for more details. Original change's description: > Enable isolated splits in canary > > All known issues have been fixed so enabling this in canary to see if > there are any major problems. > > Bug: 1126301 > Change-Id: I0c3bc7443fcca8b81f7c2652d90b982872f7ea08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478144 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819200} TBR=agrieve@chromium.org Bug: 1126301 Change-Id: Idff90dadf9a5b1ec3cf047db1ce25d85cf8faf2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493460Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6b3c8d667a5f..4cd11945c5a1 2020-10-23 fmayer@google.com Fix CI. 2020-10-23 fmayer@google.com Update traceconv and trace_processor. 2020-10-23 mast@google.com Merge "Rename ART release APEX to com.android.art." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:169148096 Tbr: perfetto-bugs@google.com Change-Id: I6f3b4bf6ad2069ad764ce0993482f39d9f3f12bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495114Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ade9a5235c73..24e636926107 2020-10-23 cwallez@chromium.org Slightly improve a RenderPipeline error message. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I4657d5ed6cc8e3ae90ecd90049423133dbd92cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495112Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603426036-fdbbb30b2e93e949277645ff11f5cf593a24568b.profdata to chrome-linux-master-1603454266-512aeaba1be85f32943004abfaab59393bece0f1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I475fb451d735ed8e5fb5c08bb6746b9ccc226c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495118Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/871500da9041..213fa85f73cd 2020-10-23 nisse@webrtc.org Internal-only visibility for rtc_base:macromagic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I842bbda90347537f18e3e8378cad611476b4c397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495109Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This simplifies further policy removing changes to be done in crbug.com/1103390 by refactoring all affected tests in 1 CL. Bug: 1103390 Change-Id: Ieaf7270cfee4fac9cd52e1834583184dc2d71a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463942 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#820241}
-
Sophey Dong authored
Bug: 1141583 Change-Id: I4ae4990ccafec8585aa91000b69a0f99ba06fed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493123Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
-
