- 14 Jan, 2020 40 commits
-
-
Nick Diego Yamane authored
crrev.com/c/1769450 removed X11-specific DWTHX11::{Set,Is}Fullscreen() overrides in favor of DWTHPlatform versions, making chrome to enter/exit browser fullscreen mode both when it is requested explicitly by the user (e.g: Using F11 keybinding) as well as when it was requested by the other process, e.g: custom WM keybinding to toggle _NET_WM_STATE_FULLSCREEN window state. Such functionality change can be considered a regression as it violate EWMH guidelines, which states: > When a window-manager tells a window to become 'fullscreen', it is not > telling the window to make a sub-selection of its contents fullscreen, but > instead optimize the whole application for fullscreen usage. Window > decorations (e.g. borders) should be hidden, but the functionalily of the > application should not change. This CL restores the previous behavior and test expectations. Additionally this fixes an issue in window bounds tracking while it is in browser fullscreen mode (but the X11 window is not in fullscreen state). Such issue was already present before this regression has been introduced. Bug: 1035772 Change-Id: Ief8fba7df2c5d2466da038c2b9edf1d928261c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989049Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#731721}
-
Oksana Zhuravlova authored
Since Java bridge is an Android-specific feature, this change guards the relevant code in the renderer with #if defined(OS_ANDROID). Bug: 794320 Change-Id: I4b14f47eebce91b6697d5dec04af0314ec6162b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995992Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#731720}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/28f5c8101b20..d3e59119bcf5 git log 28f5c8101b20..d3e59119bcf5 --date=short --first-parent --format='%ad %ae %s' 2020-01-14 primiano@google.com Merge "ui: add offline support via ServiceWorker" Created with: gclient setdep -r src/third_party/perfetto@d3e59119bcf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iba5174d39a4dfb5e4c6e3023ba8822891706ad5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001518Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731719}
-
Chris Mumford authored
Required changes: 1. Python 3 exceptions no longer have a message attribute so created a new ExtractError exception. 2. Switched from the imp to the importlib module. Bug: none Change-Id: I5c8b08dca1534e235309464cf5e054578b9ed2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000981 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#731718}
-
Bin Wu authored
In QUIC field trial testing config, change the connection_options of the 'Enabled' group from 'NSTP' to '5RTO,ACKD'. R=rch@chromium.org Change-Id: If8f66f1c892c27bb8525e0798c41be725724d6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000968 Commit-Queue: Bin Wu <wub@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#731717}
-
Julian Watson authored
Bug: 1023256 Change-Id: I69df55758d0388f9d1630bd97e57df4518b1e932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977885 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#731716}
-
Daniel McArdle authored
Change-Id: Ie0bf69b8c599c46df165e3ca624939ee34dd5dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001186Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#731715}
-
David Van Cleve authored
We have a feature in //net where we'd like to reuse the SQLite-wrapping infrastructure implemented in //chrome/browser/predictors. This change, the first of two CLs comprising this refactor, moves ResourcePrefetchPredictor's table classes to //components, making only the smallest possible changes to the classes themselves. The subsequent followup change will do some renaming in order to make the classes sound a little more generic. Bug: 1036494 Change-Id: I5dd8f35d4e135115eeae149099f474e21187c270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979366 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731714}
-
Greg Guterman authored
I've joined the current mb_config.pyl with /src/cr-buildbucket.cfg to remap masters to buckets for a new bucket-based mb_config_buckets.pyl. Also the old logic that used the 'master: { chromium: {...}}' dict to specify the chromium builders that blacklist chrome proprietary mixins now looks at a top-level config key in mb_config_buckets.pyl called 'public_artifact_builders'. mb.py has been modified to support the new type of mapping in mb_config_buckets.pyl and will use it by default if a bucket is specified. I hope to move all the code that uses mb to use buckets instead of masters, at which point I plan to remove all the master-related functions from mb.py The new functions have been written in a way that makes it easy to remove the old master-based functions at the cost of being less DRY. Validation stuff was factored out to a helper file to lighten the load inside of mb.py. Also there seems to be a dead function which I removed: CheckCompile. This pyl also excludes all the internal builders, which will be moved to src-internal. Bug: 1028719 Change-Id: I86b55b12def06afab81faec66463963ede2f3244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963441 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by:Aaron Gable <agable@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#731713}
-
Dan Beam authored
R=poromov@chromium.org Bug: 1028829 Change-Id: I851c2a128c9ce26d02f1be9f3970d1bbc46f9ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996135 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#731712}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 1041419 Change-Id: Ib7bfeb431e9f0522d2b9b1869bfcabfaf21c34fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998388 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#731711}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=alemate@chromium.org Bug: 1041419 Change-Id: I5723ed7e974e973d1e2d66c9ebf60243507e1111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998797 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#731710}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=alemate@chromium.org Bug: 1041419 Change-Id: I44fcaf044733231b29c44ee2461761a0a6ee23c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998328 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=alemate@chromium.org Bug: 1041419 Change-Id: I6d8f45630e1c04bae8d1f5ff9b41f086a383a74e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997975 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Bence Béky authored
These tests were disabled at one point during the preparation of a recent merge CL, but in the end disabling them would not have been necessary. Change-Id: Iebf4092746e84054acba1a8d6bfe5554a7720956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001317Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=alemate@chromium.org Bug: 1041419 Change-Id: I7317b4bfdc0f3a7092ab59f1e8cc5a7380bf402c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993849 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=alemate@chromium.org Bug: 1041419 Change-Id: Ib84fc73891f9d365b3dc0251f7e63111007d1115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997984 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 1041419 Change-Id: I491a7c08b004274289584a4d8d6115f7b1094833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998943 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 1041419 Change-Id: I6135aab922a507a1ec6505f2d811b895ad0e5dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993917 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 1041419 Change-Id: I3f69b601bd3cc3d55b55d00245043174bb3c68ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997763 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=nzolghadr@chromium.org Bug: 1041419 Change-Id: I86adbcbd780e75ef47856090bca1e42945691977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995847 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#731701}
-
Allen Bauer authored
Bug: 648382 Change-Id: I6a1d9075ee889b3d31b169b3f4c12bb4192ded38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001223 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#731700}
-
Dan Beam authored
prop: function(...) { to prop() { This CL changes this in: //components/ TBR=poromov@chromium.org Bug: 1041171 Change-Id: I942b81decc9ad382a14b2c0aeeb53e96e9af4bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001400Reviewed-by:Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#731699}
-
Sam Fortiner authored
Based on early results in dev/canary, this feature is looking promising and we would like to continue this experiment in Beta. To unblock that we are enabling this experiment for the perf bots now to get more data on the impact. Bug: 752756 Change-Id: Ia8078787194ce2ee5e1922456dc80576f84ef176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993144 Commit-Queue: Sam Fortiner <samfort@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e5cb8f2eff7e..cd170a5c7216 git log e5cb8f2eff7e..cd170a5c7216 --date=short --first-parent --format='%ad %ae %s' 2020-01-14 rharrison@chromium.org Implement using spvc in ExtractSpirvInfo Created with: gclient setdep -r src/third_party/dawn@cd170a5c7216 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I9b5f4c14c0bf2633a6f85d3ed013c5af56c4048c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999958Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=rnk@chromium.org Bug: 1041419 Change-Id: Icc793b1f54f98146eb7d635662d0ae184424f5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997701 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#731696}
-
Clark DuVall authored
This reverts commit c4f3b72d. Reason for revert: Breaking network_service_out_of_process_chrome_public_test_apk, see http://crbug.com/1041822 Original change's description: > Reland "Squash top level error code returned from host resolver." > > This is a reland of 834f2092 > > Now not squashing ERR_NOT_IMPLEMENTED to avoid disrupting existing > InProcessBrowserTests. > > Original change's description: > > Squash top level error code returned from host resolver. > > > > If the host resolution process fails, the top level error code should > > now be only ERR_NAME_NOT_RESOLVED. A more specific error code (e.g. > > ERR_CONNECTION_REFUSED if a secure mode DoH server was offline) may be > > found in ResolveErrorInfo. > > > > Bug: 1016325 > > Change-Id: I9f5f857fffd71be6485d05280239cd0b649d7a8f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974678 > > Commit-Queue: Katharine Daly <dalyk@google.com> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Eric Orth <ericorth@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#728725} > > Bug: 1016325 > Change-Id: If2d029ea94f1a85f95d641cf02e4283973316a98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992191 > Reviewed-by: Eric Orth <ericorth@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Katharine Daly <dalyk@google.com> > Cr-Commit-Position: refs/heads/master@{#730951} TBR=jam@chromium.org,mmenke@chromium.org,ericorth@chromium.org,dalyk@google.com Change-Id: I1d4d1c9b76c73a3762cfe739e5c99993579d1546 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016325, 1041822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001439Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#731695}
-
Daniel Murphy authored
This change adds the API method WriteBlobToFile to blob_storage_context.mojom and adds test for that method. It also adds some basic tests to the mojo version of BlobStorageContext. This call tries to optimize the file copy in the case of the blob being a single file. In that case, it will do a base::CopyFile call, which is optimized on Windows and should be faster. Otherwise, the API uses the blob.mojom ReadAll API and stream the data to a file. R=mek@chromium.org TBR=ksakamoto@chromium.org Bug: 1024966, 1036415 Change-Id: I5bf49c39780bd8e25c2ad0f68bb8de7979925284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974700Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#731694}
-
Aran Gilman authored
Bug: 1027612 Change-Id: Ia7baa75e8c66f6d5ec255bc6a044640685c83db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977380Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#731693}
-
Natalie Chouinard authored
Extract ExpandablePreferenceGroup to Settings build target, along with owned resources. Move shared resources (expand more/less icon and transitions) to ui/android. Bug: 1035928 Change-Id: I54173013d78f731aceb5ae90a7b85d07c176d94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992517 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#731692}
-
Greg Thompson authored
This aligns Chrome's DM token storage with Google Update's. This CL also makes base::win::RegKey a movable type. BUG=970162 Change-Id: Id6270411d2417501746ad85f8061cd7d93841618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997184 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731691}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I1af30f759635ad05f311f9d43b8c5c75c8f2cbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998004 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#731690}
-
Rossana Monteriso authored
This CL: * adds a required reference to the alignment.css resource file, that provides alignment-related CSS classes used in several test cases. Adding this reference fixes the align-content-distribution tests. * changes the dimension of grids having 3 rows, .verticalLR and .stretchedGrid classes, and gives them a new value of 300px width and 400px height (by using the class .width300height400). This way each row width is now equal to 300px/3=100px, instead of the previous dimension of 400px/3=133,33...px. The 133,33...px dimension was, in fact, interpreted differently in different browsers, thus making some tests fail in WebKit and Firefox. * removes the -expected.txt files, related to align-content-distribution tests, that were generated when these tests were failing. Change-Id: I404dd188e8a2275042b4ace218c78a99e3248be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996303Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#731689}
-
Piotr Bialecki authored
Prior to calling into ChromeActivity's getFullScreenManager(), we should check whether the activity is not finishing or already destroyed to protect ourselves from IllegalStateException. Fixed: 1038736 Change-Id: Ic8f25f5e839535031d92055b424cd624db4b2704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985168 Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#731688}
-
Olivier Li authored
Tracing config needed a comma for proper sepration in BENCHMARK_RENDERERS. Currently it does not and merges with the next category which breaks both. The file category should also be logged in BENCHMARK_NAVIGATION because we want to use it to get some insights into the use of ImportantFileWriter use from the Browser. Bug: 1039794 Change-Id: Ib2acf7eef6f2bacb1874d95e2bf427f54088b288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001244Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#731687}
-
Fei Ling authored
To enter full screen mode, use keyboard shortcut instead of finding and clicking the full screen button. Change-Id: I762952ed04d73d9be6a45ea3757a6212b59cff14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992693Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Fei Ling <feiling@chromium.org> Cr-Commit-Position: refs/heads/master@{#731686}
-
Jochen Eisinger authored
Bug: 873178 Change-Id: I696313dd80fb0801d951ff6c6e0c50661f84a63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000599Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#731685}
-
Filip Filmar authored
The tzdata is loaded only for OS_FUCHSIA, since Fuchsia is the only OS that needs this. Fuchsia needs tzdata loading because it supports multiple runners, and it is important that all of them use exactly the same tzdata version. If the tzdata files are not present, the execution proceeds, but the files are not loaded. In production, the runner will get time zone data from the config data directory which is made available to apps in specific Fuchsia products. Two unit tests are added: 1. A unit test that confirms tzdata loading affects the reported library revision. This test confirms that the loading mechanism works. 2. A unit test that checks whether the loaded timezone data revision matches what Fuchsia expects to see. This test will fail if loading fails so that the version in use is different from what Fuchsia expects. This allows Fuchsia engs to see how to fix the harmful version skew. This falilure should happen only if ICU libraries in Fuchsia and Chromium become backward-incompatible, which is unlikely but possible. R=dpranke@chromium.org, wez@chromium.org Bug: fuchsia:37487 Change-Id: I884777befbdb0ea9e324acc6c4359145c54d02aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949120 Commit-Queue: Filip Filmar <fmil@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#731684}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=ericrk@chromium.org Bug: 1041419 Change-Id: I38a8a73da2d421506d7cbeab034ed83850d602f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998513 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#731683}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 1041419 Change-Id: Ifbee858c55b92caa7c1d2345f207d681973526f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998380 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
