- 25 Jul, 2019 40 commits
-
-
Hiroshige Hayashizaki authored
To use common structures and names in referrer-policy and mixed-content tests, this CL - Renames `referrer_policy` to `delivery_value`, and - Moves it under `test_expansion`, because in mixed-content tests `delivery_value` can be different among multiple `test_expansion` entries under a single `specification` entry. Accordingly, `referrer_policy_schema` is moved to `test_expansion_schema`'s `delivery_value`, and related checks in spec_validator are removed. Generated files will be updated after some more changes, not now. Bug: 906850 Change-Id: I28beb09ab2eb4c69ec598de415d81cd1c8f77765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717592Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#681076}
-
Misha Efimov authored
Native C API functions are already exported from the libcronet.so file. Change-Id: I3dd65103aa8ad7c9e48f08e7a1cbdcffeeac0fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718468 Commit-Queue: Misha Efimov <mef@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#681075}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d30014c6. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" ff9a2993 "[WPT/common/security-features] Sort keys of test config JSONs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I242de766bb1b5688fe11996db84dabbc6057f8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719105Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681074}
-
Ahmed Mehfooz authored
We now reduce the number of rows of FeaturePods based on the available height for the system tray. The number of rows can go down to 1, the maximum rows remain unchanged at 3. Bug: 984367 Change-Id: Ia59afeecd357d62042d07ba15b3b40cdf90781ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704039Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#681073}
-
James Cook authored
Specifically, in multidevice settings and Play Store. Bug: 987732 Test: manually paired phone, checked strings Change-Id: I774fb80d26250b219b4dfd255ac88828e693f2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716043Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#681072}
-
Nico Weber authored
This doesn't remove the global CHROMIUM_BUILD define yet, but it removes all references to it. I will remove the define in an (easy to revert, if necessary) follow-up. Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1718785 Bug: 961769 Change-Id: Ibb920d1df7877a596d2d12df3b3ebf1d89d79c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715975 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#681071}
-
James Cook authored
* "Preferred search engine" * "Used by Chrome browser and <device> launcher" http://screen/zTiXifEKNT6 TODO: Style tooltip to spec. We should change all OS settings tooltips to use the same styling. Bug: 978464 Change-Id: If434d82607faaba0278da0a29112e8bd791281d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719268Reviewed-by:
-
Collin Baker authored
A unique_ptr<> was used inside a std::map, but std::map values are already stable in memory. We can directly store TabGroupData values without indirection and still hand out TabGroupData pointers. Bug: 905491 Change-Id: I250b156e56dc400a83374e57e06958fa5f06864f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719446 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#681069}
-
Hiroshige Hayashizaki authored
The values are always `top-level` and not used anywhere. Bug: 906850 Change-Id: Ia89f9b65cac935d65287a702f61f292513ca6189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717487 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#681068}
-
Brian Geffon authored
The kernel may not bubble up the close always if you don't specify POLLIN. BUG=chromium:964569 TESTED=tested on dev device Change-Id: I21f54edf12a4dbec1d2b3ba5fef6c78410457338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715898Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Raymond Toy authored
When there are multiple tracks in a MediaStreamAudioSourceNode, the track to use is the first track after sorting the tracks based on a lexicographic ordering of the track ids using code unit values. Feature: https://www.chromestatus.com/feature/5749997033226240 Bug: 984994, 983790 Change-Id: I0c194caa98de1f0283927dc0206219ab7679c86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706775Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681066}
-
Hiroshige Hayashizaki authored
To align spec.src.json with other parts of common/security-features/ such as common.js. Generated files will be updated after some more changes, not now. Bug: 906850 Change-Id: I87479bcf8ec6cdbf08e10a38a79885940b51e457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716109 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Toby H authored
This CL sets up the build flags to exclude supervised user code from Linux/Mac/Windows platforms. Bug: 980869 Change-Id: I25a4a64c46a0e8ac6beb4a88d144571180bdc55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713868 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#681064}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7a6d5b768672..7734ba9a7d52 git log 7a6d5b768672..7734ba9a7d52 --date=short --no-merges --format='%ad %ae %s' 2019-07-25 tsepez@chromium.org Avoid small mallocs for CPDF_Font::FormFactoryIface. 2019-07-25 tsepez@chromium.org Remove unused CFWL_WidgetTP::m_dwRefCount. 2019-07-25 tsepez@chromium.org Mark fxcrt::RetainPtr<>::m_nRefCount as mutable. Created with: gclient setdep -r src/third_party/pdfium@7734ba9a7d52 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Iea95fc25e2947341f6239b4d28f1038f57a6c368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717775Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681063}
-
Yue Li authored
In order to prevent corner cases/timing issue related to session state change, adding a check when showing the opt-in dialog. Bug: 978267 Test: Run existing tests Change-Id: I9f84e5fc90ba8d50407fa44a29749406ae1b2db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717464Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
To use common names in referrer-policy and mixed-content tests. The final goal is to rename all to `source_scheme` (which is done in https://chromium-review.googlesource.com/c/chromium/src/+/1718991). This CL renames first `source_scheme` to `source_protocol`, just to avoid rebasing in a long chain of commits. Generated files will be updated after some more changes, not now. Bug: 906850 Change-Id: Ic89e60e8a5f2f2780ad416ef189cfc5d1ad1b16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717115 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Vladimir Levin authored
If we don't have tilings, then we will append a checkerboard quad. In those cases, use scale 1.f to have more stable to-screen-space mapping, eliminating error exaggeration we might get from layer size rounding. See the referenced bug for more details. R=enne@chromium.org Bug: 986110 Change-Id: I8781077c81442466b0e91b71c5d8149a2d2bda79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717917Reviewed-by:
enne <enne@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681060}
-
Nate Fischer authored
No change to logic, only docs. This updates the class doc for AndroidStreamReaderURLLoader, since the doc was written back when it only supported shouldInterceptRequest. This adds documentation for the known subclasses of ResponseDelegate, to clarify which production cases they actually cover. Test: None Change-Id: Ib04e7dc6a43b548856d5bc2d41d9addabe824029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717440Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681059}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I4324d438bb053cadc733abe0febb645c06dc0d16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700916Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681058}
-
Hiroshige Hayashizaki authored
This CL rewrites `opt_in_method` so that both mixed-content and referrer-policy tests uses `delivery_type` and `delivery_value`. Mapping: | Before this CL | After this CL | | opt_in_method | delivery_type | delivery_value | +-------------------+---------------+----------------+ | "no-opt-in" | "meta" | null | | "meta-csp" | "meta" | "opt-in" | | "http-csp" | "http-rp" | "opt-in" | | "img-crossorigin" | Removed | "img-crossorigin" was removed because it was not implemented. Generated files will be updated after some more changes, not now. Bug: 906850 Change-Id: I4ea4571ee1c1312fe8fbc35590548a8021141258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717107 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Nico Weber authored
MEMORY_SANITIZER_INITIAL_SIZE is defined exactly if MEMORY_TOOL_REPLACES_ALLOCATOR is defined, so just use this instead. This reverts https://codereview.chromium.org/357603002/ which split this for deep memory profiler, but we haven't used that in years. While here, also change vector.h to no longer honor WTF_VECTOR_INITIAL_SIZE. This was added in https://chromiumcodereview.appspot.com/23804003 to be able to easily check different initial sizes back when it was difficult to change the value because blink was still in a different repo. The initial vector size was changed shortly after due to this experiment setup in https://codereview.chromium.org/23453040 , but it hasn't changed in the last 6 years since then -- also blink is now in src.git and if someone wants to change this value it's now very easy to do. No behavior change. Bug: 961767 Change-Id: I0e6fb5738a6f28fc833edaf90c110f4e4273e23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718596 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#681056}
-
Hiroshige Hayashizaki authored
To use common names in referrer-policy and mixed-content tests. Generated files will be updated after some more changes, not now. Bug: 906850 Change-Id: Icdb979d429f08a908a74f7f6012b4c0b7dc50c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717319Reviewed-by:
-
http://localhostStaphany Park authored
Issue #1: The "SecureContext" IDL attribute considers localhost to be secure, but the Cookie Store API assumed that it would only be exposed on cryptographically secure origins, so a DCHECK caused attempts to set/delete cookies on http://localhost to crash. This CL replaces the DCHECK with an exception that is thrown on attempts to set/delete secure cookies on cryptographically insecure origins. Issue #2: The "secure" cookie attribute defaulted to true. Setting/deleting a secure cookie on a cryptographically insecure origin is prohibited. The cookieStore.delete() API excluded the option to set the "secure" attribute, however, so there was no way to delete an insecure cookie. This CL defaults the "secure" attribute to true on cryptographically secure origins, and false otherwise. Bug: 956641 Change-Id: Iff7c22713e8604d60b68d42199a74b2d08235712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700357 Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#681054}
-
Cherie Shi authored
Bug: 987699 Change-Id: I31cd9181690e215ae8fa48d19901b0a5fa28cae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717441 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Varun Khaneja authored
R=drubery, gayane Bug: 984286 Change-Id: I0afe71b8d3f99ae15c8a2b2f61cc94daa5154617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716386 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#681052}
-
John Budorick authored
This reverts commit c9d067e0. Reason for revert: appears to be responsible for failures in external/wpt/webrtc/idlharness.https.window.html on: - https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests starting with https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/80197 - https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64 starting with https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/38821 Original change's description: > Reland "Add datachannel.maxPacketLifeTime" > > This reverts commit 49d46905. > > Reason for revert: Blame not credible - listed failures seem to be all MSAN timeouts. > > All they had in common with this CL is that the tests used the "idlharness" tool. > > Original change's description: > > Revert "Add datachannel.maxPacketLifeTime" > > > > This reverts commit e557c49c. > > > > Reason for revert: I suspect this CL causes the following test failures: > > external/wpt/xhr/idlharness.any.html > > external/wpt/storage/idlharness.https.any.html > > external/wpt/background-fetch/idlharness.https.any.serviceworker.html > > > > The first failed build: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/938 > > > > Original change's description: > > > Add datachannel.maxPacketLifeTime > > > > > > Delete nonstandard attribute maxRetransmitTime, and make both > > > maxPacketLifeTime and maxRetransmits nullable. > > > (Usage of both attributes has been measured to be negligible.) > > > > > > Bug: 696681 > > > Change-Id: If37e38114d4718b868413ea8ced9527c88510c15 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710557 > > > Commit-Queue: Harald Alvestrand <hta@chromium.org> > > > Reviewed-by: Florent Castelli <orphis@chromium.org> > > > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > > > Reviewed-by: Steve Anton <steveanton@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#679965} > > > Bug: 696681 > > Change-Id: Ic6264584cb4184f1c5acb1049fa5eb2312b41bdb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715508 > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Reviewed-by: Florent Castelli <orphis@chromium.org> > Reviewed-by: Steve Anton <steveanton@chromium.org> > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680916} TBR=hta@chromium.org,foolip@chromium.org,orphis@chromium.org,steveanton@chromium.org Change-Id: I5e5cb6425eeba84cef20313672042c8a0a7893c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 696681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719574Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#681051}
-
Vladimir Levin authored
This patch tries to normalize some of the rects we deal with when performing interest rect calculations. This is done by capping the ranges of numbers that we may encounter, in order to produce more stable results. The upside of this is that we will paint more content that we would otherwise erroneously assume to be not intersecting the viewport (even after padding). The downside of this is that we may paint more content that is properly far off screen. R=chrishtr@chromium.org Bug: 986110 Change-Id: I69254d2a855e8f083406b13638741b8bc2b85b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715917Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681050}
-
Matthew Wang authored
Chrome currently does not take into account the results of shill captive portal detection. We plan on communicating from shill the probe URL it used to get a redirect so that Chrome can use it instead of its own probe URL. Bug: 903645 Change-Id: Idacf434e84c1a065969fe0520587de34dbb1c8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659838Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#681049}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7780205b2067..c5817614666e git log 7780205b2067..c5817614666e --date=short --no-merges --format='%ad %ae %s' 2019-07-25 rmhasan@google.com [Typ] Modify parse_tagged_list to accept a function argument that returns true if two tags conflict Created with: gclient setdep -r src/third_party/catapult@c5817614666e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:973936,chromium:976505 Change-Id: Ib66ba1c515253728ac8d2bea9b6e25b979280be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718842Reviewed-by:
-
Hesen Zhang authored
Bug: 963304 Change-Id: If5633fcf01ffd4e74adba2d02db649d3ec1ec5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719266 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#681047}
-
Orin Jaworski authored
This CL expands the schema of chrome://omnibox batch exports to include information about version and running context. To do this without much duplication of code, VersionUI was refactored slightly. Bug: 964528 Change-Id: I7de7484d18497a8c5a9d6a165e0922991bf663bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713238Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#681046}
-
Paul Irish authored
Change-Id: I2aad060f74c2fe687b4e7ed062b59abef7a3e977 Bug: 987722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718778 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#681045}
-
Mohamed Amir Yosef authored
Sync USS Password on Linux has been unblocked by recent migrations in the PasswordManager team that are concluded in the parent CL. This CL is enabling the about flags for Linux and it enables it by default for all linux bots. Change-Id: Ic94267ab0e9e4cce2ac2b02f1dfa9a0a9046e902 Bug: 902349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718332 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Mustafa Emre Acer authored
This CL disallows U+3099 and U+309A characters from domain names. Any IDN containing these characters will be displayed as punycode. As of July 2019, these characters are not used in any popular domains. Bug: 868846 Change-Id: I7e36b30d7dcaf167fb3a6eb23b96f0aa4bd393ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717494Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#681043}
-
Mohamed Amir Yosef authored
Recent migrations moved all users who have been using the keying to the LoginDatabase. This CL forces all users to using LoginDatabase instead of native backends on Linux. TBR=pcc@chromium.org Change-Id: Ibac11e68d8f354ecf7f3c9828d95777ea5b3df60 Bug: 950269, 950267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713560Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#681042}
-
Brian Sheedy authored
This reverts commit fea37126. Reason for revert: Still breaking AR/VR tests on N+ Original change's description: > Reland "android: Reintroduce and rework ModernLinker." > > This reverts commit 5e961649. > > Reason for reland: Fixed loading ChromeModern on N+. > > Original change's description: > > Revert "android: Reintroduce and rework ModernLinker." > > > > This reverts commit ac8fe0e9. > > > > Reason for revert: crbug.com/986879 > > > > Original change's description: > > > android: Reintroduce and rework ModernLinker. > > > > > > This is partially a revert of two commits: > > > - 53a10113: "Delete unused file: > > > base/android/linker/android_dlext.h" > > > - fdb31883: "Use the LegacyLinker instead of the > > > ModernLinker" > > > > > > ModernLinker has been reworked, especially the native side. Notable changes: > > > - The library is only loaded once, not twice in the browser process > > > - Relocations are always shared between the browser process and the other ones. > > > > > > This is enabled only on N+ for Chrome.apk, neither for Monochrome nor for TriChrome. > > > > > > on Q, further commit will trim it as well. > > > > > > Binary-Size: Increase due to bringing back ModernLinker. Required to save memory > > > Bug: 979638 > > > Change-Id: Ia76773b58a71854a36ea49ab82daef1af717b606 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683245 > > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > > Reviewed-by: Egor Pasko <pasko@chromium.org> > > > Commit-Queue: Benoit L <lizeb@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#679535} > > > > TBR=pasko@chromium.org,yfriedman@chromium.org,agrieve@chromium.org,lizeb@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 979638 > > Change-Id: I431aa2011c4a0c4b23b725099e414a52443778f0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715745 > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > > Reviewed-by: Egor Pasko <pasko@chromium.org> > > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#680141} > > TBR=pasko@chromium.org,yfriedman@chromium.org,agrieve@chromium.org,lizeb@chromium.org,bsheedy@chromium.org > > Change-Id: Id43bd6f6dbae6d13f46eafd2342bc7b6cdc33e4d > Bug: 979638, 986879 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715276 > Reviewed-by: Benoit L <lizeb@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680872} TBR=pasko@chromium.org,yfriedman@chromium.org,agrieve@chromium.org,lizeb@chromium.org Change-Id: I2acf3fc3084d0519377e572c5f969fa3b2915063 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 979638, 986879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719125Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681041}
-
Sunny Sachanandani authored
Test that front buffer has expected contents after present. Bug: 939655 Change-Id: I5a3e89655e1ae20e04ab7463a6ad9d4040a57002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717653Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#681040}
-
Steve Kobes authored
Intent to Ship: http://bit.ly/2YmJAYN Bug: 581518 Change-Id: Ia8a0ded90e09470e019cf05e5aa2745863b2302c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719273Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#681039}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d242ed7a0e0a..3a98df0bdd49 git log d242ed7a0e0a..3a98df0bdd49 --date=short --no-merges --format='%ad %ae %s' 2019-07-25 ehmaldonado@chromium.org depot_tools: Move six to depot_tools' .vpython Created with: gclient setdep -r src/third_party/depot_tools@3a98df0bdd49 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I9280580e23c7c517d10f306b682d5d4721694b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718841Reviewed-by:
-
James Forshaw authored
This CL removes the dynamic import of APIs which are always available on all supported platforms. It also removes the old fallback path for pre-Vista platforms as well as a general code cleanup. Bug: 986625 Change-Id: I123942cdec976356bf5ba2c12e0f97cbbd65dde0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715536Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#681037}
-
