GitLab

When closing an incongito window, it is possible that the previously focused profile is already
destroyed. Since profile_->IsSameProfile(previous_focused_profile) is always true in this case, we
can just skip the check and dispatch the events against profile_.

BUG=139237
TEST=open an incognito window and close it and hope it doesn't crash.

Review URL: https://chromiumcodereview.appspot.com/10837170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126082
Review URL: https://chromiumcodereview.appspot.com/10834238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150655 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140306
Tested: Added new browser tests!

Review URL: https://chromiumcodereview.appspot.com/10830072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150654 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150652 0039d316-1c4b-4281-b951-d872f2087c98

This is particularly needed because one of the WebDriver users wants to test
with shiftshader, which is disabled because of the skip-gpu-data-loading flag.
This change makes logical sense too, since ideally ProxyLauncher should
be limited to understanding how to launch and connect to Chrome.
BUG=chromedriver:125
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150651 0039d316-1c4b-4281-b951-d872f2087c98

r1463: ninja: make cross-compilation use $CC/$CXX for the target compiler

Took over from http://codereview.chromium.org/9649016/

BUG=140900
TEST=set CC/CXX to cross-compiler, set GYP_CROSSCOMPILE to 1, run gyp, ninja chrome.

Review URL: https://chromiumcodereview.appspot.com/10836135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150650 0039d316-1c4b-4281-b951-d872f2087c98

23 is the atomic number of vanadium (next up Chromium...)
According to the birthday paradox, in a group of 23 (or more) randomly chosen people, the probability is more than 50% that some pair of them will have the same birthday.
23 is the width of the Arecibo message, sent to space in search for extraterrestrial intelligence.
Normal human reproductive cells have 23 chromosomes.
23 is the TCP/IP port used for telnet
Michael Jordan wore the number 23 when he played on the Chicago Bulls (and Washington Wizards)
The 1980s TV series Max Headroom was set at Network 23.
4, 8, 15, 16, 23*, and 42
The Number 23 is a 2007 film starring Jim Carrey.
The 23 enigma refers to the belief that most incidents and events are directly connected to the number 23.
http://www.youtube.com/watch?v=kiTScUKMZUw

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150649 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140040
TEST=Running chrome with --force-device-scale-factor=2 still loads 2x resources.


Review URL: https://chromiumcodereview.appspot.com/10837142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150648 0039d316-1c4b-4281-b951-d872f2087c98

* Lets -Wunused-private-field find more stuff
* Fixes an ASan problem on precise
* Improves the plugin's handling of inner classes (off by default,
can be enabled with |-Xclang -plugin-arg-find-bad-constructs
-Xclang check-inner-classes|)
* Makes addr2line much faster on linux
* Fix for crash we saw on the valgrind bots after the last roll attempt
* The plugin now ignores cc/ by default

BUG=139346,139912
TBR=hans

Review URL: https://chromiumcodereview.appspot.com/10831219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150647 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None.
TEST=Should compile and pass all tests.


Review URL: https://chromiumcodereview.appspot.com/10825252

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150646 0039d316-1c4b-4281-b951-d872f2087c98

This make GoogleContactStore postpone trying to update
contacts via GData when the system doesn't have a network
connection.

BUG=128805
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10829247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150643 0039d316-1c4b-4281-b951-d872f2087c98

Also adds 2 tests which weren't being counted:
http/tests/security/video-cross-origin-readback.html
http/tests/security/video-poster-cross-origin-crash.html

BUG=140583
TEST=Ran layout test analyzer.

Review URL: https://chromiumcodereview.appspot.com/10823238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150639 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130377
TEST=chrome/ppapi/tests/test_image_data.cc
Review URL: https://chromiumcodereview.appspot.com/10823211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150638 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TESTS=PipelineTest.InitFailure_XXX

Review URL: https://chromiumcodereview.appspot.com/10831214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150636 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mmenke@chromium.org
BUG=141497

Review URL: https://chromiumcodereview.appspot.com/10827236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150633 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140293
TBR=yoz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10836163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150632 0039d316-1c4b-4281-b951-d872f2087c98

This function will be used to replace two calls of FindEntryByPathSync()
placed in one function (ex. GDataFileSystem::CopyOnUIThread()).
With this function we expect to be able to eliminate 8 callers of
FindEntryByPathSync().

BUG=137694
TEST=added unit tests

Review URL: https://chromiumcodereview.appspot.com/10831212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150627 0039d316-1c4b-4281-b951-d872f2087c98

Fix the browser test DownloadExtensionTest_FileIcon_Active crash which started occurring after my change 150597
to send out Windows 8 metro notifications when downloads complete.

Reason for the crash:- We were not unsubscribing from the DownloadItem object when it was completed and instead
doing it when the download manager was going away. At that point the object was already deleted.

BUG=133109
TBR=asanka
Review URL: https://chromiumcodereview.appspot.com/10836161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150625 0039d316-1c4b-4281-b951-d872f2087c98

We define system call sets to create a partition of all existing system
calls on the x86_64 architecture.

This grand classification will allow us to write policies easily and make
sure that we have thought about what to do for every system call.

This particular change does not affect the current semantic at all, this
is achieved by using comments.

BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10834219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150624 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140293
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10837155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150622 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150618 0039d316-1c4b-4281-b951-d872f2087c98

Fixes safe_browsing_tests failure on win from 110.

BUG=96459

Review URL: https://chromiumcodereview.appspot.com/10855035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150617 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/10836149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150614 0039d316-1c4b-4281-b951-d872f2087c98

This script will convert static files from the old documentation
system to the new one.

To run from the server2/ directory try:
converter.py ../static/ ../../api templates/articles/ templates/intros/ templates/public/ static/images/ -r -s

This was moved from: http://codereview.chromium.org/10832042/

BUG=131095
Review URL: https://chromiumcodereview.appspot.com/10834130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150612 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141473

Review URL: https://chromiumcodereview.appspot.com/10830226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150611 0039d316-1c4b-4281-b951-d872f2087c98

skia expects to be initialized before it can be used. This must be done if serializing SkPicture, which we now do for benchmarking.
Review URL: https://chromiumcodereview.appspot.com/10823129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150609 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2813

Review URL: https://chromiumcodereview.appspot.com/10823220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150608 0039d316-1c4b-4281-b951-d872f2087c98

There were a few bugs, and some confusing UI. I made the following changes:
* Moved the ShouldShowIconInTray() logic into NetworkMenuIcon.
* Removed the unused function GetVpnImage()
* Made VPN icon code similar to other network types
* Changed network display order to:
** Active network
** Connected networks (VPN, Ethernet, Cellular, Wimax, Wifi)
** Unconnected networks (same order)

BUG=137941

Review URL: https://chromiumcodereview.appspot.com/10824208

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150607 0039d316-1c4b-4281-b951-d872f2087c98

Base web accessibility decisions on page transition. We only need to perform the check if the transition is web triggerable.

BUG=137435
TEST=ExtensionResourceRequestPolicyTest.WebAccessibleResources
Review URL: https://chromiumcodereview.appspot.com/10827107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150606 0039d316-1c4b-4281-b951-d872f2087c98

This will go after 'Noto Sans UI' is checked into ChromeOS.

See https://gerrit.chromium.org/gerrit/#/c/29087/1 for the
corresponding CrOS change.

Bug=131515
Test=The UI (both 'native' and web ui) uses Noto Sans UI. For English UI, it's exactly the same as Chrome Droid Sans. If you try Vietnamese UI, there will be no more ransom note effect because Noto Sans UI covers all the Latin letters used in Vietnamese while Chrome Droid Sans does not and leads to a ransom note effect (some characters from Chrome Droid Sans while others coming from other fonts).
Review URL: https://chromiumcodereview.appspot.com/10836082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150605 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10837169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150604 0039d316-1c4b-4281-b951-d872f2087c98

Don't print the callstack in forked browser test processes. This may allocate memory or try to acquire OS locks which may already be locked from the parent process. This was happening because there's a race condition where the browser process forks a process and shuts it down very soon after, before it calls exec*.

BUG=141302,139209,36678
Review URL: https://chromiumcodereview.appspot.com/10836148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150603 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134159


Review URL: https://chromiumcodereview.appspot.com/10830217

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150602 0039d316-1c4b-4281-b951-d872f2087c98

Localized_error contains code to generate error strings, and it isn't render-thread specific. Chrome for iOS uses this class for error messages, but because we don't use the render thread at all, we've had to go into contortions of DEPS and gyp files to include it. This CL pulls localized_error out of renderer into common, which will bring great sanity to the iOS build.


BUG=


Review URL: https://chromiumcodereview.appspot.com/10830218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150601 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10855041

TBR=scherkus@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832209

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150599 0039d316-1c4b-4281-b951-d872f2087c98

Reviewed at: https://chromiumcodereview.appspot.com/10799014

Reverted for failure of mac_valgrind. Failure due (almost certainly) to
a bug in Apple's code. Added suppression and filed bug (http://crbug.com/141293).

BUG=123865


Review URL: https://chromiumcodereview.appspot.com/10830207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150598 0039d316-1c4b-4281-b951-d872f2087c98

Fire a notification in Windows 8 metro chrome which informs the user about a completed download. This is achieved
by a new class DownloadCompletionObserver which lives in the newly added file download_completion_observer_win.cc/.h
in chrome/browser/download. This class observes the DownloadManager and the DownloadItem to get information about
download items getting created and completing.

BUG=133109
R=cpu,asanka
Review URL: https://chromiumcodereview.appspot.com/10832174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150597 0039d316-1c4b-4281-b951-d872f2087c98

instead of GDataFileSystem::GetEntryInfoByPath(). The two are similar
but the latter initiates feed loading/fetching. Inside GDataFileSystem,
we don't need to use the latter.

BUG=150567
TEST= out/Release/unit_tests --gtest_filter='GData*'

Review URL: https://chromiumcodereview.appspot.com/10836154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150596 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141410
TEST=Ran on chrome-qa bot to witness failing steps identified in the bug.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10826206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150595 0039d316-1c4b-4281-b951-d872f2087c98