- 28 Dec, 2019 5 commits
-
-
Bailey Berro authored
- This CL delays the rendering of the arrangement section until |displays| is truthy to avoid the arrangement section flashing. Bug: 1022315 Change-Id: I36da215142ed8bafb739dbbdedaf9bfa4f2baf24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979115Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#727657}
-
Brandon Wylie authored
TBR= mlamouri@chromium.org Bug: 1038151 Change-Id: I46a30236c75694c7682cbadedce36c649ad064fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983448Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#727656}
-
Xiaocheng Hu authored
[Sheriff] Disable GooglePasswordManagerNavigationThrottleTestWithPasswordManager.PasswordsWithGPMAndSyncUserClickedLink Bug: 1029034 Change-Id: I4a3729f7435b1002b36d53140b5b3f5d31fec6b0 Tbr: vasilii@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982934Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727655}
-
Andrew Xu authored
Enable the hotseat feature as default. Besides that, this CL does the following things: In annotation_feature_enabled_test.js and zcr_remote_shell_unittests .cc, the current tests assume that the shelf icon's size is 56x56 which is not always true under hotseat. So those tests are fixed by hard code. TBR=tbarzic@chromium.org,oshima@chromium.org tbarzic: chromeos_features.cc oshima: zcr_remote_shell_unittest.cc Bug: 1032702 Change-Id: I3b51893d4724e6f085fea8ca7c0b9b415e6cea4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974861Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727654}
-
Avery Musbach authored
Bug: None Change-Id: Iedec344fda56e80c083b31d968729cfc51b32d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983357Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#727653}
-
- 27 Dec, 2019 35 commits
-
-
Avery Musbach authored
Bug: None Change-Id: If9551bcc5b7d23affb1799adf821efa100df40ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983190Reviewed-by:
-
Avery Musbach authored
OverviewWindowDragController::DragResult values are only ever checked against kSuccessfulDragToSnap. Distinctions among the other values are for readability only. See the code review comment at [1]. So the present CL cleans it up with semantic meaning in mind, and not much concern about functionality. OverviewWindowDragController::CompleteNormalDrag is significantly simplified near the end. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1570218/3/ash/wm/overview/overview_window_drag_controller.h Bug: None Change-Id: I0ae77c4b7d8d4dfa5f01dfbcbd6990c8bd27a60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983349 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a6a291685941..588c373aced1 Created with: gclient setdep -r src-internal@588c373aced1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1036426 Tbr: jbudorick@google.com Change-Id: I4708c5b71bcef8b32b9fe1b5c1b8f676999920b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982929Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727650}
-
Tricia Crichton authored
When Timeout occurs running a command, return status 500 to client instead of 408. This cl restores compliance to the WebDriver spec. Bug: chromedriver:3291 Change-Id: Id48d08cace4dc6faf36270e130b859b179faa326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983340Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#727649}
-
Xiaocheng Hu authored
Test is flaky: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36522 Bug: 997786 Change-Id: I97f2e400e829b13859033767a257402325646cf3 NoTry: True Tbr: treib@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983441Reviewed-by:
-
John Abd-El-Malek authored
This allows production code to get to ProfileImpl from a BrowserContext, and tests to interact with it directly in future cls. Change-Id: I5f3c9899a661a3b05c67e1287467b3dbabf7f75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983255Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#727647}
-
Tarun Bansal authored
These are no longer needed. Bug: 1037176,1037172 Change-Id: I894a8ae7a0e8a467ac1786f934daef58bc1dcc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983348 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#727646}
-
Christopher Cameron authored
The logic to add FocusManager observers was smeared across NativeWidgetMac and NativeWidgetMacNSWindowHost. Change this so that all of the logic is in NativeWidgetMac::SetFocusManager. In the process, cut-and-paste a handful of functionality over to NativeWidgetMac. This is part of the larger trend of merging NativeWidgetMac and NativeWidgetMacNSWindowHost (preserving the latter perhaps, only as mojo-implementing friend). The motivation for this is that, when reparenting a non-top-level NativeWidgetMac, we do not move the FocusManager observers, which causes ConstrainedWindowViewTest.TabMoveTest to crash. This patch should have no functional change. The next patch in the sequence will update the observers as needed. Bug: 957362 Change-Id: Id5a1d6183e446df647fa877239cb9dfb549e18a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983343Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#727645}
-
Caleb Rouleau authored
Handles post submission cl comment from https://chromium-review.googlesource.com/c/chromium/src/+/1982681/5 Bug: 921353 Change-Id: If536f622a2a1d8824e1d942fccf4abc02d808a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983346 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Flakes observed at https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/43474 Bug: 1038139 Change-Id: I7c5ac70294f3a438d31c069c61689cc7ad185b7d Tbr: xiaochengh@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982932Reviewed-by:
-
Xiaocheng Hu authored
Flaky timeouts observed: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/85649 https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/457958 https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/457440 Bug: 1030551 Change-Id: I9bb0b3ba503965256a7f4225c0468eb470e78246 NoTry: True Tbr: tommycli@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982931Reviewed-by:
-
haozhe authored
Both Chrome and Firefox pass all tests Bug: 1034538 Change-Id: I9f92d6b91fafacfc12e81a7bc5941a6e8e0e4868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974755 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#727641}
-
Nicolás Peña Moreno authored
Currently, the test contains two async_tests, which is not good because they run in parallel so the tests can affect each other. The first test is redundant with buffer-layout-shift.html. The second test uses a helper function from EventTiming, so we import the script instead of copy-paste and we rename the test. Change-Id: Ibe6d200441a07c603bccf0858406cf2c4f1d37a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982710Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#727640}
-
Nicolás Peña Moreno authored
In this CL, some 'await waitForAnimationFrames(2)' are added to wait for the initial render of the test page before introducing the observer. This removes flakiness of these tests in WPT.fyi. Other cleanups are done in the test files. Bug: 1036013 Change-Id: Ic2631faf03ad00c8e32013c100c3b4ab867be2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982708Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81158535ed1b..5e976be7f0ca git log 81158535ed1b..5e976be7f0ca --date=short --first-parent --format='%ad %ae %s' 2019-12-27 brianosman@google.com Workaround MSVC 2019 code-gen bug in lighting image filter Created with: gclient setdep -r src/third_party/skia@5e976be7f0ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I4f4f6259a4f8171f7cef83998640755f5d56de43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982922Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727638}
-
Pavel Yatsuk authored
This CL moves SnackbarView.java, Snackbar.java, SnackbarCollection.java, SnackbarManager.java. Tests will be moved in a separate CL. BUG=1028382 R=mdjones@chromium.org Change-Id: I847ce100b03fb3b4596ed02c2c32d2f8505ba4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974902 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#727637}
-
Brandon Wylie authored
TBR=cduvall@chromium.org Bug: 1035894 Change-Id: Ie212a40b4aa33390734e3871e68ab03d84cd1db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983347Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aca963f8ae30..a6a291685941 Created with: gclient setdep -r src-internal@a6a291685941 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I19a4ea780c96ec5d04689f5819692b26c4c30023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982921Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3945.86-1577097374-benchmark-81.0.4005.0-r1 to 81-3945.86-1577097374-benchmark-81.0.4008.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2685c0afde88d8a2a7da564a8e60b7a2792d1372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982927Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-3987.0-1577100150-benchmark-81.0.4005.0-r1 to 81-3987.0-1577100150-benchmark-81.0.4008.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibdecb9a788de4aca4975fba7240c1fa1f398c778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982926Reviewed-by:
-
Matt Reynolds authored
A prior CL switched HidService::ConnectCallback from RepeatingCallback to OnceCallback, but did not correctly adapt the callbacks passed to PermissionBrokerClient::OpenPath on Chrome OS. OpenPath takes separate success and error callbacks, but both paths should ultimately call the same ConnectCallback. This CL uses base::AdaptCallbackForRepeating to convert the ConnectCallback to a copyable callback that can be bound to both the success and error callbacks. BUG=1036761 Change-Id: I5b39fd0df496e7a614d6a5be688d78653eb9f46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982860 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#727632}
-
Xiaocheng Hu authored
Tests disabled due to flaky failures at https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36521 Bug: 990362 Change-Id: I8a75c46e1868152216fe3cd34a579805fca871f1 NoTry: True Tbr: antrim@chromium.org, rsorokin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982923Reviewed-by:
-
Caleb Rouleau authored
1. Enable run_performance_tests.py to handle shard maps that contain gtests. 2. Convert functional test results output of gtest to a simple json3 format. This allows us to merge json test results from gtests and from telemetry tests when they are both in a single shard. Bug: 921353, 920002 Change-Id: I4b02025b882602a057f582e9a96f91f1e411c882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982681Reviewed-by:
-
Khushal Sagar authored
TBR=ericrk@chromium.org Bug: 1037654 Change-Id: I266e1f38f4e84fffd2f7ced469897cae868225e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982226Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#727629}
-
Tarun Bansal authored
Remove logic for FINAL_STATUS_DEVTOOLS_ATTACHED in prerender since it does not trigger for NoStatePrefetch (it was needed for prerender). Bug: 1038058 Change-Id: I06b4367622ef14814a7d1a01fefab244de8ee452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977830Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#727628}
-
Khushal Sagar authored
We assume the ServiceTransferCache must be set if we have a GrContext. This might not be the case if the GrContext is set for non-GL backends. R=zmo@chromium.org Bug: 1037988 Change-Id: I679fb9fe044d4f40af46a12a3e040f79d0d624aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982778 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#727627}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a7ca7a2a393..81158535ed1b git log 0a7ca7a2a393..81158535ed1b --date=short --first-parent --format='%ad %ae %s' 2019-12-27 rmistry@google.com Prevent de-duplication of Housekeeper-PerCommit-BuildTaskDrivers Created with: gclient setdep -r src/third_party/skia@81158535ed1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: Ia6f147b63b369d9009204c85d6b0b4ae9f423624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983324Reviewed-by:
-
Andrew Grieve authored
TBR=agrieve # Trivial build script change. Bug: 1036426 Change-Id: I0c10f5024ccbfaafdeae1950e18c72e7651bdd03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982774 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#727625}
-
Kurt Horimoto authored
Bug: none Change-Id: I7593ce8730acca27d3fb9f2e3bd46fdaf926f7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982772Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#727624}
-
Matthew Mourgos authored
This reverts commit a1297fc3. Reason for revert: Broke test with hotseat feature enabled. Original change's description: > CrOS Shelf: Set right margin on status area based on tablet mode > > With this change, the padding between the edge of the screen and the > status area widget no longer has anything to do with the hotseat > state. This edge padding will now only ever have two possible values, > one value in tablet mode and another value in clamshell mode. > > Bug: 1035716 > Change-Id: I70f8ffe99ddf8e44482a3c9772f72dcf7adb9885 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977025 > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727486} TBR=tetsui@chromium.org,manucornet@chromium.org,mmourgos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1035716 Change-Id: If730127fc7471d9a063fb45530c81b99b2abd035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983328Reviewed-by:
-
Will Cassella authored
Previously there were several WebXr feature flags for experimental features (WebXrARDOMOverlay, WebXRAnchors, WebXRPlaneDetection), now they've been placed under a single feature flag (WebXRIncubations). As features mature, they should be moved out from under this flag. New experimental features should be added to this flag. Change-Id: Idb0d26c2745447f1f181dea00399b8bf2a2160d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977190 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#727622}
-
Devlin Cronin authored
Remove TestExtensionDir::WriteManifestWithSingleQuotes(). This was a convenience function introduced before we had support for string literals in the language. Now that we have string literals, those are preferred: - They are more consistent - They preserve newlines - They don't clutter each line with double-quotes - It is mildly faster, since we don't have to do string replacement. Remove the old WriteManifestWithSingleQuotes() function, and update all call sites. This CL should have no behavior change. Bug: None Change-Id: I2e65c514530316d2d25fd75cb33ca2ffcb1a244e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975073 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#727621}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/eb1fb6a0..4c53f9a5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I331a408d4bb6ffb6889c1e2dc6dafa9c4f5e38ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983131Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727620}
-
Devlin Cronin authored
Extensions with withheld permissions that are invoked on a page that also need to run before the page finishes loading require a page reload to execute. This is shown to the user via a bubble prompt when the extension is invoked. Add a UI test exercising this flow with the extensions menu (one already existing for triggering and executing the bubble, but not a UI test for displaying the UI). This also serves as a replacement to ExtensionBlockedActionsBubbleTest. InvokeUi_ExtensionBlockedActionsBubble, which is more dependent on the old UI implementation. That test is now only run if the extensions menu is disabled. Also renames ExtensionsMenuViewBrowserTest.ActivationWithReloadNeeded_Accept to ExtensionsMenuViewBrowserTest.TriggeringExtensionClosesMenu, which more accurately describes its behavior and expectations. Bug: 984654 Change-Id: I68c72a1c8ce7cb0d1a70cb023ccd5c5d39083d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982240 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727619}
-
Andrew Grieve authored
Turns out google storage sets a one hour public cache header by default, which means a bad push results in the page being broken for an hour. This leaves the default header on for .size files, but sets all other files (which are tiny) to no-cache. Note: the .wasm file is big, and should probably be cached, but that is handled by the service worker already. Bug: None Change-Id: Ia3c03e4533c37338b924d5ace3f7b5fd4ac8d6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981263 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
