- 28 Sep, 2020 10 commits
-
-
Johann authored
Tests added in b85903de do not pass yet: out/Default/content_shell --run-web-tests webcodecs/basic_video_encoding.html BUG=chromium:1127073 Change-Id: Ib0dd41b9e05b7abefd9a6bdebcff1f45eba3e016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434585Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#811089}
-
Johann authored
./out/msan/sandbox_linux_unittests --gtest_filter=*BrokerRemote* TBR=mpdenton@chromium.org BUG=chromium:1117351 Change-Id: I4c833eb633ce8f93aa7846fa12cefd0f417202f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434586Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#811088}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d61e7903. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I77b45af616b29570730f21af0436cef8ccb6fe27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434624Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811087}
-
Luke Zielinski authored
This will create a -diff.txt and -pretty-diff.html file for any test that has an actual output. Absence of expected output is fine, the diff will show the actual output as all new. Bug: 1127360 Change-Id: I7f73741ff6d24571a20160239ee17ae69c6804e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428826 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#811086}
-
Noel Gordon authored
piex-wasm assumes chrome.runtime.reload can be used to reload the page on Module failures. Other environments (normal web pages, web workers, NodeJS, etc) obviously can't use chrome.runtime.reload. Remove the chrome.runtime.reload assumption: change the client code to provide the failure handler to piex-wasm. Change image_request_task.js RAW image client code: pass in the chrome.runtime.reload handler. While here, add or adjust comments to image_request_task.js and change the direct loading case to arrow function. No change in behavior. Bug: 1132695 No-try: true Change-Id: I6a2b641cdc036dd208f4d64deb4f0b7fdff0835f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432705 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#811085}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I7aeaf8c2f62f36576f418239531ae9c938f305cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433589Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#811084}
-
Weilun Shi authored
Split the rest of the histograms.xml into multiple smaller xmls. This makes all histograms are searchable from code search and reduces the load time to render a histograms.xml file. This cl hasn't deleted the old histograms.xml yet because there are other code referencing to it. Bug: 993193 Change-Id: If813a3aaaf1b60cc4db4860fef31d562a13ef23e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428796 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#811083}
-
Tal Pressman authored
Although the AgentSchedulingGroupHosts's RenderProcessHost remains constant, the underlying process behind it might die and be restarted. When that happens, we need to create a new AgentSchedulingGroup in the new renderer process, and re-bind the mojo endpoints. This is done by resetting the mojo endpoints when the process exits, and having the various public methods rebind them when necessary. Bug: 1111231 Change-Id: I48169dad231b5912078ff59f7bf6a370017d2031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397057 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#811082}
-
David Bienvenu authored
Bug: 1010217 Change-Id: I8b8759103f6f34e65d1f28ee6dde52d9a69c87f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434364Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811081}
-
Darwin Huang authored
The constructor's argument order was flipped. Please see the "fill(6)" constructor for more info: http://www.cplusplus.com/reference/string/string/string/ Previously, this would cast ' ' to a size_t, and length to a char. Change-Id: I6eca18bfa48fa3f303ea2881f3ebfd342e72742c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432747 Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
- 27 Sep, 2020 30 commits
-
-
Yue Li authored
Add the browser client to get Access token. Bug: b/150034512 Test: Manual Test Change-Id: Ic3f87ee4299779797005d56daa411b122750bea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429528 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#811079}
-
Thomas Lukaszewicz authored
Bug: 1099917 Change-Id: Ie74de530af3fdb7aa87ed14ac14aba47c7fd5b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432677 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#811078}
-
Christopher Cameron authored
Add a method to media::VideoDecodeAccelerator to indicate whether SharedImage-backed picture buffers are supported. Make this return true only for the VTVideoDecodeAccelerator. Add a parameter to media::PictureBufferManager::CreatePictureBuffers to indicate if SharedImage-backed PictureBuffers are desired. Hook the two of these together in the ProvidePictureBuffersAsync method of media::VdaVideoDecoder. Video playback fails with the Metal-based command decoder, because it binds IOSurfaces as TEXTURE_2D, not TEXTURE_RECTANGLE. Plumb through a flag to specify if TEXTURE_RECTANGLE support is present. Bug: 1108909 Change-Id: I1e42aa38e122714517724cee87eb51987645e410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427545 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#811077}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4812e31f727c..90a7c922079a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I6ad8c09731f6e939152c4a97ff4caac31bb9e6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433996Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811076}
-
Bret Sepulveda authored
When the Permission Chip is enabled, you get a broken-looking UI when there's no short string written. This patch works around this by falling back to the old UI. Bug: 1019129 Change-Id: If214734f780a0423c4ef9bdb0198c433cffc3cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431429 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811075}
-
Maciek Slusarczyk authored
ChromeOS.SAML.InSessionPasswordChangeEvent tracks usage of in-session SAML password change feature. Extending its validity by 6 months to collect additional data. Bug: 1130656 Change-Id: I2bae3dbe7cf9a08d599586d568529277aab6c89b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431886Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Cr-Commit-Position: refs/heads/master@{#811074}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bdcc75794121..4812e31f727c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I85cfff21da84e6fcdd03919e8744f84e694ddf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434504Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id5ba6dd7e98c3f1242044cb1142d4ff3c6f7fb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811072}
-
Jinsuk Kim authored
Class CustomToolbar inherits ToolbarLayout for the layout for Custom Tab Toolbar. It also provides an implementation of LocationBar interface used in omnibox. The concrete implementation classes for Custom Tab don't necessarily have to be a part of toolbar/. This CL moves the class to customtab/features/toolbar where other implementation of Custom Tab features are placed. This also helps reduce the outbound dependencies the class brought in to toolbar/. Bug: 1127732 Change-Id: I32a0d556a979d213293dd46aea5ff51afa966dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426155 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#811071}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601207727-a01abff7a6bd2da6f6116384bec1a348a3a7afe9.profdata to chrome-mac-master-1601229184-d47c881ab947e7e0fd2f4d9c9f5a7e73566e67be.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: Ibcf7d54c0a466dba3f90cbf1c939e2405ed45b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433990Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601207727-0dd0eb0febc74c41e7a623fe044ff01ea199dede.profdata to chrome-linux-master-1601229184-a90fd4bcb76e7d51e9443afa58b53f4dbea26e4c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ic59f4ae4a064384b6dbe274a5e09b74ea250d62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433989Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I04b1c027d9e650d790e303dd6433187daf22c0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434086Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811068}
-
Maciek Slusarczyk authored
In order to authorize verifyToken operation PasswordSyncTokenFetcher gets login scope OAuth token. This CL changes this authorization method to an API key. As a result we will save on network traffic (no need to fetch access token) and enable token verification in the login screen context. OAuth token stays the only valid option for createToken and getToken. Bug: 1090341 Change-Id: If802a156abd73cd8344b1be8d7f3ef3cbc7bfca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421588Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Cr-Commit-Position: refs/heads/master@{#811067}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fab653f821de..bdcc75794121 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1127088 Tbr: Change-Id: I810d2ae392a50c8310775e6bfe9b9a494b0003be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434384Reviewed-by:
-
Maks Orlovich authored
Verifying vs. RenderFrameHostImpl's UKM ID doesn't work due to the frame ID's potentially changing interpretation when the fetch races against a navigation. (I am really looking forward towards RenderDocumentHost...) Bug: 1131134 Change-Id: I66e1e0ed160994dbe3473f5a21495d38566b9cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429235Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#811065}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c913d715. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I77c6315bd04295cfe6cba8eeb68bf017e5ae1e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434244Reviewed-by:
-
tby authored
Bug: 1034842 Change-Id: I95859612d1603a1fe87641d636c29a7de8dbc658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426668Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#811063}
-
Gang Wu authored
If screen space is limited, app menu should show one and an half of the menu item at least. Bug: 1132258 Change-Id: I4721c4fb5d4eacf415c56e1aa112d8f7647a5227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432764 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#811062}
-
Michael Checo authored
Screenshots: - Diagnostics Page (before) http://shortn/_h8KubnXkcH - Diagnostics Page (after) http://shortn/_NHJD1CxaNh Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ic6fe3463c089d1f0b5150f1be128621cbb28623a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432125 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#811061}
-
Michael Checo authored
Screenshots: - Diagnostics Page (before) http://shortn/_h8KubnXkcH - Diagnostics Page (after) http://shortn/_uW8J9zp2i5 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ic649e7c4a84f9bdb27f3050aee4e0b821c49c76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429823 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
-
David Bienvenu authored
Also fix cpp lint warnings. No functional changes. Bug: 1010217 Change-Id: I60c13a4f4667522c7661b3ab91b948e71a06e657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432204 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#811059}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009270800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/0WU_n4W64ltaAxz5MUUNLa1sbT9wx_IZiR2vRW6vn2sC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ia8d11c7e3c6eef3d59258d79ef3af1a32aedadf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433986Reviewed-by:
-
tby authored
The LSP can DCHECK when calculating query/title score matches, because the query or title text can be empty. This is partly because the LSP runs even on zero-state searches, and (perhaps) partly because files can have no title. This CL adds various checks to prevent calculating scores when we don't have both a query and title. It also stops the LSP from running at all on zero-state searches. Bug: 1131358 Change-Id: I65c264def66e83f1c7fd47956eb0a9ddf59e099e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426088Reviewed-by:
-
Antonio Gomes authored
This is (a drive by CL) part of effort to reduce the dependency of /caption_buttons/ on other parts of //ash/public/cpp/. It also removes some trailing tablet_mode.h includes from //chrome as well. BUG=1113900 R=sky@chromium.org TBR=alemate@chromium.org Change-Id: Ied7a7395ce7ad103fd3ba42282dd55ca1913cc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431727 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
-
Nick Diego Yamane authored
TL;DR: Wayland Protocol needs to be extended to make it possible to properly support full Chromium's tab dragging experience. Further details in the Design document [1]. This is the first of a patch series which implements extended-drag extension in Exo compositor, adding the protocol descriptor XML file, boilerplate code as well as a stub implementation of it. Follow-up CLs will incrementally implement the extension features and start using it in Chromium Ozone/Wayland (client-side). ----------------------------------------------------------------------- An overview of how this protocol is aimed to be used in a tabdrag-like scenario, but in generic terms, is outlined below: 1. An UI item (eg: a tab in a tab bar) starts to be dragged within shell surface A owned by source client S. At some point, it gets far enough from its original location and S then starts a Wayland "extended drag" session, which protocol-wise requires to: 1.1. Create a wl_data_source, set one (or more) mime type and the supported dnd actions; 1.2. Create a zcr_extended_drag_source for the newly created drag source. Here it is possible to set a few options, such as: - ALLOW_SWALLOW: determines that the dragged item can be attached (or incorporated, also referred to as "swallow" in this protocol) to another surface, including use cases such as Chrome's tab drag. - ALLOW_DROP_NO_TARGET: In the standard DND protocol, dropping something outside shell surfaces lead to a wl_data_source::cancel, which is problematic in use cases such as tab drag, preventing us from detecting when it was really cancelled, e.g: ESC pressed. - LOCK_CURSOR: Keep the cursor shape unchanged during the whole session. Ultimately, having an extended drag source attached to the wl_data_source used to wl_data_device::start_drag instructs the compositor to run the drag session in the "extended mode". 1.3 Start the drag session as usual (i.e: wl_data_source::start_drag), with a null drag icon surface. Assuming that we're still in attached mode for now. In addition, from now on, client S must start watching for wl_data_device::{enter,leave,motion} events in order to be able to detect the next actions and state transitions as the user drags the UI item around. 1.4 Store the (x_offset, y_offset) location where the drag started in S and keep them synced to the values received in wl_data_device::motion() events. 2. Once the drag gets far enough from the original UI item's container (ie: tab bar), it's time to detach (or unswallow) it from surface A. To achieve it, client S must: 2.1. Create a new wl_surface B + its corresponding shell surface, e.g: a toplevel xdg surface where a new detached browser window will rendered to in Chrome's tab drag use case; 2.2. Issue a zcr_extended_drag_source::drag(B, x_offset, y_offset) request, which tells the compositor (in advance) that B must be set as the extended-drag surface, using x and y offsets to translate it from the current pointer location; 2.3. Map surface B (configure, attach buffer, etc) as usual. After this B's shell surface should show up tied to the mouse pointer and the compositor is supposed to take care of it, putting it in a special state where, for example, it does not receive events, etc, acting just like a standard DND "drag icon". At this point, the "unswallow" operation is done and the extended-drag session enters in detached state. 3. Supposing the drop happens while in detached state, there are 2 possible flows, which depend on whether ALLOW_DROP_NO_TARGET config is set or not (see 1.2). If it is set, wl_data_source::dnd_finished event is sent to the source client S, otherwise wl_data_source::cancelled is sent. 4. Otherwise, if before dropping, the pointer enters surface C, owned by client T. T receives a wl_data_offer O through wl_data_device::offer event as usual, to which it can attach a zcr_extended_drag_offer XO to it by issuing zcr_extended_drag::get_extended_drag_offer(O). Target client T, then starts monitoring wl_data_device::motion events, so that it can trigger a swallow based on where the pointer is. If B is dragged over a region that leads to a swallow, T must: 4.1 Issue a zcr_extended_drag_offer::swallow(serial, mime) request, asking source client S to incorporate the dragged item into its UI. S then receives a zcr_extended_drag_source::swallow(mime) event and it can accept it by calling zcr_extended_drag_source::drag(null, 0, 0), so client T can finally render it as part of its UI. At this point, the session is back to a state similar to 1.4. So, similarly to 2, once the drag gets far enough, T might want to unswallow (aka: detach) the UI item. In order to do so it must: 4.1.1 Call unswallow(serial, mime, x_offset, y_offset) on the extended-drag offer XO (created at step 4), whereas the offsets tell how the dragged surface must be positioned related to the pointer location. Client S will then receive a zcr_extended_drag_source::unswallow(mime, x_offset, y_offset) event so that it can create and map a new surface D and issue a zcr_extended_drag_source::drag(D, x_offset, y_offset), same as in step 2.3, making surface D to show up under the pointer. At target side, T can then re-render its UI without the dragged item. This finishes the unswallow (or detaching) operation, transitioning the session back to "detached" state. [1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing Bug: 1099418 Change-Id: I8d876e96e45717c625c1d1bdcc269b100524cbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307653 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#811055}
-
Yuta Hijikata authored
In order to build lacros-chrome with target_os="chromeos", we will be replacing existing defined(OS_CHROMEOS) with BUILDFLAG(IS_ASH) where appropriate i.e. the parts only needed for ash-chrome. For more detail please read the design doc go/lacros-build-config. Test: None Bug: 1052397 Change-Id: Iee48f0a3cc37efbee1b7959c9340d1255e735a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426071Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#811054}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 69467c7c. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I367c3750ac47dbbd1a7c4b0d889a6cea557ba974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433474Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601185204-f94c687281888552298caf7544ad9515cd75dc6d.profdata to chrome-mac-master-1601207727-a01abff7a6bd2da6f6116384bec1a348a3a7afe9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: Icdf5d06d39e72feecdaf424c4a3080f0f2623b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433904Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601185204-ea08500963e5ec1d97fc799611c84c5499e59042.profdata to chrome-linux-master-1601207727-0dd0eb0febc74c41e7a623fe044ff01ea199dede.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I360a4e2bed07474701c46c26b4779d36a159e44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433888Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aaed4d13394f..d6aeaf33afbe 2020-09-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4b973b8986bf6bb1f9b70d7d11a444c6b2b5475c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433887Reviewed-by:
-
