- 13 Nov, 2020 40 commits
-
-
Michael Lippautz authored
Reuse the WTF macro in platform/heap/ to avoid maintaining two macros. Bug: chromium:1056170 Change-Id: I3c3867c798ff76eeed72050674c6709a39d5f018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533776 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#827195}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 96dd7ef2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: If27c52942450284367f443483054640d9bf246a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536492Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827194}
-
Rakina Zata Amni authored
To use memory more efficiently, we're using a deque of chunks so that sent can be removed immediately after we're finished sending it. Also, protects the buffering behind a flag (later on we'll do it only when we're deferring due to bfcache, when it's possible to know that). Bug: 1148064 Change-Id: I13902906675a337bf8e02653f0a7f23e4f579ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531803 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Auto-Submit: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827193}
-
Xing Liu authored
Currently bookmark root node has 4 children instead of 5. The DCHECK is never ran. The java code calling into this is probably dead code, added a comment. Bug: 1148498 Change-Id: I20630b20ba8454665a8d1721f62e2baa312263b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535923Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827192}
-
Alan Ding authored
Update union tag bindings to support C++ code style recommendation. Keep previous style until there is enough support for camel case to deprecate *_VALUE enums. This CL was done as part of Chrome U 2020 codelabs exercise. BUG=chromium:1093757 TEST=builds, deployed, and git cl try. Change-Id: Ifbab11199dd64354be8fb84d2f8ee173c572ef5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533323Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alan Ding <alanding@chromium.org> Cr-Commit-Position: refs/heads/master@{#827191}
-
Fergal Daly authored
This reverts commit 1b3c1be9. Reason for revert: This is causing timeouts for lots of PDF tests on many dbg builders (see bug). I don't understand why but I have reproduced it locally and bisected and confirmed that this CL is culprit. Original change's description: > Add field trial config for HighPriorityBeforeUnload. > > Change-Id: Ia274d2e51503514c3fc98420fa4eee5eb040e1fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490782 > Commit-Queue: Katie Dillon <kdillon@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826894} TBR=sky@chromium.org,kdillon@chromium.org Change-Id: Id2c0f05304e515034efa769ded1bd38c61b1a53f BUG: 1148674 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537275Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#827190}
-
Frank Tang authored
1. Memory READ by ASAN in ListFormatter when there are >= 9 items in the list. 2. Intl.Locale ASAN problem when there are 9 or more Unicode extensions. 3. Windows default Timezone Detection bug https://chromium.googlesource.com/chromium/deps/icu.git/+log/c2a4cae..7db579a7 7db579a Fix windows TZ detection code for New York by Frank Tang · 10 minutes ago master efc5885 Fix Locale::setKeywordValue bug found by fuzzer by Frank Tang · 8 hours ago 3d57452 Fix memory READ by ASAN in ListFormatter by Frank Tang · 31 hours ago c7eaeed Fix memory READ by ASAN in ListFormatter by Frank Tang · 2 days ago TBR=jshin@chromium.org Bugs: 1147305, 1146468, 1146068 Change-Id: Iad839ac77d487d5e1b396bcdbc29bc7cd58a7ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536432Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827189}
-
Mason Freed authored
The [1] CL again changed the opt-in interface for declarative Shadow DOM, and I forgot to update the perf test. This CL makes that update. I wish there were perf bots in the CQ. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2530222 Bug: 1042130 Fixed: 1148583 Change-Id: Icee204fd4fecc2926dbe50ab7c08b36643d11c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536451Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#827188}
-
Christopher Cameron authored
This adds a side-channel through which a gfx::HDRMetadata can be attached to an IOSurface. In practice this can be written by the software decoder in the renderer process and read by the compositor in the GPU process. Bug: 1101041 Change-Id: I36a8f0cc8562fe1daa2e3e4c131aa7f305644aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531655 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#827187}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8d69298d9b29..b6f4d53126d3 2020-11-13 brandon1.jones@intel.com Only Increment Serials When Necessary On D3D12 2020-11-13 enga@chromium.org dawn_wire: Protect against large allocations in ChunkedCommandHandler If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1145204 Tbr: sarahmashay@google.com Change-Id: I46a43ad37e3828214e3585d775c582b820687f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536832Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827186}
-
Noel Gordon authored
Testing noted the bug was already fixed. Changed tack here therefore, to use the correct closing </cr-action-menu> tag. No need for a role= menu on this <cr-action-menu> element: WAI in M88 testing. Bug: 1134438 Change-Id: I78ea53e34324bfdcffa53927d6a72136f4edb7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534423Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827185}
-
Alan Cutter authored
This CL adds chrome/browser/resources/preinstalled_web_apps/internal to .gitignore in preparation for adding it to src-internal: https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/3402544 No-Try: true Bug: 1147692 Change-Id: I2b42c5c9b1b6c5da267366dbf6354be7fafc6859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537274Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827184}
-
Fergus Dall authored
Currently AppServiceAppWindowLauncherController assumes that whether or not crostini is allowed won't change at runtime, which is incorrect. In particular, trying to launch an app after crostini was allowed at runtime will cause a null pointer deref because the CrostiniTracker won't be created. Instead don't try to check enterprise policy here, let that be enforced by the crostini restarter code and web UI. Bug: 1015345 Change-Id: I5f0c3e450ff9f2f62b7eb643207508182ea3747e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505701Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#827183}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2a9b38f2dacd..f92a7636da65 2020-11-13 bsheedy@chromium.org [typ] Fix ResultSink expectations 2020-11-13 cduvall@chromium.org Fork WebView startup metric to use for WebLayer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1146438,chromium:998329 Tbr: zhanliang@google.com Change-Id: Ic4ea9eef3f240fd43f5a0b58270c0a2658d2bbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537092Reviewed-by:
-
Xiaoqian Dai authored
- Change the fullscreen string to be consistent in image capture and video capture scenarios - Click/Tap anywhere can start fullscreen capture TODO: - cursor change will be done in a following up cl. Bug: 1142937 Change-Id: Ife37530245cbc48f8c75be0756d4d45157aac874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536081Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#827181}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605203985-641ad6c9d1aaad676b930873880400e5a1a9a471.profdata to chrome-win64-master-1605214676-526d40dc9a19a8d8de1faf37cfb00f9c1ab93ead.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I27f99c49989f976ec43e0c4e456fa187efa66406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536892Reviewed-by:
-
Mason Freed authored
This ensures Trusted Types are aware of setInnerHTML as a powerful sink. Bug: 1042130 Change-Id: I292acc3081e26aa42f101442fb778635d0c79649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536082 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
-
Peter Marshall authored
These have been ported to frontend unit tests. Bug: 1148495 Change-Id: I3b5dc67f52a19a099d9c0a5708249812fb4f4699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536271 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#827178}
-
Alan Cutter authored
We must store this icon in a separate repository. Bug: 1147692 Change-Id: I02ff6f5994ebf0b7e630c8109b01cc242ea10eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531595Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827177}
-
Michael Thiessen authored
Ran into this crash when changing the timing of Activity finishing in tests. TabModelSelectorTabObserver#tabRemoved posts a task, and then uses the Tab after it's possibly been destroyed. Changes to CriticalPersistedState were also necessary to avoid the observer leak that would happen in this case. Change-Id: I152a2d08cee86af51517f5708e57f8dc7fad4f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535559 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#827176}
-
Luciano Pacheco authored
VolumeManager from background page Refactor FilteredVolumeManager() to not depend or reach to the background window/page, instead it just receives a promise that resolves to the `VolumeManager` which is what `FilteredVolumeManager()` needs. This is a preparation for JS modules to avoid the foreground using global variables from the background, this case is avoiding the `volumeManagerFactory` from FilteredVolumeManager(). For the SWA is the same concept, centralize the interaction with background page via the `BackgroundPage` interface. No change in the behavior, so Closure and current tests cover this. Bug: 1148545, 1133186, 1113981 Change-Id: I81b87534b26d10946dfa1dc0e287c63f003ea203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534553 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
James Vecore authored
Follow up bug for unit-tests: https://crbug.com/1148598 Fixed: 1145752 Change-Id: Ie9ee724f03498264b75b9f2ff31e5f4517ceb9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534293 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#827174}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605171583-b81bb40f399242d480e6bc76fe7dadde7d574957.profdata to chrome-win32-master-1605214676-c85e88d2c252aa731add321a6482c347ea572e8a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie9df7ae5ec4e81dd2c0d2a813dfea3389e047081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535801Reviewed-by:
-
Rakina Zata Amni authored
The BufferedBody CL got reverted at https://crrev.com/c/2532869 because it introduced flakes. This CL relands it and adds a potential fix: write the drained body gradually, as previously we won't write to the newly created pipe until we've finished draining completely. This CL also changes the buffered_body_ data type to use queue of chunks so that we can free memory as soon as we finished writing a chunk of the response body to prevent potential OOMs, and protects all of this code behind a flag (later on we'll also add a check so that we'll buffer the body only when we're deferring due to bfcache) Bug: 1147081, 1148130, 1137682 Change-Id: I61d95c9c67220a296daa66f7409f27fdeb0e8182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531338Reviewed-by:
-
Stacy Kim authored
This updates all instances of ResourceFetcher::ResourceForStaticData() to ResourceFetcher::CreateResourceForStaticData() for consistency. Proper formatting is applied on resource_fetcher.h BUG=chromium:1093757 crbug.com/1093757 R=yhirano@chromium.org Change-Id: I4410bed38716fbff35cc6ea6bffe500bb6245174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535558 Auto-Submit: Stacy Kim <stacy.kim@ucla.edu> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
-
Koji Ishii authored
This is a re-land of r824316 <crrev.com/c/2515429>, which was reverted for <crbug.com/1146797>, with following changes in |NGBoxFragmentPainter::HitTestChildBoxFragment|: * When |!FragmentRequiresLegacyFallback|, check |IsPaintedAtomically| before |IsInline|. I'm not sure why we do so for legacy, but this was the root cause of the regression in <crbug.com/1146797>. * No code changes when |FragmentRequiresLegacyFallback|. * Test for crbug.com/1146797 paasses. Original description follows: When painting and hit-testing NG fragments, |NGBoxFragmentPainter| falls back to |LayoutObject| at the BFC boundary, because we already have a logic in |LayoutObject| to switch painters for NG and legacy. This patch changes to do so only when |!CanTraverse|, because |LayoutObject| cannot handle block fragmented NG objects. This patch eliminates |CurrentFragment| from |LayoutNGBlockFlowMixin::Paint| by making sure it is not block fragmented. Also changes |HitTestChildBoxFragment| so that it can handle atomically-painted objects in NG code path. Due to the change in |FragmentRequiresLegacyFallback|, such objects go to NG code path without going through |LayoutObject|. Bug: 1061423, 829028 Change-Id: Ie795d5ab091b60535f4ee83ed548287e158cfaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526874Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#827170}
-
Joon Ahn authored
http://screen/3VkMjJQmSZKjniG Add an entry in settings under printing section for launching the scanning ui. Gated by an expflag. Bug: 1059779 Change-Id: Ib3e6b2566ababe109afa4fdafbd88f740d42c895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522498 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#827169}
-
Hidehiko Abe authored
This starts to fail on uprevving. Disabling only on Chromium waterfall to unblock the roll LKGM. Note that it is passing on Chrome OS CQ/CI. No clear reason was identified yet. Bug: 11484015 Test: None Change-Id: I144c80847bf06ff4ad0bd3f5a3c31df4f7135816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535901Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#827168}
-
Tetsui Ohkubo authored
Since ARC R, ARC started to natively support display density. That means now one Android pixel always matches the display's physical pixel, and will not be affected by default_dsf which can dynamically change when the screen scaling is changed by the user. This CL fixes the issue by adding GetDeviceScaleFactorForWindow to WMHelper. It returns the same value as GetDefaultDeviceScaleFactor() when |default_scale_cancellation| is true i.e. ARC not supporting native density. Otherwise, it returns the display's density. Additionally, |default_scale_cancellation| is forwarded from WaylandRemoteShell to WMHelper. TEST=manual BUG=b:172031529 Change-Id: I04c2a14712c49760a38c2e21eaf4a2244195397d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525703Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#827167}
-
Nancy Wang authored
This CL implements the On Startup page hidden by the FullRestore flag per the ui review deck: go/cros-full-restore (page 28) Design doc: go/chrome-os-full-restore-dd BUG=1146900 Change-Id: I9d62f821909ca09a56cba8d1c7726bde9493a9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525462 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch reduces calls to |LayoutObject::PositionForPoint| in |LocalFrame::PositionForPoint|. Unlike r827152 <crrev.com/c/2535530>, this one cannot eliminate the use in all cases. Also the logic looks very similar but has slightly differently written, there may be some behavior changes. Bug: 829028 Change-Id: Ife1dd69e7a24462b0370766e4cf89fb76d2de97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535890 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Ramin Halavati authored
This feature is now used in Offline pages and Reader Mode. Bug: 1023759 Change-Id: I7fe1ce7de0db04eee8ec313f5ef02443e7ce6ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529097Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Side Yilmaz <sideyilmaz@google.com> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#827164}
-
Luciano Pacheco authored
Josh has become committer congrats! Change-Id: I0b39ecd0b9b1b755aac8fa4a92d8ac30f28c1b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536215Reviewed-by:
Josh Simmons <simmonsjosh@google.com> Reviewed-by:
-
Luciano Pacheco authored
This CL fixes some inconsistencies that become larger issues for running with JS modules and within SWA container. Issues: 1. The `window.background` was defined using `var background =`, however for JS Modules this doesn't set in the global `window`. 2. The interface `FileBrowserBackground` is actually used by other apps other than Files app, despite the prefix `FileBrowser`. Fix by renaming the interface to `BackgroundBase` and in turn rename the implementation to `BackgroundBaseImpl`. 3. The implementation `BackgroundBase` doesn't have a `@implements` to its interface, which was confusingly named `FileBrowserBackground`. Fix by adding the `@implements` accordingly. 4. The methods `ready()` and `setLauncherHandler()` were the defined in the wrong interfaces. Fix by moving `ready()` to `FileBrowserBackgroundFull` because it's used only in Files app and move `setLauncherHandler()` to `BackgroundBase` because it's used in all apps. No change in behavior, Closure type-checking and current tests cover all changes. Bug: 1148545, 1133186, 1113981 Change-Id: I4ca90e826faf88b7def3b12d89ae249c091ec973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534551 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I5c5cd3d035d767d2392fe5d2cd17f7979f3994b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536723Reviewed-by:
-
Glen Robertson authored
Change-Id: I92b855f231ede21d1263b4147d895864e7961268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536651 Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827160}
-
Josiah K authored
AX-Relnotes: Fixes a bug where the full screen and docked magnifiers would jump unexpectedly when using the arrow keys to move up and down through the omnibox results. Also fixes a bug where the full screen and docked magnifiers jump to the center of the omnibox entries, cutting off the left edge with the site icon and text. Now, the left edge of the selected omnibox entry is aligned with the left edge of the magnifier viewport, so that the site icon and text are visible. Fixed: 1147350, 1147354 Change-Id: I8d2dc3515d9cd565e5cdff3ec84903a6f339eccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528613 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827159}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ib58a338e0a97e79c44467f56be6d53f92541dcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537091Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6a79629904ea..8343d0cf8953 2020-11-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ief5bf6573ba89048528248dab810614a73cae206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537093Reviewed-by:
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of content_browser_client.h from 3.47MB to 2.85MB. This CL has no behavior changes. Change-Id: I567970cfa113607f9b1e0511cd4fffe6de1256ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535895Reviewed-by:
-
