GitLab

This reverts commit c422bd5a
(reviewed on crrev.com/c/934923).

The CL was to reduce number of paint property nodes and paint operations
for objects with border-radius and overflow-clip and the clip rects are
the same.

Revert because:
- Border radius with overflow clip is rare;
- Hiding ObjectPaintProperties::OverflowClip() and exposing
  OverflowOrInnerBorderRadiusClip() was confusing, and I would not like
  to hide OverflowClip() again after crrev.com/c/1026941;
- The relationship between omitting OverflowClip and clip for hit
  testing is complex and tricky. Sometimes omitting OverflowClip causes
  full subtree property update when we just need a clip for hit
  testing. The cost is much bigger than saving just one paint property
  node and 3 paint operations.

Cluster-telemetry shows only 0.39% increase of paint op count with this
CL: https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180506194029/html/index.html

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7c25a727d2f0bfa52dda4151e817ac71d5feb5c7
Reviewed-on: https://chromium-review.googlesource.com/1046152
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556614}

Bug: None
Change-Id: I11c89039ad565e30f531c72d5daa85de3d27c3f8
Reviewed-on: https://chromium-review.googlesource.com/1048318Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556613}

This CL does not introduce any functionality change, but makes
it easier to add a new category of RTTs by combining similar
methods in Network Quality Estimator (NQE).

Bug: 834119
Change-Id: I60623ad51733c9339168993cb8b10202c0a68adf
Reviewed-on: https://chromium-review.googlesource.com/1040913Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556612}

https://webrtc.googlesource.com/src.git/+log/d5ef6ff258da..31dbc246d744

$ git log d5ef6ff25..31dbc246d --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I318726a1ab0073b24e8945609fa9ff220968c97d
Reviewed-on: https://chromium-review.googlesource.com/1048314
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556611}

fdio_transfer_fd() was returning number of returned handles, while
LaunchProcess() was expecting 0 on success. Also added a unittest.

Bug: 826018
Change-Id: Iebc4457449036cc9bfe4eb2203363edde98d75af
Reviewed-on: https://chromium-review.googlesource.com/1045558
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556610}

BUG=840381

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id48c1ea24bbbc642a3f70501ea19767ac83aec0a
Reviewed-on: https://chromium-review.googlesource.com/1047686Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556609}

changes:
This CL add app shortcut items to shelf context menu. Executing app
shortcut item menu entry would launch the corresponding app shortcut.
This CL is shelf side change.
The app list side changes are: crrev.com/c/1029412, crrev.com/c/1041574.

Bug: 803291
Test: tested on device with Android CLs; video: go/appshortcuts-demo-2
Change-Id: I278bdcdc20b1dd48e3c6ac21d18ad98c8b184ecf
Reviewed-on: https://chromium-review.googlesource.com/1045841
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556608}

https://skia.googlesource.com/skia.git/+log/2a943df011ef..9a9c25b36ce5

$ git log 2a943df01..9a9c25b36 --date=short --no-merges --format='%ad %ae %s'
2018-05-07 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ 336cdd903..d4e488eb6 (1 commit)
2018-04-10 halcanary SkAdvancedTypefaceMetrics: simplify more
2018-05-07 kjlubick Trim down T8888 configs
2018-05-07 mtklein make SkColorSpace::MakeICC strict as skcms
2018-05-04 brianosman Handle failure to create SkColorSpaceXform in SkConvertPixels
2018-05-07 herb Make sure the ScalerContextRec is dense

Created with:
  roll-dep src/third_party/skia
BUG=chromium:838115


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I602ef190a5deff01e7d762624f3a50e4b4ba2bff
Reviewed-on: https://chromium-review.googlesource.com/1048273
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556607}

This CL makes {Weak}WrapperSharedURLLoaderFactory available to builds that
shall not depend on //content/ (namely ios/chrome builds).

In practice, it moves wrapper_shared_url_loader_factory.* and
weak_wrapper_shared_url_loader_factory.* out of //content/common and
//content/public/common, respectively, into services/network/public/cpp/.

The various callsites are updated, but no functionality changes are
expected.

The dependency chain looks like this:

- WeakWrapperSharedURLLoaderFactory (weak_wrapper_shared_url_loader_factory.*) depends on
- WrapperSharedURLLoaderFactoryInfo (wrapper_shared_url_loader_factory.*), which depends on
- WrapperSharedURLLoaderFactory (wrapper_shared_url_loader_factory.h).

BUG=773295

TBR=boliu@chromium.org,blundell@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If6a1c9ac1197e1eafe17c4ba9d4136b52803a5f8
Reviewed-on: https://chromium-review.googlesource.com/1046306
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556606}

This CL:
- Adds an UpgradeToTLS() API to mojom::TCPConnectedSocket, so consumers of
  mojom::TCPConnectedSocket can perform TLS connect on top of an already
  connected tcp client socket.
- Adds a tls_socket.mojom file which includes the interface definition of
  TLSClientSocket.

Other changes to support implementing UpgradeToTLS():
- Uses net::StreamSocket::ReadIfReady() instead of net::StreamSocket::Read() in
  socket_data_pump.h/cc. Using ReadIfReady() allows us to cancel the receive
  side in preparation for UpgradeToTLS() without worrying that data might be
  buffered by the tcp socket.
- Adds a net::Socket::CancelReadIfReady(), so we can tell the underlying tcp
  socket to cancel a pending ReadIfReady() and unregister their event watchers.

Bug: 721401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic23fc782f6e701e6b7a9f60ac2ddfeccc6031744
Reviewed-on: https://chromium-review.googlesource.com/1034080
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556605}

https://chromium.googlesource.com/catapult.git/+log/e54b6ffb6dad..e853531767d2

$ git log e54b6ffb6..e85353176 --date=short --no-merges --format='%ad %ae %s'
2018-05-07 nednguyen Remove deadcode related to old test disabling system in Telemetry story runner
2018-05-04 dtu [pinpoint] Look in new location for perf results file.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:796340,chromium:836037


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Id4ca3154cc36c121ee3a7b9347df5053decf30f3
Reviewed-on: https://chromium-review.googlesource.com/1048307
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556604}

PowerMonitorBroadcastSource receives mojo power notifications on IO
thread, and can use PowerMonitor after it's destroyed on main thread.
Disabling power notifications on the IO thread prevents this data race.

Bug: 834312
Change-Id: I1677b6098d158ecc18dfce60eaeed9590110a962
Reviewed-on: https://chromium-review.googlesource.com/1041215
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556603}

R=enne@chromium.org

Bug: 839711
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib6e45db4752533219a9dbabb82187f4422afd697
Reviewed-on: https://chromium-review.googlesource.com/1048127Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556602}

Bug: None
Test: build locally, no check error
Change-Id: I243982950572ff4250e6aea02799b10afc2dbbf1
Reviewed-on: https://chromium-review.googlesource.com/1048030
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556601}

We should only reset the deadline when ui is resizing because OS is
guttering us anyways. In other cases use the real deadline.

Bug: 834449, 672962
Change-Id: I95a29e3cf8a508d0d1cd614df79c0e12183f1487
Reviewed-on: https://chromium-review.googlesource.com/1048206Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556600}

As in each app, the service keeps two seed files: "variations_seed" and
"variations_seed_new", and uses them the same way. New seeds are written
to "variations_seed_new" and then "variations_seed_new" is renamed to
"variations_seed". The service uses the "variations_stamp_file"
similarly as well; while apps use it to rate-limit their requests to the
service, the service uses its own stamp file to rate-limit requests to
the variations seed server.

AwVariationsSeedFetcher (named to avoid confusion with the existing
VariationsSeedFetcher) is a JobService which downloads the seed on
behalf of the service. The job is scheduled whenever an app requests the
seed, and the last job ran at least one day ago. Since WebView is used
frequently, the job will be effectively periodic (with a period of one
day) as long as the device is in use and has network access.

VariationsSeedHolder managers the WebView service's copy of the seed.
Work on the seed is done by posting Runnables (SeedWriter and
SeedUpdater) to a certain background thread, to ensure mutual exclusion.
A SeedWriter job is posted whenever an app requests the seed from the
service; the SeedWriter writes the service's seed to the provided file
descriptor. A SeedUpdater job is posted to update the seed with a newly
downloaded one.

BUG=733857

Change-Id: I40763a2cdbb2d70889a8547349c1f550488d5ff5
Reviewed-on: https://chromium-review.googlesource.com/1036852
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556599}

Bug: b:79359468
Test: locally build and run
Change-Id: I031c85fd1aad7647b84741f638b9dac385ea560a
Reviewed-on: https://chromium-review.googlesource.com/1048121Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556598}

Instead add a function. This is easier to use in calling code.

BUG=837686
TEST=none

Change-Id: I0b9b8e973d9d454f18a7711f2d8ab6a6540144fa
Reviewed-on: https://chromium-review.googlesource.com/1045466Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556597}

In LayoutNG, HasPercentHeightDescendants() does not produce correct results
and it is difficult to get it to produce correct results. Accordingly, let's
disable this optimization for now.

Bug: 635619, 839661
Change-Id: I766ea2fbea647eb9d0f3767b64788b678d328953
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/1043009
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556596}

Switch SnapshotAllCompositorKeyframes implementation to *always* check the dirty
bit and make that an internal details instead of relying on clients to check.

To this end, we explicitly invalidate the snapshots when viewport was zoomed or
resized. Also now we correctly set the dirty bit when a new keyframes are set.

TEST: third_party/blink/renderer/core/animation/keyframe_effect_model_test.cc

Change-Id: I9b941abf68f3e6897b2ab349a2afc6264d25bf96
Reviewed-on: https://chromium-review.googlesource.com/1033575Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556595}

Change-Id: I4079e769b46f16d3635c25276beb832ced10107b
Reviewed-on: https://chromium-review.googlesource.com/1041076Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556594}

Error 22 (EINVAL) is often associated with use-after-frees.
I've seen multiple developers independently spending cycles figuring
this out. Add a hint for everyone once and for all in POSIX's LockImpl

Issues where this may be useful:
https://bugs.chromium.org/p/chromium/issues/list?q=%22Check+failed%3A+rv+%3D%3D+0+(22+vs.+0)%22

Sadly I couldn't find a way to test this. I tried to write a death
test on a manual use-after-free but the error is unreliable.

R=dcheng@chromium.org

Bug: 818163
Change-Id: I2f9a3aeadebd8bd7b32e2a28d1ba4b801efed9ff
Reviewed-on: https://chromium-review.googlesource.com/1040586Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556593}

-Wno-deprecated-declarations is no longer needed after
http://crrev.com/689599319903ef86.

Bug: 752720
Change-Id: Ief8b8d62b9d503c597e05534009ca728786e764d
Reviewed-on: https://chromium-review.googlesource.com/1046405Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556592}

See bug for more details.

Bug: 838690
Change-Id: I96593a5265457ec83c0c50ce390ccf883b71f34f
Reviewed-on: https://chromium-review.googlesource.com/1048313Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556591}

Move the code from WebDisplayItemListImpl up into each DisplayItem
subclass in blink. Make LinkHighlightImpl and GraphicsLayer into
cc::ContentLayerClients instead of WebContentLayerClients, and have
them construct/finalize/return a cc::DisplayItemList instead of a
WebDisplayItemList.

R=jbroman@chromium.org, pdr@chromium.org

Bug: 738465, 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I56f20f93ac29125e23a15acccaa403f95f71061b
Reviewed-on: https://chromium-review.googlesource.com/1045229Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556590}

This CL introduces the PendingConnectionRequest class, which represents
a request to create a connection to particular device.

Bug: 824568, 752273
Change-Id: I122f207858b87d624bc621b2eff59010d87bbbce
Reviewed-on: https://chromium-review.googlesource.com/1038649Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556589}

Currently we use the concept of a Swap ID in LatencyInfoCache. We want
to depend on this pattern in additional places as well.

Unfortunately, the ID used in LatencyInfoCache is loosely coupled to
the ID generated in the GPU proc - they seem to line up now, but
nothing guarantees they keep doing so.

To make this system more robust, this patch introduces client
generation of Swap IDs, which are then sent to the GPU proc and
round-tripped back to the client.

Bug: 837476
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I04f762c7f84a437b13fe1ff75abb13fc0237dc08
Reviewed-on: https://chromium-review.googlesource.com/1035536
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556588}

This includes adding a third asset to indicate "selecting" state for a better
user experience.

Bug: 753018
Change-Id: Ice6d666f2b92c232c7c74a1fb28a0175c274a7e7
Reviewed-on: https://chromium-review.googlesource.com/1045549Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556587}

This has been launched for a couple weeks.

Bug: 787067
Change-Id: I5b206ee7945f48ab7641bb823e2b0e320a32a413
Reviewed-on: https://chromium-review.googlesource.com/1044534Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556586}

Bug: 768073
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id56c5c360e17d09d0f4f806da9a18c43a25a6e6b
Reviewed-on: https://chromium-review.googlesource.com/1048032Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556585}

Only show the tab strip in RegularxRegular trait collection.

Bug: 831978
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibcebaeb6c2236a03f0c238f51cf00e66100d9fe5
Reviewed-on: https://chromium-review.googlesource.com/1046128
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556584}

Uses an updated asset for the query in omnibox magnifying glass to match
the size of the security icon.

Bug:836043

Change-Id: Ia84817af01373fbcfc3f07656ce0ee77a0f553e0
Reviewed-on: https://chromium-review.googlesource.com/1040534
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556583}

Adding set method in ChromecastConfigAndroid which will be called by
native method.
This method will be called when prefs value is updated.

called when prefs value changes.

Test: Verified that the ChromecastConfigAndroid mutator function is
Bug: Internal b/77485825
Change-Id: Ie6021da906a7a87ec07a2d27e56c98ef75925bc4
Reviewed-on: https://chromium-review.googlesource.com/1045314Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Shyamsundar Parthasarathy <shyamsundarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556582}

Some of the new redirect-style interventions require a sticky
permission bit. There is a plan to govern these interventions via
the popup setting.

This CL does a few things:
1. Start sending down popup settings to the renderer via
   content_settings.mojom

2. Modify framebust logic to allow the framebust (but still log a
   warning) if the setting is set to allow

3. Modify FramebustBlockTabHelper to allow for setting multiple observers,
   to aid in test ergonomics.

4. Add a few browsertests which exercise the new logic end to end.

Follow-up CLs will actually improve the UI to allow for setting this
in response to a framebust being blocked.

Bug: 840352
Change-Id: Id05eeb20a488ab8691384362c544e1a42f4b5ed6
Reviewed-on: https://chromium-review.googlesource.com/1042360Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556581}

Don't use a net::URLRequestInterceptor to count the number of times a resource was loaded, as that doesn't work when net/ runs in a separate process. Instead count the number of times the test server saw the request.

Bug: 705114
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie042e56ee192774c51bb8d1b568a569ca90b4e42
Reviewed-on: https://chromium-review.googlesource.com/1047788Reviewed-by: Doug Turner <dougt@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556580}

This change causes arrowing upwards at the top of a menu, or arrowing downward
at the bottom of the menu, not to wrap around on Mac. It also adds a test
for this behavior.

This also moves and documents a helper in MenuConfig.

Bug: 837229
Change-Id: Iad73206dcede3a742242754801588e6d6a96c18b
Reviewed-on: https://chromium-review.googlesource.com/1038323
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556579}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5e5f2d60353b..5ae86d202127

$ git log 5e5f2d603..5ae86d202 --date=short --no-merges --format='%ad %ae %s'
2018-04-26 jbroman Update canned PRESUBMIT checks to report that TBR does not apply to OWNERS.
2018-05-07 tandrii Update windows git to 2.17.0

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:811681


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Id8f55746eacc756b3f167e503a9e62482a2a7ebd
Reviewed-on: https://chromium-review.googlesource.com/1048183Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556578}

Rebaseline paint/selection/text-selection-inline-block.html and the rtl
version, paint/selection/text-selection-inline-block-rtl.html as the NG
rendering is more correct than the old legacy baselines.

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I55cacb0726ab0b8bf4c87fe9710eecc1c4bd3933
Tbr: atotic@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1048037Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556577}

Bug: 840453
Change-Id: I76e819cd53b3f834eb6252808e1323080aa69525
Reviewed-on: https://chromium-review.googlesource.com/1048122Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556576}

In crrev.com/c/1022872 we changed the logic of how we initialize
CompositorOverlayCandidateValidatorOzone.

We erroneously changed the logic to always instantiate
CompositorOverlayCandidateValidatorOzone even when no strategies were
specified.

This broke legacy devices. This CL makes sure not to instantiate
the validator if not needed.

Bug: 840267, 834015
Test: Play video on veyron_minnie
Change-Id: Ibde65689c05d38a3fe22d81748db8d21f89d725e
Reviewed-on: https://chromium-review.googlesource.com/1048245Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556575}