- 27 Jan, 2016 40 commits
-
-
robhogan authored
Ensure that ancestors that no longer need to track percentage descendants after the split have them removed from their tracking lists. BUG=568387 Review URL: https://codereview.chromium.org/1551573002 Cr-Commit-Position: refs/heads/master@{#371791}
-
tmoniuszko authored
BUG= Review URL: https://codereview.chromium.org/1646483002 Cr-Commit-Position: refs/heads/master@{#371790}
-
dnicoara authored
Followup to https://codereview.chromium.org/1631073002/ to make sure that the OnMessageReceived returns false for unhandled IPC messages. BUG=558602 Review URL: https://codereview.chromium.org/1640263002 Cr-Commit-Position: refs/heads/master@{#371789}
-
loyso authored
We always create new animations with unique ids. So the removeAnimation(unique_id, target_property) call on adding a new animation is meaningless. This change allows us to forward declare WebCompositorAnimation class for WebLayer interface. BUG=577016 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1637083004 Cr-Commit-Position: refs/heads/master@{#371788}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/89d5fb66..aa81c816 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1643543002 Cr-Commit-Position: refs/heads/master@{#371787}
-
horo authored
This cl will fix the bug reported at https://crbug.com/253465#c26. With this patch, MediaMetadataRetriever can get the metadata of the local video file which is selected with the file input element. BUG=253465 Review URL: https://codereview.chromium.org/1626283002 Cr-Commit-Position: refs/heads/master@{#371786}
-
jkarlin authored
BUG=410201 Review URL: https://codereview.chromium.org/1636613002 Cr-Commit-Position: refs/heads/master@{#371785}
-
rohitrao authored
Removes dependencies on chrome/ and content/ and moves the file to components/omnibox/browser. BUG=581108 TEST=None Review URL: https://codereview.chromium.org/1635653002 Cr-Commit-Position: refs/heads/master@{#371784}
-
fmalita authored
http://crrev.com/1623073003 introduced a bug where moveTos only update the subpath point when immediately following a closePath. This is incorrect: moveTos should always update the subpath point. BUG=581451 R=fs@opera.com,pdr@chromium.org Review URL: https://codereview.chromium.org/1635323002 Cr-Commit-Position: refs/heads/master@{#371783}
-
caryclark authored
Changes to Skia polynomial evaluation caused a slight difference in cubic path measure, causing a few tests to fail. Suppressing these failures until they can be rebaselined. R=fmalita@chromium.org BUG=581661 Review URL: https://codereview.chromium.org/1645483002 Cr-Commit-Position: refs/heads/master@{#371782}
-
vasilii authored
Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't ping the model after bubble destruction. Rename some classes for good. BUG=579726 Review URL: https://codereview.chromium.org/1645503002 Cr-Commit-Position: refs/heads/master@{#371781}
-
avayvod authored
BUG=580113 TEST=e2e tests with replacing the current script with the new one. For Chrome 50, the new version of cast_sender.js will be served that doesn't use PresentationRequest.join("_receiver-action") to get the receiver action event. Instead, the PresentationConnection is returned immediately after the user picked a device for PresentationRequest.start() and the receiver action message is sent back to the page via the corresponding MediaRoute. This in particular means the route will exist without the CastSession and some messages need to be handled by CastMediaRouteProvider, as well as queued until "client_connected" is sent to the route. Review URL: https://codereview.chromium.org/1614023002 Cr-Commit-Position: refs/heads/master@{#371780}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/deb8260a..89d5fb66 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1640203002 Cr-Commit-Position: refs/heads/master@{#371779}
-
lionel.g.landwerlin authored
The genereated Ogg/Opus files don't seem to play in Chromium (which uses ffmpeg) while they do VLC or Gstreamer. Turns out we have the wrong flag set on the OpusTags packet and a wrong size written for one of the strings. BUG=none TEST=play the generated file on Chromium Review URL: https://codereview.chromium.org/1640703002 Cr-Commit-Position: refs/heads/master@{#371778}
-
bratell authored
A PeriodicWave object can use half a MB and v8 needs to know about that or it will not schedule garbage collects when memory usage increases. BUG=578351 Review URL: https://codereview.chromium.org/1632753002 Cr-Commit-Position: refs/heads/master@{#371777}
-
xiaochengh authored
|ReplaceSelectionCommand| stores the inserted range after |doApply()|. This range may be invalidated if |Editor::appliedEditing()| modifies the DOM, causing spellcheck run on an invalid range. This CL moves the spellcheck request into |Editor::appliedEditing()| before dispatching any event, ensuring spellcheck run on a valid range. BUG=580950 TEST=LayoutTests/editing/pasteboard/paste-webkit-editable-content-changed-crash.html Review URL: https://codereview.chromium.org/1636883003 Cr-Commit-Position: refs/heads/master@{#371776}
-
dominicc authored
Tiny bit of cleanup: Some timers used to be 'snapped' to an 'aligned' fire time so that work would get batched, particularly when suspended timers were rescheduled. This sort of thing is now the responsibility of the scheduler; nobody is using Timer::alignedFireTime any more. Because alignedFireTime had no tests :O no tests were harmed in the preparation of this changelist. :D BUG=331912 Review URL: https://codereview.chromium.org/1625413002 Cr-Commit-Position: refs/heads/master@{#371775}
-
tkent authored
A crash of crbug.com/537815 was due to an editable <p> as document.documentElement. Supporting such invalid HTML structure is costly. So we correct such HTML structure before executing execCommands. - We show a console warning if the autocorrection happens. - After the autocorrection, document.write() doesn't work because the document tree is complete. BUG=537815 Review URL: https://codereview.chromium.org/1637323002 Cr-Commit-Position: refs/heads/master@{#371774}
-
mstensho authored
This was an "alias" for -webkit-column-span:none. '1' is not a valid value, according to the spec. The only valid values are 'none' and 'all'. In an older version of the spec, '1' and 'all' were the valid values. In the latest version (2011), '1' was changed to 'none'. It's highly unlikely that removing this should cause compatibility problems. The initial value is 'none' (which is what '1' was mapped to), so in order to cause trouble, one would need a declaration -webkit-column-span:all to be overridden by a -webkit-column-span:1. I went through httparchive to verify. No sites were found to do this. R=timloh@chromium.org Review URL: https://codereview.chromium.org/1635993002 Cr-Commit-Position: refs/heads/master@{#371773}
-
sigbjornf authored
If a ScriptRunner has been disposed of already, allow ScriptLoaders to notify of their failure without asserting. R=haraken BUG=570012 Review URL: https://codereview.chromium.org/1644483002 Cr-Commit-Position: refs/heads/master@{#371772}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/45f7b52d..deb8260a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1636383002 Cr-Commit-Position: refs/heads/master@{#371771}
-
primiano authored
This CL removes the support for the CHROME_PROFILER_TIME env var, originally introduced by crrev.com/9212025 more than 3 years ago, which allows to change the time source for the profiler via the environment. Reason for deleting it: could not find any active user of that. See also discussion in project-trim@chromium.org @ goo.gl/p3GEUy . After this CL (almost*) nothing outside of base depends on tcmalloc. This is the place where we want to be, as base should be the only thing knowing about allocator internals. * There is only one dep left in content_child_helpers.cc, which is relied on by old-style telemetry memory benchmarks. But that code is literally a dead man walking and there is no point refactoring it. BUG=564618, 581365 Review URL: https://codereview.chromium.org/1632253002 Cr-Commit-Position: refs/heads/master@{#371770}
-
oshima authored
Pepper API is device scale factor aware, so we need to convert the coordinates between viewport and DIP, when use-zoom-for-dsf mode is enabled. * Convert events and bounds from the Viewport to DIP. * Convert caret bounds from DIP to Viewport. * Moved the utility function to scale WebInputEvent to ui/events/blink This CL depends on https://codereview.chromium.org/1603253003/ BUG=485650 Review URL: https://codereview.chromium.org/1609193002 Cr-Commit-Position: refs/heads/master@{#371769}
-
tfarina authored
This patch moves this free function from generic net_util.h header, into url_util.h, because it operates on a URL part (hostname), so it seems more appropriate there than in the soon-to-go-way net_util.h. BUG=488531 TEST=net_unittests --gtest_filter=UrlUtil* R=eroman@chromium.org TBR=felt@chromium.org Review URL: https://codereview.chromium.org/1629733002 Cr-Commit-Position: refs/heads/master@{#371768}
-
magjed authored
Revert of command_buffer: Enable gl path rendering by default (patchset #1 id:1 of https://codereview.chromium.org/1626363002/ ) Reason for revert: This CL is causing the Linux Release (NVIDIA) builder to fail: https://build.chromium.org/p/chromium.gpu/builders/Linux%20Release%20(NVIDIA) It fails on step gl_tests on test GLClearFramebufferTestWithParam/GLClearFramebufferTest.ClearDepthStencil/0 with this error message: GLClearFramebufferTestWithParam/GLClearFramebufferTest.ClearDepthStencil/0: [13969:13969:0126/235302:15239455268986:ERROR:buffer_manager.cc(361)] [GroupMarkerNotSet(crbug.com/242999)!:C84AD1F190090000]GL ERROR :GL_INVALID_ENUM : glBufferData: <- error from previous GL command ../../gpu/command_buffer/tests/gl_test_utils.cc:31: Failure Value of: error Actual: 1280 Expected: static_cast<GLenum>(0) Which is: 0 GL ERROR in no errors at line 52 : 1280 Original issue's description: > command_buffer: Enable gl path rendering by default > > Enable gl path rendering by default if it is supported by the > hardware. > > Skia will use it when GPU rasterization MSAA codepath is used. > > BUG=344330 > > Committed: https://crrev.com/3f4b630297d744ce825a18f167550c10892e7e76 > Cr-Commit-Position: refs/heads/master@{#371753} TBR=vmiura@chromium.org,bsalomon@google.com,zmo@google.com,senorblanco@chromium.org,zmo@chromium.org,kkinnunen@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=344330 Review URL: https://codereview.chromium.org/1641623002 Cr-Commit-Position: refs/heads/master@{#371767}
-
fs authored
Even if the transform-origin is the same as the current value, rareNonInheritedData will still be copied. Add a new macro SET_NESTED_VAR, similar to the existing SET_VAR, but allowing an intermediate |base| field to be specified, avoiding the access in the dereference of that field from the group. BUG=571183 Review URL: https://codereview.chromium.org/1636503005 Cr-Commit-Position: refs/heads/master@{#371766}
-
mvanouwerkerk authored
This prepares the notification feature plumbing for using multiple resources when buttons can have icons. IPC messages cannot take more than 5 arguments, so the idea is that all icon resources will be wrapped in this struct. BUG=581336 Review URL: https://codereview.chromium.org/1634933006 Cr-Commit-Position: refs/heads/master@{#371765}
-
davve authored
Image::hasRelative{Width,Height} always return the same result so there is no need for two functions. Since https://codereview.chromium.org/26390004 there is no reason to have these separate since the SVGImage implementations are gone. BUG=581357 Review URL: https://codereview.chromium.org/1634133003 Cr-Commit-Position: refs/heads/master@{#371764}
-
iceman authored
Just removed NOTIMPLEMENTED from BridgedNativeWidget::PrepareForLayerBoundsChange() function. BUG=454698 Review URL: https://codereview.chromium.org/1627193004 Cr-Commit-Position: refs/heads/master@{#371763}
-
oshima authored
Add dedicated windowToViewport method to convert FloatRect from window coordinates to Viewport coordinates. ... to avoid rounding issue with fractional scale factor. BUG=485650 Review URL: https://codereview.chromium.org/1603253003 Cr-Commit-Position: refs/heads/master@{#371762}
-
davve authored
All other return values pass through computeReplacedLogicalWidthRespectingMinMaxWidth, let this one do so too. Review URL: https://codereview.chromium.org/1637473002 Cr-Commit-Position: refs/heads/master@{#371761}
-
rune authored
If we return nullptr trying to consume a compound, and all tokens have been consumed, we don't recognize that as a parse failure if a valid selector precedes the compound. Set m_failedParsing to true to notice we have an invalid selector. R=timloh@chromium.org BUG=581257 Review URL: https://codereview.chromium.org/1634273003 Cr-Commit-Position: refs/heads/master@{#371760}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5c7b38de6fd5..537c7c6cb877 $ git log 5c7b38de6..537c7c6cb --date=short --no-merges --format='%ad %ae %s' CQ_INCLUDE_TRYBOTS= TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1640553003 Cr-Commit-Position: refs/heads/master@{#371759}
-
tkent authored
* <!DOCTYPE> should be shown differently. Old: html 0xhhhhhhhh New: DOCTYPE html 0xhhhhhhhh * Processing Instructions should be shown differently. Old: xml-stylesheet 0xhhhhhhhh New: ?xml-stylesheet 0xhhhhhhhh * Elements and documents show editability Old: body 0xhhhhhhhh New: body 0xhhhhhhhh (editable) This CL has no behaivor changes in production. Review URL: https://codereview.chromium.org/1639193002 Cr-Commit-Position: refs/heads/master@{#371758}
-
yuzus authored
Change getDistributedNodes to getAssignedNodes to make the performance test run. BUG=531990 Review URL: https://codereview.chromium.org/1630003004 Cr-Commit-Position: refs/heads/master@{#371757}
-
raymes authored
This CL adds metrics to measure the usage of features that require permissions in Chrome when they are used in cross-origin iframes only. In particular we only want to count an iframe if it doesn't have scripting access into the top level document. A new UseCounter::countCrossOriginIframe function has been added which will only count this type of usage. Note that this intends to count cases when a site tries to use an API whether or not the permission is granted by the user. BUG=444744 Review URL: https://codereview.chromium.org/1578263006 Cr-Commit-Position: refs/heads/master@{#371756}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#371755}
-
a-v-y authored
R=pkasting@chromium.org Review URL: https://codereview.chromium.org/1639833002 Cr-Commit-Position: refs/heads/master@{#371754}
-
kkinnunen authored
Enable gl path rendering by default if it is supported by the hardware. Skia will use it when GPU rasterization MSAA codepath is used. BUG=344330 Review URL: https://codereview.chromium.org/1626363002 Cr-Commit-Position: refs/heads/master@{#371753}
-
jochen authored
This will avoid new dependencies and helps with keeping track of the refactoring. R=pfeldman@chromium.org BUG= NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1632273002 Cr-Commit-Position: refs/heads/master@{#371752}
-