- 24 Feb, 2020 40 commits
-
-
Wolfgang Beyer authored
As preparation to revert commit Bug: chromium:1035309 Change-Id: I91417547e188f2ef4028cd556b4b3026302dbd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069142Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743981}
-
Daniel Rubery authored
The server will be reporting failure as a separate verdict, rather than using the status field (right now the status field is always unset). The corresponding server-side change is cl/296334194 Change-Id: Iea78604e6d07871f7e5c798dab5b933969d21d25 Bug: 1045986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068038 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743980}
-
Ming-Chuan Lin authored
Bug: None Change-Id: I27fe19f5d1df2d36f42d711ab3bc7e4622f7c940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068267Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Ming-Chuan Lin <mingcl@google.com> Cr-Commit-Position: refs/heads/master@{#743979}
-
Andrew Grieve authored
5853fbdc did this for .jar files. This CL addresses compile_resources.py. Bug: 1036426 Change-Id: I991132f4b2b1bc99002ec2a153d35ab815bd84b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070370 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#743978}
-
Eric Boren authored
borenet@chromium.org -> borenet@google.com Change-Id: I190fde6ee81e3b4804b73f05d813ef165fc7c44d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067867Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Eric Boren <borenet@google.com> Cr-Commit-Position: refs/heads/master@{#743977}
-
Shawn Pickett authored
Bug:1027046,984851 Per issue tracked in http://crbug.com/1027046, the functionality tied to the 'turn-off-streaming-media-caching' flag will be leveraged as part of an experiment to determine whether it should be permanently enabled. Since the flag is set to expire in M82, this change extends the expiration to M86 (given we do not have a clear timeframe for the experiment at this time). Change-Id: I8b8778bc836b5e738860dd104156d4927a931af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068726Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Shawn Pickett <shawnpi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743976}
-
ckitagawa authored
Use onPageLoadFinished() rather than onDidFinishNavigation() for capture experiments. This ensures the page is loaded and most of the content is renderered before we attempt a capture. At present this is happening as a navigation occurs which is too soon as there is often no content. Known Issue: some sites may trigger too soon as they lazily load resources. It would be better to trigger on navigate away, but AFAICT such a trigger/handler doesn't exist as we normally avoid doing work when unloading the page (requires further investigation). Bug: 1055353 Change-Id: I33b99835f96543c476a858dd629ce1b41c130b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070104Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#743975}
-
Eric Seckler authored
This prepares for crrev.com/c/2066976 by plumbing the PerfettoService pointer down into MockProducerHost, which will require it to obtain a reference to the service's task runner. Bug: 1006753 Change-Id: I947357d56b4abc3b8435ededc8165e70f5b44286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070199Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#743974}
-
Peng Huang authored
Vulcan functions are loaded from shared library dynamically. Calling those function pointer with cfi will cause SIGILL / ILL_ILLOPN. So blacklist cfi sanitize for Vulcan function calls. Bug: 1016885 Change-Id: I73989cebc9ab35d6f35fac508e8f0bcfc23cbd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066937Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743973}
-
Daniel Rubery authored
This CL expands the per-file ownership to all the files that exclusively contain functionality related to enterprise scanning (in contrast to APP scanning) Change-Id: Ia8a7ee1012fc81d12651ff79a6861bc43c538132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065908 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#743972}
-
Roman Sorokin authored
Hide Gaia screen when switches from 0 to >0 users, and show the account picker screen otherwise. Also remove can_close_ param from ShowGaiaSignin - relies on the user list now. Bug: 647451 Change-Id: Iec4e8182b6e07393a10d2336a9818d7d1b2d0b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035670Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743971}
-
Ionel Popescu authored
With FormControlsRefresh, the used native theme web instance is NativeThemeAura instead of NativeThemeMac. Prior to this CL, there was no support to initialize the dark mode, preferred color scheme and high contrast states for NativeThemeAura. Note that these states are going to be sent to the renderer processes by using the communication mechanism introduced by [1]. [1]: crrev.com/c/1728056 Bug: 1054725 Change-Id: I45f0d382b70bd1e616cfb8e4a59bc3db392d744a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068870Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743970}
-
Vladimir Levin authored
This patch removes the attribute version of display locking. It also removes updateRendering() which could be easily added back in. It also updates all of the tests and removes some of the earlier tests that aren't very good (they were testing promises and js APIs, none of which makes sense if we're only using CSS version). Also removed some render-subtree sizing tests, since those should be covered by contain-intrinsic-size tests instead. R=chrishtr@chromium.org, rakina@chromium.org Change-Id: I03fe9a35a4ed821c800488c316ea13f1a8be6e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054328Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#743969}
-
Andrew Grieve authored
Change-Id: Id371e32b1b7f172b252eab6e853d918fee9971bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067236 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
When --no-startup-window is passed in combination with remote debugging, browser is controlled by automation software. In this case, we keep the application running until explicit Browser.close call over protocol. Otherwise, application just exits because no browser window is opened. Drive-by: apparently, this introduced a first test with DevToolsPipeHandler, which exposed a DCHECK. Shutting down the pipe handler posts a task to delete threads which joins them and requires sync primitives task trait. Bug: 1054831 Change-Id: I1fcfdad11ec10661a2163b18a7547668655f25bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068043Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#743967}
-
Eric Seckler authored
The deprecated TRACE_EVENT_ASYNC* macros have been superseded by TRACE_EVENT_NESTABLE_ASYNC*. Bug: 1038710 Change-Id: I84610e4ca4f4aa2204dee4ecff28d4d501280449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069139 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Toni Barzic authored
The flakiness seems to have been fixed by CL:2067814 BUG=1053980 Change-Id: Iabe7ff55945d4321ff18cafa05a585bfed42a205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069852Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#743965}
-
Theodore Olsauskas-Warren authored
As part of the privacy settings redesign to the capability to surface recently changed permissions is required. A previous CL introduced the capability to retrieve these changes and this CL introduces a Polymer element to display them. This CL also places that element in the site_settings_page hidden behind the privacySettingsRedesignEnabled flag. Bug: 1032584 Change-Id: I744f2a57de65200c2c0684b4777bd77549496e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030525 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#743964}
-
Ben Joyce authored
Cannot update all of tab_ui to use androidx yet because it'd require changes to modelutil/SimpleRecyclerViewAdapter.java which necessitates a whole host of other changes. Bug: 1052460 Change-Id: I7064f33d672ff404d46778af8fc25aaa96da6e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069198Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#743963}
-
Elly Fong-Jones authored
Clicking the "Continue" button on this dialog would end up trying to call through a null delegate pointer. There was no test coverage for this. Oops! This change fixes the bug and adds test coverage. Bug: 1054866 Change-Id: Ia92f51c24a6053a0762e70e7216b5cc2de37d33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068304 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#743962}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9642b31a71fc..108a494984da git log 9642b31a71fc..108a494984da --date=short --first-parent --format='%ad %ae %s' 2020-02-24 benjaminwagner@google.com Omit crashing bench on iOS Metal 2020-02-24 robertphillips@google.com Add a program iterator to SkDeferredDisplayList Created with: gclient setdep -r src/third_party/skia@108a494984da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Id614df757d105e824816f73955e5409aa256d21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067235Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743961}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be465ac3..cb8594a9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib7d1c8614ec850ade4ff4ebcc2722980cd88fce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070024Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743960}
-
Eric Seckler authored
Prepare for startup tracing v2: With the new startup tracing, PerfettoTracedProcess may be created much earlier when the thread-pool isn't around yet, and thus posting the task to construct the system producer in its constructor isn't possible. This separates construction of the system producer from its connection. The task to connect is still posted after thread pool init onto the correct sequence. Also renames accessors in preparation for the startup tracing patch. Bug: 1006753 Change-Id: I3f5d454ff48b490704ce15a10ee491d6c8135107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066976 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#743959}
-
Anatoliy Potapchuk authored
We have been getting SIGSEGV when finalizing profile after chrome::AttemptUserExit(). We did it for asynchronous prefs load, but did not cover the synchronous one(the one in tests). Bug: 964333 Change-Id: I81f9485cf2c8af7b1ea1f619e143a2ce8468657c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066717Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#743958}
-
Henrique Nakashima authored
This flag is not cached, so it should not go through CachedFeatureFlags. Bug: 1012975 Change-Id: I7420dade015dad4a1905e93d702aa70fc452602d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068923Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#743957}
-
Nina Satragno authored
Add kCtap2ErrUvBlocked to GetCtapResponseCodeList. Fixed: 1054922 Change-Id: Ia03fadd79d3b4b786dc928d47fc26cba17f9a919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068741 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#743956}
-
Sesh Sadasivam authored
Classes that inherit from `NSThemeFrame` seem to show window buttons in the incorrect position when the primary MacOS language is set to an RTL (right-to-left) language like Arabic or Hebrew. The fix in this commit mirrors that of `tabbed_browser_window.mm` (https://chromium-review.googlesource.com/c/chromium/src/+/562603/10/chrome/browser/ui/cocoa/tabbed_browser_window.mm#88). This fix is based on a patch required to fix an Electron issue. The corresponding PR is: https://github.com/electron/electron/pull/22016 BUG=1049796 BUG Change-Id: I1c7a3daec85922b119cd97e2171bae838d05e207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040377 Auto-Submit: Sesh Sadasivam <sesh@fb.com> Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743955}
-
Robbie Gibson authored
On iPhone, the height of the toolbar changes with dyanmic type size. Before, the height of the FindInPage bar was fixed. According to the design, the actual content of FindInPage should not change (as it is semantically a toolbar). The height should change, however. Now, if the toolbar grows, the FindInPage bar stays centered in the background view beneath the safe area. One small thing to note is that the toolbar layout guide changes when the toolbar shrinks into fullscreen. In this case, the FindInPage bar will change height along with the toolbar until a minimum height is reached. At that point, it will stop shrinking. Fixed: 1053976 Change-Id: I2172b37dc039239b13b44e42caebb03176e6100a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066751Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#743954}
-
arthursonzogni authored
This came from: https://github.com/web-platform-tests/wpt/pull/21856 This patch updates Chrome implementation to match the spec. Bug: 1031542 Change-Id: Iea32be8d0c8b286802c1a372c39298ce97e19dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068606Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#743953}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: Ida5215d2f46985370da3407df968673546aab651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066848Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#743952}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b9651c5ec90..7f1834b06ad1 Created with: gclient setdep -r src-internal@7f1834b06ad1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5e5be78bd2c36b1e103363c02855ccfe84c99d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070089Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743951}
-
Ella Ge authored
The |InstallableManagers.icons_| stored in InstallableManager was stored in a map by IconPurpose. We want to change it to stored by usage for the following reason: 1. we only need one icon per usage: primary icon and badge icon. 2. When we add the fetch for splash icon, we may have multiple icons for one purpose: IconPurpose::ANY can for both primary and splash This CL change the |icons_| map's key to a enum class IconUsage, and adds |IconPurpose| to |IconProperty| struct to help check if primary icon needs to fallback from maskable to IconPurpose::ANY. Bug: 1043271 Change-Id: I53717b998c66f3e3d46b63c1716af2b7da695d16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005819 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743950}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icda8343ce61dcd0b5e2cc8876bf13fe2c7dbdf30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067234Reviewed-by:
-
Daniel Libby authored
In fuzzer runs, the CSS parser is invoked with a CSSParserContext object that does not have a Document. There are a few places where the CSS parser uses the context's Document pointer in order to get an ExecutionContext to enable origin trial controlling the exposure of RuntimeEnabledFeatures. This change adds an ExecutionContext accessor to CSSParserContext that will return null when the CSSParserContext doesn't have a Document. R=futhark@chromium.org Bug: 1055119 Change-Id: I394976bd1d4548fd13db1845f0b84b7612076eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069851Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743948}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8c5bd85a9ac2..db63601344ca git log 8c5bd85a9ac2..db63601344ca --date=short --first-parent --format='%ad %ae %s' 2020-02-24 ilkos@google.com Merge "Revert "Add regex matching for the focus"" 2020-02-24 skyostil@google.com Merge "TrackEvent: Add API for querying whether a tracing category is enabled" 2020-02-24 ilkos@google.com Merge "Add regex matching for the focus" Created with: gclient setdep -r src/third_party/perfetto@db63601344ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0c9d1043d0995979a3995e3ee62f8381dcb147bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067233Reviewed-by:
-
Jose Dapena Paz authored
Build error in GCC: ../../services/network/public/cpp/content_security_policy/csp_source_list.h:19:6: error: ‘string’ in namespace ‘std’ does not name a type Bug: 819294 Change-Id: I9c8665050cae038530a79323b65932a124adf2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067074 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#743946}
-
Eric Seckler authored
We're refactoring startup tracing in Chrome, see design doc[1]. With the new startup tracing architecture, each process needs to allocate a shared memory buffer when enabling startup tracing. In the browser process on linux (when the zygote is enabled), this can only happen after InitializeZygoteSandboxForBrowserProcess() is run, because this function forks & may emit trace events in the forked process - which could cause deadlocks or writing to the same SMB from two processes at the same time and corrupting trace data. This patch moves startup tracing initialization until after this point when the zygote is enabled. [1] https://docs.google.com/document/d/1FygJQbD29vMkfVfT7m0Lb1u1zZZU1VgXAPi_R0uBoTw/edit?usp=sharing Bug: 1006753 Change-Id: I21eebfd9196731f810a24e41787c42b66568f3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067075 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Guillaume Jenkins authored
Makes the implementation of the background helper in the WindowsSpellChecker class cleaner by using PostTaskAndReplyWithResult. Currently, a reference to the main thread task runner is passed to the background helper at construction, and the background helper uses it in several methods to post callback tasks on the main thread. With this change, the background helper is simplified and just needs to return results normally. Note that with this change, we lose a little bit of visibility on the fact that the callbacks are run on the main thread. This isn't really an issue because the callbacks don't need to be run on the main thread. The important thing is that COM objects are interacted with on the background thread, and the background helper already enforces that. Change-Id: I86afa6daf6d4e038bd4bdce9a058a9dd6417eed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067263Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#743944}
-
Tim Volodine authored
Add an instrumentation test for the case when max number of redirects is reached using an SXG fallback. In particular the tests ensures that: - the test case does not crash (crbug.com/994439), - the test case results in error page (due to net::ERR_TO_MANY_REDIRECTS). Originally this case resulted in chrome and webview crashes, see crbug.com/994439. Also after the CL in [1] webview will not invoke callbacks (such as onPageFinished, onReceivedError) for this case. This issue is tracked in crbug.com/1052242 and is documented in the test. In more detail the test constructs an SGX with a fallback url and ensures the max number redirects is reached, by redirecting 19 times before loading the SXG. The SXG invokes a fallback url which results in an extra redirect reaching the max number of redirects (kMaxRedirects = 20). In that case the url_loader_ in [2] has already been cleared and is a nullptr. Note: depends on CL in [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2043173 [2] https://cs.chromium.org/chromium/src/content/browser/loader/navigation_url_loader_impl.cc?l=979&rcl=947d318437fdbae52043963f215c9cd409cd2db5 BUG=994439,1052242 TEST=run_webview_instrumentation_test_apk -f ClientOnPageFinishedTest#testMaxRedirect_SXG Change-Id: Ic1e635e37741018d893f9b0807ca0f809d27bbbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057130 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743943}
-
Elly Fong-Jones authored
This change: 1) Removes clumptini, victorvianna, & hhw from flag owners 2) Replaces a few usernames with email addresses when those usernames don't have @chromium.org accounts but *do* have @google.com accounts Bug: 1053302 Change-Id: I0de0409ee84518ee6c10e8be7dac8d0f71664b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065436Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#743942}
-
