- 02 Oct, 2018 40 commits
-
-
Jun Cai authored
This CL removes SensorThread from platform_sensor_provider_win.cc and uses the //base/task/post_task.h APIs instead. Bug: 883877 Change-Id: Icd3632f33e58b2577c2f2d6925d9ce5c3469e4d0 Reviewed-on: https://chromium-review.googlesource.com/c/1246063 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#595980}
-
Karan Bhatia authored
This CL deletes WebRequestEventRouterDelegate and its implementation ChromeExtensionWebRequestEventRouterDelegate. It's only method, NotifyWebRequestWithheld is replaced with a method on the ExtensionsAPIClient. This will make it easier to share the implementation with the Declarative Net Request API. This CL should have no behavior change. BUG=809680 Change-Id: I696dbf8d3a34ae546342eb7ba98a1dd9e26fe3aa Reviewed-on: https://chromium-review.googlesource.com/c/1256218 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595979}
-
Justin DeWitt authored
The country code comes from the first place in the following list with a non-empty country code: * Field Trial parameter "country_override", configurable by Finch server * Finch permanent country, which is updated when the Finch configs are updated (by default once per Chrome version). Permanent country may not be available in the first run of Chrome. * Finch latest country, which is available on every run of Chrome. Bug: 867488 Change-Id: I0e407a50a4020882152dda85935ecf843a000cb0 Reviewed-on: https://chromium-review.googlesource.com/c/1256110 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#595978}
-
Bill Orr authored
This reverts commit 5c87a0a4. Reason for revert: Re-enabling processing of WebVR Origin Trial tokens. BUG=891425 Original change's description: > Remove the WebVR Origin Trial. > > As previously announced (https://groups.google.com/a/chromium.org/d/msg/blink-dev/-s4pWwshKhI/M78h2_scBwAJ), the WebVR Origin Trial is ending after M68 as WebVR is replaced by the WebXR Device API and Origin Trial. > > WebVR can still be manually enabled through chrome://flags. > > BUG=758265 > > Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I752ac8d61c8436abd80a511cc66d4aad502d0245 > Reviewed-on: https://chromium-review.googlesource.com/1144278 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Brandon Jones <bajones@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Commit-Queue: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576732} TBR=ddorwin@chromium.org,dcheng@chromium.org,bajones@chromium.org,billorr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 758265 Change-Id: Ic1be18fa173aa9a5ec90c3f5c8b388cc610c76d1 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1257670 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595977}
-
Khushal authored
This change adds the basic framework for using SurfaceControl to manage the buffer queue for the DisplayCompositor on Android. This includes the following additions. 1) Adding the ABI for loading functions for the SurfaceControl API at runtime in base::android::SurfaceComposer. This allows us to create transactions for presenting buffers parented to the ANativeWindow in the GPU process. 2) Use GLOutputSurfaceBufferQueue to maintain a queue of buffers in the viz display compositor that are sent as overlays to the GPU main thread. This is used based on whether the GLSurface is marked surfaceless, set by the ImageTransportSurfaceOverlayAndroid. 3) Add an implementation of GLSurface for Android which collects a list of overlays to send to the framework and sends it in a single transaction to ensure the updates are made atomically. A few capabilities are missing in the implementation, for instance setting a transform on the overlay, getting transaction acks for correctly synchronizing reuse of buffers, as these are still a WIP on the NDK API. R=ericrk@chromium.org, piman@chromium.org, yfriedman@chromium.org Bug: 889328 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1634e379626ac7b2a08c96dccc6cd767c9dce154 Reviewed-on: https://chromium-review.googlesource.com/c/1250212Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#595976}
-
Mason Freed authored
Previous to this CL, there were corner case crashes occurring when another call to LocalFrameView::UpdateLifecyclePhases needed to call synchronously back to the browser process, for example to gather Font information. In those cases, if CompositeWithRaster was called (synchronously), it would be allowed to run by Mojo, which would cause a re-entrant call to LocalFrameView::UpdateLifecyclePhases. By converting this method to asynchronous, Mojo will block it and wait for existing synchronous calls to complete, avoiding the re-entrancy. Bug: 877093 Change-Id: Ide4036f485662bc576aaf661fb227f59955ac026 Reviewed-on: https://chromium-review.googlesource.com/c/1252141Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#595975}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /remoting. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=joedow@chromium.org Bug: 890902 Change-Id: Ib36073c54837ccd92347d202b539cef688d8402a Reviewed-on: https://chromium-review.googlesource.com/c/1257908Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#595974}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /device. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=reillyg@chromium.org, rkc@chromium.org Bug: 890902 Change-Id: Ic49b7caed2bbc9950b3aa580fea0e79da4043d2f Reviewed-on: https://chromium-review.googlesource.com/c/1257883Reviewed-by:
-
Tarun Bansal authored
Bug: 891458 Change-Id: I261651abb0ecfec9b46fa1a6ee8b269963de9f7e Reviewed-on: https://chromium-review.googlesource.com/c/1258049Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#595972}
-
Robert Ogden authored
The Safebrowsing string is no longer applicable since SB is now available to all users, not just Data Saver users. Also remove the premium services string since this will be moved to the Help Center page instead. Bug: 889684 Change-Id: I974b922d7691bce3ff48640ff91fcf5f5fe645c2 Reviewed-on: https://chromium-review.googlesource.com/c/1257222Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#595971}
-
Fabio Tirelo authored
This was suggested during UI review for finer-grained Autofill settings. Screenshots in the bug. Bug: 891373 Change-Id: Ia14a9573e1ac0ffe010c98c38af7301dfb1b435d Reviewed-on: https://chromium-review.googlesource.com/c/1257624Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595970}
-
Xi Cheng authored
This limits the amount of memory used for unserialized profiles that have been collected but not yet uploaded (e.g. due to being offline). When the number of unserialized profiles exceeds the cap, serialize the new ones to save memory. Code-wise, this CL changes PendingProfiles to maintain two separate vectors for unserialized profiles and serialized profiles, so that we can retrieve the count of each kind of profiles immediately. This CL also simplified the implementation a bit so that struct ProfileState is no longer needed. Bug: 888716, 851163 Change-Id: I177d51065da04789db8d411af8387e08336c2342 Reviewed-on: https://chromium-review.googlesource.com/c/1250144 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595969}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f9c2ea4282f..76c775f48dec git log 9f9c2ea4282f..76c775f48dec --date=short --no-merges --format='%ad %ae %s' 2018-10-02 csmartdalton@google.com ccpr: Fix the path cache on Android framework 2018-10-02 mtklein@google.com Revert "Always include public/include headers for vulkan and just guard src files with SK_VULKAN." 2018-10-02 kjlubick@google.com Fix text on CanvasKit 2018-10-02 mtklein@google.com Revert "clamp gamut if needed in SkConvertPixels" 2018-10-02 egdaniel@google.com Always include public/include headers for vulkan and just guard src files with SK_VULKAN. 2018-10-02 jvanverth@google.com Add some checks to GrDashOp 2018-10-02 bsalomon@google.com Don't crash in aaflags GM if context is abandoned 2018-10-02 fmalita@chromium.org [sksg] Fix inval tracking in Group::removeChild() 2018-10-02 herb@google.com Remove obsolete paint copy 2018-10-02 bsalomon@google.com Add support for per-edge AA to GrTextureOp. 2018-10-02 bsalomon@google.com On ES2 + EXT_color_buffer_half_float cannot render to GL_R16F. 2018-10-02 jvanverth@google.com Add SkImage_GpuYUVA 2018-10-02 bungeman@google.com Remove SK_IGNORE_TINY_FREETYPE_SIZE_FIX 2018-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f1d777c71f03..60be5c45fab2 (3 commits) 2018-10-02 reed@google.com removed dead flag check Created with: gclient setdep -r src/third_party/skia@76c775f48dec The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:862144,chromium:862144 TBR=mtklein@chromium.org Change-Id: I30c571a7c53580dc3962fd943f055b1d3215b5c4 Reviewed-on: https://chromium-review.googlesource.com/c/1257703Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595968}
-
Jian Li authored
Bug: 891084 Change-Id: Ie41ad671edcd94e43ff6f47e08839d736df170a6 Reviewed-on: https://chromium-review.googlesource.com/c/1257673Reviewed-by:
-
Yue Cen authored
Bug: 865797, 889926 Change-Id: I61046742614c58c477036cf259348ce250bd889a Reviewed-on: https://chromium-review.googlesource.com/c/1252843 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595966}
-
Mounir Lamouri authored
Bug: 891455 Change-Id: I3fa228b3ef6946f151510c50137cd3a172d50384 Reviewed-on: https://chromium-review.googlesource.com/c/1257678Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#595965}
-
Stephen McGruer authored
Our guess is that OS_MACOSX is true for ios, but the mojom file here uses is_mac (which isn't true for ios). So the guards on the file are wrong. However the file has existed for months, so it is not clear why it suddenly failed now - hence tentative! Bug: None Change-Id: I721db80c8360fbe2c3461dce28afba9a61344fc5 TBR=ccameron@chromium.org NOTREECHECKS=true NOTRY=true Change-Id: I721db80c8360fbe2c3461dce28afba9a61344fc5 Reviewed-on: https://chromium-review.googlesource.com/c/1258048 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#595964}
-
Tom Anderson authored
Also remove OnMaximizedStateChanged(), OnFullscreenStateChanged() which are no longer necessary. BUG=737995,881371 R=pkasting Change-Id: I1649a19a6b5c4f601789f22c64536e25db25dc87 Reviewed-on: https://chromium-review.googlesource.com/c/1252380 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#595963}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0da73fedd900..df836ff8f17d git log 0da73fedd900..df836ff8f17d --date=short --no-merges --format='%ad %ae %s' 2018-10-02 jmadill@chromium.org Call onProgramExecutableChange in useProgram. Created with: gclient setdep -r src/third_party/angle@df836ff8f17d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I43e9f615a28a394f5c2650c07f886696c8e5a540 Reviewed-on: https://chromium-review.googlesource.com/1257705Reviewed-by:
-
Kelvin Jiang authored
Fix typo occurence with occurrence in 1 file (first change to Chromium!) Change-Id: I6edd6784ffd54a1f4bf0bc056692cfd89ad65ca7 Reviewed-on: https://chromium-review.googlesource.com/c/1257667Reviewed-by:
-
Martin Kreichgauer authored
This changes the counter sublabel for the "passwords and other sign-in data" item in the browsing data deletion dialog to include the number of WebAuthn credentials stored by authenticators built into Chrome (currently this is only the Touch ID authenticator on macOS). The format is: - "None" if neither passwords nor WebAuthn credentials are present - the counter label for passwords or WebAuthn credentials if only one of them is present. E.g., "1 password" or "sign-in data for 3 accounts". - both counter labels separated by "; " if both are present. E.g., "2 passwords (synced); sign-in data for 1 account". Note that while passwords can be synced, WebAuthn credentials cannot. Bug: 879548 Change-Id: I4ea5035841192fce6e185fa4fa4b077986bed041 Reviewed-on: https://chromium-review.googlesource.com/1246822Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#595960}
-
Tommy Martino authored
This CL introduces a new class, AutofillDropdownFooter, to represent the footer in the UI Refresh of the Autofill dropdown. This class is backed by a new XML layout. In addition, the AutofillPopup receives new logic separating out the footer items from the rest of the suggestions, and passing them along to an instance of the new class, if and only if the UI refresh is in use. Bug: 874077 Change-Id: Ia6b28633afabc3c418908efcdde77a52af6fdb0a Reviewed-on: https://chromium-review.googlesource.com/c/1255886 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595959}
-
Raphael Kubo da Costa authored
Commit d1034e1e ("sensors: Make SensorProviderProxy supplement Document, not LocalFrame") tied a sensor's lifetime to a document rather than a frame, but we continued to assume Document::GetFrame() would never return null. This is not true, as evidenced by the crash reports in bug 889754, caused by SensorProxy::ShouldSuspendUpdates() trying to invoke methods on a LocalFrame that can actually be a nullptr. The original backtrace in the bug report seems to come from sensor creation, but it is easier to trigger the same crash with a focus change after destroying a sensor's document's frame. Bug: 861675, 889754 Change-Id: Idb9ed5c18a655e113e2fb76cde6615aeefcc544a Reviewed-on: https://chromium-review.googlesource.com/1256826Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ed6f3571d8a..55b66b22475b Created with: gclient setdep -r src-internal@55b66b22475b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2a5c88f7a759cc2af9f5524b50d04efb26217561 Reviewed-on: https://chromium-review.googlesource.com/1257606Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595957}
-
Eric Orth authored
Only used when explicitly requested. The MDnsClient is created and starts listening for MDNS messages at first use in HostResolverImpl. For now supports only a basic feature set, eg we'll DCHECK if canonname is requested (in contrast to the async resolver behavior that was unnoticed until recently due to the lack of a DCHECK). Bug: 846423 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib296ac432d392baee2454587693b2537513f461c Reviewed-on: https://chromium-review.googlesource.com/1211542Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Lakshmi Kumar Dabbiru authored
Bug: 852904 Change-Id: I5236586d58bea0888964c9f9babc5b1f183768d9 Reviewed-on: https://chromium-review.googlesource.com/1242395 Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#595955}
-
Yue Li authored
Bug: b/113699199 Test: Manual Test Change-Id: If5915651e4a45c6ba0baf2e7c26dbe2a47f7befd Reviewed-on: https://chromium-review.googlesource.com/1255627Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Kyle Milka authored
Remove flag for ntp md ui. Change the new styling to be the default and remove the md class, this mainly affects the fakebox as the icons are styled via md-icons. Bug: 864673 Change-Id: I7eb5da522a657417c527e3aa666bab14f8485bef Reviewed-on: https://chromium-review.googlesource.com/1255600Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#595953}
-
Matthew Jones authored
Previously the BottomSheetController held on to the last activity tab until a new tab was selected. This caused a memory leak if all tabs were closed. This patch clears the last active tab if that tab is destroyed. Bug: 891094 Change-Id: I84343727dba0719792e115675153c8fffba5346d Reviewed-on: https://chromium-review.googlesource.com/1256812Reviewed-by:
-
Vasilii Sukhanov authored
It's a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1256777 Bug: 887914 Change-Id: Ief2696c01ee3ee38e37557ecd3d6be289bbd4986 Reviewed-on: https://chromium-review.googlesource.com/1256970Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595951}
-
Xiaoqian Dai authored
TabletModeBrowserWindowDragDelegate::scrim_ has two uses: 1) to show the blurred background and 2) to work with SourceWindowAniamtionObserver to prevent the dragged window to merge back into its source window during dragging. Since now the blur effect is not needed as more, remove |scrim_| and also modify SourceWindowAnimationObserver to make it work on its own for the purpose 2). Bug: 887739 Change-Id: Ia36ab16a2715fd761ef4fcbaba11559ecdd22f72 Reviewed-on: https://chromium-review.googlesource.com/1257369Reviewed-by:
-
Stephen Martinis authored
Layout test results are now uploaded into a directory indicating which step name they were run as. This is to allow for without patch runs to be recorded for analytics. This CL changes rebaseline_cl to pass the step name when retrieving resuls. Bug: 882946 Change-Id: Iad18ca54cc8804fff76f059ceab49d8c69fadd3e Reviewed-on: https://chromium-review.googlesource.com/1244598 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595949}
-
Bill Orr authored
This change adds infrastructure for the browser process to submit overlays to the XR compositor on Windows, so notifications and prompts can be display in headset when necessary. This adds a concept of a runtime observer in the browser process, so Windows-specific code may hook in to know when a webpage is presenting to a headset, and when presentation has ended. This adds alpha blend support for compositing WebXR and overlays simultaneously. This change introduces VRBrowserRendererHostWin and VRBrowserRendererThreadWin, which are analogues to the Android VrShell and VrGLThread. Finally, this change introduces SimpleOverlayRendererWin, which is throwaway code to demonstrate rendering overlays and submitting them to the XR compositor. In a followup, this will be replaced with rendering through a CommandBuffer so the actual rendering happens in the GPU process. The code is not currently enabled. BUG=819448 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3c790efef66346cb36b8401237efb6ce29fa6e5e Reviewed-on: https://chromium-review.googlesource.com/1237398 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#595948}
-
Xianzhu Wang authored
A clip rect mapped through multiple transform spaces can be (1.99999, 2.00001, 10.999998, 20.000002). Previously we use ToEnclosingRect to convert it to an integral rect and will result a rect that has 1 pixel bigger in some directions, causing incorrect clipping result. Now add gfx::ToEnclosingIgnoringError to convert a near integral gfx::RectF to the nearest integral gfx::Rect. Bug: 879173 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id7ab68c04f8f1efed1dfe1810b82dd24d1a41ea5 Reviewed-on: https://chromium-review.googlesource.com/1252143Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#595947}
-
Jennifer Apacible authored
Change-Id: I4321d6126848c955389512b25d0de55e01debcca Reviewed-on: https://chromium-review.googlesource.com/1249570Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#595946}
-
David Black authored
Per request from UI/UX folks, the Assistant caption bar should have horizontal insets of 8dip to give more separation between the buttons and container edge. See bug for screenshots. Bug: b:115635716 Change-Id: I2edb54e50ea63bbc7a50dd15d1c962c7aa14f7a8 Reviewed-on: https://chromium-review.googlesource.com/1256363 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
erikchen authored
This CL begins the process of removing initialization races from Blink layout tests. Prior to this CL, a newly created main_window_ used a different navigation mechanism than a reused main_window_. The latter would use a navigation with ui::PAGE_TRANSITION_LINK [with an already constructed renderer]. The former would spawn a renderer during the ui::PAGE_TRANSITION_TYPED navigation to the layout test URL. This caused races between IPCs that occur during renderer construction, and IPCs that occur as a result of loading the layout test. This CL doesn't fix these races yet -- it simply converts initialization to use the same mechanism for both cases [using ui::PAGE_TRANSITION_LINK with an already constructed renderer]. Change-Id: I5a21bfdd9a47425f1eb9579235da5ffb4fbc19f7 Bug: 889036, 889952 Reviewed-on: https://chromium-review.googlesource.com/1257683Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595944}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 748bfebd. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." a9d61b8e "Implement RTCIceTransport.onselectedcandidatepairchange" 3e89d0d3 "Revert "Implement RTCIceTransport.onselectedcandidatepairchange"" 8c84af9b "Update beacon WPTs" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25752 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If85537293268a554e41804e862f245a19c0dd349 Reviewed-on: https://chromium-review.googlesource.com/1257144 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595943}
-
Lei Zhang authored
Also remove a redundant entry for page_info_strings_grdp. BUG=397984 Change-Id: If1d5eca82ef556b0fc34cff10c189a550fffef7c Reviewed-on: https://chromium-review.googlesource.com/1255146Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#595942}
-
Stephen McGruer authored
These are flaky consistently and causing trouble for dozens of CLs on the CQ. Bug: 891116 Change-Id: Ib9b82f68e9868d18f05edb59a203ee11f430c8e6 TBR=noel@chromium.org Change-Id: Ib9b82f68e9868d18f05edb59a203ee11f430c8e6 Reviewed-on: https://chromium-review.googlesource.com/1257547Reviewed-by:
-
