- 18 Sep, 2019 40 commits
-
-
Aran Gilman authored
The main consumer of DistillabilityResult on desktop, the Reader Mode icon, updates whenever the user switches tabs. However, the distillability service usually will not run again when the tabs are switched, so the icon will not update if it sees the web contents' distillability only when OnResult() is called. It needs to be retrieve the distillability of a given web contents in between calls to OnResult(), as well as keep track of which web contents the result belonged to. The simplest solution is to store the result in DistillabilityDriver, since it is already correctly scoped to a single web contents. Bug: 952042 Change-Id: I8a8633a52583f04b49298ee5186b24a5eb092fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788498Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#697724}
-
Patrick Monette authored
Bug: 1004324 Change-Id: I85a80a8d590c44f2f23659bbafb79c6c3b83e059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804513 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#697723}
-
Nikunj Bhagat authored
Change-Id: Ib38e214d278c0b4629734e81cb1a473e5b18f5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589363 Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#697722}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7259f61fb600..56f9ee6b49fc git log 7259f61fb600..56f9ee6b49fc --date=short --no-merges --format='%ad %ae %s' 2019-09-18 nicomazz@google.com Merge "Implement android traced_consumer socket comunication" Created with: gclient setdep -r src/third_party/perfetto@56f9ee6b49fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie7c745a0482844fac5bbb6f496035e6577428967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810247Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697721}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/795cab2777e2..377dbef2b5ab Created with: gclient setdep -r src-internal@377dbef2b5ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1005170 Change-Id: I130ff5b06c6483422671e88198fe8380f25af89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697720}
-
Mandy Chen authored
This CL adds the following functions: * Runtime.getResourceURL: returns the request URL given resource name and request base URL (e.g. devtools://devtools/bundle/ or devtools://devtools/remote/serve_file/@010ddcfda246975d194964ccf20038ebbdec6084/) * (Runtime) module: return Runtime.Module object given module name * (Runtime.Module) fetchResource: make a request to load a script of the given name in the current module. This is in the Runtime.Module class so that the request can be adjusted based on if the module is remote or not. We can leverage these functions to request specific files. I'm planning to use them to request the appropriate locale file for lighthouse in the audits worker, e.g. `await self.runtime.module('audits_worker').fetchResource('lighthouse/locales/zh.json')`. Bug: 941561 Change-Id: Ib5c7bfdc46bef7d98533c89b12c7d365d4a26dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784981Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697719}
-
Matt Menke authored
SocketPosix::Close() was freeing the write buffer before destroying a socket. Unclear if this is the cause of the linked bug, but it seems not a great thing to be doing. Bug: 1005042 Change-Id: I2cc35154b6f9de8d272244456eeed5fb9465da4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810321Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697718}
-
Wei-Yin Chen (陳威尹) authored
This should not increase the crash rate. Bug: 718153 Change-Id: I86915c51945db21cd5e528d7270150e648fbfc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810035 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#697717}
-
Adrienne Walker authored
This definitely looks extremely sketchy when reading code. Make the BlobReader owned by a callback itself instead of needing to document everywhere that a raw new is ok because the class is self-deleting. Ultimately, this ends up being the same, but is a readability improvement. Change-Id: I56f19679a97e3bf220a09fc7f84d3772972b52c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804821 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#697716}
-
Antonio Gomes authored
BUG=919392, 787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ie40d53355cbcfeecd65e30f0bd25334e86ebf5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807716 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#697715}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8d5e8816..46e424ec Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I447a153f9a99df61093fa152fd0aba2c01317638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810723Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697714}
-
John Lee authored
The interactions and visual polish of drag and drop is still in flux but this CL adds basic functionality such that TabElements can be dragged to be re-ordered within the tab strip. This CL also only adds support for reordering tabs within the same pinned status. Bug: 989131 Change-Id: I93cd72ea527f53e2973c98ad1739abb11561e285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800914Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#697713}
-
danakj authored
Emulation only changes a few VisualProperties, and then calls SynchronizeVisualProperties(), which is a subset of OnSynchronizeVisualProperties(). This moves code from inside SynchronizeVisualProperties() to OnSynchronizeVisualProperties() when the emulator does not change those values. This helps to clarify which code needs to run from the emulator and which does not. R=avi@chromium.org Change-Id: Ia8253ab6a32d4fd2c5f0b69c1310536d75faa6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809604Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#697712}
-
siashah authored
Bug: 980716 Change-Id: Ib4222f1ab31ed135705a4d3cb3be0531a8ed81a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809408Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#697711}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 6 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-03-15. Change-Id: I865023cb3ea0ddfb0b5e2d88551cc6343cef9aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809418 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#697710}
-
Andrew Xu authored
Two issues are exposed during tests when enabling the scrollable shelf flag: (1) TabletModeController is destructed before ScrollableShelfView. But the pointer to TabletModeController is not checked in the current code. (2) StatusAreaWidget is destructed before ScrollableShelfView. However, ScrollableShelfView relies on StatusAreaWidget during its destruction. The CL fixes those problems. Bug: 973481 Change-Id: I89ff7acab60960939e586a22c09c0b2d65340c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809904Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697709}
-
Matt Jones authored
Change-Id: I60385d89b85ef354e4bf86aa6c1580a6a343d988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797242 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697708}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e3671013e5a1..8391bac5c6f0 git log e3671013e5a1..8391bac5c6f0 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 bsalomon@google.com Add F16Norm mode to viewer 2019-09-18 bsalomon@google.com blurrect_compare GM: draw "masks" in white for RGBA fallback. 2019-09-18 csmartdalton@google.com Weed out duplicates from the proxy version of addDependency 2019-09-18 mtklein@google.com faster PNG encoding in skottie_tool 2019-09-18 csmartdalton@google.com Revert "Use a "decal" domain for filterMaskGPU" 2019-09-18 csmartdalton@google.com Revert "Abolish absClear" 2019-09-18 bsalomon@google.com Use mipmapping/protected to lookup scratch textures. Created with: gclient setdep -r src/third_party/skia@8391bac5c6f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Idf5b5f85bbe4afcdd14d81268b8c2ae219107ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811337Reviewed-by:
-
Matt Reynolds authored
GamepadService maintains a set of GamepadConsumers that are registered to receive gamepad events. In normal operation, ConsumerBecameActive is called when the consumer is ready to receive events and ConsumerBecameInactive is called when the consumer wants to temporarily pause events without unregistering. The |num_active_consumers_| member tracks how many consumers are currently active and should always equal the count of consumers in |consumers_| that have the is_active flag set. If a consumer calls these methods in an invalid order, this invariant may be broken. For instance, calling ConsumerBecameInactive will decrement |num_active_consumers_| even if the consumer was already inactive. This CL enforces the invariant by changing DCHECKs into CHECKs. This also fixes a bug where consumers_.end() may be dereferenced when ConsumerBecameInactive is called for a consumer that was never added to |consumers_|. BUG=998431 Change-Id: I86c53a481601cf05a66b3b0a8b011412660c805e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804379Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#697706}
-
Fredrik Söderquist authored
All calls (one) to SetTargetElement(...) that can set a non-null target are surrounded by calls to Disconnect... and Connect..., so we need not disconnect again inside SetTargetElement(...). Similarly we can't get to NeedsToProgress() without having a valid target (DCHECKed in SMILAnimationSandwich::UpdateTiming). Bug: 998526 Change-Id: I73028646021ce6be2169194d6d371f43e19f0c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810978Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#697705}
-
Ted Meyer authored
This will help us debug _why_ certain D3D11 calls in DXVA are failing. Change-Id: I0e05f87c9411d0ff973a7074908b1ddd58f82416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809556Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#697704}
-
Robert Ogden authored
Plenty more clean up to do after this, but this is a start. Bug: 1005295 Change-Id: I35e89e0a25aa2eee3f6129158f0b1a5f5c47b6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810769Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#697703}
-
liberato@chromium.org authored
It turns out to be very convient to have the LearningTask on the client side of the mojo connection. This CL allows us to specify a LearningTask during construction of the client, that is returned by GetLearningTask. Change-Id: I41e852f338dcbeed26a2a20022e8ceaa5226a649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809891Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#697702}
-
Khushal authored
We currently ignore overlay video enabled when SurfaceControl is enabled, because we never expected it to be used when this feature is enabled since video overlaying is done using the SurfaceControl API in the GPU process. But AR will be using a similar approach for overlaying WebGL based content composited in the browser process using a seperate Dialog. So fix the above by always respecting that bit, even if SurfaceControl is enabled. Also respect the |mAlwaysTranslucent| bit used on low memory devices. The expectation for using a RGB_565 format in the compositor which affects this decision also apply to the SurfaceControl case. Also ensure that if the compositor is using the alpha channel when drawing the primary plane, then it is not marked opaque. R=dtrainor@chromium.org Change-Id: I95bb5603e9e21f0b0e4cb94bbfb56e5443952d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801753 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
Antonio Gomes authored
Now that their solely client [1] has been Onion soup'ed, it is possible to bypass (and remove) these helpers in favor of accessing blink::RtcVideoDecoderFactory's and RtcVideoEncoderFactory's ctors directly. [1] //third_party/blink/renderer/platform/peerconnection/video_codec_factory.cc BUG=787254, 919392 Change-Id: Ieb090709080de71fb98d8b2be68afa57ad88fee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807714 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Sebastien Marchand authored
The bug causing TabLifecycleUnitTest.CannotFreezeOrDiscardIfConnectedToBluetooth was due to the test running right before it, which was modifying a global state without resetting it to the proper value. Bug: 1004578 Change-Id: I0c8fa306e0d2f40911c18de52c062352d380fb5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808335 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#697699}
-
Tarun Bansal authored
Add experiment to preconnect to predicted redirect target. The redirect target is returned as part of loading prediction by the loading predictor. Change-Id: I9e00363db609470d92dd5f2196aad71868dc68ed Bug: 983234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699738 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Eric Karl authored
Change-Id: I2249d8380a3c46764476d5ec59aec65705c4344d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809114 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#697697}
-
Maksim Ivanov authored
Refactor the SystemTokenCertDBInitializer class to live in its own .h+.cc files, rather than being defined inside the already heavy chrome_browser_main_chromeos.cc. Other minor changes made there: 1. Removed the Initialize() method, and added a ShutDown() method (the latter will become non-empty in a follow-up CL:1796426). 2. Replaced base::Bind/base::Callback with their modern Once/Repeating analogs. Bug: 725500 Change-Id: Ia172f3cf1e049171914f5fd251a8cc88f6643e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806859 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#697696}
-
Connor Clark authored
Bug: 1004875 Change-Id: I3fc4cc0d6fdaaa366bfb20b95ab7d79049b3c21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809102 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change implements base::CheckedRandomAccessConstIterator in terms of base::CheckedRandomAccessIterator, while still allowing safe conversions between iterators. Bug: 817982, 828324 Change-Id: Ibc3a80cf01e30fc60b33c4c92324a728b8635cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807331 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#697694}
-
Brandon Wylie authored
This is to comply with the new presubmit rule which enforces the following keyword order: public protected private abstract default static final transient volatile synchronized native strictfp Bug: 1003711 Change-Id: I6b2d98814427b9e9c14b8d705a4a8a114aac2c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810018 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
Matt Simmons authored
Add vertical space below MV tiles. R=yusufo@chromium.org Bug: 985386 Change-Id: Id72f1339c9150530248173e5a9dc4bec6681fc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808792Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#697692}
-
Jae Hoon Kim authored
This creates the DlcserviceClient to call into dlcservice daemon's exposed DBus API. The dlcservice daemon provides management of DLC (Downloadable Content) modules. Exposures from DlcserviceClient is to allow for Install/Uninstall/GetInstalled in a manner that wraps the respective DBus API exported from the dlcservice daemon in a Chrome style callable interface. Information on building a DLC and how what dlcservice daemon is can be followed at: https://chromium.googlesource.com/chromiumos/platform2/+/HEAD/dlcservice Bug: 1000711 Test: autoninja -C out/Default chromeos_unittests && testing/xvfb.py out/Default/chromeos_unittests --gtest_filter=DlcserviceClientTest* Test: autoninja -C out/Default unit_tests && testing/xvfb.py ./out/Default/unit_tests Test: autoninja -C out_${SDK_BOARD}/Release chrome nacl_helper && deploy_chrome --build-dir=out_${SDK_BOARD}/Release --to=$TEST_IP Test: modifications to actually call into to DlcserviceClient with nebraska.py as payload path server. $> restart ui Test: Custom CHROMEOS_AUSERVER within /mnt/stateful_partition/etc/lsb-release on DUT with local nebraska.py port. Change-Id: Ia269cab18d7fcc4c1c6d0ee72fb3383b11af38a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802682 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697691}
-
Adam Ettenberger authored
This is CL [1/4] in a series of CLs to expose "display: none" elements to the browser process AXTree. 1. Add and improve tests for CSS display and visibility. 2. Introduce new command line flag and chrome://flags entry. 3. Update AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree and relevant logic for the feature to work, disabled using the feature flag. 4. Enable the feature in tests; update expectation files. --- In this change I added the following tests : * DumpAccessibilityTreeTest.AccessibilityCSSDisplayToNone * DumpAccessibilityTreeTest.AccessibilityCSSVisibilityToHidden * DumpAccessibilityTreeTest.AccessibilityCSSVisibilityToCollapsed * DumpAccessibilityTreeTest.AccessibilityCSSVisibilityToVisible I also updated the following html files : content/test/data/accessibility/css/display-to-block.html content/test/data/accessibility/css/display-to-inline.html The reason I updated these html files is so that... 1) Each related test file has comparable layout and WAIT-FOR behavior 2) Once the feature is enabled, the WAIT-FOR will flaky fail because exposing the node in the tree may trigger WAIT-FOR before the script has a chance to modify the accessibility tree. Bug: 651614 Change-Id: I501086047de409a8544f5ff8937d7ebd422fed13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809454 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#697690}
-
Henrique Nakashima authored
Clank HOA Lite specifies features should be in chrome/browser rather than chrome/lib. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1801803 with the following changes: https://chromium-review.googlesource.com/c/chromium/src/+/1810767/1..2 This fixes a jni header include which should have been changed in the original CL to point to the new location. CQ bots missed this because the generated header persists across builds in the wrong location, even though it was now being generated in the new location. TBR=yfriedman@chromium.org,wylieb@chromium.org,wnwen@chromium.org Bug: 995916 Change-Id: I4915d2a52a7d877c35486b83fa5d31b840ba5d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810767Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697689}
-
Ian Struiksma authored
Following up after https://crrev.com/c/1787406 appears to have fixed idle paint issue by enabling 3 disabled tests: accesscorrections jetspizza star_city_games Bug: 993044 Change-Id: I005f0c722b9168a32579b2aafcb851e763105e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808425 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#697688}
-
danakj authored
Page zoom level is a page/view concept, but the code to manage it is currently in RenderFrameImpl, though only run when it is the root frame. This doesn't dramatically change ownership of responsibility but moves the code up into RenderViewImpl. RenderWidget still goes through RenderFrameImpl (though more explicitly) to set the zoom level on the RenderView. And RenderWidget takes responsibility for closing the page popup instead of having multiple "set page zoom" methods on RenderViewImpl. This uncovered some spooky action-at-a-distance and makes it more explicit and documented, though no less unfortunate. A local root LocalFrame does not initialize with the correct page zoom value because it has no parent to read it from. We (accidentally?) worked around that by setting the RenderView's page zoom to its current value when navigating a (new) LocalFrame, which would call into blink's WebView and walk through the entire frame tree setting the value on everything, eventually also on the new LocalFrame. Now on navigation, for a local root, we call RenderWidget's UpdateWebViewWithDeviceScaleFactor() which does the same thing by re-setting the WebView's page zoom factor. This was done when making a new main frame in multiple places (RenderView and RenderFrame both called it in the same CreateFrame() callstack). Now it is consolidated to a single place on navigation for the main frame and child frames giving them more consistent behaviour, and going explicitly through this method that should go away if things were well designed, rather than re-setting the RenderView to its own value. Remove calls to UpdateWebViewWithDeviceScaleFactor() scattered throughout RenderViewImpl and RenderFrameImpl. What we need is for 1) The Page to be updated with PreferCompositingToLCDText when the device scale factor changes. 2) The WebView to be updated when the device scale factor changes. 3) The LocalFrame of a local root needs its page zoom set by poking the WebViewImpl to walk through all frames and set it. R=erikchen@chromium.org Bug: 419087 Change-Id: I97c0e287be8f96a4ac632d63b981c190169dc1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799386Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#697687}
-
Dominic Battre authored
This experiment did not provide data indicating that we want to launch it, so let's make sure that it does no remain as an active experiemnt in fieldtrial_testing_config.json. Bug: 966406 Change-Id: I70a46f6234137fdfe696b738f3fa3b7b109b1a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807324 Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8c80da317efc..7259f61fb600 git log 8c80da317efc..7259f61fb600 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 fmayer@google.com Merge "Use GetTestDataPath for tests." Created with: gclient setdep -r src/third_party/perfetto@7259f61fb600 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib56de7b4ab6fe4a53910c65e2d7078d6c6335425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809888Reviewed-by:
-
