- 23 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/751a6ed6316a..f28949d69964 2020-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib97faabc4a435b01c0266c08842b60905b3c8581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820485}
-
Collin Baker authored
Bug: 1133016 Change-Id: I4c33d871f13d888392c293a9d4197378d2b82698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473537 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#820484}
-
Darin Fisher authored
This CL changes NativeDesktopMediaList to no longer assume that CaptureFrame completes synchronously. This means changing the code to wait for OnCaptureResult before calling CaptureFrame again. DCHECKs are added to DesktopCapturerLacros to guard against such misuse in the future. Bug: 1141483 Change-Id: I579dd0f5ea8bef9a02c7be6d3dead23805601038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492940 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820483}
-
Jeffrey Kardatzke authored
The USE flag for CHROMEOS_PROTECTED_MEDIA will be turned on before we have encrypted content handling done here, so reject that config in all cases until that is done. BUG=b:153111783 TEST=Builds Change-Id: Ibcd83a91ab83ef30afd01bbe7db6b5c792f474a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495801 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820482}
-
Eugene But authored
Also updated callsites to use -[EarlGrey rotateDeviceToOrientation:error:]. Old method was needed to support EG1 tests, because EG1 did not have rotateDeviceToOrientation:error: method. R: zhaoyangli@chromium.org Bug: 1017281 Change-Id: Ia7a016f3c78e3ee550dda4a5d4cf00e3a15ac312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495602 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#820481}
-
adoneria authored
script_test template. It will be used to pass arguments to the test target for test run via typ. Bug: 1141577 Change-Id: I11582b6e97d0dd088ededf5bd61247ee6ecfa3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493368Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#820480}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 82982a2b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I9bbd812f848d0b653e1f53aee6734674558642a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495643Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820479}
-
Eugene But authored
Also updated callsites to use -[EarlGrey isKeyboardShownWithError:]. Old method was needed to support EG1 tests, because EG1 did not have isKeyboardShownWithError method. Bug: 1017281 Change-Id: I78f69b868b45ed34e4fd35b031ca7a1897fffdd3 R: zhaoyangli@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495330 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#820478}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I728bd3a60556d43f65fde9763dcf21b7947626ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495349Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820477}
-
Shrek Shao authored
New UKM metrics Request doc: go/client-rendering-api-ukm-review Add collections for Canvas/OffscreenCanvas context type: 2d, bitmap, webgl, webgl2. Tested locally with canvas.getContext and chrome://ukm WebGPU context is not added yet in this patch as it's not associated with canvas. Bug: 1135706 Change-Id: Ib6c15629e5f69f3be554e1614351b815e15a6c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473043 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#820476}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/867ef5f63787..d84ef00c9666 $ git log 867ef5f63..d84ef00c9 --date=short --no-merges --format='%ad %ae %s' 2020-10-23 haoyuewang Reduce QuicConfig size from 1432 bytes to 1160 bytes by better padding. 2020-10-22 mattm Add QuicConnection::HaveSentPacketsInCurrentKeyPhaseButNoneAcked method. 2020-10-22 quiche-dev Rename SpdyHeaderBlock to Http2HeaderBlock. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ibfad65022d1065dab86862d12aff144d3478c422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495263 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#820475}
-
Vidhan authored
Bug: 904390 Change-Id: If057d964a0e4224233aa074b6172b98793cae98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494812Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#820474}
-
John Lee authored
The WebUI tab strip is a tab strip built using JavaScript. It allows users to drag tabs, and to do so, it relies on JS drag events. The JS checks the dropEffect on a DragEvent's dataTransfer object to determine if a tab was moved. This CL overrides the dropEffect to `move` when dragging a tab using the WebUI tab strip to allow the front-end to correctly catch cases in which a tab is dragged into its own window. Bug: 1081905 Change-Id: Ief542c8eeb15a8324efbcc26cbde366ad84ba029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488741 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#820473}
-
Allen Bauer authored
Updated LabelButton to subscribe to the callback rather than overriding the virtual. Bug: 938501 Change-Id: I8063618a2f8d3b3b2903281cd59ca5449e051dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495828 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820472}
-
Jazz Xu authored
This CL adds feature param to control default pin state for the experiment. Change-Id: I42f8244adfc5f8fb5a195f7a5243314864cd57a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488721Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820471}
-
Antonio Gomes authored
It is not needed to include any //ui/aura headers. This CL will make //ui/ozone/platform_wayland depend on //chromeos/ui/base more easily. BUG=1113900 R=jamescook@chromium.org Change-Id: Icc30e4cf93955abc4be6add8d882ccfbf5c7e338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492565 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#820470}
-
Wei Li authored
These buttons are subclasses of ImageButton or LabelButton. Since they didn't set their focus behavior, they inherit the beahvior. This CL uses DCHECK to assert such behavior, and set the behavior explicitly. So when we change ImageButton and LabelButton's focus behavior later, these buttons won't be affected. Bug: 1001103 Change-Id: I88675c772b83348f68234d588a3c3884387fea84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495820Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#820469}
-
Robert Sesek authored
Also crash on sysctl-read failures. Bug: 1126350 Change-Id: I9d69c69979ab076e257ca079f6e5f09aed5c28be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493440 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#820468}
-
Dana Fried authored
This CL moves the logic for calculating size and placmeent and for drawing the "New" badge into any View. It also provides (as a convenience) a drop-in version of Label that displays a "New" badge that can be used in almost any situation a plain label can be used. Bug: 1055150 Change-Id: Ib9227c9dfc630eb0c03650adf5b8f177a086b431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486575Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#820467}
-
Max Curran authored
As part of the refactor and improvements to Translate's metrics, added two UMA histograms related to TranslateRanker. This information will eventually be logged in UKM as well. Updated TranslateRanker's unit tests and added unit tests for TranslateMetricsLogger to confirm that the metrics are recorded as expected. Full Design Doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing Bug: 1114868 Change-Id: I56ea8fc167599688596da015cef00454790f991c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481472 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#820466}
-
Lei Zhang authored
It's been replaced with LOGGING_NUM_SEVERITIES. Bug: 849450 Change-Id: Ib43718d39a8d171a53e88d6d51942d28f42b7585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494504Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820465}
-
Chait Pinnamaneni authored
Original PR https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841 Bug: 1137050 Change-Id: If9bc0044ad01654eb4a92f81acd28d346ab291d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495786Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820464}
-
Steven Bennetts authored
Static IP configuration for Cellular networks does not work and can only break things. Bug: 993587 Change-Id: I734c25ccabd5330134aa59be9eea04f3dc6ad0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495704 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#820463}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/42c17639..c572b425 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie07fa49ce28eecad493eff84d3a92452e7232393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495247Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820462}
-
Scott Violet authored
BUG=1141927 TEST=test only change TBR=xdai@chromium.org Change-Id: I150f47081d1d88afc15c0c90f7f1fc6c333aee48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495831Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820461}
-
Liquan (Max) Gu authored
Context: Currently, //components payment targets depends on //chrome resources ic_edit_24dp.png, product_logo_name.png, fre_product_logo.png. It's because the payment view templates depend on them. This CL is written to break the dependencies. Changes: * this CL changes to set fre_product_logo and product_logo_name programmatically from //chrome, from having them referenced in //components templates. * ic_edit_24dp.png is moved from //chrome into //components Before: The two //components xml templates depends on the //chrome resources ic_edit_24dp.png, product_logo_name.png, fre_product_logo.png. After: No //components payment targets depends on the //chrome resources. Bug: 1141076 Change-Id: Idea99bdb55d1dd633a540eee4d2db27e2c471634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490162 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#820460}
-
Joe DeBlasio authored
This CL re-arranges some early-abort behaviors to avoid calling GetDomainInfo() when possible, since GetDomainInfo() is very expensive. This is a pretty small change that'll hopefully help some performance regressions. A better long-term way to make a difference is to put off the expensive parts of GetDomainInfo, possibly by lazily populating the IDN-related parts, until needed. I might give that a shot in a follow-up CL. Bug: 1135279 Change-Id: Iaddc566274501501a7d8a141bc58c21639ee0f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495611 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#820459}
-
Austin Sullivan authored
Bug: N/A Change-Id: I2fa776ab02969c19fec3cc1bffd0745a181da598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488393Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Auto-Submit: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#820458}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1bec20b5b70c..3691164b7e2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sky@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sky@google.com,mohsen@google.com Change-Id: Ia54a6ddcbb17f39c8a1dd734de351d8898db8a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495050Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820457}
-
Dana Fried authored
This change switches the extensions menu to enable focus traversal at the focus manager level, allowing both right/left and up/down key traversal. It also removes BubbleDialogDelegateView::EnableUpDownKeyboardAccelerators() - which is only used in one other place - in favor of FocusManager::set_arrow_key_traversal_enabled(), which also supports left/right arrows and pre-exists the bubble dialog method. These changes mean that when the scroll pane is active in either dialog, up and down will scroll the pane but left and right arrow keys will still allow the user to traverse the dialog (at least on Windows and Linux; on Mac, up/down may still work within the pane). Bug: 1140632 Change-Id: I8ea5bc79e9b9ed2595e9503be1221843c50a7b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487904Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#820456}
-
Jeffrey Kardatzke authored
Expands testing in a few ways: 1. Adds an additional test file to fully parse. 2. Checks validity of parsed fields in SPS. 3. Adds a fuzzer (it even found a bug already). BUG=chromium:1141237,b:153111783 TEST=media_unittests pass, fuzzer builds/runs Change-Id: I3036c2e28466e460ba35647bea38fd53d491b844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495344Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#820455}
-
Eric Orth authored
Change the return type of DNSDomainToString() to base::Optional<std::string>, so it can return nullopt on malformed and empty string on root. This is needed because HTTPS records can have root names in some cases, so we need to be able to differentiate that from actual malformed names. While messing with the method interface, also fixed the camelcasing in the method name, and changed the type to StringPiece value instead of the unnecessary const&. A subsequent CL will have more substantive fixes to make DnsDomainToString() stricter to the standards validations we need, but I wanted to get the mostly-mechanical stuff out of the way first in a separate CL. Bug: 1138620 Change-Id: I23d092051fe48826972a5fb5b3279dedf473ee1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495296 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#820454}
-
Bruce Dawson authored
When running blink web tests it is important to invoke the wrapper script (run_isolated_script_test.py) with vpython or else psutil and six will fail to import. This change wraps the import of psutil and six in an exception handler so that a useful error message can be printed. This should make it easier for users to find the correct solution. Change-Id: Ia2712e97790d8b54bb9cc640ace37a0fe01ce1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495868 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820453}
-
Lei Zhang authored
Bug: 646113 Change-Id: If54ca0e37d47fcd40ac4abab7f0f586c31c0640c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483028 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820452}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/530933006d3c..42a741a2145c 2020-10-23 robertphillips@google.com Allow vertex data to be stored in the thread safe cache 2020-10-23 jvanverth@google.com Add control to toggle immediate/delayed MTLDrawable acquisition 2020-10-23 kjlubick@google.com [canvaskit] Use portable fonts for GMs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: egdaniel@google.com Change-Id: I0d79db5a392a394d65b335e9d9acde044c3ed1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495295Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820451}
-
Nate Chapin authored
HID becomes a Supplement<Navigator> instead of an ExecutionContextClient. This means it retains a references to the Navigator, which is itself an ExecutionContextClient, so it still has access to the ExecutionContext. Change-Id: Ie1d789fb6588c816f39c5b0645d1973aee43caef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495503 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820450}
-
Lei Zhang authored
Mechanically convert OneArgument(std::move(value_unique)) to OneArgument(base::Value::FromUniquePtrValue(std::move(value_unique))). Bug: 1139221 Change-Id: I0d7bbfebc3d4397bfef68e77fb1b09bffa4bb696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473502 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#820449}
-
Vidhan authored
Bug: 1127001 Change-Id: Ic565865326ca4d75ed5c21e34bc2ca207f1f5c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404640Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#820448}
-
Victor Costan authored
Change-Id: I07613815b937259cac8a4ffe9128740a3877a0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496020 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820447}
-
cfredric authored
MakeURLRequestContext. Change-Id: Ib70802646e93f7f03d26d0db5a708193db94b4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495291 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#820446}
-