- 01 Oct, 2019 40 commits
-
-
Stepan Khapugin authored
Adds |window| property to SceneState. It is backed by SceneDelegate's |window| property and by UIWindowScene's |scenes| property on iOS 13 with multiwindow; or with an ivar otherwise. When it's an ivar, SceneController is now responsible for window creation. Note that the getter for AppDelegate's window remains for iOS 12 compat. Note that the window is always a ChromeOverlayWindow. have tested it manually on my machine and it still works) Bug: none Test: verify that the incognito screenshot blocker works as expected (I Change-Id: Ic418ece228854e43aa0e4c9d9e503c1b54bca901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827373 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#701569}
-
Evan Stade authored
The passed profile always matches |profile_|, so just remove it. Bug: none Change-Id: I29940c6ab54e9e9dbd7b1ed1833ab8893a2212d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832611Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#701568}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/94c47dd3da78..b689fa536c9b git log 94c47dd3da78..b689fa536c9b --date=short --no-merges --format='%ad %ae %s' 2019-10-01 fmayer@google.com Merge "Add heap_graph_object table." Created with: gclient setdep -r src/third_party/perfetto@b689fa536c9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I99f39bfb93b4bbee5a3ccc61316af247f6aff071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833063Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701567}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1001364 Change-Id: Idf5ae6d99e038d159794e0cf18f9261d6d464c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833283Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701566}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f85c9327..cf9b9029 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I75a09ff4f6ccb454fb1f168cca20d9aaeab8824e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833661Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701565}
-
Matt Falkenhagen authored
This will make it easy to test the feature on Android without needing a command-line flag. Bug: 824858 Change-Id: I26736f1c2edbad635d9030f9d35939ace6daa799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833026 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#701564}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1009287 Change-Id: Ic32dd467368d3afbf9fe4ee567aecca33c8f8b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832690Reviewed-by:
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1009182 Change-Id: I3960639b4f48a33cb4836d2e394bcb11bdb00245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832990Reviewed-by:
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010032 Change-Id: I2399f478fca573cd0c9ebd8666c8832f072228f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832989Reviewed-by:
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/accelerated_widget_mac to the recommended methods/types. Also change PumpableTaskRunner::EnqueueAndPostWrappedTask to take the task as an std::unique_ptr<WrappedTask> to remove usage of base::Owned() and remove a naked "new". Bug: 1007844 Change-Id: I893b7d83715ed960898034608ea83afb39c7efe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833462 Commit-Queue: ccameron <ccameron@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#701560}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/android to the recommended methods/types. Bug: 1007845 Change-Id: Ia401c734f7530732917c94f7dea6359200f34199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833461 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#701559}
-
Darin Fisher authored
This CL introduces a new version of WindowToViewportScalar that takes a LocalFrame parameter, marks the existing version as deprecated, and adds one caller to the new version. The new caller is DataTimeChooserImpl, and that change is what fixes bug 1006919. What was happening before is that in the context of an out-of-process subframe, WindowToViewportScalar was not finding a LocalFrame for the top frame. It would then bail out early, not calling the appropriate WebWidgetClient method. Hence, the error reported in the bug. A follow-up CL will migrate the rest of the callers over to the version of this method that takes a LocalFrame parameter and remove the other. Bug: 1006919 Change-Id: I04bd2fa80abed139b90a42b81668bcc3aba8f967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831447Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#701558}
-
Joonghun Park authored
Blink doesn't have table wrapper box currently while Gecko has it, so this CL tries to mimic the behavior that clientWidth/Height refers to table wrapper box which doesn't have borders applied to itself and table grid box has the borders. This CL adds table's border sizes to clientWidth/Height at |LayoutBox::PixelSnappedClientWidth/Height|. As a result of this CL, table's clientWidth/Height and offsetWidth/Height are equal now, respectively. The corresponding csswg discussion is https://github.com/w3c/csswg-drafts/issues/4245. Bug: 560528, 978019 Change-Id: I2693eaf38b882fe4a41f931ec1312ecf53352f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763510 Commit-Queue: Joonghun Park <pjh0718@gmail.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#701557}
-
Raul Tambre authored
This change is backwards compatible with Python 2 and functionally equivalent. Traceback (most recent call last): File "../../base/win/embedded_i18n/create_string_rc.py", line 601, in <module> sys.exit(main()) File "../../base/win/embedded_i18n/create_string_rc.py", line 578, in main mode_specific_strings.itervalues().next().iterkeys()] AttributeError: 'dict' object has no attribute 'itervalues' Bug: 941669 Change-Id: I2d26e810bf98840cdae46c0a0de249bf0b19f5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829208 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#701556}
-
Lily Chen authored
This change switches http://google.com to https://google.com in the GaiaCookieManagerService. This is for the purpose of fixing the DiceBrowsingDataRemoverBrowserTests, which otherwise fail when the test cookie is made Secure. This test cookie must be made Secure because it is set with SameSite=None, which under the upcoming SameSite changes (see crbug.com/1002052) means the cookie will be rejected unless it is secure. Bug: 1006816 Change-Id: I2c5b5dd393c8547dbdacb832fb1447090a00a6a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829672 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#701555}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010031 Change-Id: I9ad685d4f58729f3ac6296e3aa7297c315261660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832987Reviewed-by:
-
Xiaocheng Hu authored
Now that we support non-calc math functions in 'sizes' attribute, the name SizesCalcParser is no longer accurate. Hence, this path renames it into SizesMathFunctionParser. Bug: 825895 Change-Id: I8f995298af0495c50822fd6addebd0d437dccaf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832701 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#701553}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010027 Change-Id: If748a3342be75e72b79a4b989a9af131847e6a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829786Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7b6d6034. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" ab4b7009 "[Native File System] Aborting a directory iteration succeeds" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I833c008e0946657834e5b9d3a93319b45aa70ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833522Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701551}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010025 Change-Id: If9f84e7040efe3e7e0b41310805764a102b392dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833482Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/94a459c0b4c7..dba6e775bc2b git log 94a459c0b4c7..dba6e775bc2b --date=short --no-merges --format='%ad %ae %s' 2019-10-01 vapier@chromium.org cros_build_lib: run: drop unused stdout_to_pipe 2019-10-01 mmortensen@google.com Update generated proto api for sysroot_pb2.py. 2019-10-01 ahassani@chromium.org vm_test_stages: Use cros_au_test_harness.py instead of ctest.py Created with: gclient setdep -r src/third_party/chromite@dba6e775bc2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6ebd2e773d107292149a1a46792d2d2cd4cc04e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833112Reviewed-by:
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010020 Change-Id: Ia15694adcd86238dd59b7775d9d6a25ee3d2cfcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833118Reviewed-by:
-
Kush Sinha authored
Active Directory's account reconcilor currently gets instantiated for all Active Directory enrolled devices for which Chrome OS Account Manager has been turned on. But we have a pending bug (https://crbug.com/1008349) which makes the usage of Chrome OS Account Manager on Active Directory devices a bit buggy. Fix the initialization condition to check whether Chrome OS Account Manager is available for the session, instead of checking for the flag. Bug: 1008349, 993317, 1009960 Change-Id: I50725523a8315ae07ae6ce04cbc30414cd7cca1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832268 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#701547}
-
Xida Chen authored
There is already a rotate-interpolation.html under wpt/. This CL adds more test cases to it. Bug: 900581 Change-Id: I4bfc7678d2ec266e243394f4886c0ad7f03497d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832561Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701546}
-
Henrik Boström authored
It's flaking on various platforms. See bug. TBR=qinmin@chromium.org, xingliu@chromium.org NOTRY=True Bug: 1009913 Change-Id: I7d2be8e07d45e00bf427ece5d4c46b1a8655e166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832214Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701545}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010020 Change-Id: I6f78af68ae006d29e991b180adadc347170224a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833116Reviewed-by:
-
Sam Maier authored
Built-in Robolectric test runners require knowledge of where our resource apk is in order to run with binary resources mode. This change gives all junit_binary targets a .properties file that Robolectric uses to provide the location of this resource apk. Bug: 1008309 Change-Id: Ie80bb1f5a927b254c08b4aed8c30630e24dc6000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829472Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#701543}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010016 Change-Id: Ifff6105c6f46a35d8248f1c5c70237a104e8d714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833311Reviewed-by:
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010013 Change-Id: I4b1eafd67d1ade9665776d5adf02ab716501dd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833310Reviewed-by:
-
Mohamed Abdelhalim authored
This is the 9th CL of multiple CLs to remove the usages of NavigationHandleImpl completely and replace it with NavigationRequest. This CL completely removes NavigationHandleImpl and now NavigationRequest implement NavigationHandle. Bug: 995268 Change-Id: Iddb81aa13135ee630a189c165a9cfb087e99e1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816469 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#701540}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2f7d7794719a..b3bb2040a15c git log 2f7d7794719a..b3bb2040a15c --date=short --no-merges --format='%ad %ae %s' 2019-10-01 philipel@webrtc.org Remove unused RtpFrameObject ctor. Created with: gclient setdep -r src/third_party/webrtc@b3bb2040a15c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I6322abde14b9d7d3bd8a0d39c18e97b3142b2f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833115Reviewed-by:
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010007 Change-Id: I5ad7138904fad9b5787e088dcf0db80b0215e399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833244Reviewed-by:
-
Maksim Sisov authored
GetWorkspace is a Linux and X11 specific feature. Wayland does not seem to support that (at least, I could not find anything, and it looks to be natural as Wayland does not provide clients with positions of their windows). Also IsVisibleOnAllWorkspaces and SetVisibleOnAllWorkspaces have been moved from DWTHX11 to DWTHLinux and the interfaces are declared in the PlatformWindowLinux now. Bug: 990756 Change-Id: Ib9a342623a0db2985e7041fa287d0c4c6fd76be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831898Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#701537}
-
Xiaocheng Hu authored
This patch supports parsing 'clamp(MIN, VAL, MAX)' into a CSSNumericValue via the parse() method. This was missed in the previous implementation of clamp(), and should be the last missing piece of the implementation. Bug: 825895 Change-Id: I6da8113d62b1416dc6d3521b58134932b257ca62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832147 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
As CSS comparison function implementation is done, this patch is part of the cleanup work that finishes the TODOs left behind. Bug: 825895 Change-Id: Ibd03d10591fdc1923ab34908126521eda27fa444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831993 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Arthur Hemery authored
Currently, we simply store the RenderFrameHost when caching a page in the BackForwardCache. We need more than just a RenderFrameHost however, so we introduce the concept of a BFCache Entry, that encapsulate everything we need to store and restore. This patch makes RenderFrameProxyHosts part of an entry, as the first extra state we want to preserve. Design doc for the proxies: https://docs.google.com/document/d/1EhTp7Tz0sd0e3Fgtjrx1b28kx5ULL7CjIwDsoS7GirI/edit?usp=sharing Bug: 990816 Change-Id: I821b484c9899c0f0e5a2fc76586331c9d57a5962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738451 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#701534}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a39aa78ade7b..563255c6577d Created with: gclient setdep -r src-internal@563255c6577d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: If4297af70841093d12fe2ec78edb93e706570cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833113Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701533}
-
Xida Chen authored
Crashes on win TBR=hbos@chromium.org NOTRY=true Bug: 1010000 Change-Id: Iad6d7c4fb09568baa46291d1aa027ba50a4be434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833309Reviewed-by:
-
Lowell Manners authored
TBR=vakh@chromium.org Change-Id: If78de3f54944ae0aed101c7ca692bdbe5d2d308c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827280 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Shimi Zhang authored
These two functions need to be abstract. Bug: 1004544 Change-Id: I893a47747333d6e39a6855cb7e3627a0ea6a8e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829874 Auto-Submit: Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701530}
-
