- 29 May, 2013 40 commits
-
-
thestig@chromium.org authored
Formats from Canon, Fuji, Minolta, Olympus, Panasonic, and Sigma. BUG=165598 Review URL: https://chromiumcodereview.appspot.com/15875004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202800 0039d316-1c4b-4281-b951-d872f2087c98
-
umar.hansa@gmail.com authored
BUG=243208 R=dbeam@chromium.org Review URL: https://chromiumcodereview.appspot.com/15823004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202799 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
Original patch broke SelectFileAndOpen browser test. This is because Files.app notify 'selection-change-complete' to the tests even if the selection is empty. This CL is fixed the problem by adding a check of the number of selected items. Previously reverted CL: crrev.com/15950003 BUG=243687 TEST=browser_tests Review URL: https://chromiumcodereview.appspot.com/15808007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202798 0039d316-1c4b-4281-b951-d872f2087c98
-
yoz@chromium.org authored
http://i.imgur.com/VHG6Zbl.png BUG=229102 Review URL: https://chromiumcodereview.appspot.com/15745022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202795 0039d316-1c4b-4281-b951-d872f2087c98
-
jered@chromium.org authored
We're going to send this down after all so the page can properly match Chrome's decision about whether what you've typed is an URL. TEST=Manually with GWS change to deal with SWYT. BUG=243201 Review URL: https://chromiumcodereview.appspot.com/15732014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202794 0039d316-1c4b-4281-b951-d872f2087c98
-
toyoshim@chromium.org authored
BUG=236781 TEST=browser_tests --gtest_filter='TranslateBrowserTest.*' Review URL: https://chromiumcodereview.appspot.com/15680006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202793 0039d316-1c4b-4281-b951-d872f2087c98
-
chromeos-lkgm@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202792 0039d316-1c4b-4281-b951-d872f2087c98
-
jackhou@chromium.org authored
AppShimHost is now confined to interacting with the app shim and passing events to AppShimHandlers. ExtensionAppShimHandler becomes the default handler for app shim events. BUG=168080 TEST=There should be no behavior change with this refactor. Review URL: https://chromiumcodereview.appspot.com/15269003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202791 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
Suspected to break Linux ChromeOS build http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/19953/steps/compile/logs/stdio obj/ui/snapshot/test/snapshot_unittests.run_all_unittests.o:run_all_unittests.cc:function main:error: undefined reference to 'ui::test::CompositorTestSuite::CompositorTestSuite(int, char**)' obj/ui/snapshot/test/snapshot_unittests.run_all_unittests.o:run_all_unittests.cc:function main:error: undefined reference to 'ui::test::CompositorTestSuite::~CompositorTestSuite()' > Remove unnecessary ui::CompositorTestSupport > > The ui::CompositorTestSupport class existed to initialize WebKit since > ui::Compositor depends on cc which used to depend on WebKit being initialized > to function properly. cc no longer has this requirement, so this class is > unnecessary. > > R=piman, sky > > Review URL: https://chromiumcodereview.appspot.com/14744016 TBR=jamesr@chromium.org Review URL: https://codereview.chromium.org/15838015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202790 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
The FakeVideoDecoder simulates a typical video decoder that could have some decoding delays (to simulate out-of-order decoding). Since it's fake, it does not care about what the input is. It always generate output frames successfully but with a frame delay (specified in the ctor). All callbacks passed to FakeVideoDecoder can be held if desired. This gives the test class a chance to do some operation during pending callbacks. BUG=141788 Review URL: https://chromiumcodereview.appspot.com/15085011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202789 0039d316-1c4b-4281-b951-d872f2087c98
-
gcasto@chromium.org authored
The motivating force behind this change is we want to ping the first time a generated password is used. If we need to keep information about first use, we might as well keep total usage stats as it is an interesting UMA statistic as well. Changes to the other PasswordStore implementations will be in separate CLs BUG=240560 Review URL: https://chromiumcodereview.appspot.com/14811010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202788 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
The ui::CompositorTestSupport class existed to initialize WebKit since ui::Compositor depends on cc which used to depend on WebKit being initialized to function properly. cc no longer has this requirement, so this class is unnecessary. R=piman, sky Review URL: https://chromiumcodereview.appspot.com/14744016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202787 0039d316-1c4b-4281-b951-d872f2087c98
-
haitaol@chromium.org authored
* Make worker observe the destruction of the thread where it does work. * Make work done signal a memeber of worker and set it when worker's working thread is destroyed so that syncer won't be blocked indefinitely on work that's not gonna run. * Ref-count worker in session context so that worker remains valid when syncer is still iterating through workers but registrar has erased it from its worker map. * Add RequestStop() and Stopped() to allow worker to return early when it's stopped while waiting to run work on its working thread. This cl by itself should have no real impact because the added functions are not used. BUG=19757 Review URL: https://chromiumcodereview.appspot.com/14046031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202786 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=239168,125846 R=jamescook@chromium.org,ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16070003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202783 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
BUG=244464 TEST=trybots R=oshima@chromium.org Review URL: https://chromiumcodereview.appspot.com/15960013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202782 0039d316-1c4b-4281-b951-d872f2087c98
-
yoshiki@chromium.org authored
BUG=239282 TEST=manual Review URL: https://chromiumcodereview.appspot.com/15670008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202778 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
IdleActionWarningDialogView uses Widget::CreateWindow. Use DialogDelegate::CreateDialogWidget instead. See before/after pics at http://crbug.com/166075#c106 Trigger with debug code in Patch Set 1. BUG=166075 TEST=Idle action warning dialog does not have an extra border. R=derat@chromium.org Review URL: https://chromiumcodereview.appspot.com/16032008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202777 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
This was initially introduced to get ExternalFileSystem's local mount root path, but accessing MountPointProvider from lower-layer FileUtil module looks ugly. This patch: - Deprecate FileSystemMountPointProvider::GetFileSystemRootPathOnFileThread - Add FileSystemOperationContext::root_path() instead for passing root path BUG=241701 TEST=Moved tests from content_unittests:FileSystemMountPointProviderTest.* to content_unittests:SandboxMountPointProviderTest.* R=bauerb@chromium.org, michaeln@chromium.org, tzik@chromium.org Review URL: https://codereview.chromium.org/15959006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202776 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
Testing shows we can allow for much lower buffer sizes on WASAPI, OSX, and PulseAudio clients. In most cases, this change brings those clients down to the nearest multiple of 512. WaveOut and ALSA clients will use the nearest multiple of 2048. Based on testing done in https://codereview.chromium.org/14570002/ BUG=162207 TEST=Using these buffer sizes for HTML5 audio works without glitching when an AudioConverter is in the graph. Review URL: https://chromiumcodereview.appspot.com/14573006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202775 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
The original name was redundant. BUG=242121 TEST=none R=hashimoto@chromium.org, jhawkins@chromium.org Review URL: https://codereview.chromium.org/15650008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202774 0039d316-1c4b-4281-b951-d872f2087c98
-
miletus@chromium.org authored
We are converting gesture's timestamp to microseconds at many places (e.g. for latency measure). So let's not truncate the timestamp to milliseconds level when creating the event. BUG=243443 TEST=None. Review URL: https://chromiumcodereview.appspot.com/16159007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202773 0039d316-1c4b-4281-b951-d872f2087c98
-
jbauman@chromium.org authored
This structure would be useful in ui/surface, which can't depend on cc/. BUG= Review URL: https://chromiumcodereview.appspot.com/14999012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202772 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202770 0039d316-1c4b-4281-b951-d872f2087c98
-
jyasskin@chromium.org authored
Also revert the leak suppression (r202589) so we'll know if this didn't fix the problem. BUG=244446 Review URL: https://chromiumcodereview.appspot.com/16133011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202768 0039d316-1c4b-4281-b951-d872f2087c98
-
mgiuca@chromium.org authored
This fixes the response from readdir when applied to memfs mounts. Also added tests for st_ino (from MountNode::GetStat) and d_ino, d_off and d_reclen (from MountNodeDir::GetDents). In a test environment, MountNode now sets st_ino to 1, instead of 0 (since 0 is an invalid inode value). BUG=244315 Review URL: https://chromiumcodereview.appspot.com/16122002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202767 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
WebString::data forces a widening of the underlying String from 8 bits to 16 bits. We should remove this function because most callers of the API don't understand these implementation details of WebString. In order to remove the API, we need to remove all the callers. This CL removes all the callers I could find in Chromium. This CL depends on https://codereview.chromium.org/15806014/ which removes the callers in Blink (and introduces WebString::at to address one data() use case). R=jamesr TBR=groby@chromium.org Review URL: https://chromiumcodereview.appspot.com/15960012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202766 0039d316-1c4b-4281-b951-d872f2087c98
-
pan.deng@intel.com authored
To Fix ResourceLoadTiming resolution lose issue, "int" deltas in millisecond will be replaced by "double" monotonicallyIncreasing time in blink. This change remove previous delta calculation in glue, and pass nature monotonicallyIncreasing time to blink. Contributed by pan.deng@intel.com BUG=242452 Review URL: https://chromiumcodereview.appspot.com/15552003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202765 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
Broke Mac ASAN Tests (2): NotificationsApiTest.TestGetAll: dyld: warning, unknown environment variable: DYLD_NO_PIE dyld: warning, unknown environment variable: DYLD_NO_PIE dyld: warning, unknown environment variable: DYLD_NO_PIE dyld: warning, unknown environment variable: DYLD_NO_PIE [5768:3847:0528/182240:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context. ../../chrome/browser/extensions/api/notifications/notifications_apitest.cc:331: Failure Value of: kNotificationsToCreate Actual: 4 Expected: return_value->size() Which is: 0 > Reland 201932: Add API function chrome.notifications.getAll > > This function returns an object whose keys are the notification > IDs of all notifications created by that extension. > > BUG=240924 > > TBR=miket@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/15715008 TBR=dewittj@chromium.org Review URL: https://codereview.chromium.org/15820009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202764 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
Broke ScriptBadgeControllerTest.ExecutionMakesBadgeVisible on Linux Clang (dbg) [ RUN ] ScriptBadgeControllerTest.ExecutionMakesBadgeVisible [16238:16238:0528/195340:652289748:ERROR:activity_log.cc(168)] BrowserThread::DB does not exist, running on UI thread! Received signal 11 SEGV_MAPERR 000000000058 [0x7f664570b17e] base::debug::StackTrace::StackTrace() [0x7f664570acb7] base::debug::(anonymous namespace)::StackDumpSignalHandler() [0x7f66363facb0] <unknown> [0x0000032aa59c] extensions::RulesRegistryService::content_rules_registry() [0x0000032a8cc8] extensions::TabHelper::DidNavigateMainFrame() [0x7f663c8ca46d] content::WebContentsImpl::DidNavigateMainFramePostCommit() [0x7f663c8cba53] content::WebContentsImpl::DidNavigate() [0x7f663c8cbb97] content::WebContentsImpl::DidNavigate() [0x7f663c7d58a1] content::RenderViewHostImpl::OnNavigate() [0x000002efa9dd] content::TestRenderViewHost::SendNavigateWithParameters() [0x000002efa462] content::TestRenderViewHost::SendNavigateWithTransitionAndResponseCode() [0x000002efa4df] content::TestRenderViewHost::SendNavigateWithTransition() [0x000002efa34d] content::TestRenderViewHost::SendNavigate() [0x000002ef30d2] content::TestWebContents::CommitPendingNavigation() [0x000002ef2df3] content::TestWebContents::NavigateAndCommit() [0x000002eeb1a7] content::RenderViewHostTestHarness::NavigateAndCommit() [0x000000b9d012] extensions::(anonymous namespace)::ScriptBadgeControllerTest_ExecutionMakesBadgeVisible_Test::TestBody() [0x000003567393] testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x00000355e25e] testing::internal::HandleExceptionsInMethodIfSupported<>() [0x000003555da5] testing::Test::Run() [0x0000035564ab] testing::TestInfo::Run() [0x000003556a47] testing::TestCase::Run() [0x00000355ad75] testing::internal::UnitTestImpl::RunAllTests() [0x000003564453] testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x00000355f70e] testing::internal::HandleExceptionsInMethodIfSupported<>() [0x00000355aa64] testing::UnitTest::Run() [0x0000043d60df] base::TestSuite::Run() [0x0000042948ed] content::UnitTestTestSuite::Run() [0x00000406ad24] main [0x7f663402776d] __libc_start_main [0x0000004fbb09] <unknown> r8: 0000000000000020 r9: 0101010101010101 r10: 00007fff7dd127c0 r11: 00007f6634091d2e r12: 00000000004fbae0 r13: 00007fff7dd14f00 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000000000 si: 00007fff7dd12840 bp: 00007fff7dd12b00 bx: 0000000000606cd0 dx: 0000000000000000 ax: 0000000000000000 cx: 0000000000000001 sp: 00007fff7dd12b00 ip: 00000000032aa59c efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000058 > Change RulesRegistryService to use ProfileKeyedAPI. > > BUG=179951 > > Review URL: https://chromiumcodereview.appspot.com/13825014 TBR=patrickriordan177@gmail.com Review URL: https://codereview.chromium.org/16109003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202763 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@google.com authored
Move webkit/blob to new locations. Also move content::WebBlobRegistryImpl to the new common_child library. - just moving the files in the source repository - and fixing up complilation guards - and fixing up include paths throughout - and fixing up DEPs files as needed Note: Everything in /webkit is still being built into the same old webkit_storage target for now, new actual build target(s) will come later. TBR=kinuko@chromium.org, thestig@chromium.org BUG=239109 Review URL: https://codereview.chromium.org/15746017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202762 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
R=nduca@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/16069004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202761 0039d316-1c4b-4281-b951-d872f2087c98
-
jschuh@chromium.org authored
BUG=242304 R=jln@chromium.org TBR=jln@chromium.org Review URL: https://chromiumcodereview.appspot.com/15766009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202760 0039d316-1c4b-4281-b951-d872f2087c98
-
dvh@chromium.org authored
- Improved UX of the dev tools. a/ "Load unpacked", "Pack" and "Update now" buttons have been moved to the top b/ The header is now sticky like in chrome://extensions c/ The list of extensions/apps is centered when the window is expanded BUG=242747 BUG=242743 Review URL: https://chromiumcodereview.appspot.com/15389003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202759 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
Alt-F4 key events are handled by the window manager, who then sends an X11 message telling us that we should close. This used to be hooked up, but it looks like it broke when we merged with the crossplatform DesktopNativeWidgetAura code that we also use on Windows. BUG=176783 Review URL: https://chromiumcodereview.appspot.com/15827009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202758 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
test is disabled because it will fail until the bug is fixed BUG=244515 Review URL: https://chromiumcodereview.appspot.com/16096007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202757 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=178853 Review URL: https://chromiumcodereview.appspot.com/15692009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202756 0039d316-1c4b-4281-b951-d872f2087c98
-
vollick@chromium.org authored
Cubic bezier timing functions are based on two knots (x1, y1) and (x2, y2) (the other knots are assumed to be (0, 0) and (1, 1)). We require that x1, x2 lie within (0, 1) (so that the bezier does not 'fold back' on itself), but y1, and y2 should have no such constraint. They currently do. This CL reimplements bezier interpolation without this restriction. This interpolation has two steps: 1) Find the t corresponding to the desired x. 2) Interpolate y's at the t computed in step 1. Step 1 is an iterative minimization. Here I do bisection for simplicity, but I could take Newton steps if this turns out to be a bottleneck. R=ajuma@chromium.org BUG=178070 Review URL: https://chromiumcodereview.appspot.com/16112002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202755 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/16041004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202754 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
In the network list on the settings page, the pop-up bubble for a managed network has that network's list entry as its parent. The list entry must allow overflow to be visible so that the bubble does not get clipped. BUG=243659 TEST=Manual Review URL: https://chromiumcodereview.appspot.com/15690006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202753 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
After recent refactorings chrome/browser/api and a few chrome/browser/profiles/ includes are not necessary anymore. c/b/api was removed in r195919 by Peter and some c/b/profiles/ were moved in r201167 by Pawel. BUG=138280,144783, 140037, 144050, 146851, 233552 TEST=checkdeps.py passes. TBR=joi@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/16182002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202752 0039d316-1c4b-4281-b951-d872f2087c98
-