- 26 Feb, 2019 40 commits
-
-
Eyor Alemayehu authored
Currently, G-Suite users whose policy is enforced by the administrator are prompted to enable the Web and App activity when they launch Assistant. However, they are not authorized to enable the Web and App activity. Made changes to present an appropriate prompt as outlined in: go/gsuite-optin Bug: b:123638794 Change-Id: I883efed56948f0d22e577902eb489b37b894af94 Reviewed-on: https://chromium-review.googlesource.com/c/1480539 Commit-Queue: Eyor Alemayehu <eyor@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#635698}
-
dalyk authored
To send DoH requests, LogDnsClient needs to set the URLRequestContext to be used for a transaction. The TreeStateTracker is configured with a URLRequestContext that is passed to the resulting LogDnsClient. Bug: 878582 Change-Id: Iea5be660ac1ac0db9a2338386201ff6a92796b0a Reviewed-on: https://chromium-review.googlesource.com/c/1486718 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#635697}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f073572f..44fde444 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9bda0800d015dfd33bfa6c21b830850191b8bd7d Reviewed-on: https://chromium-review.googlesource.com/c/1489411Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635696}
-
John Budorick authored
also alphabetize the console by builder name. Bug: 935764 Change-Id: I7c6951d264f97d184c22cddb4a3b8600a59e5e93 Reviewed-on: https://chromium-review.googlesource.com/c/1489893 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#635695}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1a930646662a..793add9a8d60 git log 1a930646662a..793add9a8d60 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 dgarrett@google.com chromeos_config: Remove prototype-factorybranch. Created with: gclient setdep -r src/third_party/chromite@793add9a8d60 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I7be60339f73aa4d6a70d5c2743356af17c8b98d5 Reviewed-on: https://chromium-review.googlesource.com/c/1489691Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635694}
-
David Jacobo authored
Smart text selection was originally implemented to be accessed via context menu and so the UMA description reflected that. After that it was decided the feature should also be accessible via touchscreen and so this CL reflects that update. Bug: None Change-Id: Ib4216e7e913d4a7aa2273b23f7e010ff6e883840 Reviewed-on: https://chromium-review.googlesource.com/c/1489792 Auto-Submit: David Jacobo <djacobo@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635693}
-
Joshua Pawlicki authored
This allows us to reuse the unzip / patch implementations of update_client. Bug: 926236 Change-Id: Iabdbe9f4017b69d3e38a2137e8905b6d274f4ed7 Reviewed-on: https://chromium-review.googlesource.com/c/1461079 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#635692}
-
Fabrice de Gans-Riberi authored
This is a reland of 7da3d9df This creates chromium.web.CreateContextParams2 and chromium.web.LoadUrlParams2 as extensible FIDL tables. All the Chromium-internal call sites have been updated to use the newer APIs. The original APIs will be removed in a future CL when all out-of-tree callers for them will have been updated. Bug: 931831 Change-Id: I8f324342f928c1217b8b88cf8db6797ecfc9aecc Reviewed-on: https://chromium-review.googlesource.com/c/1481080 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#635691}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/024f271ae0c7..fe3d4978886b git log 024f271ae0c7..fe3d4978886b --date=short --no-merges --format='%ad %ae %s' 2019-02-26 chrisforbes@google.com Fix various issues in vertex fetch setup Created with: gclient setdep -r src/third_party/swiftshader@fe3d4978886b The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124177079 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ib549139ede1a70db9e5b8f60d712fa7a8846f734 Reviewed-on: https://chromium-review.googlesource.com/c/1488960Reviewed-by:
-
Nico Weber authored
Requires suppressing the warning for a file generated by mc.exe, and for a system header (which is arguably a clang bug, see comment in the .h). Bug: 926235 Change-Id: Iee8ecd6eab476207c1507719ba5102403f381cae Reviewed-on: https://chromium-review.googlesource.com/c/1489102Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635689}
-
Manu Cornet authored
This should help with flaky tests reported in the linked bug. Bug: 934558 Change-Id: I78b09e596d7da42c3c483598f62e969fff017309 Reviewed-on: https://chromium-review.googlesource.com/c/1487145 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#635688}
-
Nicolás Peña Moreno authored
This CL moves the input delay computations for UKM to further down the pipeline to where they are computed for EventTiming. After this CL, the same types of events are logged by both UMA/UKM and EventTiming. The WebViewTest is fixed so that the artificial events move further enough down the pipeline. The tests checking for pointerCancels are no longer applicable since these only applied to the UMA/UKM computations, per issue 924278. By unifying input delay computation, this CL also fixes frame attribution for the UMA/UKM input delays: PageWidgetDelegate does not know the target frame (before, it would tell the root that an event has occurred even if it occurred in an iframe. Bug: 897656, 925130 Change-Id: I27dba1cbb82ad780d21166a5469001e266612a78 Reviewed-on: https://chromium-review.googlesource.com/c/1476070Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#635687}
-
Céline O'Neil authored
Small bug fixes: browser UI CompositorFrame now has a valid frame_token, and validation logic for the fuzzed CompositorFrame ensures that the RenderPass output_rect contains the damage_rect, and that the DrawQuad's rect contains its visible_rect. R=kylechar@chromium.org Bug: 934656 Change-Id: If90756a4a608407952fde27e308db1d90a14f1fb Reviewed-on: https://chromium-review.googlesource.com/c/1489632Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Céline O'Neil <celineo@google.com> Cr-Commit-Position: refs/heads/master@{#635686}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f53e1f6e2d49..5da3a7e01dc2 git log f53e1f6e2d49..5da3a7e01dc2 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 perezju@chromium.org [Telemetry] Implement TelemetryTracingAgent Created with: gclient setdep -r src/third_party/catapult@5da3a7e01dc2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931236 TBR=sullivan@chromium.org Change-Id: I2b0cddded0cc3a6c15be5a779ac767f4b3c525e5 Reviewed-on: https://chromium-review.googlesource.com/c/1489453Reviewed-by:
-
Collin Baker authored
The enable_features array was missing in my last CL. Bug: 887991 Change-Id: Ie69d9189a3255e93ee0fb41b24bc54db9b3d670a Reviewed-on: https://chromium-review.googlesource.com/c/1489108Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#635684}
-
Yue Li authored
Bug: None Test: Local build Change-Id: I619f49394f25c072bfa714ac0648800b89f2c729 Reviewed-on: https://chromium-review.googlesource.com/c/1484586Reviewed-by:
-
David Tseng authored
Bug: 935963 Test: manual. Change-Id: I7db0bc37d8085ac3f812818542d1a9dd6f8465de Reviewed-on: https://chromium-review.googlesource.com/c/1489533 Auto-Submit: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#635682}
-
Ehsan Karamad authored
The API MaybeCreateMimeHandlerView passes an int which is used as the element instance ID for the GuestView. The int is obtained from BrowserPluginManager::GetNextInstnaceID() which itself obtains it from RenderThread::GenerateRoutingID() (publicly accessible to outside of content/). This is unnecessary and can be generated inside MimeHandlerViewFrameContainer instead. This (mechanical) CL removes the argument from all the methods involved. TBR=avi@chromium.org,wjmaclean@chromium.org Bug: 659750 Change-Id: Ia20e2e2dd59f144ebaa646a4c022390398ea8e07 Reviewed-on: https://chromium-review.googlesource.com/c/1487209Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#635681}
-
Ehsan Karamad authored
This CL fixes a few types and mistakes in the original CL which implemented opener policies (CL: 1384992). Besides, this CL adds two WPTs to complement the test coverage for "FeaturePolicyForSandbox". The current tests verify correctness of propagation in the following cases: 1- "window.open" from an <iframe> that is not sandbox. 2- "window.open" from an <iframe> that is sandboxed but allows escaping. In case (1) the policies are expected to be inherited but in case (2) they should not be inherited from the <iframe>. Future tests add support for cross-origin frames/window as well as rel=noopener case if need be. TBR=mkwst@chromium.org Bug: 774620, 926293 Change-Id: I2da875a008584c7e2015a020fcad92e9528e748d Reviewed-on: https://chromium-review.googlesource.com/c/1483942 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#635680}
-
Michael Thiessen authored
Bug: 933884 Change-Id: I596e3a3d59e93e8991a5740eb49b6355e5bbcd7a Reviewed-on: https://chromium-review.googlesource.com/c/1489514 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635679}
-
Xiaocheng Hu authored
Tbr: dgozman@chromium.org NoTry: True Bug: 934818 Change-Id: I302a1cd8252dd0a9401beea1b7762c379e7794c5 Reviewed-on: https://chromium-review.googlesource.com/c/1489853Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635678}
-
Andrew Grieve authored
This reverts commit d9d05e18. Reason for revert: java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.Integer.intValue()' on a null object reference at org.chromium.chrome.browser.compositor.bottombar.OverlayPanelBase.getPreviousPanelState (OverlayPanelBase.java: 620) at org.chromium.chrome.browser.compositor.bottombar.OverlayPanelBase.updatePanelForHeight (OverlayPanelBase.java: 783) at org.chromium.chrome.browser.compositor.bottombar.OverlayPanelBase.setPanelHeight (OverlayPanelBase.java: 758) at org.chromium.chrome.browser.compositor.bottombar.OverlayPanelAnimation.lambda$animatePanelTo$0$OverlayPanelAnimation (OverlayPanelAnimation.java: 354) at org.chromium.chrome.browser.compositor.bottombar.OverlayPanelAnimation$$Lambda$0.onAnimationUpdate (OverlayPanelAnimation.java) at org.chromium.chrome.browser.compositor.animation.CompositorAnimator.doAnimationFrame (CompositorAnimator.java: 207) at org.chromium.chrome.browser.compositor.animation.CompositorAnimationHandler.pushUpdate (CompositorAnimationHandler.java: 108) at org.chromium.chrome.browser.compositor.animation.CompositorAnimationHandler.pushUpdate (CompositorAnimationHandler.java: 91) at org.chromium.chrome.browser.compositor.layouts.LayoutManager.onUpdate (LayoutManager.java: 361) at org.chromium.chrome.browser.compositor.layouts.LayoutManager.onUpdate (LayoutManager.java: 344) at org.chromium.chrome.browser.compositor.CompositorViewHolder.onCompositorLayout (CompositorViewHolder.java: 738) at org.chromium.chrome.browser.compositor.CompositorView.onCompositorLayout (CompositorView.java: 316) Original change's description: > Migrate PanelState from enum to @IntDef + remove one Map > > @IntDef/@StringDef annotation are preferred way for declaring > set of String/int values > > 1. they need less space in APK than enum, see > https://developer.android.com/topic/performance/reduce-apk-size#remove-enums > 2. they give more control over allowed values than "static final" values > > Main goal of patch is writing PanelState enum in the form common with other Chrome @IntDef: > > 1. with @IntDef first, @Retention second > and related @interface third > 2. with values inside @interface > 3. with NUM_ENTRIES declaring number of entries > 4. with comment about numbering from 0 without gaps > 5. with @Retention(RetentionPolicy.SOURCE) > 6. without "static final" in the @interface > > There is additionally removed one unnecessary Map. > > BUG=919666 > > Change-Id: I8149a0800bd5c0bb205028d230edadc83016ebb9 > Reviewed-on: https://chromium-review.googlesource.com/c/1142764 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Donn Denman <donnd@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635196} TBR=dtrainor@chromium.org,donnd@chromium.org,agrieve@chromium.org,marcin@mwiacek.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 919666, 936105 Change-Id: I58863b9ffe0dbdf311f0feb459729445b75af179 Reviewed-on: https://chromium-review.googlesource.com/c/1488575Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#635677}
-
Jérôme Lebel authored
The sign-in cell opens to the account list view controller, it needs to have a disclosure indicator. Before: https://drive.google.com/open?id=1Opqj8IeHkqfeIbrb5ayizQxk3YFL4p6g After: https://drive.google.com/open?id=1VOoQgkNrnNaexALS-Dprvn6H4YjyDQrH Bug: 914059 Change-Id: I50616173dd5fb6eb457005518e096cc084bcd721 TBR: gambard Reviewed-on: https://chromium-review.googlesource.com/c/1489204Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635676}
-
Khushal authored
It is important to flush skia's GPU work before using the resource for compositing. Woops. R=fserb@chromium.org Change-Id: I71c0966719fa022352a52c39d2a2ce74330c1c33 Reviewed-on: https://chromium-review.googlesource.com/c/1487146 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635675}
-
Tarun Bansal authored
Bug: 746640 Change-Id: I195b55947d466533661d02ab07fc74ec512c1860 Reviewed-on: https://chromium-review.googlesource.com/c/1488313Reviewed-by:
-
Tarun Bansal authored
Add metrics to record gap between start of delayble (aka low priority) request and start of non-delayable (aka high priority) requests. This will help us quantify how long the low priority requests should be additionally delayed for to avoid network congestion with high priority requests. Bug: 935703 Change-Id: I730b7f5663352689fd66a43f60f3268100a3c920 Reviewed-on: https://chromium-review.googlesource.com/c/1487891Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#635673}
-
Jérôme Lebel authored
Opens the Web and App activity dialogs from Manage sync settings. Bug: 914059 Change-Id: I3687c32231066504f46a46f8bde71d131443effe Reviewed-on: https://chromium-review.googlesource.com/c/1488091 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#635672}
-
Khushal authored
There is no framework support to use SurfaceControl on webview. R=boliu@chromium.org Bug: 889328 Change-Id: I0f3bc51d7cc7c1a1207e52eaa31f8c8a0625a4df Reviewed-on: https://chromium-review.googlesource.com/c/1489257Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#635671}
-
Yining Wang authored
design doc: go/minimal-chrome-desktop-ui Bug: 935679 Change-Id: I08f63e1bc65756d13d3689faa78dc1609be60095 Reviewed-on: https://chromium-review.googlesource.com/c/1487699 Commit-Queue: Yining Wang <yiningwang@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#635670}
-
liberato@chromium.org authored
Previously, LTC accepted complete LabelledExample instances, with feature values, target value, and weight. This was sufficient for MediaCapabilities, since its features are idempotent with respect to a playback segment. As we move to new tasks, however, we need to snapshot feature values at the time we would otherwise want to make a prediction, in case they change before the TargetValue becomes known. This CL provides a callback-based approach to start building a LabelledExample at prediction time. The callback can be used to add a TargetValue at some later time. Since most of this logic is self-contained, it's been moved into LearningTaskControllerHelper. It will be re-used later when we update the mojo interfaces to conform to this new API. When we do that, we'll expose LTC via mojo directly, rather than sending all examples via LearningSession. The LTC mojo client will want to do essentially the same thing as LCTI. Change-Id: I5ae032c806a095162ead8b64e1f64d646397d52f Reviewed-on: https://chromium-review.googlesource.com/c/1464434 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#635669}
-
Victor Costan authored
This CL removes two classes of histograms. 1) SQL statement timing distributions, in the histograms below. * Sqlite.AutoCommitTime.* * Sqlite.CommitTime.* * Sqlite.QueryTime.* * Sqlite.UpdateTime.* The timing distributions cover all SQL statements issued by each browser feature built on top of SQLite, so they collect a large volume of data. Their usefulness does not measure up to the amount of data collected, for the reasons below. * The histograms are too coarse to be useful as feature-level metrics. The features whose owners are interested in optimizing performance should deploy metrics that are specific to concrete investigations and experiments. * The histograms are less useful as SQLite-level metrics than the heartbeat metrics that show overall Chrome performance. 2) Statistics about successful SQL statements and transactions, expressed as the following enum values in Sqlite.Stats.* * EVENT_STATEMENT_RUN * EVENT_STATEMENT_ROWS * EVENT_STATEMENT_SUCCESS * EVENT_EXECUTE * EVENT_CHANGES_AUTOCOMMIT * EVENT_CHANGES * EVENT_BEGIN * EVENT_COMMIT * EVENT_ROLLBACK * EVENT_MMAP_SUCCESS_NEW * EVENT_MMAP_SUCCESS_PARTIAL * EVENT_MMAP_SUCCESS_NO_PROGRESS These statistics cover all SQL statements / transactions used by each browser features. Like the timing distributions above, they end up collecting a lot of data, and aren't very useful. Raw SQL statement counts are at best a very indirect measure of each feature's usage. This CL removes the success outcomes, but keeps the error outcomes. The metrics for errors are recorded much less often, as SQL operations fail rarely, and are sufficient for computing error rates, which are a bit more actionable. Bug: 935824 Change-Id: Ia8f8c13a45ba78819bab8f130509cd6a8c6842a7 Reviewed-on: https://chromium-review.googlesource.com/c/1488952 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
-
Vlad Tsyrklevich authored
The TID returned by PlatformThread::CurrentId() uses `pthread_mach_thread_np(pthread_self())` which does not match the one used by crashpad (and hence reported server-side.) Record a matching TID instead. Bug: 934888 Change-Id: I9606827874c6072fc8ba1dc9a1ed6b67e27a0898 Reviewed-on: https://chromium-review.googlesource.com/c/1484351 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#635667}
-
Jordan Demeulenaere authored
This CL adds the concept of contents with custom lifecycle. This type of content is not hidden nor cleared from the content queue when the user navigates away from the current page or switches tab. Bug: 933070 Change-Id: I092bff8a76bf119b2064a6a66a6e58b431486c5c Reviewed-on: https://chromium-review.googlesource.com/c/1470228Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#635666}
-
Xing Liu authored
This CL adds the virtual destuctor in download_service.h Change-Id: If044cf2100fc1e8cd6c61f71c79fafd634d3bfda Reviewed-on: https://chromium-review.googlesource.com/c/1487359 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635665}
-
Dmitry Gozman authored
FrameLoader::DidFinishNavigation wants to skip some work for provisional frame, and uses protect_provisional_loader_ flag for this. The logic was introduced in https://crrev.com/555109, which claims to only care about provisional frames being swapped out, so we can instead be explicit and check for provisional frame. Bug: none Change-Id: If32f6f9f8ae00286ba0c1eace9cc061f1f20b7eb Reviewed-on: https://chromium-review.googlesource.com/c/1487875 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#635664}
-
Elly Fong-Jones authored
Bug: 912129 Change-Id: I4e0761d1eeed00cfb0594e6ecb50a6e1f41092ef Reviewed-on: https://chromium-review.googlesource.com/c/1489107 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#635663}
-
Mike Wittman authored
This reverts commit e6314175. Reason for revert: Crashing in TracingProfileBuilder::OnSampleCompleted on Android. Original change's description: > [Sampling profiler] Use null for invalid ModuleCache::Module state > > Eliminates the internal null Module state in favor of nullptr. > > Bug: 931418 > Change-Id: I8d7f6f00f5433d189542bceb790ca23c5b97fb4d > Reviewed-on: https://chromium-review.googlesource.com/c/1478095 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635242} TBR=wittman@chromium.org,alph@chromium.org,oysteine@chromium.org,charliea@chromium.org Change-Id: I6f188e5b05f747d9104f9b96dac71b7603e9507a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931418, 936099 Reviewed-on: https://chromium-review.googlesource.com/c/1489515Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635662}
-
Carlos Knippschild authored
Bug: 935065 Change-Id: I33c99186314f0cd27abd2cb078069028723e29f1 Reviewed-on: https://chromium-review.googlesource.com/c/1484975Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635661}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c1b9ea5f3400..c08497af77b7 git log c1b9ea5f3400..c08497af77b7 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 eseckler@google.com Merge "build: Add new protos to libperfetto public_deps" Created with: gclient setdep -r src/third_party/perfetto@c08497af77b7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia6b027cfea6dffac70e97bf6fa30aedd78d73565 Reviewed-on: https://chromium-review.googlesource.com/c/1489511Reviewed-by:
-
Xiaocheng Hu authored
Tbr: reillyg@chromium.org NoTry: True Bug: 936065 Change-Id: I373e9801f8de781745dbccb7b16a7c8c47159715 Reviewed-on: https://chromium-review.googlesource.com/c/1489714Reviewed-by:
-
