GitLab

Blink r199183 changed the encoder to no longer reserve WTF::Vector capacity.
An alternative is to no longer use a WTF::Vector, and allocate the buffer in
an OwnPtr<T[]> instead.

BUG=504690

Review URL: https://codereview.chromium.org/1285533002

git-svn-id: svn://svn.chromium.org/blink/trunk@200702 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In order to handle fetch() Request data more correctly, this CL introduces
FetchFormDataConsumerHandle which is made from FormData (including String
and ArrayBuffer) and provides a means to drain the data as a FormData.

This CL also modifies drainAsBlobDataHandle contract and implementation.

BUG=457484

Review URL: https://codereview.chromium.org/1265413002

git-svn-id: svn://svn.chromium.org/blink/trunk@200701 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change sorts the generated palette by hue and expands the palette to
24 colors. This change reduces the preview palette size to fix a line
wrapping issue on Mac.

BUG=521228,521139,461320

Review URL: https://codereview.chromium.org/1300513003

git-svn-id: svn://svn.chromium.org/blink/trunk@200700 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=515763

Review URL: https://codereview.chromium.org/1295083003

git-svn-id: svn://svn.chromium.org/blink/trunk@200699 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix z-index of tooltips to appear on top of glass panes such as the new main menu. This also adds a tooltip for toggle dock side tooltip.

BUG=520272,521206

Review URL: https://codereview.chromium.org/1294033002

git-svn-id: svn://svn.chromium.org/blink/trunk@200698 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is split out from [1] where we support multiple author origins in
terms of shadow dom scopes. The vector of MatchedProperties contains
matched declarations from all origins in the order in which they should
be applied. For !important declarations, they are applied in the same
order within the same origin, but the order of the origins are different
as the cascading order is:

  - UA important
  - Author important
  - Author
  - UA

We used to have two ranges, one for UA and one for author to accomplish
this. However, with the normal/!important cascading order for
declarations from different shadow doms, we need multiple author ranges:

  - UA important
  - Author important scope n
  ...
  - Author important scope 1
  - Author scope 1
  ...
  - Author scope n
  - UA

We introduce an ImportantAuthorRangeIterator to iterate through the
author ranges and add iterator-style iteration for each range through the
MatchedPropertiesRange class.

As the applyMatchedProperties code is hot, I've run the blink_perf.css
tests locally. Some improved by 2-4%, some became worse by similar
percentages.

[1] https://codereview.chromium.org/1224673002/

BUG=487125
TEST=fast/css

Review URL: https://codereview.chromium.org/1282243002

git-svn-id: svn://svn.chromium.org/blink/trunk@200697 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch is to address a reverted patch (https://codereview.chromium.org/1264913002/).  At line 253 in WorkerThread.cpp, the original check was script()->scriptState()->contextIsValid() which can crash if the scriptState is null.  This patch was reverted and is now changed to script()->isContextInitialized().  isContextInitialized was also changed from a private to a public function.

BUG=501569

Review URL: https://codereview.chromium.org/1287103002

git-svn-id: svn://svn.chromium.org/blink/trunk@200696 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Length::intrinsic() doesn't return true for min-intrinsic. isLegacyIntrinsic()
does. But use isIntrinsicOrAuto() to catch both intrinsic, legacy-intrinsic and
auto values, since that seems to be a rather popular way of doing things.
Nobody seems to call isLegacyIntrinsic() directly. Regarding auto values here,
it doesn't really matter whether we call valueForLength() or not, since they'll
resolve to 0 anyway.

BUG=521526
R=leviw@chromium.org,robhogan@gmail.com

Review URL: https://codereview.chromium.org/1292163005

git-svn-id: svn://svn.chromium.org/blink/trunk@200695 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an iframe's custom scrollbar changes its thickness, it is the LayoutView
within the iframe that should be marked for relayout, not the LayoutIFrame.

BUG=512914

Review URL: https://codereview.chromium.org/1296033002

git-svn-id: svn://svn.chromium.org/blink/trunk@200694 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Document about replacing:
https://docs.google.com/document/d/1e4OvVMFuPxtoLGr6VkAu7qTaHWS02qBv5ndQoW8v1Wg/edit

blink-dev thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/1YrpiUJ0etg

BUG=

Review URL: https://codereview.chromium.org/1278983003

git-svn-id: svn://svn.chromium.org/blink/trunk@200693 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This use counter tracks whenever a page starts multiple CSS animations
on an element where the tail animations include neutral keyframes.
This is to gauge the occurrence of this in the wild to determine the
viability of altering the behaviour in a subset of these cases.

Review URL: https://codereview.chromium.org/1248483005

git-svn-id: svn://svn.chromium.org/blink/trunk@200692 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Biquad filters have a tail where zero input can produce non-zero
output due memory from previous inputs.  However, we were
disconnecting biquad filter nodes when the input is disconnected such
as when a source node is finished.  This causes the biquad to suddenly
produce zero output.

Add a case to handle biquad filters like convolver nodes and delay
nodes which don't disconnect their outputs even if the inputs are
disconnected.

This is a temporary solution until full tail-time supported is implemented.
That will fix this issue, and also allow biquad's to be collected when
no longer needed.  With this change, biquad's will be active for a
very long time even with no inputs.

BUG=521155
TEST=biquad-tail.html

Review URL: https://codereview.chromium.org/1285073005

git-svn-id: svn://svn.chromium.org/blink/trunk@200691 bbb929c8-8fbe-4397-9dbb-9b2b20218538

nextChild may be removed from the DOM tree during the
|parserRemoveChild(*newChild)| call which triggers unload events of newChild's 
descendant iframes. In order to maintain the integrity of the DOM tree, the
insertion of newChild must be aborted in this case.

This patch adds a return statement that rectifies the behavior in this
edge case.

BUG=519558

Review URL: https://codereview.chromium.org/1283263002

git-svn-id: svn://svn.chromium.org/blink/trunk@200690 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896
NOTRY=true

Review URL: https://codereview.chromium.org/1296013002

git-svn-id: svn://svn.chromium.org/blink/trunk@200689 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=439376
TBR=yurys@chromium.org, oilpan-reviews@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1298843002

git-svn-id: svn://svn.chromium.org/blink/trunk@200688 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes files in "core/editing/" to match Blink coding style and
formatting comments, near style changes, to fit 80 characters to ease of working
these files in the future for improving code health.

Note: Naming related style violation will be addressed in other patches to
reduce size of patches.

This patch is also a preparation of moving execCommand related files,
http://crrev.com/1294543005

BUG=509257
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1292303005

git-svn-id: svn://svn.chromium.org/blink/trunk@200687 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=519918

Review URL: https://codereview.chromium.org/1287423005

git-svn-id: svn://svn.chromium.org/blink/trunk@200686 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200677

BUG=509025
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1287903005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200684 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is output of webkit-patch print-flaky-tests.

TBR=leviw@chromium.org
BUG=521862, 521861, 521860, 521859, 521858, 521857, 521856, 521855, 521854, 521853, 521852, 521852, 521852, 521852

Review URL: https://codereview.chromium.org/1300733003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200682 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=515518
R=pfeldman@chromium.org, pfeldman

Review URL: https://codereview.chromium.org/1282593003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200681 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Re-rebaseline xp results after r200605 (patchset #1 id:1 of https://codereview.chromium.org/1296753004/ )

Reason for revert:
webkit_lint errors due to duplicate TestExpectation entries

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/43492/steps/webkit_lint/logs/stdio

The test is already marked as failing by https://codereview.chromium.org/1286343003 Auto-rebase didn't help first time that's why I preferred skipping it on XP and let the author to take care of it.

Original issue's description:
> Re-rebaseline xp results after r200605
> 
> The rest of the bots updated and were happy. XP kept failing...
> 
> BUG=449197
> TBR=fmalita@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200676

TBR=fmalita@chromium.org,leviw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449197

Review URL: https://codereview.chromium.org/1299473004

git-svn-id: svn://svn.chromium.org/blink/trunk@200680 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521704,496259

Review URL: https://codereview.chromium.org/1286373004

git-svn-id: svn://svn.chromium.org/blink/trunk@200679 bbb929c8-8fbe-4397-9dbb-9b2b20218538

InspectorDebuggerAgent now implements V8DebuggerAgent::Client and aggregates V8DebuggerAgent. The latter will be moved into a reusable component which cannot depend on Blink.

BUG=439376

Review URL: https://codereview.chromium.org/1286343003

git-svn-id: svn://svn.chromium.org/blink/trunk@200678 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The widths just changed by a pixel

BUG=509049
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/1252603003

git-svn-id: svn://svn.chromium.org/blink/trunk@200677 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The rest of the bots updated and were happy. XP kept failing...

BUG=449197
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1296753004

git-svn-id: svn://svn.chromium.org/blink/trunk@200676 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521801
TBR=leviw,fmalita@chromium.org,
NOTRY=true

Review URL: https://codereview.chromium.org/1298063002

git-svn-id: svn://svn.chromium.org/blink/trunk@200675 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=sergeyv@chromium.org, sergeyv

Review URL: https://codereview.chromium.org/1297053002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200674 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=520066
NOTRY=true

Review URL: https://codereview.chromium.org/1291673005

git-svn-id: svn://svn.chromium.org/blink/trunk@200673 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=sergeyv@chromium.org, pfeldman, sergeyv

Review URL: https://codereview.chromium.org/1296513005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200672 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Move dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl. (patchset #2 id:20001 of https://codereview.chromium.org/1295053002/ )

Reason for revert:
Looks like it caused a race in:

ProfileErrorBrowserTestInstance/ProfileErrorBrowserTest.CorruptedProfile


Original issue's description:
> Move dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl.
> 
> This removes the last user of didLayoutWithPendingStylesheets() and instead moves
> the call to dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl so the
> notification to the embedder is tied to the pumping of frames. This changes the
> behavior of this notification to only dispatch for the top level frame,
> but Chromium already has a check for that:
> 
> https://chromium.googlesource.com/chromium/src/+/976d4d9a2735bdc11e5a641c84b6382566d48f1d/content/renderer/render_frame_impl.cc#3472
> 
> RenderFrameImpl::didFirstVisuallyNonEmptyLayout's first check is
> 
> if (frame->parent())
>     return;
> 
> so we already ignore all frames that are not the main frame. Future patches will
> clean up this interface so it's obvious this really only happens for the main
> frame.
> 
> BUG=521692
> R=dglazkov@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200664

TBR=dglazkov@chromium.org,ojan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=521692

Review URL: https://codereview.chromium.org/1294683004

git-svn-id: svn://svn.chromium.org/blink/trunk@200669 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Using this method makes the code intent more clear.

Review URL: https://codereview.chromium.org/1296543003

git-svn-id: svn://svn.chromium.org/blink/trunk@200667 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert "Revert "Reland 2: mac: Use a placeholder string for the family name of the system font." Branch 2485"

I had intended to revert the CL on branch 2485, but the CQ sent it straight to
trunk. Undoing the revert.

TBR=tkent@chromium.org, keishi@chromium.org, thakis@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1292593003

git-svn-id: svn://svn.chromium.org/blink/trunk@200666 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert "Reland 2: mac: Use a placeholder string for the family name of the system font." Branch 2485

This reverts commit c05256796e62264bd6f477581b905a02105b0aa1.

BUG=521034
TBR=tkent@chromium.org, keishi@chromium.org, thakis@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1299653004

git-svn-id: svn://svn.chromium.org/blink/trunk@200665 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This removes the last user of didLayoutWithPendingStylesheets() and instead moves
the call to dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl so the
notification to the embedder is tied to the pumping of frames. This changes the
behavior of this notification to only dispatch for the top level frame,
but Chromium already has a check for that:

https://chromium.googlesource.com/chromium/src/+/976d4d9a2735bdc11e5a641c84b6382566d48f1d/content/renderer/render_frame_impl.cc#3472

RenderFrameImpl::didFirstVisuallyNonEmptyLayout's first check is

if (frame->parent())
    return;

so we already ignore all frames that are not the main frame. Future patches will
clean up this interface so it's obvious this really only happens for the main
frame.

BUG=521692
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/1295053002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200664 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Reland Call dispatcher's releaseRegistration when done with registrations (patchset #2 id:40001 of https://codereview.chromium.org/1290073003/ )

Reason for revert:
Speculatively reverting to fix crashes in http/tests/cache/cached-main-resource.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=http%2Ftests%2Fcache%2Fcached-main-resource.html

Original issue's description:
> Reland Call dispatcher's releaseRegistration when done with registrations
> 
> Reland of https://codereview.chromium.org/1279323002/
> 
> OilPan objects can be garbage collected at any time, so it's necessary to check the pointers.
> 
> BUG=502214
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200657

TBR=jsbell@chromium.org,jkarlin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=502214

Review URL: https://codereview.chromium.org/1288893004

git-svn-id: svn://svn.chromium.org/blink/trunk@200663 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521730

Review URL: https://codereview.chromium.org/1299743002

git-svn-id: svn://svn.chromium.org/blink/trunk@200662 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of 2D canvas: remain in deferred rendering mode with canvas to canvas drawImage (patchset #2 id:20001 of https://codereview.chromium.org/1288773005/ )

Reason for revert:
Appears to be triggering MSAN crashes: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fdisplay_list_2d_canvas%2Ffast%2Fcanvas%2F2d.composite.globalAlpha.fillPath.html&testType=layout-tests

Original issue's description:
> 2D canvas: remain in deferred rendering mode with canvas to canvas drawImage
> 
> If the source canvas is not animated, no need to exit deferred rendering
> because there is no risk of memory bloat due to snapshotting.
> 
> BUG=521001
> TEST=telemetry tough_canvas_cases
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200654

TBR=senorblanco@chromium.org,junov@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=521001

Review URL: https://codereview.chromium.org/1295673003

git-svn-id: svn://svn.chromium.org/blink/trunk@200660 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While fontWeight was protected using !fontWeightNeedsResolving in
order to not call fontWeightIsBold for lighter/bolder, baseFontWeight
was not, so add that logic.

BUG=518572

Review URL: https://codereview.chromium.org/1284313002

git-svn-id: svn://svn.chromium.org/blink/trunk@200659 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Reland #1: Add a short term solution to fix OSX 10.11 system font rendering problems. (patchset #2 id:20001 of https://codereview.chromium.org/1289823008/ )

Reason for revert:
Broke layout tests on Mac 10.10

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/2551/steps/webkit_tests/logs/stdio

Original issue's description:
> Reland #1: Add a short term solution to fix OSX 10.11 system font rendering problems.
> 
> I forgot to update the test FontFamilyMatcherMacTest.YosemiteFontWeights.
> 
> > I landed a CL (https://codereview.chromium.org/1276003003/) which fixes system
> > font problems on OSX 10.9 and OSX 10.10. The CL also fixed MatchNSFontFamily()
> > to correctly return the system font on 10.11, but this causes glyph rendering
> > problems. In the short term, I'm adding logic to MatchNSFontFamily() to return
> > nil on 10.11, which was the original behavior before I landed that CL.
> >
> > BUG=521034
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200618
> 
> BUG=521034
> TBR=tkent@chromium.org, keishi@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200653

TBR=tkent@chromium.org,keishi@chromium.org,erikchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=521034

Review URL: https://codereview.chromium.org/1299723002

git-svn-id: svn://svn.chromium.org/blink/trunk@200658 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reland of https://codereview.chromium.org/1279323002/

OilPan objects can be garbage collected at any time, so it's necessary to check the pointers.

BUG=502214

Review URL: https://codereview.chromium.org/1290073003

git-svn-id: svn://svn.chromium.org/blink/trunk@200657 bbb929c8-8fbe-4397-9dbb-9b2b20218538