- 23 Apr, 2019 40 commits
-
-
Sigurdur Asgeirsson authored
LocalSiteCharacteristicsWebContentsObserver (L41r) is the last user of the PageSignalGenerator (PSG). This CL replaces that functionality with a dedicated graph observer in preparation for retiring the PSG. The storage of load time performance estimates is also removed. The PSG maintains state for this that will be rewritten as a graph decorator in due course. Bug: 931407 Change-Id: I9840b6e9833702efde4d1587a990108c655e3b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579363 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#653367}
-
Corentin Wallez authored
Reland with a fix for missing immediate data storage in the decoder unittests. These WebGPU IPC commands allows wrapping a mailbox in a Dawn texture and associate it to a given ID in dawn_wire. There is the respective dissociate command too. SharedImageRepresentationIOSurfaceDawn is changed to destroy() the Dawn texture on EndAccess so it is an error to access the texture after the mailbox has been dissociated. The class also gets some refcounting improvements. This also makes some GPU service objects able to be used when no GL context is present, as is the case when running WebGPU unittests. BUG=chromium:877147 Change-Id: Ib0c8f6251441c9dbe69252773279b53a1fec3736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577422Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#653366}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/18d98f00a12c..9616947a9374 git log 18d98f00a12c..9616947a9374 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 mathewk@chromium.org Mark lakitu boards as important 2019-04-23 norvez@chromium.org chromeos_config: mark nyan_big/blaze important 2019-04-23 derat@chromium.org chromeos_config: Run TastVMTest on amd64-generic-goma-full. Created with: gclient setdep -r src/third_party/chromite@9616947a9374 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Iddea723ccd0f9c77371ffcc01a9372959607ceb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653365}
-
Tanya Gupta authored
The tests check for two cases: - When SendTabToSelf receiving is enabled on both devices, device info for both are updated to reflect this. - When SendTabToSelf receiving is disabled on one device, device info accurately reflects this change. Change-Id: Ie3350e66783890b8271d9700b1d6d4b35a8a84d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577946 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#653364}
-
Sky Malice authored
* Reworked how focus was stored and passed around. Instead of having a JSON backed class with strong types, use a TypedKeyValues object backed by a Bundle. Each ViewHolder is responsible for creating these when they're focused, and after onViewBind() the ViewHolders are offered a generic focus object to see whether they want to restore focus with it. * Reworked when requestFocus() is called to be a little later, during LinearLayoutManager#onLayoutCompleted(). This was necessary for the above the fold views to correctly focus, and the NTP to mirror EoS. * Added support for focusing the view elements with the above the fold card. AboveTheFoldViewHolder itself is still outside of the MVC pattern, but delegation to the OpenTabButton and SiteSuggestions components follows MVC. Bug: 937452 Change-Id: I2df007f3a41007fd6a2b327b4729e30042d16bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563035 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#653363}
-
Staphany Park authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/9f893b99598b..a53e931dcd00 $ git log 9f893b995..a53e931dc --date=short --no-merges --format='%ad %ae %s' 2019-04-18 gennadiycivil Update README.md 2019-04-18 misterg Googletest export 2019-04-18 absl-team Googletest export 2019-04-18 misterg Googletest export 2019-03-08 yaneurabeya clang: fix `-Wsign-conversion` errors Created with: roll-dep src/third_party/googletest/src Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel,mac_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official Change-Id: I063fb50f95b0af4a7686c3f59d01b7d0a2db6ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577861 Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#653362}
-
John Williams authored
Bug: 954797 Change-Id: Idec1306428c4efa4500534ad970da1606e132003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575435 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#653361}
-
Tanya Gupta authored
The function assumed that all calls would return non-null pointers. Fixed that to explictly check for nullptr. Bug: 950640 Change-Id: I7b1ff107b3dd6b94b439f486779cfefe2ae1688e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577977Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#653360}
-
David Benjamin authored
This takes away one source of SSLConfig variation. We can instead put it back in SSLConnectJob (the flattened socket pools should avoid the NTLM bug), but no point when we don't need it anymore. TLS 1.3 has been shipping for over a year now, and the admin policy expired in M75. Per chrome/VERSION, trunk is now M76. This CL does not change whether connections with TLS-1.3-intolerant networks or servers fail. It only shifts the error back to ERR_SSL_PROTOCOL_ERROR, ERR_CONNECTION_RESET, or whatever we actually get out of the server. Bug: 951205 Change-Id: I95f1730c7b835c9aab1998c0cda56bcfaca45e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574368 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#653359}
-
Huanzhong Huang authored
-Add another initializer for ClearBrowsingDataManager -Make BrowsingDataRemover and CounterProducer explicit dependencies of CBDManager, so to allow dependency injections in tests. Bug: 935350 Change-Id: I2e445e474c7a549b3aebcf1007b543b371644bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577421 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#653358}
-
Caitlin Fischer authored
Bug: 955638 Change-Id: I375ca09f4c117ad35b84a85c97dae9702d8b534a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579521Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#653357}
-
Junbo Ke authored
[chromecast] Add a function in CastContentBrowserClient to initialize CastURLLoaderThrottle::Delegate Bug: b/129956026 Merge-With: eureka-internal/265739 Test: Manual test Change-Id: Icebc1806c842ba7b69be7dac425ccda433b23d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577960 Commit-Queue: Junbo Ke <juke@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#653356}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6d9913ab1893..158a65393019 git log 6d9913ab1893..158a65393019 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@158a65393019 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I25cf0f0c3e52a1544216b8b57b61c2cf89c92f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579439Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653355}
-
Paul Meyer authored
This patch applies content sniffing to WebP images in order to determine whether they use lossy or lossless compression. This allows the the policies to be applied more precisely to WebP images. Bug: 955580 Change-Id: Id5d97d9d10e1253fe353dc03ffbdbdee69e9428b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569691Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#653354}
-
Mike Klein authored
Neither of these should do anything yet: - add top-level Skia directory to include path so includes like "include/core/SkCanvas.h" will work (see https://skia-review.googlesource.com/c/skia/+/209706) - define SK_USER_CONFIG_HEADER to point to Chromium's SkUserConfig.h (see https://skia-review.googlesource.com/c/skia/+/209866) As a small sanity cleanup: - remove Skia's include/config from the include path. We don't ever want to use Skia's default SkUserConfig.h, only ever Chromium's. I think the include order means we have no bug here, but removing the undesirable include path should make that extra snuggly safe. Change-Id: I87ac5132967251e80f7b0bbea01676df25195b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577632Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#653353}
-
Nate Chapin authored
This is a small code change with a lot of test changes. The two most common reasons for those changes are: * Cases where the ordering of messages reaching the browser process changed in ways that browser_tests were sensitive to. * A navigation scheduled by NavigationScheduler doesn't prevent a DidStopLoading() callback, but starting the navigation immediately does prevent DidStopLoading(). So location API navigations inside onload used to result in two pairs of DidStartLoading/DidStopLoading callbacks, where there is now only one pair. Bug: 914587 Change-Id: I83b016041c4579a64cf9ccfd7876dba335b799d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526426 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653352}
-
Zhenyao Mo authored
We want to know how our user base migrate to newer GPU generations over time, so definitely want to keep this alive for much longer. BUG=945562 TEST=bots Change-Id: Ibc762346b315454d4918b22aa51816700a48ae80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575084Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#653351}
-
Daniel McArdle authored
Testing with media_unittests Bug: 755368 Change-Id: I9b45735a5d3054207d3bc340bce45fb25014a447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568847 Auto-Submit: Daniel McArdle <dmcardle@chromium.org> Commit-Queue: Daniel McArdle <dmcardle@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#653350}
-
Jared Saul authored
Bug: 855182 Change-Id: I8760ab9eb7bf3fbae726674537555dad5dcb8870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577876Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#653349}
-
Emil A Eklund authored
Bug: 714962 Change-Id: I37dea7db4dfc33b561871a20969629e8b497c103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579030Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#653348}
-
Regan Hsu authored
Patches diff from https://chromium-review.googlesource.com/c/chromium/src/+/1574440 to os settings. Bug: 950007 Change-Id: Ifbd4489816055260f3fb1a48ee91620b53e6d61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577943Reviewed-by:
May Lippert <maybelle@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653347}
-
Nick Harper authored
Change-Id: I5244ca5369eba162c2314ad1aedddfbe9c7ddb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577583Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#653346}
-
Sebastien Marchand authored
This feature has been enabled by default for a while now, the flag isn't needed anymore. The feature is being kept for now as there's some feature parameters that we'll want to explore in the feature, but there's no need for a flag. Bug: 839878 Change-Id: Ib848d9762317985cf3c3df18710154c972dc445a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579323 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#653345}
-
Tom Sepez authored
Prefer Span() to bare Characters() calls. Use it in one place where it is obvious to do so. Bug: 955067 Change-Id: I8ac39279f4c117ab235642e82da4db23c31a9e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578595Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#653344}
-
Sky Malice authored
Bug: 937446 Change-Id: I6fe3c61d715cf8e541922d01e561696c434155d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577935 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#653343}
-
Huanzhong Huang authored
Remove a few tests in ClearDataItemTest, as enabling the new CBD UI flag breaks them, and we are switching to CBD table view. Bug: 935350 Change-Id: Ied27069a56d7bc67bc42de5f67596d741b004d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576567Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#653342}
-
Matt Menke authored
The one consumer of the method now creates ConnectJobs directly, instead of going through ClientSocketPoolManager. As the consumer isn't even using SocketPools, the new layering makes more sense. Bug: 533571 Change-Id: I7c7ade3a5204d6df4c26fd444b67f20192b8d707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577843 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#653341}
-
Karan Bhatia authored
This CL removes the unused WebRequestWSRequestHeadersModification enum. This was added to report header modification for web sockets, but wasn't removed when the corresponding histogram was deprecated. BUG=None Change-Id: I1298a48772e9dec456f6902fc768b8754b82dd9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577742 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#653340}
-
Chris Cunningham authored
Flaking regularly on all platforms https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=UnifiedConsentBrowserTest.SettingsOptInTakeOverServicePrefChanges Bug: 954167 Change-Id: Iad5e8798636692ab692ef1980dd9b2ce694549b9 TBR: tangltom@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579519Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#653339}
-
Elly Fong-Jones authored
Bug: None Change-Id: I2151f1e9d30a4973f9b5ceea9ebef429aae5a374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575678Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#653338}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I15ecfa935eb67952de961f40803db25a5fbfb231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653337}
-
Siddhartha S authored
For interface clients, track the name of the interface in tracing for the type of message that is queued a lot. BUG=874530 Change-Id: I3a6e2ea125758d4e0df9b851778e834f5805b502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570195 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#653336}
-
Matt Mueller authored
os.system passes the command line to a shell to execute, which requires careful quoting/escaping (which the script was not doing). subprocess.call executes the target directly and arguments are not processed by the shell. iossim has one argument that is itself a list of arguments to pass to its child process, so extra care is taken in escaping that argument. Change-Id: I6785c83d732dc1fe6a874598f13cb4e47eaa35e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577877Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#653335}
-
Yi Gu authored
Currently all effects must have the same document to create a worklet animation. However, animating a target which is from a different document, e.g. an iframe, should be allowed. Change-Id: I24ed3597cbbe588f78829fb64e305e3cd07f637c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574427 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#653334}
-
Jared Saul authored
Change-Id: Ib85fbac78d0ae96b5abad2cbec7a028fa64c78a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578062Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#653333}
-
Antoine Labour authored
Bug: 924592 Change-Id: I30bacfe9209cfca2680ec9e234c4e83b596acd22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577683 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653332}
-
Yuly Novikov authored
To 12 hours, since it fails to finish in 6 hours. TBR=martiniss Bug: 881625 Change-Id: I26b0d47d3f6e8d844a25987e3420483f1e7c5799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579471Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#653331}
-
Chrome Cunningham authored
This reverts commit 040e68ad. Reason for revert: Suspected break of android omnibox tests. Original change's description: > Reland "[Image Fetcher] Replace AnswersImageFetcher with CachedImageFetcher" > > This is a reland of 9f250174 > > Original change's description: > > [Image Fetcher] Replace AnswersImageFetcher with CachedImageFetcher > > > > Removing a duplicate cached image fetcher here. > > > > Bug: 934950 > > Change-Id: I0063aa8e26cbd4c0a0acb7f3c59f4ee86116e2db > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481955 > > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#651905} > > Bug: 934950 > Change-Id: I33f1f4b6f2aefe8a6fc733102c568f9420f0451d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574628 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652949} TBR=rkaplow@chromium.org,tedchoc@chromium.org,twellington@chromium.org,wylieb@chromium.org,ender@google.com Change-Id: Iae5f8a23d8fb7f6478e56128d0eb7c6cb4da02d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934950, 955634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577997Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#653330}
-
John Rummell authored
If the feature "FailUrlProvisionFetcherForTesting" is enabled, all MediaDrm provisioning requests will not be sent to the provisioning server and will respond as if the request failed. BUG=954541 TEST=tested manually Change-Id: I9606e05671d1ffaede8743a150ebe67cfbfb2836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576121 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#653329}
-
Wei Li authored
Add a general support for setting properties in metadata. The properties are passed in as string from frontend, we will parse and set it accordingly. Also, since frontend doesn't do any checking, we also add a simple check for boolean type for now. BUG=954675 Change-Id: I1e6d241a27fe5dd390b2c5ff2888d77a3f13094a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578099 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#653328}
-