GitLab

BUG=658242

Review-Url: https://codereview.chromium.org/2527383002
Cr-Commit-Position: refs/heads/master@{#434973}

Reland of After detach, there's no document to notify parsing is finished. (patchset #1 id:1 of https://codereview.chromium.org/2538473004/ )

Reason for revert:
Reland, probably innocuous for crbug.com/669435

Original issue's description:
> Revert of After detach, there's no document to notify parsing is finished. (patchset #3 id:40001 of https://codereview.chromium.org/2537043002/ )
>
> Reason for revert:
> Speculative revert for crbug.com/669435
>
> Original issue's description:
> > After detach, there's no document to notify parsing is finished.
> >
> > HTMLViewSourceParser was tripping the DCHECK in
> > DocumentParser::document when it recieved the last bytes of the
> > document it was parsing after it was detached.
> >
> > BUG=664915
> >
> > Committed: https://crrev.com/8e59e2d6feaa38b37836837e996b9ad91c0b3745
> > Cr-Commit-Position: refs/heads/master@{#434937}
>
> TBR=tkent@chromium.org,yoichio@chromium.org,yosin@chromium.org,dominicc@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664915
>
> Committed: https://crrev.com/ffe8e7b51df227590c9cadad11dd9e734f571129
> Cr-Commit-Position: refs/heads/master@{#434954}

TBR=tkent@chromium.org,yoichio@chromium.org,yosin@chromium.org,dominicc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664915

Review-Url: https://codereview.chromium.org/2535233002
Cr-Commit-Position: refs/heads/master@{#434972}

This will lay out multicol containers in one single tall column, without any
support for fragmentation or column balancing.

Also had to disable creation of the anonymous LayoutMultiColumnFlowThread child
of multicol containers, since that's not going to be used in LayoutNG.

The algorithm for calculating the used values of column-width and column-count
can be found here: https://drafts.csswg.org/css-multicol-1/#pseudo-algorithm

Review-Url: https://codereview.chromium.org/2528203002
Cr-Commit-Position: refs/heads/master@{#434971}

[ RUN      ] AutofillManagerTest.UploadCreditCard
../../components/autofill/core/browser/autofill_manager_unittest.cc:4496: Failure
Value of: autofill_manager_->credit_card_was_uploaded()
  Actual: false
  Expected: true

BUG=666704
TBR=mathp@chromium.org

Review-Url: https://codereview.chromium.org/2533253002
Cr-Commit-Position: refs/heads/master@{#434970}

We'll no longer perform inaccurate layout from insertFloatingObject(), but
defer all layout to positionAndLayoutFloat(). We need to do this correctly
everywhere. One crucial thing is also to pay attention to the resulting
pagination strut before the float, if any. There's only one place where we do
this, and that's in positionAndLayoutFloat().

At most call sites, insertFloatingObject() is followed by a call to
placeNewFloats(), which will call positionAndLayoutFloat(). There are
exceptions to this in line layout, though. In some cases we just insert floats
without laying them out and placing them. This happens when we need to figure
out the height of the current line before we can place floats below it. In
order to figure out if a float fits on the current line, though, we first need
to lay it out without marking it as placed.

We lacked some test coverage, so I added
float-pushed-to-next-fragmentainer-by-floats.html . This also passed prior to
this CL, but I nearly broke it while working on this.

BUG=663942

Review-Url: https://codereview.chromium.org/2532573003
Cr-Commit-Position: refs/heads/master@{#434969}

Also type-check that we're dealing with a LayoutBlockFlow before casting.

Review-Url: https://codereview.chromium.org/2527393002
Cr-Commit-Position: refs/heads/master@{#434968}

Add "Add to" to the strings.
Also add olivierrobin as owners of the extensions.

BUG=661920

Review-Url: https://codereview.chromium.org/2540553003
Cr-Commit-Position: refs/heads/master@{#434967}

Currently WebGL2RenderingContext is not yet exposed in worker, which means
calling OffscreenCanvas.getContext('webgl2') fails in a worker.

This CL expose it with ExperimentalCanvasFeatures flag.
The test for this is upstreamed here:
https://github.com/KhronosGroup/WebGL/pull/2159

BUG=668727
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2531853003
Cr-Commit-Position: refs/heads/master@{#434966}

That height may not be uniform throughout the entire fragmentation context
anyway, so it's not reliable to do it like this. For multicol, the value was
only used as a flag (0=unknown height, 1=known height).

Move calculation of available column height to LayoutMultiColumnFlowThread. It
no longer needs to live in LayoutBlockFlow.

Review-Url: https://codereview.chromium.org/2529073002
Cr-Commit-Position: refs/heads/master@{#434965}

This is the same version of Clang, but contains a patched version of
LLVMgold.so to fix the problem of missing RUNPATH.

BUG=668587

Review-Url: https://codereview.chromium.org/2536973002
Cr-Commit-Position: refs/heads/master@{#434964}

The only stats dictionary that was missing was 'data-channel'. For it to
be included data channels had to be created. Added CreateDataChannel to
webrtc_browsertest_base.h/cc and peerconnection.js. Unittest updated to
EXPECT that no expected stats are missing.

Original CL: https://codereview.chromium.org/2527273003/
Reason for revert: A whitelist filter was landed roughly at the same
time as the the original CL, causing expected stats to be blacklisted.
In this re-land, the whitelist is updated.

BUG=chromium:627816

Review-Url: https://codereview.chromium.org/2533223003
Cr-Commit-Position: refs/heads/master@{#434963}

Attempt to compensate for some recent changes to DRT output. Also try
to get some more "correct" reference images.

TBR=schenney@chromium.org
NOTRY=true
BUG=639147

Review-Url: https://codereview.chromium.org/2537083003
Cr-Commit-Position: refs/heads/master@{#434962}

This patch changes |Editor::unappliedEditing()| to use |isNone()| predicate
rather than checking |Document| equality of |Position| to simplify source code
for improving code health.

Since |correctVisibleSelection()| always returns |VisibileSlection| which
is an empty or valid for specified |Document|, checking equality of |Document|
between selection start and |frame.document()| is equivalent to empty selection
check.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2540613002
Cr-Commit-Position: refs/heads/master@{#434961}

Revert of Script blocking resources tracking should be only done by Document::isScriptExecutionReady (patchset #3 id:40001 of https://codereview.chromium.org/2536753003/ )

Reason for revert:
Speculative revert for crbug.com/669435.

BUG=669435

Original issue's description:
> Script blocking resources tracking should be only done by Document::isScriptExecutionReady
>
> Before this CL, we had a duplicated tracking flag
> HTMLScriptRunner::m_hasScriptsWaitingForResources.
>
> This CL removes the flag in HTMLScriptRunner and changes code so it checks
> Document::isScriptExecutionReady() state instead.
>
> This CL also removes a comment referring to HTMLDocumentParser::executeScriptsWaitingForResources
> being called when it hasScriptsWaitingForResources as it should never happen
> and replaces it with a DCHECK
>
> BUG=None
>
> Committed: https://crrev.com/74341a4386cbe0c0b94eba0535fbbbf8d1aff8ea
> Cr-Commit-Position: refs/heads/master@{#434935}

TBR=dominicc@chromium.org,yhirano@chromium.org,kouhei@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2540653002
Cr-Commit-Position: refs/heads/master@{#434960}

Fails on Nexus 4 only with the following error:
../../base/test/histogram_tester.cc:40: Failure
Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00>
vs NULL
Histogram "WebCore.UseCounter_TEST.Features" does not exist.

BUG=667913
TBR=rbyers@chromium.org

Review-Url: https://codereview.chromium.org/2534833005
Cr-Commit-Position: refs/heads/master@{#434959}

BUG=667975

Review-Url: https://codereview.chromium.org/2535893002
Cr-Commit-Position: refs/heads/master@{#434958}

Currently there are three types of resource request.
- Normal resource request from renderer process.
- Resource request for browser side navigation. (PlzNavigate).
- Download request or Page Save request.

In ResourceRequestInfoImpl, these type are distinguished by process_type and
the existence of ResourceMessageFilter. But it is a bit confusing.
For example:
- AsyncRevalidationManager is checking only the existence of the filter to
  check that "the renderer is gone" or "the request is for PlzNavigate".
- service_worker_context field is added for PlzNavigate support. And the field
  is used only when the filter is not available in HandleServiceWorkerLink().

This CL introduces ResourceRequesterInfo to make it easy to distinguish those
requester types.

BUG=468227,649558
TBR=michaeln@chromium.org

Review-Url: https://codereview.chromium.org/2481093003
Cr-Commit-Position: refs/heads/master@{#434957}

 * propagate information about the success of an attach attempt
 * force-attach support
 * added the IsAttached() method

BUG=546953

Review-Url: https://codereview.chromium.org/2531313002
Cr-Commit-Position: refs/heads/master@{#434956}

In the ToValueImpl specialization for std::unique_ptr<T>, call ToValue
with the dereferenced type. All specializations take const&, which would
previously result in a call to ToValue(const*&), resulting in a wrong
specialization to be selected.

BUG=546953

Review-Url: https://codereview.chromium.org/2533083003
Cr-Commit-Position: refs/heads/master@{#434955}

Revert of After detach, there's no document to notify parsing is finished. (patchset #3 id:40001 of https://codereview.chromium.org/2537043002/ )

Reason for revert:
Speculative revert for crbug.com/669435

Original issue's description:
> After detach, there's no document to notify parsing is finished.
>
> HTMLViewSourceParser was tripping the DCHECK in
> DocumentParser::document when it recieved the last bytes of the
> document it was parsing after it was detached.
>
> BUG=664915
>
> Committed: https://crrev.com/8e59e2d6feaa38b37836837e996b9ad91c0b3745
> Cr-Commit-Position: refs/heads/master@{#434937}

TBR=tkent@chromium.org,yoichio@chromium.org,yosin@chromium.org,dominicc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664915

Review-Url: https://codereview.chromium.org/2538473004
Cr-Commit-Position: refs/heads/master@{#434954}

Recording this metric gives insight into how many people update their
settings after seeing the disclosure.

BUG=661011

Review-Url: https://codereview.chromium.org/2518963002
Cr-Commit-Position: refs/heads/master@{#434953}

Previously, for a multipart image,
- ResourceClient::notifyFinished() and
- ImageResourceObserver::imageNotifyFinished()
might be called twice:
1. When the first part is loaded, and
2. When the whole loading is finished.

This CL removes the second case to make callback/observer control consistent
and simpler, as preparation for https://codereview.chromium.org/2469873002/.

Behavior change:
Previously, multipart images are replaced with broken images when cancelled
after the first part is loaded.
After this CL, multipart images remains as-is in such cases.
https://codereview.chromium.org/1840933002 fixes layout tests for this change.

BUG=668598

Review-Url: https://codereview.chromium.org/2513413008
Cr-Commit-Position: refs/heads/master@{#434952}

This eliminates one of the sources of flakiness in
ResourcePrefetchPredictorBrowserTest.
It seems impossible to avoid an emergence of several requests belonging to the
same subresource but we could just ignore them as real code does.
The real code also ignores repeating entries of the same subresource but doesn't
modify collection passing to test observer.

BUG=650253

Review-Url: https://codereview.chromium.org/2529263003
Cr-Commit-Position: refs/heads/master@{#434951}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a72be232..2ef8719e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2536123002
Cr-Commit-Position: refs/heads/master@{#434950}

Remove future and deprecated policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG=616800
BUG=616801

Review-Url: https://codereview.chromium.org/2529383003
Cr-Commit-Position: refs/heads/master@{#434949}

BUG=667751

Review-Url: https://codereview.chromium.org/2525303002
Cr-Commit-Position: refs/heads/master@{#434948}

Preparation for https://codereview.chromium.org/2513413008.

This CL introduces Internals::isLoading() and make the tests to use
isLoading() instead of size checks for detecting broken images.

BUG=668598

Review-Url: https://codereview.chromium.org/1840933002
Cr-Commit-Position: refs/heads/master@{#434947}

This plumbing was never actually used, and we're now getting rid of the pings completely.

BUG=646308

Review-Url: https://codereview.chromium.org/2525653002
Cr-Commit-Position: refs/heads/master@{#434946}

Revert of win: Remove unneeded references to visual_studio_version now that it's always 2015. (patchset #4 id:60001 of https://codereview.chromium.org/2450933002/ )

Reason for revert:
V8 relies on this.

Original issue's description:
> win: Remove unneeded references to visual_studio_version now that it's always 2015.
>
> BUG=
>
> Committed: https://crrev.com/a628db5056deb88589224bd68dcd9ec029932c83
> Cr-Commit-Position: refs/heads/master@{#427463}

TBR=scottmg@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2531333004
Cr-Commit-Position: refs/heads/master@{#434945}

Reland after revert in 1b8f4236,
previous CL https://codereview.chromium.org/2530153002/
Previously failing Win10 test needs a rebaseline.

Issue 618178 describes an example where a Burmese text run starts with a
leading punctuation character followed by a combining spacing mark. This
grapheme cannot be shaped with the default font, since Times for example
cannot display the combination of a left quote with a Burmese combining
mark. Our fallback code attempts to find a fallback font based on the
first character at the beginning of an extracted unshaped sub-run, which
does not lead to finding a font suitable for Myanmar text in this case.
So in a way it runs into a fallback trap, where no fallback hint helps
to find the right fallback font and the whole run ends up as notdef
glyphs.

This CL attempts to resolve this by looking for a better fallback hint
character, which is not script common or inherited, if such is
available. This improves the situation for the Burmese text from the
issue report.

In addition, as a better fix we should give higher importance to the
locale information in font fallback, filed as issue 668706.

BUG=618178
TBR=eae,kojii,behdad

Review-Url: https://codereview.chromium.org/2539733002
Cr-Commit-Position: refs/heads/master@{#434944}

This patch moves "core/editing/*Test.cpp" to "core/editing/BUILD.gn" from
"core/BUILD.gn" to reduce size of "core/BUILD.gn" and ease of adding new test
for improving development experience.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2533213002
Cr-Commit-Position: refs/heads/master@{#434943}

Makes non-cross-origin accessible attributes be accessor
properties.

[CachedAccessor] already made window.document an accessor
property, and this CL doesn't affect it.

Cross-origin accessible attributes remain being data
properties.

The previous attempt was http://crrev.com/1380503002

BUG=475556

Review-Url: https://codereview.chromium.org/2506393004
Cr-Commit-Position: refs/heads/master@{#434942}

Revert of Hook up views/widgets to AshDevToolsDOMAgent (patchset #3 id:40001 of https://codereview.chromium.org/2529553002/ )

Reason for revert:
Reverting due to a memory leak. See http://crbug.com/648701#c26

Original issue's description:
> Hook up views/widgets to AshDevToolsDOMAgent
>
> - This CL adds AshDevToolsDOMAgent as an observer to all widgets and views.
> The WidgetRemovalObserver is specifically to remove the RootView subtree,
> while the ViewObserver is to update any other descendant views.
> AddViewTree was created so that whenever any |view| is added, it can
> be pushed to the frontend.
> - Add tests for when views are inserted, removed, rearranged,
> removed & inserted.
> - Add test to check if a widget owned by a native widget is represented
> properly in the DOM.
>
> BUG=648701
>
> Committed: https://crrev.com/b4ce166c6eb7bf65dedbdb6947e23fbf2992e251
> Cr-Commit-Position: refs/heads/master@{#434863}

TBR=sadrul@chromium.org,mhashmi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648701

Review-Url: https://codereview.chromium.org/2532243003
Cr-Commit-Position: refs/heads/master@{#434941}

When we need to recollect active stylesheets for all scopes, have an
explicit markAllTreeScopesDirty method instead of relying on
FullStyleUpdate which will go away for async active stylesheet updates.

This CL does not contain functional changes.

R=meade@chromium.org
BUG=567021

Review-Url: https://codereview.chromium.org/2534863002
Cr-Commit-Position: refs/heads/master@{#434940}

The third parameter of "launchApp" is only used for the webstore app,
and used to append utm_source=chrome-ntp-icon to the app URL.
But the launchApp handler did not validate that the URL is safe.
To fix that issue, I specialize the parameter for launchApp: It now takes the
source string ("chrome-ntp-icon") instead of a URL without validation.

BUG=668665
TEST=Manually using test case from bug report. Also opened the app launcher and
verified that clicking on the Webstore icon still leads to the same place.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2527413002
Cr-Commit-Position: refs/heads/master@{#434939}

This patch adds AddRequestTask with its tests to ensure request queue
operations are properly sequenced.

BUG=651238

Review-Url: https://codereview.chromium.org/2527293002
Cr-Commit-Position: refs/heads/master@{#434938}

HTMLViewSourceParser was tripping the DCHECK in
DocumentParser::document when it recieved the last bytes of the
document it was parsing after it was detached.

BUG=664915

Review-Url: https://codereview.chromium.org/2537043002
Cr-Commit-Position: refs/heads/master@{#434937}

SourceStream::prepareDataOnMainThread() seems to be called after
ScriptStreamer::cancel() and thus SourceStream()::cancel() are called.

BUG=668611

Review-Url: https://codereview.chromium.org/2539683002
Cr-Commit-Position: refs/heads/master@{#434936}

Before this CL, we had a duplicated tracking flag
HTMLScriptRunner::m_hasScriptsWaitingForResources.

This CL removes the flag in HTMLScriptRunner and changes code so it checks
Document::isScriptExecutionReady() state instead.

This CL also removes a comment referring to HTMLDocumentParser::executeScriptsWaitingForResources
being called when it hasScriptsWaitingForResources as it should never happen
and replaces it with a DCHECK

BUG=None

Review-Url: https://codereview.chromium.org/2536753003
Cr-Commit-Position: refs/heads/master@{#434935}

This makes 'transform', 'gradientTransform' and 'patternTransform'
presentation attributes on SVGGraphicsElements, SVGGradientElements
and SVGPatternElements respectively.

Spec:

 http://www.w3.org/TR/css3-transforms/#svg-transform
 http://www.w3.org/TR/css3-transforms/#svg-syntax
 http://www.w3.org/TR/css3-transforms/#svg-gradient-transform-pattern-transform

Salvaged from https://codereview.chromium.org/423093014, but takes a
different approach to bridge the syntax gap and avoid crbug.com/577219.

The strategy taken here is to use the SVGTransformList to generate a
CSSValue for the presentation attribute style, and hence postponing
both support for the full transform syntax and a way around the bug
mentioned above. Essentially softening the blow. These two "features"
are expected to be implemented eventually, so this is just a "first
step".

BUG=369942
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2478233002
Cr-Commit-Position: refs/heads/master@{#434934}