- 08 Apr, 2019 40 commits
-
-
John Abd-El-Malek authored
Revert "Ensure header modification for a redirect's onBeforeSendHeaders is applied with network service." This reverts commit b5e1969b. Bug: 949478 Original change's description: > Ensure header modification for a redirect's onBeforeSendHeaders is applied with network service. > > This currently worked if 'extraHeaders' was specified, but not without it. > > Bug: 942062 > Change-Id: Ic962ad256d89384082e25a5983181bf563021ffb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548673 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647160} TBR=jam@chromium.org,rockot@google.com,karandeepb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 942062 Change-Id: I8aadb1bb0bcb0562a607c2a74d3c2cf1060c560f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557746Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#648758}
-
Andrew Grieve authored
Might lead to correctness bugs, but that is (likely) better than crashing. This code is soon to be replaced by BlinkGenPropertyTree, so this fix should be short-lived. Bug: 939342 Change-Id: Ia14b31420a1a78e738036a3d2c6bff4d3b46ec0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554731Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#648757}
-
PKH authored
This CL propagates the WebApkConstants.EXTRA_SPLASH_PROVIDED_BY_WEBAPK flag from WebappLauncherActivity to WebApkActivity. This matters when WebApkActivity is recreated after being killed by the Android OOM killer. BUG=817263 Change-Id: Ib9c2f0e9c9c57dbafaac59c3d3099913e1e88798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557540Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#648756}
-
Etienne Bergeron authored
This CL is removing the GetNativeFont calls to the PlatformFontWin. This is a step toward replacing PlatformFontWin with PlatformFontSkia. There was 4 cases to be fixed: 1) gfx/font_unittest.cc These tests will no longer need to check for the HFont, the same tests than the ones done by PlatformFontSkia is enough. We removed these check on windows. 2) gfx/system_fonts_win.cc GetFont was checking for a valid HFONT when accessing a font. We check the HFONT on creation instead. The creation of system fonts (AddFont) is only used for the font we can get from GetFont. 3) gfx/font_fallback_win.cc The GetUniscribeFallbackFont was selecting the native font before running the script analysis (to determine the fallback fonts). Instead of accessing the HFONT, we are creating a new one from a gfx::Font. This is compatible with both PlatformFontWin and PlatformFontSkia 4) views/corewm/tooltip_win.cc Some fonts doesn't display correctly when too small. They may need an override (e.g. Malayalam, Bengali). The previous code was taking a HFONT from the Window, rescaling it and received the scaled font as a gfx::Font. The HFont from that gfx::Font was set on the Window. We are proposing to keep the code only GDI (not using gfx::Font). The function gfx::win::AdjustExistingSystemFont is adjusting an HFONT and produces an a HFONT. We propose to keep the function AdjustExistingSystemFont into gfx::win::SystemFonts since all the font adjustment logic is there. R=fdoray@chromium.org, asvitkine@chromium.org CC=dfried@chromium.org, robliao@chromium.org Bug: 944227 Change-Id: I5b0afac3f0ea8a4c67d0408e4fab06d36813466e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553459Reviewed-by:Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#648755}
-
Maggie Chen authored
WebglConformance_conformance_rendering_rendering_sampling_feedback_loop fails on chromium.gpu.fyi bots Android FYI Release (Nexus 6P) Android FYI Release (Nexus 6) Android FYI Release (Nexus 6) Skip this test for now. Bug: 950301 Change-Id: I842a071259984f080017508fdff7693bcdaf0efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557086 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#648754}
-
Austin Eng authored
Bug: 877147 Change-Id: I29fa88ab691262974783a6e327d2b75fa1e70b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547937 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#648753}
-
Thomas Tangl authored
- The sync page is always focused when it is opened. - The passphrase input is focused after flushing the dom instead of listening for 'show-container'. Bug: 831030 Change-Id: I0da46715eeffca0567b6d5121e320060dc181626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547790Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#648752}
-
Tony de Luna authored
Removes a couple of functions that have no callers. Change-Id: I52f28a479db844eedf2c3a08d9480fd44ac5bf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557426Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Cr-Commit-Position: refs/heads/master@{#648751}
-
Ian Wells authored
The original CL added a column to the "page_thumbnails" table with NOT NULL but with no default value. The procedure for upgrading to the new schema version involved copying all rows of that table but did not give a value for the new column, causing a crash during schema upgrades. This CL adds a default value for "favicon", eliminates copying all rows as it was unnecessary anyway, and improves testing by ensuring a row exists in page_thumbnails before the schema upgrade. Bug: 841516 Change-Id: I3c9988bb7e23dec1fcc8d1f25db0c9efe8d88517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552117Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#648750}
-
Thomas Tangl authored
Screenshot: https://drive.google.com/file/d/1gwajK8CHXiZYNn5M_V02OUoXyji3fj3n/view?usp=sharing Additional change: The autofill group is always separated by a line. Bug: 950534 Change-Id: I8e3a14c4e44dd38f188ff0c76ec84dce7f802894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556846Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#648749}
-
James Darpinian authored
webgl2_conformance_gl_passthrough_tests needs to be disabled on the Linux FYI Experimental Release (Intel HD 630) bot because the test conformance2/textures/misc/tex-3d-size-limit.html hangs the whole machine. This was fixed for the validating command decoder but not for passthrough yet. Also suppress one new failure in webgl2_conformance_tests on this bot, conformance2/textures/misc/tex-base-level-bug.html. TBR: ynovikov@chromium.org, kbr@chromium.org Bug: 927470, 950552 Change-Id: Ib329f72cfb41a6e444a5cc3232e1b10089f636cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557742Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#648748}
-
Ken Rockot authored
Implements support for the [ShareMessageOrder] attribute on mojom method parameters and struct fields. If the field or parameter is a pending_receiver or pending_remote type (or a container of one of those types), its handle will be attached to the encompassing serialized message with the new MOJO_APPEND_MESSAGE_DATA_HANDLE_FLAG_SPLICE flag set, meaning that interface pipe will begin to share message ordering with the sending pipe after message transmission. This support should be sufficient to fully replace usage of associated interfaces while eliminating all bindings-layer encoding and routing support for multiplexed pipes. See bug for design doc link. Bug: 941809 Change-Id: I5629497705e4e747f9d63ef8198091d7917a41a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548611 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#648747}
-
Sergey Kuznetsov authored
PatchService is needed for component updater, because 'DeltaUpdateOpPatch::DoRun' calls 'patch::Patch', the underlying service for 'patch::Patch' is PatchService. Change-Id: Ic2397ffe38d92ec7ffb8e4fa2e88fc99f5382791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543261 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Min Qin authored
Currently InProgressDownloadManager is created in DownloadManagerImpl. However, for content layer, we don't need to create the in-progress DB. As a result, This CL move InProgressDownloadManager creation to Chrome layer, it also allows us to construct the SimpleFactoryKey from the profile, which can later be used to create the SimpleDownloadManagerCoordinator. BUG=942770 Change-Id: I8f020f2685dd0d6972c56ab1225b440c3c73051b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555010Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#648745}
-
Sean Gilhuly authored
SkiaRenderer's handling of AA edges is slightly different (up to 10 difference in the RGB values), but perceptually close enough. Add images specific to SkiaRenderer to the tests AntiAliasing and AntiAliasingPerspective. Bug: 947055 Change-Id: If7e9571ec6a038d28786b23e21870ea5a4312146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553879Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#648744}
-
Ken Rockot authored
This is a reland of afff956d Fixes some trivial uninitialized value bugs only caught by MSAN after landing. PS1 is the original CL, PS2 is the diff which fixes the bugs. Original change's description: > [mojo-core] Support pipe splicing > > This change allows message pipes to be "spliced" into other message > pipes, unifying their message queues while retaining their logical > independence for routing of written messages. > > This is supported by adding an array of per-handle options and flags to > MojoAppendMessageDataOptions. If a handle is marked with > MOJO_APPEND_MESSAGE_DATA_HANDLE_FLAG_SPLICE when appended to a message, > sending that message will effectively cause the handle and its peer to > be spliced into the sending pipe. > > See bug for design doc link. > > Bug: 941809 > Change-Id: I191fb4df4c1586bcee91a3ccf595d76869451e7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548145 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648579} Bug: 941809 Change-Id: Ia66fa98810fae88023c71b50e5b6fd3862c4474e TBR: oksamyt@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558190Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#648743}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/09d022cbb8a6..7656b2c18ce8 git log 09d022cbb8a6..7656b2c18ce8 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 reed@google.com Revert "Revert "Move localmatrix routines to shaderbase, no need to be public."" 2019-04-08 ethannicholas@google.com fixed ArithmeticImageFilter input type 2019-04-08 nigeltao@google.com Update Wuffs version 2019-04-08 mtklein@google.com fm_bot: look for and explain too-late flags 2019-04-08 reed@google.com Reland "Revert "Move localmatrix routines to shaderbase, no need to be public."" 2019-04-08 robertphillips@google.com Reduce the number of flush entry points Created with: gclient setdep -r src/third_party/skia@7656b2c18ce8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I8873153c71294acab33472611b0e3eb8d9d50b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648742}
-
Jose Dapena Paz authored
__has_feature is not available in GCC (and that is the reason why we have HAS_FEATURE macro). So use HAS_FEATURE instead. BUG=chromium:819294 Change-Id: I41923ff93a69107b160a5f1a5eb4c3056d53300d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554666 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#648741}
-
Francois Doray authored
Reland of https://chromium-review.googlesource.com/1020720. Launching child processes blocks shutdowns. 12% of shutdown hangs on Windows are caused by this. This CL makes the process launcher sequence CONTINUE_ON_SHUTDOWN on Windows instead of BLOCK_SHUTDOWN to prevent these hangs. There a DCHECKs in place to ensure that CONTINUE_ON_SHUTDOWN tasks don't access state that is teared down by AtExitManager, local tests didn't reveal any problem and manual inspection didn't reveal any access to global state from the process launcher sequence. https://chromium-review.googlesource.com/1020720 will ensure that there are no leftover processes on bots with this change, unlike when this change first landed. Bug: 830954 Change-Id: If89cfab59698c6b2c827cadd599490e3f5a52e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549478Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#648740}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cfc84d9bdd36..fa0935506a93 Created with: gclient setdep -r src-internal@fa0935506a93 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: Ieff955611838529a15fa684d959f0cf1b648396c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557891Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648739}
-
Kush Sinha authored
Chrome OS displays different types of notifications for Primary and Secondary Account errors. Primary Account errors and notifications should be given a higher priority than Secondary Account errors since the Primary Account is used for Sync and other important System services. We can generalize this for other platforms too and prioritize all Primary Account errors over Secondary Account errors. Bug: 940419 Test: components_unittests --gtest_filter="*SigninErrorControllerTest*" Change-Id: I59f6341bb315439f799a11feaae7e7369236903a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547737Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Ian Vollick authored
This reverts commit a3c69dac. Reason for revert: causing mac failure Original change's description: > Apply outline-offset for interested video > > Updates the interest ring UX for video with spatial navigation. > > Bug: None > Change-Id: Id5a5ac5860859710be8959b1c1923c5982831fd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554820 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648691} TBR=vollick@chromium.org,pdr@chromium.org,mlamouri@chromium.org,futhark@chromium.org Change-Id: I40363bd695c72130b271d204f5218c8df361ff9c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557750Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#648737}
-
Olivier Robin authored
The command parameter can contain not ascii characters which will not be decoded correctly by fromCharCode. Using TextDecoder will be more robust to decode the string. Bug: 950538 Change-Id: Ia7495c328582585ab8d47038b3c0bd192a40fe37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556848 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#648736}
-
Patrick Monette authored
This ensures that it's not possible to lose more than 5 minutes worth of module inspection. Bug: 932267 Change-Id: Ifdb7e75aaddf01b0e1a07888f65da8cf381e8045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542467 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#648735}
-
Abhijeet Kandalkar authored
The primary motivation of CL is that the //content/renderer/devtools/ is not related to devtools and hence should be moved. This CL removes //content/renderer/devtools/ and moves it to //content/renderer. Bug: 950171 Change-Id: Id8083f2ef76cbdf70506963d48e38173f552cd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557480Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#648734}
-
Devlin Cronin authored
Many chrome.extension methods are directly aliased to their chrome.runtime counterparts. If the chrome.runtime object has a custom getter that throws on access, trying to access the chrome.extension variant will trigger it. Protect against this by checking the result of the Get() in GetAliasedFeature(). Add regression tests in both a targeted unit test and an end-to-end browser test. Bug: 949170 Change-Id: I7405953a7ce735fe7d5fa055de8a5d97a1fbe1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553804 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#648733}
-
Dominik Laskowski authored
This CL modernizes style and removes repetitive code. Bug: 929449 Test: display_unittests Change-Id: I55e360d833a5dae345c071f0ba431cd89d68f39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553504Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Auto-Submit: Dominik Laskowski <domlaskowski@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#648732}
-
Niels Möller authored
Bug: None Change-Id: Iced96fabe17a47d9b24171bc0a323761836fec99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556781 Auto-Submit: Niels Möller <nisse@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
-
Joshua Bell authored
In August 2013, Adam Barth wrote an overview of the WTF::String type[1] and associated classes. Now that we prefer to keep docs in the tree, move it into Blink's platform/wtf/text directory as a README. The following edits were made to the doc: * Markdown formatting (headers, italics, code) * Updated StringImpl flag count/descriptions * Updated method names with new casing/spelling. * Dropped discussion of String::Append() (removed) * Dropped #blink IRC channel reference [1] https://docs.google.com/document/d/1kOCUlJdh2WJMJGDf-WoEQhmnjKLaOYRbiHz5TiGJl14/edit?usp=sharing Change-Id: I6e6c92ef21d32f647487e0558c3fdf66cd7f7e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555003 Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by:
-
Joshua Pawlicki authored
Re-encode several extensions as CRX3. Bug: 740715 Change-Id: I9953fb3fbd98e5076a5bc470e1e6edc114493e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515690Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#648729}
-
Devlin Cronin authored
Empty lists in features files are generally bad, since the features code in extensions checks lists (like the allowlist) for whether it's empty, and assumes "empty" means "unspecified". Make empty lists in features files a compiler error for all keys except 'dependencies'. ('dependencies' is valid, since a child feature may want to override the dependency list of the parent to be empty.) Bug: None Change-Id: Ib6c9db1e7740d5f42556bde79f62f806d7e8619b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553175Reviewed-by: -
Jamie Madill authored
This is a reland of fab66bae Includes necessary change to luci-scheduler.cfg and updated docs. Original change's description: > Add new ANGLE Linux and Mac tester configs. > > These configs will replace linux_angle_rel_ng and mac_angle_rel_ng. > They initially mirror the configuration but will soon be updated to > run only the subsets of tests that are most relevant to ANGLE. This > should reduce flakiness in ANGLE and reduce load for Chrome. > > Also updates related configuration files to include linux-angle-rel > and mac-angle-rel. > > Bug: 822310 > Change-Id: I2b40ed45f5d9e105c088ab166bd2207c96280151 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551463 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647854} Bug: 822310 Tbr: jbudorick@chromium.org Change-Id: Iaeeffc7b089b05d379bb353d627d13b39fd43704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554296 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/de64cb214d81..36589c6fccb2 git log de64cb214d81..36589c6fccb2 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 evanhernandez@chromium.org controller: Pass correct cwd to commands.py Created with: gclient setdep -r src/third_party/chromite@36589c6fccb2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ic3216a1f8ed0ea5f4e8ccd03a6893d7aaab8f04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558210Reviewed-by:
-
sczs authored
- Moves the AutoFillEditItem/Cell implementation into TableViewTextEditItem. - Renames AutoFillEditItemUnittest to TableViewTextEditItemUnittest - AutoFillEditItem is now a subclass of TableViewTextEditItem. - Moves the edit_icon resources from autofill to tableview. Screenshot: https://drive.google.com/open?id=1VERKBwioAvqjNhk3j3AWA9DNuW7OxgMJ Bug: 945478 Change-Id: I4d6633d7c26ca8f0b5a0f009549a1f77ec8753d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554281Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648725}
-
Dominic Battre authored
external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/symbols-function.html also fails on Linux and release builds. Labeling the bug as failing there as well. TBR=mstensho@chromium.org Bug: 935689 Change-Id: I3b3b0c5330594bfd6df1a9b77a912d928b776862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558230Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#648724}
-
Maks Orlovich authored
As some of those writes are ignored by PrepareTarget, they end up being to before the buffer's base, which messes with the expansion calculations before getting the "exit when length == 0" case; but those writes do not expand, so they can exit before the expansion handling. Bug: 946538 Change-Id: I9afd9371b16e4d80a5e1f11ec739e49a688bcef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554780Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#648723}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59e875ce18bb..e9d2b4efdd5d git log 59e875ce18bb..e9d2b4efdd5d --date=short --no-merges --format='%ad %ae %s' 2019-04-08 jeroendb@webrtc.org Revert "Remove old audio device implementation." 2019-04-08 orphis@webrtc.org Revert "Remove TaskQueue constructor that uses GlobalTaskQueueFactory" 2019-04-08 eladalon@webrtc.org Rename EncoderKeyFrameCallback back to EncoderRtcpFeedback 2019-04-08 eladalon@webrtc.org Give VideoSendStreamImpl access to RTP timestamps 2019-04-08 kthelgason@webrtc.org Remove old audio device implementation. 2019-04-08 sprang@webrtc.org Update VideoStreamEncoder to use new VideoEncoder::SetRates() method. 2019-04-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision baccefbc..7987ebdc (648532:648632) 2019-04-08 eladalon@webrtc.org Add RtpSequenceNumberMap::InsertFrame() 2019-04-08 asapersson@webrtc.org Remove unused members in VCMJitterEstimator. 2019-04-08 nisse@webrtc.org Delete placeholder code for Windows Media Foundation capturer. 2019-04-08 eladalon@webrtc.org Fix timeout in rtcp_receiver_fuzzer - limit input length 2019-04-08 kron@webrtc.org Fix potential bug due to malformed input 2019-04-08 kuddai@google.com Change PlayoutLatency setLatency zero-threshold value. 2019-04-08 titovartem@google.com Add stream labels into PeerConnection level smoke test. 2019-04-08 nisse@webrtc.org Move enum VideoType out of common_types.h 2019-04-08 titovartem@google.com Fix naming in NetworkEmulationManager: endpoint_controller -> endpoint_container 2019-04-08 kron@webrtc.org Make UDP receive buffer size configurable via field trial 2019-04-08 benwright@webrtc.org Added FrameDecryptorInterface::Result constructor and IsOk() member function. 2019-04-07 mbonadei@webrtc.org Implement DefaultAudioQualityAnalyzer. 2019-04-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 58ec016f..baccefbc (648432:648532) 2019-04-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0a611f37..58ec016f (648329:648432) 2019-04-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 37663bcc..0a611f37 (648215:648329) 2019-04-05 benwright@webrtc.org Add Result FrameDecryptorInterface::Decrypt 2019-04-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f91f8258..37663bcc (648096:648215) 2019-04-05 srte@webrtc.org Using simulated time for GoogCC tests. 2019-04-05 gustaf@webrtc.org AEC3: Enable usage of external delay estimator 2019-04-05 philipel@webrtc.org Tune VideoCodecTestLibvpx.TemporalLayersVP8 thresholds. 2019-04-05 srte@webrtc.org Running scenario quality unit tests in simulated time. 2019-04-05 danilchap@webrtc.org Remove TaskQueue constructor that uses GlobalTaskQueueFactory Created with: gclient setdep -r src/third_party/webrtc@e9d2b4efdd5d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:none,chromium:None,chromium:948469,chromium:949020,chromium:939340,chromium:None,chromium:None,chromium:None,chromium:None,chromium:b/130016532,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I47cf11c55e2695f3d95d4e9109726ab7477a85f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557892Reviewed-by:
-
Raul Tambre authored
The script still works with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I9d0d56b95eccc82da7820347877f4df0339ff731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556773 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#648721}
-
Cathy Li authored
[Explore sites][Touchless]: Ensure that category title will always be visible when a site has focus. Bug: 944258 Change-Id: I7bae69cad28c93affd08afcb8646dfc52ec0e4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550002Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#648720}
-
Joshua Pawlicki authored
Bug: 881076 Change-Id: I4b6172fb454138a622a1beb671c5c54a51171390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548067 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
